René's URL Explorer Experiment


Title: perf: combine logger zap sampling by davdhacs · Pull Request #19997 · stackrox/stackrox · GitHub

Open Graph Title: perf: combine logger zap sampling by davdhacs · Pull Request #19997 · stackrox/stackrox

X Title: perf: combine logger zap sampling by davdhacs · Pull Request #19997 · stackrox/stackrox

Description: The StackRox Kubernetes Security Platform performs a risk analysis of the container environment, delivers visibility and runtime alerts, and provides recommendations to proactively improve security by hardening the environment. - perf: combine logger zap sampling by davdhacs · Pull Request #19997 · stackrox/stackrox

Open Graph Description: Description Replace per-logger zap sampling with a single shared sampler core. Each per-logger sampler allocated a [7][4096]counter array (~450 KB each). The shared sampler preserves the exact same...

X Description: Description Replace per-logger zap sampling with a single shared sampler core. Each per-logger sampler allocated a [7][4096]counter array (~450 KB each). The shared sampler preserves the exact same...

Opengraph URL: https://github.com/stackrox/stackrox/pull/19997

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f098c2cd-582e-09ef-7387-11e81b627d31
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82E4:8F52B:EA64F9:1467F8F:6A4E9407
html-safe-nonced88de072e9a3e49dbdb2fb002eac131c7237744c0d1aa091d1bd94de41472396
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkU0OjhGNTJCOkVBNjRGOToxNDY3RjhGOjZBNEU5NDA3IiwidmlzaXRvcl9pZCI6IjcyNTkyNzYxNjMxNDQ2MDIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac440de53a28aec79c7f846e014a5671fb5f202dcab4ba8d5f2e39920d1710f3ba
hovercard-subject-tagpull_request:3530672903
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/stackrox/stackrox/19997/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7fd14a0588843364bf8e5113aadc1770d7c1b0fae217d032380357cfebe03080/stackrox/stackrox/pull/19997
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7fd14a0588843364bf8e5113aadc1770d7c1b0fae217d032380357cfebe03080/stackrox/stackrox/pull/19997
og:image:altDescription Replace per-logger zap sampling with a single shared sampler core. Each per-logger sampler allocated a [7][4096]counter array (~450 KB each). The shared sampler preserves the exact same...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedavdhacs
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/stackrox/stackrox git https://github.com/stackrox/stackrox.git
octolytics-dimension-user_id40638982
octolytics-dimension-user_loginstackrox
octolytics-dimension-repository_id434017296
octolytics-dimension-repository_nwostackrox/stackrox
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id434017296
octolytics-dimension-repository_network_root_nwostackrox/stackrox
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/stackrox/stackrox/pull/19997#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fstackrox%2Fstackrox%2Fpull%2F19997
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fstackrox%2Fstackrox%2Fpull%2F19997
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=stackrox%2Fstackrox
Reloadhttps://github.com/stackrox/stackrox/pull/19997
Reloadhttps://github.com/stackrox/stackrox/pull/19997
Reloadhttps://github.com/stackrox/stackrox/pull/19997
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
stackrox https://github.com/stackrox
stackroxhttps://github.com/stackrox/stackrox
Notifications https://github.com/login?return_to=%2Fstackrox%2Fstackrox
Fork 180 https://github.com/login?return_to=%2Fstackrox%2Fstackrox
Star 1.3k https://github.com/login?return_to=%2Fstackrox%2Fstackrox
Code https://github.com/stackrox/stackrox
Issues 53 https://github.com/stackrox/stackrox/issues
Pull requests 565 https://github.com/stackrox/stackrox/pulls
Actions https://github.com/stackrox/stackrox/actions
Security and quality 0 https://github.com/stackrox/stackrox/security
Insights https://github.com/stackrox/stackrox/pulse
Code https://github.com/stackrox/stackrox
Issues https://github.com/stackrox/stackrox/issues
Pull requests https://github.com/stackrox/stackrox/pulls
Actions https://github.com/stackrox/stackrox/actions
Security and quality https://github.com/stackrox/stackrox/security
Insights https://github.com/stackrox/stackrox/pulse
davdhacshttps://github.com/davdhacs
masterhttps://github.com/stackrox/stackrox/tree/master
davdhacs/pr1a-zap-samplinghttps://github.com/stackrox/stackrox/tree/davdhacs/pr1a-zap-sampling
Conversationhttps://github.com/stackrox/stackrox/pull/19997
Commits3 (3)https://github.com/stackrox/stackrox/pull/19997/commits
Checkshttps://github.com/stackrox/stackrox/pull/19997/checks
Files changedhttps://github.com/stackrox/stackrox/pull/19997/files
perf: combine logger zap samplinghttps://github.com/stackrox/stackrox/pull/19997#top
davdhacshttps://github.com/davdhacs
masterhttps://github.com/stackrox/stackrox/tree/master
davdhacs/pr1a-zap-samplinghttps://github.com/stackrox/stackrox/tree/davdhacs/pr1a-zap-sampling
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
Apr 14, 2026https://github.com/stackrox/stackrox/pull/19997#issue-4264843446
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
zap's SamplerWithOptions documentationhttps://pkg.go.dev/go.uber.org/zap/zapcore#NewSamplerWithOptions
CHANGELOG.mdhttps://github.com/stackrox/stackrox/blob/master/CHANGELOG.md
documentation PRhttps://spaces.redhat.com/display/StackRox/Submitting+a+User+Documentation+Pull+Request
GAhttps://github.com/stackrox/stackrox/blob/master/PR_GA.md
feature flaghttps://github.com/stackrox/stackrox/blob/master/pkg/features/README.md
inspectedhttps://docs.google.com/document/d/1d5ga073jkv4CO1kAJqp8MPGpC6E1bwyrCGZ7S5wKg3w/edit?tab=t.0#heading=h.w4ercgtcg0xp
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
https://github.com/davdhacs
https://github.com/claude
perf: remove per-logger zap sampling to save ~46 MB runtime memoryhttps://github.com/stackrox/stackrox/pull/19997/commits/d46c638d0f905c20aac62c39a28bca832d404834
d46c638https://github.com/stackrox/stackrox/pull/19997/commits/d46c638d0f905c20aac62c39a28bca832d404834
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
ai-assisted https://github.com/stackrox/stackrox/issues?q=state%3Aopen%20label%3Aai-assisted
Apr 14, 2026https://github.com/stackrox/stackrox/pull/19997#event-24504699843
https://github.com/apps/openshift-ci
openshift-cihttps://github.com/apps/openshift-ci
Apr 14, 2026https://github.com/stackrox/stackrox/pull/19997#issuecomment-4247277337
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
https://github.com/apps/openshift-ci
openshift-cihttps://github.com/apps/openshift-ci
do-not-merge/work-in-progress https://github.com/stackrox/stackrox/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress
Apr 14, 2026https://github.com/stackrox/stackrox/pull/19997#event-24504700934
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
Apr 14, 2026 https://github.com/stackrox/stackrox/pull/19997#ref-pullrequest-4264846172
perf: reduce memory baseline for busybox and sensor #19999 https://github.com/stackrox/stackrox/pull/19999
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 14, 2026https://github.com/stackrox/stackrox/pull/19997#issuecomment-4247384564
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
4d2d701https://github.com/stackrox/stackrox/commit/4d2d70104deef10a217393dacd08fa31e258f85d
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
davdhacshttps://github.com/davdhacs
April 14, 2026 15:44https://github.com/stackrox/stackrox/pull/19997#commits-pushed-ed46d66
https://github.com/davdhacs
https://github.com/claude
perf: use shared sampler instead of removing sampling entirelyhttps://github.com/stackrox/stackrox/pull/19997/commits/ed46d662c22fcaf26f420c9e118acbfaa6ad6fd9
ed46d66https://github.com/stackrox/stackrox/pull/19997/commits/ed46d662c22fcaf26f420c9e118acbfaa6ad6fd9
https://github.com/davdhacs
https://github.com/claude
chore: remove empty measurement tool placeholdershttps://github.com/stackrox/stackrox/pull/19997/commits/a87eface9c25be79e15f075d31e0fd830f2577f4
a87efachttps://github.com/stackrox/stackrox/pull/19997/commits/a87eface9c25be79e15f075d31e0fd830f2577f4
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
janiszhttps://github.com/janisz
parametalolhttps://github.com/parametalol
April 14, 2026 22:14https://github.com/stackrox/stackrox/pull/19997#event-24505715584
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
Apr 14, 2026https://github.com/stackrox/stackrox/pull/19997#issuecomment-4247533732
@parametalolhttps://github.com/parametalol
@janiszhttps://github.com/janisz
https://redhat-internal.slack.com/archives/C0321S70YK1/p1775843560874039https://redhat-internal.slack.com/archives/C0321S70YK1/p1775843560874039
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
Apr 14, 2026https://github.com/stackrox/stackrox/pull/19997#issuecomment-4247549535
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Apr 14, 2026https://github.com/stackrox/stackrox/pull/19997#issuecomment-4247559579
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
Codecovhttps://app.codecov.io/gh/stackrox/stackrox/pull/19997?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox
13998bdhttps://app.codecov.io/gh/stackrox/stackrox/commit/13998bd1dbdd6312fdfcf0bcd3a70536e982e2f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox
a87efachttps://app.codecov.io/gh/stackrox/stackrox/commit/a87eface9c25be79e15f075d31e0fd830f2577f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox
Flaghttps://app.codecov.io/gh/stackrox/stackrox/pull/19997/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox
go-unit-testshttps://app.codecov.io/gh/stackrox/stackrox/pull/19997/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox
Click herehttps://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox#carryforward-flags-in-the-pull-request-comment
☔ View full report in Codecov by Sentryhttps://app.codecov.io/gh/stackrox/stackrox/pull/19997?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stackrox
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
Apr 15, 2026https://github.com/stackrox/stackrox/pull/19997#event-24508910575
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
April 15, 2026 05:32https://github.com/stackrox/stackrox/pull/19997#event-24514816311
https://github.com/apps/openshift-ci
openshift-cihttps://github.com/apps/openshift-ci
do-not-merge/work-in-progress https://github.com/stackrox/stackrox/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress
Apr 15, 2026https://github.com/stackrox/stackrox/pull/19997#event-24514817467
https://github.com/apps/openshift-ci
openshift-cihttps://github.com/apps/openshift-ci
Apr 15, 2026https://github.com/stackrox/stackrox/pull/19997#issuecomment-4249931711
@davdhacshttps://github.com/davdhacs
a87efachttps://github.com/stackrox/stackrox/commit/a87eface9c25be79e15f075d31e0fd830f2577f4
linkhttps://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/stackrox_stackrox/19997/pull-ci-stackrox-stackrox-master-ocp-4-12-operator-e2e-tests/2044287737544052736
Full PR test historyhttps://prow.ci.openshift.org/pr-history?org=stackrox&repo=stackrox&pr=19997
Your PR dashboardhttps://prow.ci.openshift.org/pr?query=is:pr+state:open+author:davdhacs
herehttps://git.k8s.io/community/contributors/guide/pull-requests.md
kubernetes-sigs/prowhttps://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:
herehttps://go.k8s.io/bot-commands
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
https://github.com/parametalol
parametalolhttps://github.com/parametalol
Apr 15, 2026 https://github.com/stackrox/stackrox/pull/19997#pullrequestreview-4111920698
View reviewed changes https://github.com/stackrox/stackrox/pull/19997/files/a87eface9c25be79e15f075d31e0fd830f2577f4
https://github.com/parametalol
parametalolhttps://github.com/parametalol
Apr 15, 2026https://github.com/stackrox/stackrox/pull/19997#issuecomment-4250404290
@davdhacshttps://github.com/davdhacs
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
4d2d701https://github.com/stackrox/stackrox/commit/4d2d70104deef10a217393dacd08fa31e258f85d
Apr 15, 2026https://github.com/stackrox/stackrox/pull/19997#event-24527657141
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
April 15, 2026 12:25https://github.com/stackrox/stackrox/pull/19997#event-24527658604
perf: share single lumberjack writer across loggers #20018 https://github.com/stackrox/stackrox/pull/20018
feat: add ROX_LOGGING_TO_FILE to disable file logging #20019 https://github.com/stackrox/stackrox/pull/20019
vikin91https://github.com/vikin91
Apr 16, 2026 https://github.com/stackrox/stackrox/pull/19997#ref-commit-bfd875a
https://github.com/davdhacs
https://github.com/claude
https://github.com/vikin91
perf: combine logger zap sampling (https://github.com/stackrox/stackrox/commit/bfd875a7a358a93849c7220595a8e303b7558863
#19997https://github.com/stackrox/stackrox/pull/19997
)https://github.com/stackrox/stackrox/commit/bfd875a7a358a93849c7220595a8e303b7558863
bfd875ahttps://github.com/stackrox/stackrox/commit/bfd875a7a358a93849c7220595a8e303b7558863
https://github.com/davdhacs
davdhacshttps://github.com/davdhacs
Apr 24, 2026 https://github.com/stackrox/stackrox/pull/19997#ref-pullrequest-4245179605
perf: reduce busybox init-time memory allocation #19952 https://github.com/stackrox/stackrox/pull/19952
https://github.co/hiddenchars
https://github.com/stackrox/stackrox/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fstackrox%2Fstackrox%2Fpull%2F19997
https://github.com/parametalol
parametalol https://github.com/parametalol
https://github.com/stackrox/stackrox/pull/19997/files/a87eface9c25be79e15f075d31e0fd830f2577f4
https://github.com/janisz
janisz https://github.com/janisz
ai-assisted https://github.com/stackrox/stackrox/issues?q=state%3Aopen%20label%3Aai-assisted
Please reload this pagehttps://github.com/stackrox/stackrox/pull/19997
https://github.com/davdhacs
https://github.com/parametalol
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.