René's URL Explorer Experiment

Title: perf(ci): use stable test ldflags for Go test cache by davdhacs · Pull Request #19394 · stackrox/stackrox · GitHub

Open Graph Title: perf(ci): use stable test ldflags for Go test cache by davdhacs · Pull Request #19394 · stackrox/stackrox

X Title: perf(ci): use stable test ldflags for Go test cache by davdhacs · Pull Request #19394 · stackrox/stackrox

Description: Description Enable Go build cache reuse across commits by stabilizing the -X ldflags that Go includes in build ActionIDs. The problem scripts/go-tool.sh injects per-commit version values via -X ldflags: -X MainVersion=4.11.x-317-gabcdef (changes every commit — includes commit count + SHA) -X GitShortSha=abcdef (changes every commit) Go includes -X ldflags in the link ActionID (exec.go:1404: linkflags %q). When ldflags change, Go computes a new ActionID for every package that gets linked, causing cache misses for: Build binaries: the linked binary cache key changes (though Go patches -X values post-link, so the build cost is minimal ~1-2s) Test binaries: the test binary ID changes, causing all test results to miss the cache and re-run from scratch every commit The fix Split ldflags into two sets: Build ldflags: full per-commit version (unchanged from today) Test ldflags: stable base version tag (e.g. 4.11.x from git describe --tags --abbrev=0), GitShortSha skipped This preserves the correct version string in all built binaries while giving test binaries a stable ActionID across commits. -buildvcs=false Go 1.18 (adopted September 2022) silently enabled buildvcs=auto, which stamps vcs.revision, vcs.time, vcs.modified into every binary via the linker. No code in the repository reads this data — version stamping is done independently via the -X ldflags from status.sh. The buildvcs data was never intentionally enabled; it appeared as an unnoticed side effect of the Go 1.18 upgrade. The only time it was previously noticed was July 2024 (PR #11935) when it broke a scanner CI workflow. Adding -buildvcs=false removes this unused overhead. What changes One file: scripts/go-tool.sh Split ldflags into build_ldflags (full version) and test_ldflags (stable base tag) Tests get -X MainVersion=4.11.x instead of -X MainVersion=4.11.x-317-gabcdef Tests skip -X GitShortSha (not needed, changes per commit) -buildvcs=false added to both build and test What is preserved //XDef: annotations — unchanged status.sh — unchanged -X ldflags for builds — unchanged (full git describe version in binaries) version_data.go — unchanged Operator Dockerfile — unchanged Built binary version strings — identical to today Build cache impact Builds already benefit from GOCACHE for compilation (.a files are keyed by source hashes, not ldflags). The -X ldflags only affect linking, and Go patches -X values post-link so there is minimal build cost (~1-2s). The main benefit of this PR is enabling test result caching when combined with PR #19395 (file mtime stabilization). Together they achieve: Job Master warm Combined warm Speedup go unit tests 35m ~8m 4.5x go-postgres 31m ~36s 52x sensor-integration 26m ~2.5m 11x A combined test branch (davdhacs/test-cache-combined) with only these two changes is being tested to provide clean timing data. Partially generated by AI.

Open Graph Description: Description Enable Go build cache reuse across commits by stabilizing the -X ldflags that Go includes in build ActionIDs. The problem scripts/go-tool.sh injects per-commit version values via -X ldf...

X Description: Description Enable Go build cache reuse across commits by stabilizing the -X ldflags that Go includes in build ActionIDs. The problem scripts/go-tool.sh injects per-commit version values via -X ldf...

Opengraph URL: https://github.com/stackrox/stackrox/pull/19394

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width