René's URL Explorer Experiment


Title: Fix the Ollama FIM completion by jhrozek · Pull Request #848 · stacklok/codegate · GitHub

Open Graph Title: Fix the Ollama FIM completion by jhrozek · Pull Request #848 · stacklok/codegate

X Title: Fix the Ollama FIM completion by jhrozek · Pull Request #848 · stacklok/codegate

Description: We were not passing the suffix at all which was breaking the FIM completion. Fixes: #853

Open Graph Description: We were not passing the suffix at all which was breaking the FIM completion. Fixes: #853

X Description: We were not passing the suffix at all which was breaking the FIM completion. Fixes: #853

Opengraph URL: https://github.com/stacklok/codegate/pull/848

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:044c0531-97dd-7cca-ec27-3a4a0238c64f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92EE:11CC1B:56B76CD:768FAA0:698CD948
html-safe-nonce8ddc248753a7f0ac445b0057b58c068d42bfe6792d690f7a8e82cabfa411f5e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkVFOjExQ0MxQjo1NkI3NkNEOjc2OEZBQTA6Njk4Q0Q5NDgiLCJ2aXNpdG9yX2lkIjoiMTY4Mzc3MzYyNzMwMjczMDA1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc2e15d8e9aa4d97cfd83a6cc0c7f99ed683940a8c2164eb9fa500a9f32ad57b2
hovercard-subject-tagpull_request:2306663058
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/stacklok/codegate/848/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1db4a7d970058df64c9a45871e87dfb51f5b21172e10e392dc32b58de6d3caea/stacklok/codegate/pull/848
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1db4a7d970058df64c9a45871e87dfb51f5b21172e10e392dc32b58de6d3caea/stacklok/codegate/pull/848
og:image:altWe were not passing the suffix at all which was breaking the FIM completion. Fixes: #853
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejhrozek
hostnamegithub.com
expected-hostnamegithub.com
None640eeb7b6ff4d8d106235d228c0c286e82592d4d2403227b5b2b4fc5832297a4
turbo-cache-controlno-preview
go-importgithub.com/stacklok/codegate git https://github.com/stacklok/codegate.git
octolytics-dimension-user_id110237746
octolytics-dimension-user_loginstacklok
octolytics-dimension-repository_id886698771
octolytics-dimension-repository_nwostacklok/codegate
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id886698771
octolytics-dimension-repository_network_root_nwostacklok/codegate
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3d444f0a47beeeac94cddbb51c91ab408befe8d4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/stacklok/codegate/pull/848#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fstacklok%2Fcodegate%2Fpull%2F848
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fstacklok%2Fcodegate%2Fpull%2F848
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=stacklok%2Fcodegate
Reloadhttps://github.com/stacklok/codegate/pull/848
Reloadhttps://github.com/stacklok/codegate/pull/848
Reloadhttps://github.com/stacklok/codegate/pull/848
stacklok https://github.com/stacklok
codegatehttps://github.com/stacklok/codegate
Notifications https://github.com/login?return_to=%2Fstacklok%2Fcodegate
Fork 92 https://github.com/login?return_to=%2Fstacklok%2Fcodegate
Star 712 https://github.com/login?return_to=%2Fstacklok%2Fcodegate
Code https://github.com/stacklok/codegate
Issues 106 https://github.com/stacklok/codegate/issues
Pull requests 17 https://github.com/stacklok/codegate/pulls
Discussions https://github.com/stacklok/codegate/discussions
Actions https://github.com/stacklok/codegate/actions
Projects 0 https://github.com/stacklok/codegate/projects
Security 0 https://github.com/stacklok/codegate/security
Insights https://github.com/stacklok/codegate/pulse
Code https://github.com/stacklok/codegate
Issues https://github.com/stacklok/codegate/issues
Pull requests https://github.com/stacklok/codegate/pulls
Discussions https://github.com/stacklok/codegate/discussions
Actions https://github.com/stacklok/codegate/actions
Projects https://github.com/stacklok/codegate/projects
Security https://github.com/stacklok/codegate/security
Insights https://github.com/stacklok/codegate/pulse
jhrozekhttps://github.com/jhrozek
mainhttps://github.com/stacklok/codegate/tree/main
ollama_fim_fixhttps://github.com/stacklok/codegate/tree/ollama_fim_fix
Fix the Ollama FIM completion https://github.com/stacklok/codegate/pull/848#top
jhrozekhttps://github.com/jhrozek
mainhttps://github.com/stacklok/codegate/tree/main
ollama_fim_fixhttps://github.com/stacklok/codegate/tree/ollama_fim_fix
Conversation 1 https://github.com/stacklok/codegate/pull/848
Commits 7 https://github.com/stacklok/codegate/pull/848/commits
Checks 4 https://github.com/stacklok/codegate/pull/848/checks
Files changed https://github.com/stacklok/codegate/pull/848/files
Please reload this pagehttps://github.com/stacklok/codegate/pull/848
https://github.co/hiddenchars
https://github.com/stacklok/codegate/pull/{{ revealButtonHref }}
https://github.com/jhrozek
jhrozekhttps://github.com/jhrozek
Jan 30, 2025https://github.com/stacklok/codegate/pull/848#issue-2820599663
Please reload this pagehttps://github.com/stacklok/codegate/pull/848
#853https://github.com/stacklok/codegate/issues/853
Please reload this pagehttps://github.com/stacklok/codegate/pull/848
https://github.com/JAORMX
JAORMXhttps://github.com/JAORMX
Jan 30, 2025 https://github.com/stacklok/codegate/pull/848#pullrequestreview-2583880281
View reviewed changes https://github.com/stacklok/codegate/pull/848/files
jhrozekhttps://github.com/jhrozek
January 30, 2025 17:05https://github.com/stacklok/codegate/pull/848#commits-pushed-ccf0235
https://github.com/jhrozek
Do not send the system message, only the user message to Ollama FIMhttps://github.com/stacklok/codegate/pull/848/commits/ccf02352d40d2241af134b336364b9cab6a41cda
ccf0235https://github.com/stacklok/codegate/pull/848/commits/ccf02352d40d2241af134b336364b9cab6a41cda
https://github.com/jhrozek
Pass the suffix parameter if present to the FIM generate callhttps://github.com/stacklok/codegate/pull/848/commits/3b8a3d381aa5114b260685953985c6110fd81166
3b8a3d3https://github.com/stacklok/codegate/pull/848/commits/3b8a3d381aa5114b260685953985c6110fd81166
https://github.com/rdimitrov
https://github.com/jhrozek
Run make formathttps://github.com/stacklok/codegate/pull/848/commits/1a306867ff58f8fcf170ffaf11427bb7ed32563b
1a30686https://github.com/stacklok/codegate/pull/848/commits/1a306867ff58f8fcf170ffaf11427bb7ed32563b
https://github.com/rdimitrov
https://github.com/jhrozek
Fix the unit tests for ollama FIMhttps://github.com/stacklok/codegate/pull/848/commits/1100547207e757ca393a81312b0c9f86a7533ea2
1100547https://github.com/stacklok/codegate/pull/848/commits/1100547207e757ca393a81312b0c9f86a7533ea2
https://github.com/jhrozek
Pass along the raw parameterhttps://github.com/stacklok/codegate/pull/848/commits/328c048058beffcf065ad68b1004fa6a0192d17d
328c048https://github.com/stacklok/codegate/pull/848/commits/328c048058beffcf065ad68b1004fa6a0192d17d
https://github.com/jhrozek
Print the full reply as debug message in integration testshttps://github.com/stacklok/codegate/pull/848/commits/e91201da9f433a81c5504d4521abd8da73489a3c
e91201dhttps://github.com/stacklok/codegate/pull/848/commits/e91201da9f433a81c5504d4521abd8da73489a3c
https://github.com/jhrozek
Adjust the Ollama FIM testcase to match the model we are usinghttps://github.com/stacklok/codegate/pull/848/commits/4e2c5f1e7fdc8ca30367e8334b567ea6b5cdc2c4
4e2c5f1https://github.com/stacklok/codegate/pull/848/commits/4e2c5f1e7fdc8ca30367e8334b567ea6b5cdc2c4
https://github.com/jhrozek
jhrozekhttps://github.com/jhrozek
JAORMXhttps://github.com/JAORMX
stale reviewhttps://github.com/stacklok/codegate/pull/848#pullrequestreview-2583880281
4e2c5f1https://github.com/stacklok/codegate/commit/4e2c5f1e7fdc8ca30367e8334b567ea6b5cdc2c4
January 30, 2025 20:09https://github.com/stacklok/codegate/pull/848#event-16129526613
https://github.com/jhrozek
jhrozekhttps://github.com/jhrozek
force-pushedhttps://github.com/stacklok/codegate/compare/3df7c6cc00ffc25e457d65041ed6cd875953c1c2..4e2c5f1e7fdc8ca30367e8334b567ea6b5cdc2c4
3df7c6chttps://github.com/stacklok/codegate/commit/3df7c6cc00ffc25e457d65041ed6cd875953c1c2
4e2c5f1https://github.com/stacklok/codegate/commit/4e2c5f1e7fdc8ca30367e8334b567ea6b5cdc2c4
Compare https://github.com/stacklok/codegate/compare/3df7c6cc00ffc25e457d65041ed6cd875953c1c2..4e2c5f1e7fdc8ca30367e8334b567ea6b5cdc2c4
January 30, 2025 20:09https://github.com/stacklok/codegate/pull/848#event-16129526621
https://github.com/rdimitrov
rdimitrovhttps://github.com/rdimitrov
Jan 30, 2025 https://github.com/stacklok/codegate/pull/848#pullrequestreview-2585247010
View reviewed changes https://github.com/stacklok/codegate/pull/848/files/4e2c5f1e7fdc8ca30367e8334b567ea6b5cdc2c4
rdimitrovhttps://github.com/rdimitrov
https://github.com/stacklok/codegate/pull/848#pullrequestreview-2585247010
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/stacklok/codegate/pull/848
https://github.com/jhrozek
jhrozekhttps://github.com/jhrozek
d81e0e5https://github.com/stacklok/codegate/commit/d81e0e510143ec6d6f323860c25ea981659e25e9
Jan 31, 2025https://github.com/stacklok/codegate/pull/848#event-16135506744
Please reload this pagehttps://github.com/stacklok/codegate/pull/848
https://github.com/jhrozek
jhrozekhttps://github.com/jhrozek
January 31, 2025 08:12https://github.com/stacklok/codegate/pull/848#event-16135506966
lukehindshttps://github.com/lukehinds
Jan 31, 2025 https://github.com/stacklok/codegate/pull/848#ref-commit-0ebb02c
https://github.com/jhrozek
https://github.com/rdimitrov
https://github.com/lukehinds
Fix the Ollama FIM completion (https://github.com/stacklok/codegate/commit/0ebb02ce08fe20857b59ea60838bc42fd5b42e8b
#848https://github.com/stacklok/codegate/pull/848
)https://github.com/stacklok/codegate/commit/0ebb02ce08fe20857b59ea60838bc42fd5b42e8b
0ebb02chttps://github.com/stacklok/codegate/commit/0ebb02ce08fe20857b59ea60838bc42fd5b42e8b
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fstacklok%2Fcodegate%2Fpull%2F848
https://github.com/rdimitrov
rdimitrov https://github.com/rdimitrov
https://github.com/stacklok/codegate/pull/848/files/4e2c5f1e7fdc8ca30367e8334b567ea6b5cdc2c4
https://github.com/JAORMX
JAORMX https://github.com/JAORMX
https://github.com/stacklok/codegate/pull/848/files/3df7c6cc00ffc25e457d65041ed6cd875953c1c2
Ollama FIM doesn't work https://github.com/stacklok/codegate/issues/853
Please reload this pagehttps://github.com/stacklok/codegate/pull/848
https://github.com/jhrozek
https://github.com/JAORMX
https://github.com/rdimitrov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.