Title: CMake 3.11 (potential) issues · Issue #1361 · sqlitebrowser/sqlitebrowser · GitHub
Open Graph Title: CMake 3.11 (potential) issues · Issue #1361 · sqlitebrowser/sqlitebrowser
X Title: CMake 3.11 (potential) issues · Issue #1361 · sqlitebrowser/sqlitebrowser
Description: Details for the issue CMake 3.11 produces a mocs_compilation.cpp file that has the includes in a slightly different order than CMake 3.10. This affects the build of the embedded QScintilla, which has a header file declaring enum { SCI_SE...
Open Graph Description: Details for the issue CMake 3.11 produces a mocs_compilation.cpp file that has the includes in a slightly different order than CMake 3.10. This affects the build of the embedded QScintilla, which h...
X Description: Details for the issue CMake 3.11 produces a mocs_compilation.cpp file that has the includes in a slightly different order than CMake 3.10. This affects the build of the embedded QScintilla, which h...
Opengraph URL: https://github.com/sqlitebrowser/sqlitebrowser/issues/1361
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"CMake 3.11 (potential) issues","articleBody":"### Details for the issue\r\n\r\nCMake 3.11 produces a `mocs_compilation.cpp` file that has the includes in a slightly different order than CMake 3.10. This affects the build of the embedded QScintilla, which has a header file declaring `enum { SCI_SELECTALL = 2013 }` and a different header file doing `#define SCI_SELECTEALL 2013` .\r\n\r\nThere doesn't seem to be a CMake policy to change to the old sorting; you could add a weird hack to the Scintilla headers to force the declaration to be included from the header doing the `#define`ing -- before the `#define`s -- to avoid this. I don't know what (if) QScintilla is doing about it.\r\n\r\nIn the FreeBSD packaging (which is where I noticed this), we have just switched to using the system QScintilla. (Which needed patching -- the FindQScintilla module is a bit wonky).\r\n\r\n### Useful extra information\r\n\r\nActrual compiler error:\r\n\r\n```\r\nIn file included from libs/qscintilla/Qt4Qt5/qscintilla2_autogen/mocs_compilation.cpp:4:\r\nIn file included from libs/qscintilla/Qt4Qt5/qscintilla2_autogen/SARX73RSAP/moc_qsciabstractapis.cpp:9:\r\nIn file included from libs/qscintilla/Qt4Qt5/qscintilla2_autogen/SARX73RSAP/../../Qsci/qsciabstractapis.h:29:\r\nIn file included from libs/qscintilla/Qt4Qt5/Qsci/qsciscintilla.h:32:\r\nIn file included from libs/qscintilla/Qt4Qt5/Qsci/qscicommand.h:27:\r\nlibs/qscintilla/Qt4Qt5/Qsci/qsciscintillabase.h:121:9: error: expected identifier\r\n SCI_SELECTALL = 2013,\r\n ^\r\nlibs/qscintilla/Qt4Qt5/../include/Scintilla.h:65:23: note: expanded from macro 'SCI_SELECTALL'\r\n#define SCI_SELECTALL 2013\r\n```\r\n\r\n#### I'm opening this issue because:\r\n\r\n- [ ] DB4S is crashing\r\n- [ ] DB4S has a bug\r\n- [ ] DB4S needs a feature\r\n- [X] DB4S has another problem\r\n\r\n#### I'm using DB4S on:\r\n\r\n- [ ] Windows: ( _version:_ ___ )\r\n- [ ] Linux: ( _distro:_ ___ )\r\n- [ ] Mac OS: ( _version:_ ___ )\r\n- [X] Other: FreeBSD\r\n\r\n#### I'm using DB4S version:\r\n\r\n- [X] 3.10.1\r\n- [ ] 3.10.0\r\n- [ ] 3.9.1\r\n- [ ] Other: ___\r\n\r\n#### I have also:\r\n\r\n- [ ] Tried out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds\r\n- [X] Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20","author":{"url":"https://github.com/adriaandegroot","@type":"Person","name":"adriaandegroot"},"datePublished":"2018-04-02T13:12:06Z","url":"https://github.com/sqlitebrowser/sqlitebrowser/issues/1361"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:cf599c26-c6e0-860c-2e48-b18219b17f0d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D444:1007B2:11CB7F:191CDF:6AFD4DAE |
| html-safe-nonce | 24128918e4dcbb080782fd6a3313c34c28f2917f95b35dd381928d8824a1d97d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDQ0OjEwMDdCMjoxMUNCN0Y6MTkxQ0RGOjZBRkQ0REFFIiwidmlzaXRvcl9pZCI6Ijc1ODQ3NzAyNzEwNjcwNDgxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cf2b67d2c8511479949b3477a621e3f81eab7bc9c34822a94253f387344fb025 |
| hovercard-subject-tag | issue:310481168 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/sqlitebrowser/sqlitebrowser/1361/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4f8486bf3d7a3deb4e4168e15cbd84c6d33fede3f29283bd1d96b181ea271d8b/sqlitebrowser/sqlitebrowser/issues/1361 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4f8486bf3d7a3deb4e4168e15cbd84c6d33fede3f29283bd1d96b181ea271d8b/sqlitebrowser/sqlitebrowser/issues/1361 |
| og:image:alt | Details for the issue CMake 3.11 produces a mocs_compilation.cpp file that has the includes in a slightly different order than CMake 3.10. This affects the build of the embedded QScintilla, which h... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | adriaandegroot |
| hostname | github.com |
| expected-hostname | github.com |
| None | 66653c2e55a6fff2930be1bdf07ee4f8aa137e3956d056c822563be6f878755e |
| turbo-cache-control | no-preview |
| go-import | github.com/sqlitebrowser/sqlitebrowser git https://github.com/sqlitebrowser/sqlitebrowser.git |
| octolytics-dimension-user_id | 7454271 |
| octolytics-dimension-user_login | sqlitebrowser |
| octolytics-dimension-repository_id | 19416551 |
| octolytics-dimension-repository_nwo | sqlitebrowser/sqlitebrowser |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 19416551 |
| octolytics-dimension-repository_network_root_nwo | sqlitebrowser/sqlitebrowser |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b6f01f7cb9f35f8c09949773241a3d49dd04b340 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width