Title: fix: show database name field for SQL Server connections by octo-patch · Pull Request #185 · sqlchat/sqlchat · GitHub
Open Graph Title: fix: show database name field for SQL Server connections by octo-patch · Pull Request #185 · sqlchat/sqlchat
X Title: fix: show database name field for SQL Server connections by octo-patch · Pull Request #185 · sqlchat/sqlchat
Description: Fixes #166 Problem The database name field in the connection modal was only shown for PostgreSQL connections. SQL Server (MSSQL) also requires specifying a database name to establish a proper connection. Without this field, users cannot target a specific database when connecting to SQL Server, resulting in connection failures. Solution Updated showDatabaseField condition in CreateConnectionModal.tsx to also show the database name input field when SQL Server engine is selected: // Before const showDatabaseField = connection.engineType === Engine.PostgreSQL; // After const showDatabaseField = connection.engineType === Engine.PostgreSQL || connection.engineType === Engine.MSSQL; The MSSQL connector already supports the database property in the connection object — this change simply exposes it in the UI. Testing Select SQL Server as the database type in the connection modal Verify the "Database Name" field now appears Connect to a SQL Server instance with the database name specified
Open Graph Description: Fixes #166 Problem The database name field in the connection modal was only shown for PostgreSQL connections. SQL Server (MSSQL) also requires specifying a database name to establish a proper conne...
X Description: Fixes #166 Problem The database name field in the connection modal was only shown for PostgreSQL connections. SQL Server (MSSQL) also requires specifying a database name to establish a proper conne...
Opengraph URL: https://github.com/sqlchat/sqlchat/pull/185
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2c642133-b5a8-8120-292a-a9cc4916d759 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D6B8:20E521:64D3F9:8E3DDA:6A631185 |
| html-safe-nonce | 139160867723db77185609d9361593fdc2f64c4f6ac35d7ab9195cc8c6da60eb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkI4OjIwRTUyMTo2NEQzRjk6OEUzRERBOjZBNjMxMTg1IiwidmlzaXRvcl9pZCI6IjU5NzIwMDIwNTUyMDQ4MzU3MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c72e7a572520ae7db5fd083069d0e1d10a0a382afa66b7603488237d9a6f4204 |
| hovercard-subject-tag | pull_request:3559522410 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/sqlchat/sqlchat/pull/185/files |
| twitter:image | https://avatars.githubusercontent.com/u/266937838?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/266937838?s=400&v=4 |
| og:image:alt | Fixes #166 Problem The database name field in the connection modal was only shown for PostgreSQL connections. SQL Server (MSSQL) also requires specifying a database name to establish a proper conne... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1a6c056e02f174fffc096c521ec0ff6fb83e40a2ec8cb8875466ec1524872dd6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/sqlchat/sqlchat git https://github.com/sqlchat/sqlchat.git |
| octolytics-dimension-user_id | 128299021 |
| octolytics-dimension-user_login | sqlchat |
| octolytics-dimension-repository_id | 614656648 |
| octolytics-dimension-repository_nwo | sqlchat/sqlchat |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 614656648 |
| octolytics-dimension-repository_network_root_nwo | sqlchat/sqlchat |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a93e25585f487ddff9e3996c06d5b869d6e1828 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width