René's URL Explorer Experiment


Title: Invalid name generation when using python reserved keywords by QuentinN42 · Pull Request #89 · sqlc-dev/sqlc-gen-python · GitHub

Open Graph Title: Invalid name generation when using python reserved keywords by QuentinN42 · Pull Request #89 · sqlc-dev/sqlc-gen-python

X Title: Invalid name generation when using python reserved keywords by QuentinN42 · Pull Request #89 · sqlc-dev/sqlc-gen-python

Description: Fixes #88 To fix this issue, here is my proposition: class Author(pydantic.BaseModel): + model_config = pydantic.ConfigDict( + validate_by_alias=True, + validate_by_name=True, + ...

Open Graph Description: Fixes #88 To fix this issue, here is my proposition: class Author(pydantic.BaseModel): + model_config = pydantic.ConfigDict( + validate_by_alias=True, + validate_by_name=True, + ...

X Description: Fixes #88 To fix this issue, here is my proposition: class Author(pydantic.BaseModel): + model_config = pydantic.ConfigDict( + validate_by_alias=True, + validate_by_name=True, + ...

Opengraph URL: https://github.com/sqlc-dev/sqlc-gen-python/pull/89

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5bd046fb-456b-8c12-5111-73dcc6017fad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC00E:10D6B7:CF4554:1115E75:69702214
html-safe-nonce87669f0ba81f179b22ba7cc1447868d069c0c9bd98cbecef76a07cad63736b49
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDBFOjEwRDZCNzpDRjQ1NTQ6MTExNUU3NTo2OTcwMjIxNCIsInZpc2l0b3JfaWQiOiIzMzA5NjA3NTc3MDc0MDE2Nzg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc0a0f77554a74cdde5e86e902f8af36b88d01b7051cf3dd83f4f16296ed78b10
hovercard-subject-tagpull_request:2695480932
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sqlc-dev/sqlc-gen-python/89/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4fab43210c1892a618d72ee0ae3b5c80115e20c2280a1ab08a9da14d67a63e07/sqlc-dev/sqlc-gen-python/pull/89
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4fab43210c1892a618d72ee0ae3b5c80115e20c2280a1ab08a9da14d67a63e07/sqlc-dev/sqlc-gen-python/pull/89
og:image:altFixes #88 To fix this issue, here is my proposition: class Author(pydantic.BaseModel): + model_config = pydantic.ConfigDict( + validate_by_alias=True, + validate_by_name=True, + ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameQuentinN42
hostnamegithub.com
expected-hostnamegithub.com
None26d344b5c41e8171f05f1b33de4ed89a222e01250099adfcd988bb0e02fd1cbb
turbo-cache-controlno-preview
go-importgithub.com/sqlc-dev/sqlc-gen-python git https://github.com/sqlc-dev/sqlc-gen-python.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id548530161
octolytics-dimension-repository_nwosqlc-dev/sqlc-gen-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id548530161
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc-gen-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9f0c240136b4f91bdb92e57a88ba5dc425cbdb12
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc-gen-python/pull/89#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc-gen-python%2Fpull%2F89
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc-gen-python%2Fpull%2F89
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc-gen-python
Reloadhttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
Reloadhttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
Reloadhttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
sqlc-dev https://github.com/sqlc-dev
sqlc-gen-pythonhttps://github.com/sqlc-dev/sqlc-gen-python
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc-gen-python
Fork 46 https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc-gen-python
Star 304 https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc-gen-python
Code https://github.com/sqlc-dev/sqlc-gen-python
Issues 33 https://github.com/sqlc-dev/sqlc-gen-python/issues
Pull requests 13 https://github.com/sqlc-dev/sqlc-gen-python/pulls
Actions https://github.com/sqlc-dev/sqlc-gen-python/actions
Projects 0 https://github.com/sqlc-dev/sqlc-gen-python/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/sqlc-dev/sqlc-gen-python/security
Please reload this pagehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
Insights https://github.com/sqlc-dev/sqlc-gen-python/pulse
Code https://github.com/sqlc-dev/sqlc-gen-python
Issues https://github.com/sqlc-dev/sqlc-gen-python/issues
Pull requests https://github.com/sqlc-dev/sqlc-gen-python/pulls
Actions https://github.com/sqlc-dev/sqlc-gen-python/actions
Projects https://github.com/sqlc-dev/sqlc-gen-python/projects
Security https://github.com/sqlc-dev/sqlc-gen-python/security
Insights https://github.com/sqlc-dev/sqlc-gen-python/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsqlc-dev%2Fsqlc-gen-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc-gen-python%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/sqlc-dev/sqlc-gen-python/pull/89#issue-comment-box
QuentinN42https://github.com/QuentinN42
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc-gen-python/tree/main
Escape-Technologies:mainhttps://github.com/Escape-Technologies/sqlc-gen-python/tree/main
Invalid name generation when using python reserved keywords https://github.com/sqlc-dev/sqlc-gen-python/pull/89#top
QuentinN42https://github.com/QuentinN42
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc-gen-python/tree/main
Escape-Technologies:mainhttps://github.com/Escape-Technologies/sqlc-gen-python/tree/main
Conversation 6 https://github.com/sqlc-dev/sqlc-gen-python/pull/89
Commits 5 https://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits
Checks 0 https://github.com/sqlc-dev/sqlc-gen-python/pull/89/checks
Files changed https://github.com/sqlc-dev/sqlc-gen-python/pull/89/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc-gen-python/pull/{{ revealButtonHref }}
https://github.com/QuentinN42
QuentinN42https://github.com/QuentinN42
Jul 25, 2025https://github.com/sqlc-dev/sqlc-gen-python/pull/89#issue-3263813507
#88https://github.com/sqlc-dev/sqlc-gen-python/issues/88
Please reload this pagehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
QuentinN42https://github.com/QuentinN42
July 25, 2025 15:37https://github.com/sqlc-dev/sqlc-gen-python/pull/89#commits-pushed-19e8d56
https://github.com/QuentinN42
feat: added invalid test for invalid name generation when using pytho…https://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits/19e8d56813a83664bc19c12a3121e84e8bc7af66
19e8d56https://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits/19e8d56813a83664bc19c12a3121e84e8bc7af66
https://github.com/QuentinN42
fix: added reserved python keywordshttps://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits/f92824439ae12b72d107d31b4cffcfcb92cb79f8
f928244https://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits/f92824439ae12b72d107d31b4cffcfcb92cb79f8
https://github.com/QuentinN42
refactor: use poet.Nodehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits/24fcd39f834e82f95563e5e23a31519d7e48bc88
24fcd39https://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits/24fcd39f834e82f95563e5e23a31519d7e48bc88
https://github.com/QuentinN42
test: added more tests to the poet pkg and generated the pydantic.Con…https://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits/a5d1ee84533fc7db53fb358b3869e91eb80ea756
a5d1ee8https://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits/a5d1ee84533fc7db53fb358b3869e91eb80ea756
https://github.com/QuentinN42
feat: added dataclasses testshttps://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits/068fd251596b60ba31d51fb8ffd3a5b057413269
068fd25https://github.com/sqlc-dev/sqlc-gen-python/pull/89/commits/068fd251596b60ba31d51fb8ffd3a5b057413269
https://github.com/devstein
devsteinhttps://github.com/devstein
Copilothttps://github.com/apps/copilot-pull-request-reviewer
devsteinhttps://github.com/devstein
kyleconroyhttps://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
November 24, 2025 16:17https://github.com/sqlc-dev/sqlc-gen-python/pull/89#event-21143198937
started reviewinghttps://github.com/copilot/tasks/pull/PR_kwDOILHn8c6gqcZk?session_id=dd2af941-4b79-42f2-a0d0-0efd99328038
devsteinhttps://github.com/devstein
November 24, 2025 16:18https://github.com/sqlc-dev/sqlc-gen-python/pull/89#event-21143209829
View session https://github.com/copilot/tasks/pull/PR_kwDOILHn8c6gqcZk?session_id=dd2af941-4b79-42f2-a0d0-0efd99328038
finished reviewinghttps://github.com/copilot/tasks/pull/PR_kwDOILHn8c6gqcZk?session_id=dd2af941-4b79-42f2-a0d0-0efd99328038
devsteinhttps://github.com/devstein
November 24, 2025 16:20https://github.com/sqlc-dev/sqlc-gen-python/pull/89#event-21143267242
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 24, 2025 https://github.com/sqlc-dev/sqlc-gen-python/pull/89#pullrequestreview-3501230008
View reviewed changes https://github.com/sqlc-dev/sqlc-gen-python/pull/89/files/068fd251596b60ba31d51fb8ffd3a5b057413269
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/sqlc-dev/sqlc-gen-python/pull/89#pullrequestreview-3501230008
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add Copilot custom instructionshttps://github.com/sqlc-dev/sqlc-gen-python/new/main/.github/instructions?filename=*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
internal/gen.gohttps://github.com/sqlc-dev/sqlc-gen-python/pull/89/files/068fd251596b60ba31d51fb8ffd3a5b057413269#diff-8e745f10e32a54e4d9b0479fbd670007f1a9658bc9518177d5261b27ba46ba1c
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 24, 2025https://github.com/sqlc-dev/sqlc-gen-python/pull/89#discussion_r2556932781
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
internal/poet/builders.gohttps://github.com/sqlc-dev/sqlc-gen-python/pull/89/files/068fd251596b60ba31d51fb8ffd3a5b057413269#diff-8cb403d7f1275b029703ffb3335e6680d1e780d5ae0d0d3b1e55045143af27e1
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 24, 2025https://github.com/sqlc-dev/sqlc-gen-python/pull/89#discussion_r2556932809
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
internal/poet/reserved_test.gohttps://github.com/sqlc-dev/sqlc-gen-python/pull/89/files/068fd251596b60ba31d51fb8ffd3a5b057413269#diff-c389135b4e9d6b7f1af523db7723e19415837b977dca190cfd58303ebfca5468
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 24, 2025https://github.com/sqlc-dev/sqlc-gen-python/pull/89#discussion_r2556932828
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
internal/poet/reserved.gohttps://github.com/sqlc-dev/sqlc-gen-python/pull/89/files/068fd251596b60ba31d51fb8ffd3a5b057413269#diff-87848398b0d3db7be0a3b423e086eefec41bcbcf1db3b05b26557d9ebc80455b
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 24, 2025https://github.com/sqlc-dev/sqlc-gen-python/pull/89#discussion_r2556932848
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
internal/endtoend/endtoend_test.gohttps://github.com/sqlc-dev/sqlc-gen-python/pull/89/files/068fd251596b60ba31d51fb8ffd3a5b057413269#diff-05b57a482f9a1eab1ee8b30fa77f0daa2bd2e3f7b1e5031e477a851ae3ec7f5e
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 24, 2025https://github.com/sqlc-dev/sqlc-gen-python/pull/89#discussion_r2556932873
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
Copilothttps://docs.github.com/copilot/responsible-use-of-github-copilot-features/responsible-use-of-github-copilot-code-review
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc-gen-python%2Fpull%2F89
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
https://github.com/sqlc-dev/sqlc-gen-python/pull/89/files/068fd251596b60ba31d51fb8ffd3a5b057413269
https://github.com/devstein
devstein https://github.com/devstein
https://github.com/kyleconroy
kyleconroy https://github.com/kyleconroy
Invalid name generation when using python reserved keywords https://github.com/sqlc-dev/sqlc-gen-python/issues/88
Please reload this pagehttps://github.com/sqlc-dev/sqlc-gen-python/pull/89
https://github.com/QuentinN42
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.