| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9c43bbb1-1130-0394-c411-9c718e088c9e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC20:27E5CD:23A11F9:2D95DFA:6B0175EF |
| html-safe-nonce | 68271d75af55bd3de5bf8a2cc7dfdf16ef6bd350319e8997e0d301eb5ed02219 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzIwOjI3RTVDRDoyM0ExMUY5OjJEOTVERkE6NkIwMTc1RUYiLCJ2aXNpdG9yX2lkIjoiNDg4Njk2MjQ1Mjg4NzA3NDI4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3c3be03c9193cc8976c16cb128c7fe84439ff21945de2066ea875cc68e394bdd |
| hovercard-subject-tag | pull_request:622931201 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/sqlc-dev/sqlc/pull/984/files |
| twitter:image | https://avatars.githubusercontent.com/u/7122116?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7122116?s=400&v=4 |
| og:image:alt | Identifies every column with a returned struct for queries.
This is a breaking change. I'm very open to comments, ideas, or reasons why this shouldn't even happen. To prevent breakage we co... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git |
| octolytics-dimension-user_id | 136738596 |
| octolytics-dimension-user_login | sqlc-dev |
| octolytics-dimension-repository_id | 193160679 |
| octolytics-dimension-repository_nwo | sqlc-dev/sqlc |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 193160679 |
| octolytics-dimension-repository_network_root_nwo | sqlc-dev/sqlc |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/sqlc-dev/sqlc/pull/984/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F984%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F984%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sqlc-dev%2Fsqlc |
| Reload | https://github.com/sqlc-dev/sqlc/pull/984/files |
| Reload | https://github.com/sqlc-dev/sqlc/pull/984/files |
| Reload | https://github.com/sqlc-dev/sqlc/pull/984/files |
| sqlc-dev | https://github.com/sqlc-dev |
| sqlc | https://github.com/sqlc-dev/sqlc |
| Code | https://github.com/sqlc-dev/sqlc |
| Issues600 (600) | https://github.com/sqlc-dev/sqlc/issues |
| Pull requests132 (132) | https://github.com/sqlc-dev/sqlc/pulls |
| Discussions | https://github.com/sqlc-dev/sqlc/discussions |
| Actions | https://github.com/sqlc-dev/sqlc/actions |
| Projects | https://github.com/sqlc-dev/sqlc/projects |
| Security and quality | https://github.com/sqlc-dev/sqlc/security |
| Insights | https://github.com/sqlc-dev/sqlc/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose |
| kylecarbs | https://github.com/kylecarbs |
| sqlc-dev:main | https://github.com/sqlc-dev/sqlc/tree/main |
| kylecarbs:embedded | https://github.com/kylecarbs/sqlc/tree/embedded |
|
Conversation
11
| https://github.com/sqlc-dev/sqlc/pull/984 |
|
Commits
8
| https://github.com/sqlc-dev/sqlc/pull/984/commits |
|
Checks
0
| https://github.com/sqlc-dev/sqlc/pull/984/checks |
|
Files changed
| https://github.com/sqlc-dev/sqlc/pull/984/files |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/984/files |
|
feat: Add embedded structs based on result match
| https://github.com/sqlc-dev/sqlc/pull/984/files#top |
|
Show all changes
8 commits
| https://github.com/sqlc-dev/sqlc/pull/984/files |
|
7c4be53
feat: Add identified embeddable structs
kylecarbs Apr 26, 2021
| https://github.com/sqlc-dev/sqlc/pull/984/commits/7c4be53b0731c70d4cc8b97e2c092e126bcc5c70 |
|
4045387
Embedded structs now fully work
kylecarbs Apr 26, 2021
| https://github.com/sqlc-dev/sqlc/pull/984/commits/404538788147313d9271dfcc2e6b2f03c3b2f42a |
|
a37d35a
Fix embedding of multiple structs
kylecarbs Apr 26, 2021
| https://github.com/sqlc-dev/sqlc/pull/984/commits/a37d35a85c2467686d6bed7cda686dad3d44fe84 |
|
76b5622
Fix duplicate identifier incrementing
kylecarbs Apr 26, 2021
| https://github.com/sqlc-dev/sqlc/pull/984/commits/76b5622c2175755989d7e447284ad22a02a344af |
|
28cc3bc
Fix single columns marshal
kylecarbs Apr 26, 2021
| https://github.com/sqlc-dev/sqlc/pull/984/commits/28cc3bcb907cf9d37b0aae86e6e74678a9db1749 |
|
52f4996
Directly access embedded struct when referenced
kylecarbs Apr 26, 2021
| https://github.com/sqlc-dev/sqlc/pull/984/commits/52f49961e87bdda5e7c9c2ff2e72dfdbe02c0060 |
|
31f95b0
Fix length access when too many fields
kylecarbs Apr 26, 2021
| https://github.com/sqlc-dev/sqlc/pull/984/commits/31f95b0cae10ec6501a280f196a350176688d3d8 |
|
949e5be
Merge branch 'main' into embedded
kylecarbs May 5, 2021
| https://github.com/sqlc-dev/sqlc/pull/984/commits/949e5be1d450e7f62072733052cd7a3755d97230 |
|
Clear filters
| https://github.com/sqlc-dev/sqlc/pull/984/files |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/984/files |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/984/files |
|
field.go
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-54f4a6c7f5b7bb232f06a9dac29cfbf22cbfe60c5b300fee166771cbf1773fbb |
|
gen.go
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-c04dab838c419b0703213fce993d48f3d4f5fd6a659bb993d5528dd763b36198 |
|
query.go
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-0882adeeefd3539f903f1ec19fe956505df3f46aed6221453d055b82c771a46a |
|
result.go
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-554ace7a315b3c4704a348e208df36f1f4cffbd0ba9dfd51048f11fbffe8c138 |
|
struct.go
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-73d191f77e550f86ed1fb7f8d2122d1917f498f5bed6951d9d853246d4b7c3d2 |
| internal/codegen/golang/field.go | https://github.com/sqlc-dev/sqlc/pull/984/files#diff-54f4a6c7f5b7bb232f06a9dac29cfbf22cbfe60c5b300fee166771cbf1773fbb |
|
View file
| https://github.com/kylecarbs/sqlc/blob/949e5be1d450e7f62072733052cd7a3755d97230/internal/codegen/golang/field.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/984/{{ revealButtonHref }} |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-54f4a6c7f5b7bb232f06a9dac29cfbf22cbfe60c5b300fee166771cbf1773fbb |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-54f4a6c7f5b7bb232f06a9dac29cfbf22cbfe60c5b300fee166771cbf1773fbb |
| internal/codegen/golang/gen.go | https://github.com/sqlc-dev/sqlc/pull/984/files#diff-c04dab838c419b0703213fce993d48f3d4f5fd6a659bb993d5528dd763b36198 |
|
View file
| https://github.com/kylecarbs/sqlc/blob/949e5be1d450e7f62072733052cd7a3755d97230/internal/codegen/golang/gen.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/984/{{ revealButtonHref }} |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-c04dab838c419b0703213fce993d48f3d4f5fd6a659bb993d5528dd763b36198 |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-c04dab838c419b0703213fce993d48f3d4f5fd6a659bb993d5528dd763b36198 |
| internal/codegen/golang/query.go | https://github.com/sqlc-dev/sqlc/pull/984/files#diff-0882adeeefd3539f903f1ec19fe956505df3f46aed6221453d055b82c771a46a |
|
View file
| https://github.com/kylecarbs/sqlc/blob/949e5be1d450e7f62072733052cd7a3755d97230/internal/codegen/golang/query.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/984/{{ revealButtonHref }} |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-0882adeeefd3539f903f1ec19fe956505df3f46aed6221453d055b82c771a46a |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-0882adeeefd3539f903f1ec19fe956505df3f46aed6221453d055b82c771a46a |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-0882adeeefd3539f903f1ec19fe956505df3f46aed6221453d055b82c771a46a |
| internal/codegen/golang/result.go | https://github.com/sqlc-dev/sqlc/pull/984/files#diff-554ace7a315b3c4704a348e208df36f1f4cffbd0ba9dfd51048f11fbffe8c138 |
|
View file
| https://github.com/kylecarbs/sqlc/blob/949e5be1d450e7f62072733052cd7a3755d97230/internal/codegen/golang/result.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/984/{{ revealButtonHref }} |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-554ace7a315b3c4704a348e208df36f1f4cffbd0ba9dfd51048f11fbffe8c138 |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-554ace7a315b3c4704a348e208df36f1f4cffbd0ba9dfd51048f11fbffe8c138 |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-554ace7a315b3c4704a348e208df36f1f4cffbd0ba9dfd51048f11fbffe8c138 |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-554ace7a315b3c4704a348e208df36f1f4cffbd0ba9dfd51048f11fbffe8c138 |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-554ace7a315b3c4704a348e208df36f1f4cffbd0ba9dfd51048f11fbffe8c138 |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-554ace7a315b3c4704a348e208df36f1f4cffbd0ba9dfd51048f11fbffe8c138 |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-554ace7a315b3c4704a348e208df36f1f4cffbd0ba9dfd51048f11fbffe8c138 |
| internal/codegen/golang/struct.go | https://github.com/sqlc-dev/sqlc/pull/984/files#diff-73d191f77e550f86ed1fb7f8d2122d1917f498f5bed6951d9d853246d4b7c3d2 |
|
View file
| https://github.com/kylecarbs/sqlc/blob/949e5be1d450e7f62072733052cd7a3755d97230/internal/codegen/golang/struct.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/984/{{ revealButtonHref }} |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-73d191f77e550f86ed1fb7f8d2122d1917f498f5bed6951d9d853246d4b7c3d2 |
|
| https://github.com/sqlc-dev/sqlc/pull/984/files#diff-73d191f77e550f86ed1fb7f8d2122d1917f498f5bed6951d9d853246d4b7c3d2 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |