| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ba77a81e-5cd1-574c-b66b-e25562a3b841 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 86F6:1087D4:27FF8A4:35793BB:6B01B867 |
| html-safe-nonce | 1cdc5426f267305475743ca0245e7d8e292f1e0e33ad27e8e1ea210fc1f619f9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkY2OjEwODdENDoyN0ZGOEE0OjM1NzkzQkI6NkIwMUI4NjciLCJ2aXNpdG9yX2lkIjoiMzQwMDY5MDcxNjYxODM3MzIyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9f72bcc73d85b6ba1131dc8f32e26a93d097e00701ed0679789e90aaced356ed |
| hovercard-subject-tag | pull_request:590926710 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/sqlc-dev/sqlc/pull/939/files |
| twitter:image | https://avatars.githubusercontent.com/u/794548?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/794548?s=400&v=4 |
| og:image:alt | Based on comments on my initial python codegen PR I've put together some potential changes to the generated python code.
I've marked this as a draft PR because I've only made manual edi... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git |
| octolytics-dimension-user_id | 136738596 |
| octolytics-dimension-user_login | sqlc-dev |
| octolytics-dimension-repository_id | 193160679 |
| octolytics-dimension-repository_nwo | sqlc-dev/sqlc |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 193160679 |
| octolytics-dimension-repository_network_root_nwo | sqlc-dev/sqlc |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/sqlc-dev/sqlc/pull/939/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F939%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F939%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sqlc-dev%2Fsqlc |
| Reload | https://github.com/sqlc-dev/sqlc/pull/939/files |
| Reload | https://github.com/sqlc-dev/sqlc/pull/939/files |
| Reload | https://github.com/sqlc-dev/sqlc/pull/939/files |
| sqlc-dev | https://github.com/sqlc-dev |
| sqlc | https://github.com/sqlc-dev/sqlc |
| Code | https://github.com/sqlc-dev/sqlc |
| Issues600 (600) | https://github.com/sqlc-dev/sqlc/issues |
| Pull requests132 (132) | https://github.com/sqlc-dev/sqlc/pulls |
| Discussions | https://github.com/sqlc-dev/sqlc/discussions |
| Actions | https://github.com/sqlc-dev/sqlc/actions |
| Projects | https://github.com/sqlc-dev/sqlc/projects |
| Security and quality | https://github.com/sqlc-dev/sqlc/security |
| Insights | https://github.com/sqlc-dev/sqlc/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose |
| kyleconroy | https://github.com/kyleconroy |
| sqlc-dev:master | https://github.com/sqlc-dev/sqlc/tree/master |
| robholt:python-improvements | https://github.com/robholt/sqlc/tree/python-improvements |
|
Conversation
17
| https://github.com/sqlc-dev/sqlc/pull/939 |
|
Commits
3
| https://github.com/sqlc-dev/sqlc/pull/939/commits |
|
Checks
0
| https://github.com/sqlc-dev/sqlc/pull/939/checks |
|
Files changed
| https://github.com/sqlc-dev/sqlc/pull/939/files |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939/files |
|
Python: Eliminate runtime package and use sqlalchemy
| https://github.com/sqlc-dev/sqlc/pull/939/files#top |
|
Show all changes
3 commits
| https://github.com/sqlc-dev/sqlc/pull/939/files |
|
c95b5ef
Manually edit python example code
Mar 11, 2021
| https://github.com/sqlc-dev/sqlc/pull/939/commits/c95b5efcac419c89c7cfd55a935dfffd918e671c |
|
d9c77db
Remove leftover debug code in python tests
Mar 11, 2021
| https://github.com/sqlc-dev/sqlc/pull/939/commits/d9c77db3e1e3cf6c3478ab8be833f156be76eda2 |
|
5f73dbd
Python: implement new codegen
Mar 15, 2021
| https://github.com/sqlc-dev/sqlc/pull/939/commits/5f73dbdaca13f5e5484d60d035e5ab00df741e21 |
|
Clear filters
| https://github.com/sqlc-dev/sqlc/pull/939/files |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939/files |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939/files |
|
requirements.txt
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-c233c301c314607d2dfcee9a9ec0d5a7b78a67d2c8927808fd4c9d382bbb4a8e |
|
sqlc.json
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-51ce5461fb9e627abb72ef91a05f41da8a7272d3d6d9101fe941b3b5ed7d99d9 |
|
models.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-ee5ac580ad63bf714e44b9be5731416a492cf541f81038ad93aa944ad974a4c4 |
|
query.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-c89f8979af02e775ccddfaba91d614eddb3bab71498afba34cc43d6464cffad9 |
|
models.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-96909b321988c2a971e29eaa178d76f6c13550c628fc9238525934947d95c7bf |
|
query.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-ecc31cbe8cf7dd3168f2145777c647e51a41fed5f009a2ca5531136b75d3513c |
|
migrations.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-085a2592d365b45529f54567683e6f86bcfcaacf6861c444c1f1587f6198e803 |
|
models.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-bb527e6d8bb3ab4658d672ea3f63e9c5c583c927cc70cab2ec1066d5c2364e4a |
|
query-building.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-509b3335e4fbca4d213186c60be3d59e4f1d53846d86dd576357315b09e8ce08 |
|
city.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-bdad798e6b8e85201714a8192ac42845523dbbb5a5a017d6b739ef66e5839fc1 |
|
models.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-4fe6296bd7df312e72842738a7944d256832948fbb1df1adeaab3a9391fc3eee |
|
venue.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-40122bbc61cbbfbffce8e3eb9733a7701e4c3cb675a4190f93b76172ee6dc03c |
|
conftest.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-6fb414c226d7f3b94d6748e88dbd6f5839d7843cd1b7c6e75ced2f014bc22b89 |
|
test_authors.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-25cbb374c04950655a28cbc365e7abb6c80108da5c564057c41f8bad903a84c3 |
|
test_booktest.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-2f6d7f5b3991bc5a950ba891a64ef574e2be28ff5506b892fc3a36bc355e0f89 |
|
test_ondeck.py
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-9472850ce0e42b3e9a2c736765bc700caeff7cae221c83866f7337d41d743e86 |
|
gen.go
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-4a1cf90ba2481aa2ceb7d4fa05de163b7af23afe883d14d85dac6f7bd031fe67 |
|
imports.go
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-ec691f29985038d8622fe3e038f5ef9ea3dab8bde745df1a7a201d1e5a35b3e5 |
|
config.go
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-54c7c1af5fa8d5db4dc49f0e8e80e93ba2b1183ba4d5c9e2e5729e6deae6a3cd |
|
v_two.go
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-5cbb844a4791fafa0b189ed613ce169fd9157f636b7767f35555c62d91206bd4 |
| examples/python/requirements.txt | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-c233c301c314607d2dfcee9a9ec0d5a7b78a67d2c8927808fd4c9d382bbb4a8e |
|
View file
| https://github.com/robholt/sqlc/blob/5f73dbdaca13f5e5484d60d035e5ab00df741e21/examples/python/requirements.txt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/939/{{ revealButtonHref }} |
|
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-c233c301c314607d2dfcee9a9ec0d5a7b78a67d2c8927808fd4c9d382bbb4a8e |
| examples/python/sqlc.json | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-51ce5461fb9e627abb72ef91a05f41da8a7272d3d6d9101fe941b3b5ed7d99d9 |
|
View file
| https://github.com/robholt/sqlc/blob/5f73dbdaca13f5e5484d60d035e5ab00df741e21/examples/python/sqlc.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/939/{{ revealButtonHref }} |
|
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-51ce5461fb9e627abb72ef91a05f41da8a7272d3d6d9101fe941b3b5ed7d99d9 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939/files |
|
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-51ce5461fb9e627abb72ef91a05f41da8a7272d3d6d9101fe941b3b5ed7d99d9 |
|
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-51ce5461fb9e627abb72ef91a05f41da8a7272d3d6d9101fe941b3b5ed7d99d9 |
|
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-51ce5461fb9e627abb72ef91a05f41da8a7272d3d6d9101fe941b3b5ed7d99d9 |
|
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-51ce5461fb9e627abb72ef91a05f41da8a7272d3d6d9101fe941b3b5ed7d99d9 |
| examples/python/src/authors/models.py | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-ee5ac580ad63bf714e44b9be5731416a492cf541f81038ad93aa944ad974a4c4 |
|
View file
| https://github.com/robholt/sqlc/blob/5f73dbdaca13f5e5484d60d035e5ab00df741e21/examples/python/src/authors/models.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/939/{{ revealButtonHref }} |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939/files |
|
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-ee5ac580ad63bf714e44b9be5731416a492cf541f81038ad93aa944ad974a4c4 |
| examples/python/src/authors/query.py | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-c89f8979af02e775ccddfaba91d614eddb3bab71498afba34cc43d6464cffad9 |
|
View file
| https://github.com/robholt/sqlc/blob/5f73dbdaca13f5e5484d60d035e5ab00df741e21/examples/python/src/authors/query.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/939/{{ revealButtonHref }} |
| examples/python/src/booktest/models.py | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-96909b321988c2a971e29eaa178d76f6c13550c628fc9238525934947d95c7bf |
|
View file
| https://github.com/robholt/sqlc/blob/5f73dbdaca13f5e5484d60d035e5ab00df741e21/examples/python/src/booktest/models.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/939/{{ revealButtonHref }} |
|
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-96909b321988c2a971e29eaa178d76f6c13550c628fc9238525934947d95c7bf |
|
| https://github.com/sqlc-dev/sqlc/pull/939/files#diff-96909b321988c2a971e29eaa178d76f6c13550c628fc9238525934947d95c7bf |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |