| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2b3d63cc-4efa-c67d-146b-f52eec3ee9f2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB54:19B6A2:8DF6B2:BB9EFE:6B01B271 |
| html-safe-nonce | 97dde9df089d428568e0340310040af9433f0295fcf5122008982bcf97a27bd5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjU0OjE5QjZBMjo4REY2QjI6QkI5RUZFOjZCMDFCMjcxIiwidmlzaXRvcl9pZCI6Ijg1ODkxMDQ1NTI3MTA2MTU2NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 134ead1c47ad30a281e6c38c99c29d1b7636343259ffbb54aad9ee5cab9d1328 |
| hovercard-subject-tag | pull_request:590926710 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sqlc-dev/sqlc/939/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e740051e37ab0345fb14589530f20e921895b3e6281ae48e9fce89ad2945b163/sqlc-dev/sqlc/pull/939 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e740051e37ab0345fb14589530f20e921895b3e6281ae48e9fce89ad2945b163/sqlc-dev/sqlc/pull/939 |
| og:image:alt | Based on comments on my initial python codegen PR I've put together some potential changes to the generated python code.
I've marked this as a draft PR because I've only made manual edi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | robholt |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git |
| octolytics-dimension-user_id | 136738596 |
| octolytics-dimension-user_login | sqlc-dev |
| octolytics-dimension-repository_id | 193160679 |
| octolytics-dimension-repository_nwo | sqlc-dev/sqlc |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 193160679 |
| octolytics-dimension-repository_network_root_nwo | sqlc-dev/sqlc |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/sqlc-dev/sqlc/pull/939#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F939 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F939 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc |
| Reload | https://github.com/sqlc-dev/sqlc/pull/939 |
| Reload | https://github.com/sqlc-dev/sqlc/pull/939 |
| Reload | https://github.com/sqlc-dev/sqlc/pull/939 |
| sqlc-dev | https://github.com/sqlc-dev |
| sqlc | https://github.com/sqlc-dev/sqlc |
| Code | https://github.com/sqlc-dev/sqlc |
| Issues600 (600) | https://github.com/sqlc-dev/sqlc/issues |
| Pull requests132 (132) | https://github.com/sqlc-dev/sqlc/pulls |
| Discussions | https://github.com/sqlc-dev/sqlc/discussions |
| Actions | https://github.com/sqlc-dev/sqlc/actions |
| Projects | https://github.com/sqlc-dev/sqlc/projects |
| Security and quality | https://github.com/sqlc-dev/sqlc/security |
| Insights | https://github.com/sqlc-dev/sqlc/insights |
| https://github.com/sqlc-dev/sqlc |
| kyleconroy | https://github.com/kyleconroy |
| sqlc-dev:master | https://github.com/sqlc-dev/sqlc/tree/master |
| robholt:python-improvements | https://github.com/robholt/sqlc/tree/python-improvements |
| Conversation | https://github.com/sqlc-dev/sqlc/pull/939 |
| Commits3 (3) | https://github.com/sqlc-dev/sqlc/pull/939/commits |
| Checks | https://github.com/sqlc-dev/sqlc/pull/939/checks |
| Files changed | https://github.com/sqlc-dev/sqlc/pull/939/files |
| Python: Eliminate runtime package and use sqlalchemy | https://github.com/sqlc-dev/sqlc/pull/939#top |
| kyleconroy | https://github.com/kyleconroy |
| sqlc-dev:master | https://github.com/sqlc-dev/sqlc/tree/master |
| robholt:python-improvements | https://github.com/robholt/sqlc/tree/python-improvements |
|
| https://github.com/robholt |
| robholt | https://github.com/robholt |
| Mar 11, 2021 | https://github.com/sqlc-dev/sqlc/pull/939#issue-829228447 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| https://github.com/kyleconroy |
| kyleconroy | https://github.com/kyleconroy |
|
Mar 11, 2021
| https://github.com/sqlc-dev/sqlc/pull/939#pullrequestreview-609986244 |
|
View reviewed changes
| https://github.com/sqlc-dev/sqlc/pull/939/files |
| kyleconroy | https://github.com/kyleconroy |
| https://github.com/sqlc-dev/sqlc/pull/939#pullrequestreview-609986244 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| examples/python/src/authors/models.py | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-ee5ac580ad63bf714e44b9be5731416a492cf541f81038ad93aa944ad974a4c4 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| examples/python/src/authors/query.py | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-c89f8979af02e775ccddfaba91d614eddb3bab71498afba34cc43d6464cffad9 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| examples/python/src/authors/query.py | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-c89f8979af02e775ccddfaba91d614eddb3bab71498afba34cc43d6464cffad9 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| examples/python/src/authors/query.py | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-c89f8979af02e775ccddfaba91d614eddb3bab71498afba34cc43d6464cffad9 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| https://github.com/robholt |
| robholt | https://github.com/robholt |
| March 15, 2021 21:22 | https://github.com/sqlc-dev/sqlc/pull/939#event-4461138981 |
| https://github.com/kyleconroy |
| kyleconroy | https://github.com/kyleconroy |
|
Mar 16, 2021
| https://github.com/sqlc-dev/sqlc/pull/939#pullrequestreview-612810615 |
|
View reviewed changes
| https://github.com/sqlc-dev/sqlc/pull/939/files |
| kyleconroy | https://github.com/kyleconroy |
| https://github.com/sqlc-dev/sqlc/pull/939#pullrequestreview-612810615 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| examples/python/sqlc.json | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-51ce5461fb9e627abb72ef91a05f41da8a7272d3d6d9101fe941b3b5ed7d99d9 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| internal/config/config.go | https://github.com/sqlc-dev/sqlc/pull/939/files#diff-54c7c1af5fa8d5db4dc49f0e8e80e93ba2b1183ba4d5c9e2e5729e6deae6a3cd |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| March 16, 2021 09:36 | https://github.com/sqlc-dev/sqlc/pull/939#commits-pushed-c95b5ef |
| Manually edit python example code | https://github.com/sqlc-dev/sqlc/pull/939/commits/c95b5efcac419c89c7cfd55a935dfffd918e671c |
| c95b5ef | https://github.com/sqlc-dev/sqlc/pull/939/commits/c95b5efcac419c89c7cfd55a935dfffd918e671c |
| Remove leftover debug code in python tests | https://github.com/sqlc-dev/sqlc/pull/939/commits/d9c77db3e1e3cf6c3478ab8be833f156be76eda2 |
| d9c77db | https://github.com/sqlc-dev/sqlc/pull/939/commits/d9c77db3e1e3cf6c3478ab8be833f156be76eda2 |
| Python: implement new codegen | https://github.com/sqlc-dev/sqlc/pull/939/commits/5f73dbdaca13f5e5484d60d035e5ab00df741e21 |
| 5f73dbd | https://github.com/sqlc-dev/sqlc/pull/939/commits/5f73dbdaca13f5e5484d60d035e5ab00df741e21 |
| https://github.com/robholt |
| robholt | https://github.com/robholt |
| force-pushed | https://github.com/sqlc-dev/sqlc/compare/c84ac49fcd7539657f0b896cfbd86539f71687ab..5f73dbdaca13f5e5484d60d035e5ab00df741e21 |
| c84ac49 | https://github.com/sqlc-dev/sqlc/commit/c84ac49fcd7539657f0b896cfbd86539f71687ab |
| 5f73dbd | https://github.com/sqlc-dev/sqlc/commit/5f73dbdaca13f5e5484d60d035e5ab00df741e21 |
|
Compare
| https://github.com/sqlc-dev/sqlc/compare/c84ac49fcd7539657f0b896cfbd86539f71687ab..5f73dbdaca13f5e5484d60d035e5ab00df741e21 |
| March 16, 2021 13:36 | https://github.com/sqlc-dev/sqlc/pull/939#event-4464587937 |
| https://github.com/robholt |
| robholt | https://github.com/robholt |
| Mar 16, 2021 | https://github.com/sqlc-dev/sqlc/pull/939#issuecomment-800267489 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| https://github.com/kyleconroy |
| kyleconroy | https://github.com/kyleconroy |
|
Mar 16, 2021
| https://github.com/sqlc-dev/sqlc/pull/939#pullrequestreview-613430058 |
|
View reviewed changes
| https://github.com/sqlc-dev/sqlc/pull/939/files/5f73dbdaca13f5e5484d60d035e5ab00df741e21 |
| https://github.com/kyleconroy |
| kyleconroy | https://github.com/kyleconroy |
| 7eed90d | https://github.com/sqlc-dev/sqlc/commit/7eed90db8fab628088406ddbf55d07aad65b2fba |
| Mar 16, 2021 | https://github.com/sqlc-dev/sqlc/pull/939#event-4465457828 |
| https://github.com/danicc097 |
| danicc097 | https://github.com/danicc097 |
|
Apr 10, 2022
| https://github.com/sqlc-dev/sqlc/pull/939#ref-pullrequest-1198984125 |
|
Pydantic models config field
#1538
| https://github.com/sqlc-dev/sqlc/pull/1538 |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F939 |
|
| https://github.com/kyleconroy |
|
kyleconroy
| https://github.com/kyleconroy |
|
| https://github.com/sqlc-dev/sqlc/pull/939/files/5f73dbdaca13f5e5484d60d035e5ab00df741e21 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/939 |
|
| https://github.com/robholt |
|
| https://github.com/kyleconroy |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |