René's URL Explorer Experiment

Title: fix: robustly strip psql meta commands by ignatremizov · Pull Request #4479 · sqlc-dev/sqlc · GitHub

Open Graph Title: fix: robustly strip psql meta commands by ignatremizov · Pull Request #4479 · sqlc-dev/sqlc

X Title: fix: robustly strip psql meta commands by ignatremizov · Pull Request #4479 · sqlc-dev/sqlc

Description: Summary This PR makes PostgreSQL schema preprocessing safer for pg_dump / psql-flavored input without turning sqlc into a psql interpreter. It preserves real PostgreSQL SQL, strips or warns on client-side commands, rejects script semantics that cannot be supported safely, and shares the apply-time schema loading path used by command setup and PostgreSQL sqltest seeding. Changes PostgreSQL schema preprocessing Replace the old line-based PostgreSQL filter with a single-pass state machine that only strips top-level psql meta-commands outside SQL lexical context. Keep explicit coverage of documented psql backslash commands as a reference fixture. See PostgreSQL psql docs Preserve backslashes that appear in valid PostgreSQL SQL, including: string literals, including E'...' quoted identifiers dollar-quoted bodies comments and nested block comments Support the valid \meta ... \\ SQL... separator form and keep trailing SQL intact, including glued and one-sided-whitespace separator forms observed in supported psql versions. Preserve invalid leading \\ input instead of normalizing it into SQL. Handle Unicode dollar-quote tags, identifier-boundary checks, CR/LF normalization, and \copy ... from stdin blocks. Semantic command handling Strip semantic psql commands such as \connect, \copy, \gexec, \i, \ir, \q, \quit, and \r in parse/codegen paths with warnings so users get told when sqlc is ignoring client-side behavior. Reject those same semantic commands in apply/live-DB paths where silently flattening them would be unsafe. Reject psql conditionals (\if, \elif, \else, \endif) instead of pretending to support them. Keep standard_conforming_strings handling as a best-effort parse aid and warn in parse/codegen paths when preprocessing has to approximate session/script semantics rather than emulate psql. Suppress that parse-only approximation warning in apply/live-DB paths because the database executes transaction and session SQL directly there. Rollout across schema-loading paths Apply the shared PostgreSQL preprocessing behavior in: compiler parsing / generate createdb verify managed vet PostgreSQL sqltest seeding Surface preprocessing warnings through the relevant callers instead of keeping them internal to the migration helper. Keep apply/live-DB paths strict so invalid SQL, including dumps that recreate already-present schema objects, still fails with PostgreSQL's normal errors. Follow-up refactor Extract the repeated apply-time glob/read/preprocess/warn loop into schemautil.LoadSchemasForApply(). Reuse that loader across command setup and PostgreSQL sqltest helpers so apply-time behavior stays aligned as preprocessing evolves. Preserve read-only PostgreSQL cache hashing on preprocessed DDL. Do not special-case or rewrite pg_dump public schema DDL; apply-mode callers continue to see PostgreSQL's native behavior. Behavioral impact sqlc is now much more tolerant of pg_dump / psql-flavored PostgreSQL schema files without corrupting valid SQL that happens to contain backslashes. Parse/codegen paths are intentionally permissive with warnings when users are in footgun territory. Apply/live-DB paths stay stricter and reject client-side script behavior that sqlc cannot reproduce safely. This does not try to become a full psql interpreter; full arbitrary client-side script semantics remain out of scope here. Testing go test ./internal/migrations ./internal/compiler ./internal/schemautil ./internal/cmd ./internal/sqltest/... go test ./internal/migrations -coverprofile=/tmp/sqlc-migrations.cover reports 100.0% statement coverage for internal/migrations Related Replaces #4177. Co-authored-by: Andrew Benton andrew@sqlc.dev Addresses gbarr's comment in #4082 which closes #4065

Open Graph Description: Summary This PR makes PostgreSQL schema preprocessing safer for pg_dump / psql-flavored input without turning sqlc into a psql interpreter. It preserves real PostgreSQL SQL, strips or warns on clie...

X Description: Summary This PR makes PostgreSQL schema preprocessing safer for pg_dump / psql-flavored input without turning sqlc into a psql interpreter. It preserves real PostgreSQL SQL, strips or warns on clie...

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/4479

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width