| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:79cd0926-ada7-4427-89c5-a430b32f5c46 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D8A4:16EED3:22AEB38:2C1E82A:6B018103 |
| html-safe-nonce | 6a5cacca5b983ce51b6e6f512359ab6d5d2a10abb8ce3873aa937aca4e61f2fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEE0OjE2RUVEMzoyMkFFQjM4OjJDMUU4MkE6NkIwMTgxMDMiLCJ2aXNpdG9yX2lkIjoiNTcwMDA3NTE0MTk2ODM2NjExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1e54f1148138047da93d4af293befb7dfdfcba6b97de27b5aa67304be0398234 |
| hovercard-subject-tag | pull_request:3214920351 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/sqlc-dev/sqlc/pull/4280/files |
| twitter:image | https://avatars.githubusercontent.com/u/21323222?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/21323222?s=400&v=4 |
| og:image:alt | Fixed incorrect nullability inference when using subqueries with LEFT/RIGHT/FULL OUTER JOINs.
When using subqueries in JOINs like:
SELECT * FROM a LEFT JOIN (SELECT * FROM b) si ON si.a_id = a.id
C... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git |
| octolytics-dimension-user_id | 136738596 |
| octolytics-dimension-user_login | sqlc-dev |
| octolytics-dimension-repository_id | 193160679 |
| octolytics-dimension-repository_nwo | sqlc-dev/sqlc |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 193160679 |
| octolytics-dimension-repository_network_root_nwo | sqlc-dev/sqlc |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/sqlc-dev/sqlc/pull/4280/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F4280%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F4280%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sqlc-dev%2Fsqlc |
| Reload | https://github.com/sqlc-dev/sqlc/pull/4280/files |
| Reload | https://github.com/sqlc-dev/sqlc/pull/4280/files |
| Reload | https://github.com/sqlc-dev/sqlc/pull/4280/files |
| sqlc-dev | https://github.com/sqlc-dev |
| sqlc | https://github.com/sqlc-dev/sqlc |
| Code | https://github.com/sqlc-dev/sqlc |
| Issues600 (600) | https://github.com/sqlc-dev/sqlc/issues |
| Pull requests132 (132) | https://github.com/sqlc-dev/sqlc/pulls |
| Discussions | https://github.com/sqlc-dev/sqlc/discussions |
| Actions | https://github.com/sqlc-dev/sqlc/actions |
| Projects | https://github.com/sqlc-dev/sqlc/projects |
| Security and quality | https://github.com/sqlc-dev/sqlc/security |
| Insights | https://github.com/sqlc-dev/sqlc/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose |
| kitagry | https://github.com/kitagry |
| sqlc-dev:main | https://github.com/sqlc-dev/sqlc/tree/main |
| kitagry:fix-4117 | https://github.com/kitagry/sqlc/tree/fix-4117 |
|
Conversation
0
| https://github.com/sqlc-dev/sqlc/pull/4280 |
|
Commits
1
| https://github.com/sqlc-dev/sqlc/pull/4280/commits |
|
Checks
12
| https://github.com/sqlc-dev/sqlc/pull/4280/checks |
|
Files changed
| https://github.com/sqlc-dev/sqlc/pull/4280/files |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/4280/files |
|
fix(compiler): handle subqueries in JOIN nullability inference
| https://github.com/sqlc-dev/sqlc/pull/4280/files#top |
|
Show all changes
1 commit
| https://github.com/sqlc-dev/sqlc/pull/4280/files |
|
be44a57
fix(compiler): handle subqueries in JOIN nullability inference
kitagry Jan 27, 2026
| https://github.com/sqlc-dev/sqlc/pull/4280/commits/be44a577a518821375d87d3ddfa4a9fb29e86750 |
|
Clear filters
| https://github.com/sqlc-dev/sqlc/pull/4280/files |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/4280/files |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/4280/files |
|
output_columns.go
| https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-10352986f0bc3f9bd887ba90e50c3ff0d93f284b24a9a8c059f1f1bc0aaba061 |
|
db.go
| https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-1d29e27cbdb012e3c674768d1c5b2f3a3a8b221d89afa0fb5235b16d303baf95 |
|
models.go
| https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-ce21c559f27dcfd7e2557ed023ec5264818393c9541962175076e5f305f96979 |
|
query.sql.go
| https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-b2ce731bbf877b40b7aa483ae850d2f2495d1651c89195154423a2749dd4cbf4 |
|
query.sql
| https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-818f1a3854a533da1956b38cfc4db63f0ff7c790b7312fe8a424bbe765a33184 |
|
schema.sql
| https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-06a4b346093d47e8aa909013a9d2456b360d3c3053ac58137669a02a11454505 |
|
sqlc.json
| https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-e39719c894a9d363caafbb6997567be4135af6e2d95b1309b0d2b59261e7cb3a |
| internal/compiler/output_columns.go | https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-10352986f0bc3f9bd887ba90e50c3ff0d93f284b24a9a8c059f1f1bc0aaba061 |
|
View file
| https://github.com/sqlc-dev/sqlc/blob/be44a577a518821375d87d3ddfa4a9fb29e86750/internal/compiler/output_columns.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/4280/{{ revealButtonHref }} |
|
| https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-10352986f0bc3f9bd887ba90e50c3ff0d93f284b24a9a8c059f1f1bc0aaba061 |
|
| https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-10352986f0bc3f9bd887ba90e50c3ff0d93f284b24a9a8c059f1f1bc0aaba061 |
| internal/endtoend/testdata/join_left_subquery/postgresql/go/db.go | https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-1d29e27cbdb012e3c674768d1c5b2f3a3a8b221d89afa0fb5235b16d303baf95 |
|
View file
| https://github.com/sqlc-dev/sqlc/blob/be44a577a518821375d87d3ddfa4a9fb29e86750/internal/endtoend/testdata/join_left_subquery/postgresql/go/db.go |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/4280/files |
| internal/endtoend/testdata/join_left_subquery/postgresql/go/models.go | https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-ce21c559f27dcfd7e2557ed023ec5264818393c9541962175076e5f305f96979 |
|
View file
| https://github.com/sqlc-dev/sqlc/blob/be44a577a518821375d87d3ddfa4a9fb29e86750/internal/endtoend/testdata/join_left_subquery/postgresql/go/models.go |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/4280/files |
| internal/endtoend/testdata/join_left_subquery/postgresql/go/query.sql.go | https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-b2ce731bbf877b40b7aa483ae850d2f2495d1651c89195154423a2749dd4cbf4 |
|
View file
| https://github.com/sqlc-dev/sqlc/blob/be44a577a518821375d87d3ddfa4a9fb29e86750/internal/endtoend/testdata/join_left_subquery/postgresql/go/query.sql.go |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/4280/files |
| internal/endtoend/testdata/join_left_subquery/postgresql/query.sql | https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-818f1a3854a533da1956b38cfc4db63f0ff7c790b7312fe8a424bbe765a33184 |
|
View file
| https://github.com/sqlc-dev/sqlc/blob/be44a577a518821375d87d3ddfa4a9fb29e86750/internal/endtoend/testdata/join_left_subquery/postgresql/query.sql |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/4280/{{ revealButtonHref }} |
| internal/endtoend/testdata/join_left_subquery/postgresql/schema.sql | https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-06a4b346093d47e8aa909013a9d2456b360d3c3053ac58137669a02a11454505 |
|
View file
| https://github.com/sqlc-dev/sqlc/blob/be44a577a518821375d87d3ddfa4a9fb29e86750/internal/endtoend/testdata/join_left_subquery/postgresql/schema.sql |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/4280/{{ revealButtonHref }} |
| internal/endtoend/testdata/join_left_subquery/postgresql/sqlc.json | https://github.com/sqlc-dev/sqlc/pull/4280/files#diff-e39719c894a9d363caafbb6997567be4135af6e2d95b1309b0d2b59261e7cb3a |
|
View file
| https://github.com/sqlc-dev/sqlc/blob/be44a577a518821375d87d3ddfa4a9fb29e86750/internal/endtoend/testdata/join_left_subquery/postgresql/sqlc.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/4280/{{ revealButtonHref }} |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/4280/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |