René's URL Explorer Experiment


Title: fix(migrations): case-sensitive migration rollback detection by 0xSherlokMo · Pull Request #3919 · sqlc-dev/sqlc · GitHub

Open Graph Title: fix(migrations): case-sensitive migration rollback detection by 0xSherlokMo · Pull Request #3919 · sqlc-dev/sqlc

X Title: fix(migrations): case-sensitive migration rollback detection by 0xSherlokMo · Pull Request #3919 · sqlc-dev/sqlc

Description: This PR fixes an issue where SQLC was failing to properly detect and remove rollback statements in migration files due to case sensitivity. Previously, SQLC only recognized uppercase Down in rollback statements (e.g., -- +goose Down), but migration tools like Goose have updated their documentation to use lowercase down (e.g., -- +goose down). The change makes the rollback statement detection case-insensitive by converting the statement to lowercase before checking, ensuring compatibility with: Both -- +goose Down and -- +goose down (Goose migrations) Both -- +migrate Down and -- +migrate down (sql-migrate) Case variations in other migration tool formats This maintains backward compatibility with existing migrations while supporting the current documentation standards of migration tools. Fixes issue #3444 Changes Modified RemoveRollbackStatements to perform case-insensitive comparison by converting statements to lowercase before checking Maintains support for all existing migration tool formats: Goose sql-migrate tern dbmate Testing Verified that both uppercase and lowercase rollback statements are properly detected and removed Ensures no breaking changes for existing migration files

Open Graph Description: This PR fixes an issue where SQLC was failing to properly detect and remove rollback statements in migration files due to case sensitivity. Previously, SQLC only recognized uppercase Down in rollba...

X Description: This PR fixes an issue where SQLC was failing to properly detect and remove rollback statements in migration files due to case sensitivity. Previously, SQLC only recognized uppercase Down in rollba...

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/3919

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:98508d66-e396-5f03-039e-54218e4968a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3D0:13DDC4:8677F4A:BBF8D06:6A5064D5
html-safe-noncef9b2249cdf5242ab473ec0143d9d263635a21cc476509965f65f8d8a440a8956
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0QwOjEzRERDNDo4Njc3RjRBOkJCRjhEMDY6NkE1MDY0RDUiLCJ2aXNpdG9yX2lkIjoiNjU3MjQ0ODEyOTY4MDk1ODY3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac352d3fcbaa93a4978f2b27a9018a915e0b7db647135d0b19f3293fbd0ea4593f
hovercard-subject-tagpull_request:2437715027
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/sqlc-dev/sqlc/pull/3919/files
twitter:imagehttps://avatars.githubusercontent.com/u/108228340?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/108228340?s=400&v=4
og:image:altThis PR fixes an issue where SQLC was failing to properly detect and remove rollback statements in migration files due to case sensitivity. Previously, SQLC only recognized uppercase Down in rollba...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/3919/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F3919%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F3919%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/3919/files
Reloadhttps://github.com/sqlc-dev/sqlc/pull/3919/files
Reloadhttps://github.com/sqlc-dev/sqlc/pull/3919/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3919/files
sqlc-dev https://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Fork 1.1k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Star 18k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Code https://github.com/sqlc-dev/sqlc
Issues 597 https://github.com/sqlc-dev/sqlc/issues
Pull requests 106 https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality 0 https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Code https://github.com/sqlc-dev/sqlc
Issues https://github.com/sqlc-dev/sqlc/issues
Pull requests https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose
kyleconroyhttps://github.com/kyleconroy
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc/tree/main
0xSherlokMo:fix/goose-migration-down-relation-not-existshttps://github.com/0xSherlokMo/sqlc/tree/fix/goose-migration-down-relation-not-exists
Conversation 1 https://github.com/sqlc-dev/sqlc/pull/3919
Commits 1 https://github.com/sqlc-dev/sqlc/pull/3919/commits
Checks 0 https://github.com/sqlc-dev/sqlc/pull/3919/checks
Files changed https://github.com/sqlc-dev/sqlc/pull/3919/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3919/files
fix(migrations): case-sensitive migration rollback detection https://github.com/sqlc-dev/sqlc/pull/3919/files#top
Show all changes 1 commit https://github.com/sqlc-dev/sqlc/pull/3919/files
16bcdc4 fix(migrations): normalize case for migration statement for all cases Apr 3, 2025 https://github.com/sqlc-dev/sqlc/pull/3919/commits/16bcdc4ff470d89b9d4de6db2e2be44e617d5a12
Clear filters https://github.com/sqlc-dev/sqlc/pull/3919/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3919/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3919/files
internal/migrations/migrations.gohttps://github.com/sqlc-dev/sqlc/pull/3919/files#diff-70a6663d7610d0c0ea546d5f8464ff8eacf238af79d65443da1a5dcacc52e1be
View file https://github.com/0xSherlokMo/sqlc/blob/16bcdc4ff470d89b9d4de6db2e2be44e617d5a12/internal/migrations/migrations.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/3919/{{ revealButtonHref }}
https://github.com/sqlc-dev/sqlc/pull/3919/files#diff-70a6663d7610d0c0ea546d5f8464ff8eacf238af79d65443da1a5dcacc52e1be
https://github.com/sqlc-dev/sqlc/pull/3919/files#diff-70a6663d7610d0c0ea546d5f8464ff8eacf238af79d65443da1a5dcacc52e1be
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.