René's URL Explorer Experiment


Title: fix(sqlite): Correctly skip unknown statements by kyleconroy · Pull Request #3239 · sqlc-dev/sqlc · GitHub

Open Graph Title: fix(sqlite): Correctly skip unknown statements by kyleconroy · Pull Request #3239 · sqlc-dev/sqlc

X Title: fix(sqlite): Correctly skip unknown statements by kyleconroy · Pull Request #3239 · sqlc-dev/sqlc

Description: Without updating loc, the unknown statement would be included in the text of the next query. This will address the invalid query part of #3237

Open Graph Description: Without updating loc, the unknown statement would be included in the text of the next query. This will address the invalid query part of #3237

X Description: Without updating loc, the unknown statement would be included in the text of the next query. This will address the invalid query part of #3237

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/3239

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0f4bd213-6198-3ccf-d31e-9c49f608193e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA74E:1DD858:28713E:369127:6A512E24
html-safe-nonce156ef05977be0ed56c7c75c2cbc06e3e99aa0f0e81322e815be204cbcb9d1b8d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzRFOjFERDg1ODoyODcxM0U6MzY5MTI3OjZBNTEyRTI0IiwidmlzaXRvcl9pZCI6Ijc5ODk3MzY2NjUzMzY4NTIwMDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9d5848b059c7009c47c652b2c0f00e6d678ab5b3b59f5fead2ac6962f0939ad0
hovercard-subject-tagpull_request:1753709221
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/sqlc-dev/sqlc/pull/3239/files
twitter:imagehttps://avatars.githubusercontent.com/u/34893?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/34893?s=400&v=4
og:image:altWithout updating loc, the unknown statement would be included in the text of the next query. This will address the invalid query part of #3237
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea74ad1f4971203e7676c31c6c5233aa0b6995813088e47ba7b62c270d4b1ebfc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea4218abefb3ba97edd71b38e508f263fc8c0d1c7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/3239/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F3239%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F3239%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/3239/files
Reloadhttps://github.com/sqlc-dev/sqlc/pull/3239/files
Reloadhttps://github.com/sqlc-dev/sqlc/pull/3239/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3239/files
sqlc-dev https://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Fork 1.1k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Star 18k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Code https://github.com/sqlc-dev/sqlc
Issues 597 https://github.com/sqlc-dev/sqlc/issues
Pull requests 106 https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality 0 https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Code https://github.com/sqlc-dev/sqlc
Issues https://github.com/sqlc-dev/sqlc/issues
Pull requests https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose
kyleconroyhttps://github.com/kyleconroy
mainhttps://github.com/sqlc-dev/sqlc/tree/main
kyle/sqlite-fix-skip-todohttps://github.com/sqlc-dev/sqlc/tree/kyle/sqlite-fix-skip-todo
Conversation 0 https://github.com/sqlc-dev/sqlc/pull/3239
Commits 2 https://github.com/sqlc-dev/sqlc/pull/3239/commits
Checks 0 https://github.com/sqlc-dev/sqlc/pull/3239/checks
Files changed https://github.com/sqlc-dev/sqlc/pull/3239/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3239/files
fix(sqlite): Correctly skip unknown statements https://github.com/sqlc-dev/sqlc/pull/3239/files#top
Show all changes 2 commits https://github.com/sqlc-dev/sqlc/pull/3239/files
b0057da fix(sqlite): Correctly skip unknown statements kyleconroy Mar 4, 2024 https://github.com/sqlc-dev/sqlc/pull/3239/commits/b0057da7bff55caf0d2c9c2155913954350773b4
1849638 Pick sqlc-gen-typescript to a release kyleconroy Mar 4, 2024 https://github.com/sqlc-dev/sqlc/pull/3239/commits/1849638ed173528e58deb90504229f48b71e7d10
Clear filters https://github.com/sqlc-dev/sqlc/pull/3239/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3239/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3239/files
ci-typescript.yml https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-512b73737ebc4e4d6896389020d87a5be4b6b7b06f591ad732655955a3cdbc8f
db.go https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-2301194104b9d8f2e5da88a247f2946d6c1e38e15b36daaf87931dec8b6aa761
models.go https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-635f3f855eb34b53647306ada714dc13fc73734959660ea64f6fdf3d069dee08
query.sql.go https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-6c956d1bcea6d68912459a64b2795dfbbfc003d89d2c8f08fb3d30fcacc7db5d
query.sql https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-0ed21b0d5530dbf86bcbd5870340f4f16b86ee995269b208bd86f25ef1cde27e
schema.sql https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-1bc78b4c6c45cdd1266b10cce614f5b62f6fc124bdc8ee50368b995912ffd6f2
sqlc.json https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-8f2a58a30b920e531adf7a36169cb9822088207030c94c48854abf9894e79ed6
parse.go https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-4c5ee1dee2f3787f3ded67ffe909462482e42d7b9c4fecafcf4ea89a4ea5dee1
.github/workflows/ci-typescript.ymlhttps://github.com/sqlc-dev/sqlc/pull/3239/files#diff-512b73737ebc4e4d6896389020d87a5be4b6b7b06f591ad732655955a3cdbc8f
View file https://github.com/sqlc-dev/sqlc/blob/1849638ed173528e58deb90504229f48b71e7d10/.github/workflows/ci-typescript.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/3239/{{ revealButtonHref }}
https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-512b73737ebc4e4d6896389020d87a5be4b6b7b06f591ad732655955a3cdbc8f
internal/endtoend/testdata/sqlite_skip_todo/db/db.gohttps://github.com/sqlc-dev/sqlc/pull/3239/files#diff-2301194104b9d8f2e5da88a247f2946d6c1e38e15b36daaf87931dec8b6aa761
View file https://github.com/sqlc-dev/sqlc/blob/1849638ed173528e58deb90504229f48b71e7d10/internal/endtoend/testdata/sqlite_skip_todo/db/db.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3239/files
internal/endtoend/testdata/sqlite_skip_todo/db/models.gohttps://github.com/sqlc-dev/sqlc/pull/3239/files#diff-635f3f855eb34b53647306ada714dc13fc73734959660ea64f6fdf3d069dee08
View file https://github.com/sqlc-dev/sqlc/blob/1849638ed173528e58deb90504229f48b71e7d10/internal/endtoend/testdata/sqlite_skip_todo/db/models.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3239/files
internal/endtoend/testdata/sqlite_skip_todo/db/query.sql.gohttps://github.com/sqlc-dev/sqlc/pull/3239/files#diff-6c956d1bcea6d68912459a64b2795dfbbfc003d89d2c8f08fb3d30fcacc7db5d
View file https://github.com/sqlc-dev/sqlc/blob/1849638ed173528e58deb90504229f48b71e7d10/internal/endtoend/testdata/sqlite_skip_todo/db/query.sql.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3239/files
internal/endtoend/testdata/sqlite_skip_todo/query.sqlhttps://github.com/sqlc-dev/sqlc/pull/3239/files#diff-0ed21b0d5530dbf86bcbd5870340f4f16b86ee995269b208bd86f25ef1cde27e
View file https://github.com/sqlc-dev/sqlc/blob/1849638ed173528e58deb90504229f48b71e7d10/internal/endtoend/testdata/sqlite_skip_todo/query.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/3239/{{ revealButtonHref }}
internal/endtoend/testdata/sqlite_skip_todo/schema.sqlhttps://github.com/sqlc-dev/sqlc/pull/3239/files#diff-1bc78b4c6c45cdd1266b10cce614f5b62f6fc124bdc8ee50368b995912ffd6f2
View file https://github.com/sqlc-dev/sqlc/blob/1849638ed173528e58deb90504229f48b71e7d10/internal/endtoend/testdata/sqlite_skip_todo/schema.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/3239/{{ revealButtonHref }}
internal/endtoend/testdata/sqlite_skip_todo/sqlc.jsonhttps://github.com/sqlc-dev/sqlc/pull/3239/files#diff-8f2a58a30b920e531adf7a36169cb9822088207030c94c48854abf9894e79ed6
View file https://github.com/sqlc-dev/sqlc/blob/1849638ed173528e58deb90504229f48b71e7d10/internal/endtoend/testdata/sqlite_skip_todo/sqlc.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/3239/{{ revealButtonHref }}
internal/engine/sqlite/parse.gohttps://github.com/sqlc-dev/sqlc/pull/3239/files#diff-4c5ee1dee2f3787f3ded67ffe909462482e42d7b9c4fecafcf4ea89a4ea5dee1
View file https://github.com/sqlc-dev/sqlc/blob/1849638ed173528e58deb90504229f48b71e7d10/internal/engine/sqlite/parse.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/3239/{{ revealButtonHref }}
https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-4c5ee1dee2f3787f3ded67ffe909462482e42d7b9c4fecafcf4ea89a4ea5dee1
https://github.com/sqlc-dev/sqlc/pull/3239/files#diff-4c5ee1dee2f3787f3ded67ffe909462482e42d7b9c4fecafcf4ea89a4ea5dee1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.