René's URL Explorer Experiment


Title: fix(codegen/golang): Don't import `"strings"` for `sqlc.slice()` with pgx by andrewmbenton · Pull Request #3073 · sqlc-dev/sqlc · GitHub

Open Graph Title: fix(codegen/golang): Don't import `"strings"` for `sqlc.slice()` with pgx by andrewmbenton · Pull Request #3073 · sqlc-dev/sqlc

X Title: fix(codegen/golang): Don't import `"strings"` for `sqlc.slice()` with pgx by andrewmbenton · Pull Request #3073 · sqlc-dev/sqlc

Description: Generate type-safe code from SQL. Contribute to sqlc-dev/sqlc development by creating an account on GitHub.

Open Graph Description: Also fix the invalid test that should have caught this. Resolves #3065

X Description: Also fix the invalid test that should have caught this. Resolves #3065

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/3073

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cf189863-d623-b40d-e9aa-e1531e496192
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC90:21AE3:71A815:9D26C2:6A507BF2
html-safe-nonce117e0f521a4a857833ea07d3d48787bc3820e47013a8862d59c4168448547d87
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzkwOjIxQUUzOjcxQTgxNTo5RDI2QzI6NkE1MDdCRjIiLCJ2aXNpdG9yX2lkIjoiODMxOTg0MzQyMzU5NjA4NDIxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b0caddf7c6083d4f88c8955c742cbc22c854dcc12827e598f9cc2ea5be95f67
hovercard-subject-tagpull_request:1652521840
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sqlc-dev/sqlc/3073/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1d220b277101000d564e2e378afdcf4d109efbced2b1992674ac0a0ba86fb4e2/sqlc-dev/sqlc/pull/3073
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1d220b277101000d564e2e378afdcf4d109efbced2b1992674ac0a0ba86fb4e2/sqlc-dev/sqlc/pull/3073
og:image:altAlso fix the invalid test that should have caught this. Resolves #3065
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandrewmbenton
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/3073#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F3073
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F3073
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/3073
Reloadhttps://github.com/sqlc-dev/sqlc/pull/3073
Reloadhttps://github.com/sqlc-dev/sqlc/pull/3073
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3073
sqlc-dev https://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Fork 1.1k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Star 18k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Code https://github.com/sqlc-dev/sqlc
Issues 597 https://github.com/sqlc-dev/sqlc/issues
Pull requests 106 https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality 0 https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Code https://github.com/sqlc-dev/sqlc
Issues https://github.com/sqlc-dev/sqlc/issues
Pull requests https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
kyleconroyhttps://github.com/kyleconroy
mainhttps://github.com/sqlc-dev/sqlc/tree/main
andrew/fix-golang-bad-strings-importhttps://github.com/sqlc-dev/sqlc/tree/andrew/fix-golang-bad-strings-import
Conversationhttps://github.com/sqlc-dev/sqlc/pull/3073
Commits1 (1)https://github.com/sqlc-dev/sqlc/pull/3073/commits
Checkshttps://github.com/sqlc-dev/sqlc/pull/3073/checks
Files changedhttps://github.com/sqlc-dev/sqlc/pull/3073/files
fix(codegen/golang): Don't import "strings" for sqlc.slice() with pgxhttps://github.com/sqlc-dev/sqlc/pull/3073#top
kyleconroyhttps://github.com/kyleconroy
mainhttps://github.com/sqlc-dev/sqlc/tree/main
andrew/fix-golang-bad-strings-importhttps://github.com/sqlc-dev/sqlc/tree/andrew/fix-golang-bad-strings-import
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
Dec 20, 2023https://github.com/sqlc-dev/sqlc/pull/3073#issue-2051046814
#3065https://github.com/sqlc-dev/sqlc/issues/3065
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3073
https://github.com/andrewmbenton
fix(codegen/golang): Don't import "strings" for sqlc.slice() with…https://github.com/sqlc-dev/sqlc/pull/3073/commits/b1520bd8c24f56c5606885d992b798b1ad278cb3
b1520bdhttps://github.com/sqlc-dev/sqlc/pull/3073/commits/b1520bd8c24f56c5606885d992b798b1ad278cb3
#3065https://github.com/sqlc-dev/sqlc/issues/3065
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
Dec 20, 2023 https://github.com/sqlc-dev/sqlc/pull/3073#pullrequestreview-1791465793
View reviewed changes https://github.com/sqlc-dev/sqlc/pull/3073/files/b1520bd8c24f56c5606885d992b798b1ad278cb3
internal/codegen/golang/imports.gohttps://github.com/sqlc-dev/sqlc/pull/3073/files/b1520bd8c24f56c5606885d992b798b1ad278cb3#diff-5888848f9ffbddb7b5d76142e6226de61375df0b151360152edae46b25965fde
kyleconroyhttps://github.com/kyleconroy
Dec 20, 2023https://github.com/sqlc-dev/sqlc/pull/3073#discussion_r1433060179
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3073
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
Dec 20, 2023 https://github.com/sqlc-dev/sqlc/pull/3073#pullrequestreview-1791466097
View reviewed changes https://github.com/sqlc-dev/sqlc/pull/3073/files/b1520bd8c24f56c5606885d992b798b1ad278cb3
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
ce95162https://github.com/sqlc-dev/sqlc/commit/ce951622846601bfc675d25967d283e55cc36b41
Dec 20, 2023https://github.com/sqlc-dev/sqlc/pull/3073#event-11306197088
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
December 20, 2023 18:39https://github.com/sqlc-dev/sqlc/pull/3073#event-11306197198
alfonsodevhttps://github.com/alfonsodev
Oct 13, 2025 https://github.com/sqlc-dev/sqlc/pull/3073#ref-commit-f94a94c
https://github.com/andrewmbenton
fix(codegen/golang): Don't import "strings" for sqlc.slice() with…https://github.com/ExponentiaTeam/sqlc/commit/f94a94c6afdfc476d75d3db259614a34c9103d81
f94a94chttps://github.com/ExponentiaTeam/sqlc/commit/f94a94c6afdfc476d75d3db259614a34c9103d81
sqlc-dev#3073https://github.com/sqlc-dev/sqlc/pull/3073
sqlc-dev#3065https://github.com/sqlc-dev/sqlc/issues/3065
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F3073
https://github.com/kyleconroy
kyleconroy https://github.com/kyleconroy
https://github.com/sqlc-dev/sqlc/pull/3073/files/b1520bd8c24f56c5606885d992b798b1ad278cb3
sqlc.slice(): Generate code with unused imports https://github.com/sqlc-dev/sqlc/issues/3065
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/3073
https://github.com/andrewmbenton
https://github.com/kyleconroy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.