René's URL Explorer Experiment


Title: fix(analyzer): Error on unexpanded star expression by kyleconroy · Pull Request #2882 · sqlc-dev/sqlc · GitHub

Open Graph Title: fix(analyzer): Error on unexpanded star expression by kyleconroy · Pull Request #2882 · sqlc-dev/sqlc

X Title: fix(analyzer): Error on unexpanded star expression by kyleconroy · Pull Request #2882 · sqlc-dev/sqlc

Description: If a query includes a star reference, error if we're unable to expand that reference. The new analyzer will happily anaylyze that code. If executed at runtime, these queries could change values. Fixes #2880

Open Graph Description: If a query includes a star reference, error if we're unable to expand that reference. The new analyzer will happily anaylyze that code. If executed at runtime, these queries could change values...

X Description: If a query includes a star reference, error if we're unable to expand that reference. The new analyzer will happily anaylyze that code. If executed at runtime, these queries could change va...

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/2882

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:93c66601-1aab-de63-a467-d9a0f9b3cbd2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA42C:88334:4FFAB:6D3A4:6A510EC3
html-safe-noncecc8c0b7da0381c67dea13e4837bbeae47f88f5f80b66bc85d96cf55d59eb5c07
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDJDOjg4MzM0OjRGRkFCOjZEM0E0OjZBNTEwRUMzIiwidmlzaXRvcl9pZCI6IjUyMzEyNDEwMzk4NDM0OTU2MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac42680a755342e62fbc64b2773839ecc397b4a14847472be67ec323e88f51a9ce
hovercard-subject-tagpull_request:1563299730
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/sqlc-dev/sqlc/pull/2882/files
twitter:imagehttps://avatars.githubusercontent.com/u/34893?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/34893?s=400&v=4
og:image:altIf a query includes a star reference, error if we're unable to expand that reference. The new analyzer will happily anaylyze that code. If executed at runtime, these queries could change values...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb076e100febaa00374cd89239f915d00dd3187f7c68b12bc2b7688181305344d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d129404fc45ea64edb1b98567c53e55b395536f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/2882/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2882%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2882%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2882/files
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2882/files
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2882/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2882/files
sqlc-dev https://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Fork 1.1k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Star 18k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Code https://github.com/sqlc-dev/sqlc
Issues 597 https://github.com/sqlc-dev/sqlc/issues
Pull requests 106 https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality 0 https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Code https://github.com/sqlc-dev/sqlc
Issues https://github.com/sqlc-dev/sqlc/issues
Pull requests https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose
kyleconroyhttps://github.com/kyleconroy
mainhttps://github.com/sqlc-dev/sqlc/tree/main
kyle/verify-star-expansionhttps://github.com/sqlc-dev/sqlc/tree/kyle/verify-star-expansion
Conversation 1 https://github.com/sqlc-dev/sqlc/pull/2882
Commits 2 https://github.com/sqlc-dev/sqlc/pull/2882/commits
Checks 0 https://github.com/sqlc-dev/sqlc/pull/2882/checks
Files changed https://github.com/sqlc-dev/sqlc/pull/2882/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2882/files
fix(analyzer): Error on unexpanded star expression https://github.com/sqlc-dev/sqlc/pull/2882/files#top
Show all changes 2 commits https://github.com/sqlc-dev/sqlc/pull/2882/files
92027f2 fix(analyzer): Error on unexpanded star expression kyleconroy Oct 18, 2023 https://github.com/sqlc-dev/sqlc/pull/2882/commits/92027f2ceceb52914f46bbfd188179cfc6d8f70b
15fbc40 Update config kyleconroy Oct 18, 2023 https://github.com/sqlc-dev/sqlc/pull/2882/commits/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e
Clear filters https://github.com/sqlc-dev/sqlc/pull/2882/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2882/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2882/files
parse.go https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-6a800d9fb933dd05d4cfafe491c9a97f6caa7e5878098d4ab642860954d08ceb
exec.json https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-75ab8a4c1585854ac80a40a40ce420f7068713420b7cf44c18977459d7297e51
exec.json https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-c93289ca8f1ed2d3dbeaebb18cacf4e149204f18ad64f6c7da2e22d431cae401
db.go https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-1c17eecfdfc2b73d9a5fca40da7d64809efbbf6701f03fd15d631643be5700f6
models.go https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-2b4050597434d68cb89831270e41c407765a833304fc93c34e847fdb8fa15e59
query.sql.go https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-5c390576c60991d0501db675a629481dedf3552b6521205cb017be90da069f67
query.sql https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-547c72d65f0bbe0c626c3ca19c5c3911a1c1619e52d3914343bfba47d86ecc25
schema.sql https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-63b688be281094878b492c6cc536e7ea394e08102f9dcf374bc9b632e4b30f6e
sqlc.yaml https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-d99455f5b9357eb2900ceb29ee35f5f3afe635ad81edfc41ae4db83b1332e6ae
stderr.txt https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-ad8422076d259986912bebaa08aac5774638e14216d0ce1f8df0573b7c88c7b0
internal/compiler/parse.gohttps://github.com/sqlc-dev/sqlc/pull/2882/files#diff-6a800d9fb933dd05d4cfafe491c9a97f6caa7e5878098d4ab642860954d08ceb
View file https://github.com/sqlc-dev/sqlc/blob/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e/internal/compiler/parse.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2882/{{ revealButtonHref }}
https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-6a800d9fb933dd05d4cfafe491c9a97f6caa7e5878098d4ab642860954d08ceb
https://github.com/sqlc-dev/sqlc/pull/2882/files#diff-6a800d9fb933dd05d4cfafe491c9a97f6caa7e5878098d4ab642860954d08ceb
internal/endtoend/testdata/case_value_param/postgresql/exec.jsonhttps://github.com/sqlc-dev/sqlc/pull/2882/files#diff-75ab8a4c1585854ac80a40a40ce420f7068713420b7cf44c18977459d7297e51
View file https://github.com/sqlc-dev/sqlc/blob/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e/internal/endtoend/testdata/case_value_param/postgresql/exec.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2882/{{ revealButtonHref }}
internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/exec.jsonhttps://github.com/sqlc-dev/sqlc/pull/2882/files#diff-c93289ca8f1ed2d3dbeaebb18cacf4e149204f18ad64f6c7da2e22d431cae401
View file https://github.com/sqlc-dev/sqlc/blob/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e/internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/exec.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2882/{{ revealButtonHref }}
internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/go/db.gohttps://github.com/sqlc-dev/sqlc/pull/2882/files#diff-1c17eecfdfc2b73d9a5fca40da7d64809efbbf6701f03fd15d631643be5700f6
View file https://github.com/sqlc-dev/sqlc/blob/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e/internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/go/db.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2882/files
internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/go/models.gohttps://github.com/sqlc-dev/sqlc/pull/2882/files#diff-2b4050597434d68cb89831270e41c407765a833304fc93c34e847fdb8fa15e59
View file https://github.com/sqlc-dev/sqlc/blob/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e/internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/go/models.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2882/files
internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/go/query.sql.gohttps://github.com/sqlc-dev/sqlc/pull/2882/files#diff-5c390576c60991d0501db675a629481dedf3552b6521205cb017be90da069f67
View file https://github.com/sqlc-dev/sqlc/blob/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e/internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/go/query.sql.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2882/files
internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/query.sqlhttps://github.com/sqlc-dev/sqlc/pull/2882/files#diff-547c72d65f0bbe0c626c3ca19c5c3911a1c1619e52d3914343bfba47d86ecc25
View file https://github.com/sqlc-dev/sqlc/blob/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e/internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/query.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2882/{{ revealButtonHref }}
internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/schema.sqlhttps://github.com/sqlc-dev/sqlc/pull/2882/files#diff-63b688be281094878b492c6cc536e7ea394e08102f9dcf374bc9b632e4b30f6e
View file https://github.com/sqlc-dev/sqlc/blob/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e/internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/schema.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2882/{{ revealButtonHref }}
internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/sqlc.yamlhttps://github.com/sqlc-dev/sqlc/pull/2882/files#diff-d99455f5b9357eb2900ceb29ee35f5f3afe635ad81edfc41ae4db83b1332e6ae
View file https://github.com/sqlc-dev/sqlc/blob/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e/internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/sqlc.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2882/{{ revealButtonHref }}
internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/stderr.txthttps://github.com/sqlc-dev/sqlc/pull/2882/files#diff-ad8422076d259986912bebaa08aac5774638e14216d0ce1f8df0573b7c88c7b0
View file https://github.com/sqlc-dev/sqlc/blob/15fbc40a589a3ba432bf46a520cca1a4c50c7a0e/internal/endtoend/testdata/star_expansion_failed/postgresql/pgx/stderr.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2882/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.