René's URL Explorer Experiment


Title: fix(compiler): Support functions with OUT params by kyleconroy · Pull Request #2865 · sqlc-dev/sqlc · GitHub

Open Graph Title: fix(compiler): Support functions with OUT params by kyleconroy · Pull Request #2865 · sqlc-dev/sqlc

X Title: fix(compiler): Support functions with OUT params by kyleconroy · Pull Request #2865 · sqlc-dev/sqlc

Description: Fixes #1654 Don't panic if a function doesn't have a return type. Load the out parameters if they exist.

Open Graph Description: Fixes #1654 Don't panic if a function doesn't have a return type. Load the out parameters if they exist.

X Description: Fixes #1654 Don't panic if a function doesn't have a return type. Load the out parameters if they exist.

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/2865

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c4ad442f-903c-b79e-f21c-affc9fd856ff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8EC8:7EF99:1A86AE:2437D1:6A511339
html-safe-nonce0dadadcb16e0f1e58a3fef33b76032ae42eb346310387929b892ea572161bfda
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUM4OjdFRjk5OjFBODZBRToyNDM3RDE6NkE1MTEzMzkiLCJ2aXNpdG9yX2lkIjoiNDQ1NjA1MDIzNTE5ODczOTI1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb783bb98342bd8875d8169cf1377a81be88fff5c030b786f4519bb7a3c718790
hovercard-subject-tagpull_request:1559348552
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/sqlc-dev/sqlc/pull/2865/files
twitter:imagehttps://avatars.githubusercontent.com/u/34893?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/34893?s=400&v=4
og:image:altFixes #1654 Don't panic if a function doesn't have a return type. Load the out parameters if they exist.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb076e100febaa00374cd89239f915d00dd3187f7c68b12bc2b7688181305344d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef9137f6d981cbbfd780af369f80ce890b2d0d2d4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/2865/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2865%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2865%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2865/files
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2865/files
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2865/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2865/files
sqlc-dev https://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Fork 1.1k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Star 18k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Code https://github.com/sqlc-dev/sqlc
Issues 597 https://github.com/sqlc-dev/sqlc/issues
Pull requests 106 https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality 0 https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Code https://github.com/sqlc-dev/sqlc
Issues https://github.com/sqlc-dev/sqlc/issues
Pull requests https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose
kyleconroyhttps://github.com/kyleconroy
mainhttps://github.com/sqlc-dev/sqlc/tree/main
andrew/pg-func-out-panichttps://github.com/sqlc-dev/sqlc/tree/andrew/pg-func-out-panic
Conversation 0 https://github.com/sqlc-dev/sqlc/pull/2865
Commits 3 https://github.com/sqlc-dev/sqlc/pull/2865/commits
Checks 0 https://github.com/sqlc-dev/sqlc/pull/2865/checks
Files changed https://github.com/sqlc-dev/sqlc/pull/2865/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2865/files
fix(compiler): Support functions with OUT params https://github.com/sqlc-dev/sqlc/pull/2865/files#top
Show all changes 3 commits https://github.com/sqlc-dev/sqlc/pull/2865/files
4eb8296 test: add a test case for https://github.com/sqlc-dev/sqlc/issues/1654 andrewmbenton Oct 16, 2023 https://github.com/sqlc-dev/sqlc/pull/2865/commits/4eb82969aa77afbc726262e20b69aa336278d442
49eb099 fix(compiler): Support functions with OUT params kyleconroy Oct 16, 2023 https://github.com/sqlc-dev/sqlc/pull/2865/commits/49eb099c6e3cbd1bcf5d95e816a8f6dab98cd60b
f3231cc Add generated code kyleconroy Oct 16, 2023 https://github.com/sqlc-dev/sqlc/pull/2865/commits/f3231cc51806fbdbe4316b68f507e584c844c128
Clear filters https://github.com/sqlc-dev/sqlc/pull/2865/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2865/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2865/files
output_columns.go https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-10352986f0bc3f9bd887ba90e50c3ff0d93f284b24a9a8c059f1f1bc0aaba061
query.go https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-ca35be598dde8ab110e1644cbcb211f3df686a5ccc9385370e036002324c7608
query_catalog.go https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-0ae07885e696afe93cc851a54eaaa08bfe7b1aaf2ee9e5f7f6471028baa2a18c
issue.md https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-4d09ee8f95d4b483f6e192a67a56ae6ac7dc80a568f141209b2ef846a1e3a976
db.go https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-936768b5d33104566ecee6a83da33a0d834aac6cc596cf27ba5f932737c5583a
models.go https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-6c05669f643a0063b6f43265d2fa9c5ba0c4cbd80375dd106a76a8e02313436a
query.sql.go https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-157abf38ec4a2634dc0a5f6f83763497e1e951cd6468f642d0539665c9fb9837
query.sql https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-bf90a6a6b2dfce61bd896bb2c9edb598fcb6bae78bd8f1611e38b831e2e8cfa1
schema.sql https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-84629a552a78708f4fa9971b2fa535c27da3bd295b18ddf648da666ffcf6bb20
sqlc.yaml https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-be7f510f50e20ab1f12c95f5bca893c9aa7e5f28b594d78ec0157f93bd0dc7f9
func.go https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-484a84d393e55820b0350a5f31950677e68cec9d15e763249c3eadef79f98e53
internal/compiler/output_columns.gohttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-10352986f0bc3f9bd887ba90e50c3ff0d93f284b24a9a8c059f1f1bc0aaba061
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/compiler/output_columns.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2865/{{ revealButtonHref }}
https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-10352986f0bc3f9bd887ba90e50c3ff0d93f284b24a9a8c059f1f1bc0aaba061
https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-10352986f0bc3f9bd887ba90e50c3ff0d93f284b24a9a8c059f1f1bc0aaba061
https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-10352986f0bc3f9bd887ba90e50c3ff0d93f284b24a9a8c059f1f1bc0aaba061
internal/compiler/query.gohttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-ca35be598dde8ab110e1644cbcb211f3df686a5ccc9385370e036002324c7608
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/compiler/query.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2865/{{ revealButtonHref }}
https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-ca35be598dde8ab110e1644cbcb211f3df686a5ccc9385370e036002324c7608
https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-ca35be598dde8ab110e1644cbcb211f3df686a5ccc9385370e036002324c7608
internal/compiler/query_catalog.gohttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-0ae07885e696afe93cc851a54eaaa08bfe7b1aaf2ee9e5f7f6471028baa2a18c
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/compiler/query_catalog.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2865/{{ revealButtonHref }}
https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-0ae07885e696afe93cc851a54eaaa08bfe7b1aaf2ee9e5f7f6471028baa2a18c
internal/endtoend/testdata/func_out_param/issue.mdhttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-4d09ee8f95d4b483f6e192a67a56ae6ac7dc80a568f141209b2ef846a1e3a976
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/endtoend/testdata/func_out_param/issue.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2865/{{ revealButtonHref }}
internal/endtoend/testdata/func_out_param/pgx/go/db.gohttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-936768b5d33104566ecee6a83da33a0d834aac6cc596cf27ba5f932737c5583a
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/endtoend/testdata/func_out_param/pgx/go/db.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2865/files
internal/endtoend/testdata/func_out_param/pgx/go/models.gohttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-6c05669f643a0063b6f43265d2fa9c5ba0c4cbd80375dd106a76a8e02313436a
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/endtoend/testdata/func_out_param/pgx/go/models.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2865/files
internal/endtoend/testdata/func_out_param/pgx/go/query.sql.gohttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-157abf38ec4a2634dc0a5f6f83763497e1e951cd6468f642d0539665c9fb9837
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/endtoend/testdata/func_out_param/pgx/go/query.sql.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2865/files
internal/endtoend/testdata/func_out_param/pgx/query.sqlhttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-bf90a6a6b2dfce61bd896bb2c9edb598fcb6bae78bd8f1611e38b831e2e8cfa1
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/endtoend/testdata/func_out_param/pgx/query.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2865/{{ revealButtonHref }}
internal/endtoend/testdata/func_out_param/pgx/schema.sqlhttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-84629a552a78708f4fa9971b2fa535c27da3bd295b18ddf648da666ffcf6bb20
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/endtoend/testdata/func_out_param/pgx/schema.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2865/{{ revealButtonHref }}
internal/endtoend/testdata/func_out_param/pgx/sqlc.yamlhttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-be7f510f50e20ab1f12c95f5bca893c9aa7e5f28b594d78ec0157f93bd0dc7f9
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/endtoend/testdata/func_out_param/pgx/sqlc.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2865/{{ revealButtonHref }}
internal/sql/catalog/func.gohttps://github.com/sqlc-dev/sqlc/pull/2865/files#diff-484a84d393e55820b0350a5f31950677e68cec9d15e763249c3eadef79f98e53
View file https://github.com/sqlc-dev/sqlc/blob/f3231cc51806fbdbe4316b68f507e584c844c128/internal/sql/catalog/func.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2865/{{ revealButtonHref }}
https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-484a84d393e55820b0350a5f31950677e68cec9d15e763249c3eadef79f98e53
https://github.com/sqlc-dev/sqlc/pull/2865/files#diff-484a84d393e55820b0350a5f31950677e68cec9d15e763249c3eadef79f98e53
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.