René's URL Explorer Experiment


Title: fix(compiler): Account for parameters without parents by kyleconroy · Pull Request #2844 · sqlc-dev/sqlc · GitHub

Open Graph Title: fix(compiler): Account for parameters without parents by kyleconroy · Pull Request #2844 · sqlc-dev/sqlc

X Title: fix(compiler): Account for parameters without parents by kyleconroy · Pull Request #2844 · sqlc-dev/sqlc

Description: Before, these parameters would be dropped. Instead, add them to the list but mark their type as any. Fixes #2748 Fixes #2786

Open Graph Description: Before, these parameters would be dropped. Instead, add them to the list but mark their type as any. Fixes #2748 Fixes #2786

X Description: Before, these parameters would be dropped. Instead, add them to the list but mark their type as any. Fixes #2748 Fixes #2786

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/2844

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:63d8152c-1991-ee99-cdce-118f9a4738d4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA44:2E11B4:2767637:38276CF:6A510D1C
html-safe-nonce8104cea63189c31fabdc155d677c775f58536fd31530ba804cc0461704d0d74c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTQ0OjJFMTFCNDoyNzY3NjM3OjM4Mjc2Q0Y6NkE1MTBEMUMiLCJ2aXNpdG9yX2lkIjoiNDU0NjQ5MTMwMjg3NTgyNzQ4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac73c9ab50e8474f660e2143af4b80e4bf9fdf962304656228a4e0ec98d804dce6
hovercard-subject-tagpull_request:1555028302
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/sqlc-dev/sqlc/pull/2844/files
twitter:imagehttps://avatars.githubusercontent.com/u/34893?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/34893?s=400&v=4
og:image:altBefore, these parameters would be dropped. Instead, add them to the list but mark their type as any. Fixes #2748 Fixes #2786
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb076e100febaa00374cd89239f915d00dd3187f7c68b12bc2b7688181305344d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d129404fc45ea64edb1b98567c53e55b395536f
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/2844/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2844%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2844%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2844/files
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2844/files
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2844/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2844/files
sqlc-dev https://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Fork 1.1k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Star 18k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Code https://github.com/sqlc-dev/sqlc
Issues 597 https://github.com/sqlc-dev/sqlc/issues
Pull requests 106 https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality 0 https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Code https://github.com/sqlc-dev/sqlc
Issues https://github.com/sqlc-dev/sqlc/issues
Pull requests https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc%2Fissues%2Fnew%2Fchoose
kyleconroyhttps://github.com/kyleconroy
mainhttps://github.com/sqlc-dev/sqlc/tree/main
kyle/fix-2748https://github.com/sqlc-dev/sqlc/tree/kyle/fix-2748
Conversation 0 https://github.com/sqlc-dev/sqlc/pull/2844
Commits 2 https://github.com/sqlc-dev/sqlc/pull/2844/commits
Checks 0 https://github.com/sqlc-dev/sqlc/pull/2844/checks
Files changed https://github.com/sqlc-dev/sqlc/pull/2844/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2844/files
fix(compiler): Account for parameters without parents https://github.com/sqlc-dev/sqlc/pull/2844/files#top
Show all changes 2 commits https://github.com/sqlc-dev/sqlc/pull/2844/files
7a1f293 fix(compiler): Account for parameters without parents kyleconroy Oct 12, 2023 https://github.com/sqlc-dev/sqlc/pull/2844/commits/7a1f2938bc46a0deb0ce76bdb42360e0ef8f8401
1187ea0 mark those parameters as nullable kyleconroy Oct 12, 2023 https://github.com/sqlc-dev/sqlc/pull/2844/commits/1187ea017f75ebf0202f722d7598ed8118504ac8
Clear filters https://github.com/sqlc-dev/sqlc/pull/2844/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2844/files
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2844/files
resolve.go https://github.com/sqlc-dev/sqlc/pull/2844/files#diff-111ef9c1f26d2d0b8ea24733a1871bd77e2bac3c415607a085e092a34cbe6677
issue.md https://github.com/sqlc-dev/sqlc/pull/2844/files#diff-5e083f1873ee6cec74d343188f899bb81967c7b97126f596f48ab03f0421a6eb
db.go https://github.com/sqlc-dev/sqlc/pull/2844/files#diff-a76e77c1e63e17919e3865e325462482e2c74c2fee88ca786defe872c9a40310
models.go https://github.com/sqlc-dev/sqlc/pull/2844/files#diff-ec0687383aed0d3b3ec437031b2078791268663ff3728ff5fac29b02ef6b429b
query.sql.go https://github.com/sqlc-dev/sqlc/pull/2844/files#diff-f8d2a693cbd304c4555f1868e172cb3326ef6988395c0de87dffaa22c0c011b3
query.sql https://github.com/sqlc-dev/sqlc/pull/2844/files#diff-68b015db8dbe111126a35ce0547a181bfa23622394581988be7579e41b4c5b48
schema.sql https://github.com/sqlc-dev/sqlc/pull/2844/files#diff-a15589da60e1f7973264845057d601ee4c5f70271a1304612c1a876589cb3629
sqlc.yaml https://github.com/sqlc-dev/sqlc/pull/2844/files#diff-a972f49c5c765a4e3cf6dafda15e1c2f2d946cf09701b6991e069d6be6064b00
internal/compiler/resolve.gohttps://github.com/sqlc-dev/sqlc/pull/2844/files#diff-111ef9c1f26d2d0b8ea24733a1871bd77e2bac3c415607a085e092a34cbe6677
View file https://github.com/sqlc-dev/sqlc/blob/1187ea017f75ebf0202f722d7598ed8118504ac8/internal/compiler/resolve.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2844/{{ revealButtonHref }}
https://github.com/sqlc-dev/sqlc/pull/2844/files#diff-111ef9c1f26d2d0b8ea24733a1871bd77e2bac3c415607a085e092a34cbe6677
https://github.com/sqlc-dev/sqlc/pull/2844/files#diff-111ef9c1f26d2d0b8ea24733a1871bd77e2bac3c415607a085e092a34cbe6677
internal/endtoend/testdata/coalesce_params/issue.mdhttps://github.com/sqlc-dev/sqlc/pull/2844/files#diff-5e083f1873ee6cec74d343188f899bb81967c7b97126f596f48ab03f0421a6eb
View file https://github.com/sqlc-dev/sqlc/blob/1187ea017f75ebf0202f722d7598ed8118504ac8/internal/endtoend/testdata/coalesce_params/issue.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2844/{{ revealButtonHref }}
internal/endtoend/testdata/coalesce_params/mysql/go/db.gohttps://github.com/sqlc-dev/sqlc/pull/2844/files#diff-a76e77c1e63e17919e3865e325462482e2c74c2fee88ca786defe872c9a40310
View file https://github.com/sqlc-dev/sqlc/blob/1187ea017f75ebf0202f722d7598ed8118504ac8/internal/endtoend/testdata/coalesce_params/mysql/go/db.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2844/files
internal/endtoend/testdata/coalesce_params/mysql/go/models.gohttps://github.com/sqlc-dev/sqlc/pull/2844/files#diff-ec0687383aed0d3b3ec437031b2078791268663ff3728ff5fac29b02ef6b429b
View file https://github.com/sqlc-dev/sqlc/blob/1187ea017f75ebf0202f722d7598ed8118504ac8/internal/endtoend/testdata/coalesce_params/mysql/go/models.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2844/files
internal/endtoend/testdata/coalesce_params/mysql/go/query.sql.gohttps://github.com/sqlc-dev/sqlc/pull/2844/files#diff-f8d2a693cbd304c4555f1868e172cb3326ef6988395c0de87dffaa22c0c011b3
View file https://github.com/sqlc-dev/sqlc/blob/1187ea017f75ebf0202f722d7598ed8118504ac8/internal/endtoend/testdata/coalesce_params/mysql/go/query.sql.go
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2844/files
internal/endtoend/testdata/coalesce_params/mysql/query.sqlhttps://github.com/sqlc-dev/sqlc/pull/2844/files#diff-68b015db8dbe111126a35ce0547a181bfa23622394581988be7579e41b4c5b48
View file https://github.com/sqlc-dev/sqlc/blob/1187ea017f75ebf0202f722d7598ed8118504ac8/internal/endtoend/testdata/coalesce_params/mysql/query.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2844/{{ revealButtonHref }}
internal/endtoend/testdata/coalesce_params/mysql/schema.sqlhttps://github.com/sqlc-dev/sqlc/pull/2844/files#diff-a15589da60e1f7973264845057d601ee4c5f70271a1304612c1a876589cb3629
View file https://github.com/sqlc-dev/sqlc/blob/1187ea017f75ebf0202f722d7598ed8118504ac8/internal/endtoend/testdata/coalesce_params/mysql/schema.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2844/{{ revealButtonHref }}
internal/endtoend/testdata/coalesce_params/mysql/sqlc.yamlhttps://github.com/sqlc-dev/sqlc/pull/2844/files#diff-a972f49c5c765a4e3cf6dafda15e1c2f2d946cf09701b6991e069d6be6064b00
View file https://github.com/sqlc-dev/sqlc/blob/1187ea017f75ebf0202f722d7598ed8118504ac8/internal/endtoend/testdata/coalesce_params/mysql/sqlc.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/2844/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.