René's URL Explorer Experiment


Title: refactor(codegen): remove golang and json settings from plugin proto by andrewmbenton · Pull Request #2822 · sqlc-dev/sqlc · GitHub

Open Graph Title: refactor(codegen): remove golang and json settings from plugin proto by andrewmbenton · Pull Request #2822 · sqlc-dev/sqlc

X Title: refactor(codegen): remove golang and json settings from plugin proto by andrewmbenton · Pull Request #2822 · sqlc-dev/sqlc

Description: Generate type-safe code from SQL. Contribute to sqlc-dev/sqlc development by creating an account on GitHub.

Open Graph Description: In order to simplify the codegen plugin proto, I've removed the Go and JSON plugin settings and instead pass those settings encoded as JSON to their respective plugins. I introduce a new struct...

X Description: In order to simplify the codegen plugin proto, I've removed the Go and JSON plugin settings and instead pass those settings encoded as JSON to their respective plugins. I introduce a new st...

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/2822

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:40648269-abef-d406-0387-2a959727e733
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC238:13AD7A:30764A4:441A196:6A50E785
html-safe-nonce86c281aace59ad25b95e29d07a72d358ebea0690bad9077607902dba3997fea9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjM4OjEzQUQ3QTozMDc2NEE0OjQ0MUExOTY6NkE1MEU3ODUiLCJ2aXNpdG9yX2lkIjoiMzQ2NjczNzU2ODMzODQ3MDc4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac923badc3356bcd6f125f241a99595c371338ee4accce8f80da49eb1d33d41625
hovercard-subject-tagpull_request:1551478992
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sqlc-dev/sqlc/2822/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5abfd6dee302fa5a1a339cfc219649b666f2f2f7d1c95cc82f9c0095d5e11bba/sqlc-dev/sqlc/pull/2822
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5abfd6dee302fa5a1a339cfc219649b666f2f2f7d1c95cc82f9c0095d5e11bba/sqlc-dev/sqlc/pull/2822
og:image:altIn order to simplify the codegen plugin proto, I've removed the Go and JSON plugin settings and instead pass those settings encoded as JSON to their respective plugins. I introduce a new struct...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandrewmbenton
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-cache
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb19d617b534959801b4b7453938ecf1dfa22131
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/2822#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2822
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2822
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2822
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2822
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2822
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2822
sqlc-dev https://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Fork 1.1k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Star 18k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Code https://github.com/sqlc-dev/sqlc
Issues 597 https://github.com/sqlc-dev/sqlc/issues
Pull requests 106 https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality 0 https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Code https://github.com/sqlc-dev/sqlc
Issues https://github.com/sqlc-dev/sqlc/issues
Pull requests https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
andrewmbentonhttps://github.com/andrewmbenton
mainhttps://github.com/sqlc-dev/sqlc/tree/main
andrew/codegen-opts-from-jsonhttps://github.com/sqlc-dev/sqlc/tree/andrew/codegen-opts-from-json
Conversationhttps://github.com/sqlc-dev/sqlc/pull/2822
Commits4 (4)https://github.com/sqlc-dev/sqlc/pull/2822/commits
Checkshttps://github.com/sqlc-dev/sqlc/pull/2822/checks
Files changedhttps://github.com/sqlc-dev/sqlc/pull/2822/files
refactor(codegen): remove golang and json settings from plugin protohttps://github.com/sqlc-dev/sqlc/pull/2822#top
andrewmbentonhttps://github.com/andrewmbenton
mainhttps://github.com/sqlc-dev/sqlc/tree/main
andrew/codegen-opts-from-jsonhttps://github.com/sqlc-dev/sqlc/tree/andrew/codegen-opts-from-json
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
Oct 11, 2023https://github.com/sqlc-dev/sqlc/pull/2822#issue-1937037208
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2822
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2822
https://github.com/andrewmbenton
refactor(codegen): remove golang and json settings from plugin protohttps://github.com/sqlc-dev/sqlc/pull/2822/commits/f8516206484bad8f24cdc9166e7e20e5aceb1249
f851620https://github.com/sqlc-dev/sqlc/pull/2822/commits/f8516206484bad8f24cdc9166e7e20e5aceb1249
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
Oct 11, 2023 https://github.com/sqlc-dev/sqlc/pull/2822#pullrequestreview-1670218509
View reviewed changes https://github.com/sqlc-dev/sqlc/pull/2822/files/f8516206484bad8f24cdc9166e7e20e5aceb1249
internal/cmd/generate.gohttps://github.com/sqlc-dev/sqlc/pull/2822/files/f8516206484bad8f24cdc9166e7e20e5aceb1249#diff-2ccbd26a302b29c524a67aa623a57582264d19b24a40646065be500f2e15bbd3
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2822
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
Oct 11, 2023 https://github.com/sqlc-dev/sqlc/pull/2822#pullrequestreview-1670222380
View reviewed changes https://github.com/sqlc-dev/sqlc/pull/2822/files/f8516206484bad8f24cdc9166e7e20e5aceb1249
internal/codegen/golang/gen.gohttps://github.com/sqlc-dev/sqlc/pull/2822/files/f8516206484bad8f24cdc9166e7e20e5aceb1249#diff-c04dab838c419b0703213fce993d48f3d4f5fd6a659bb993d5528dd763b36198
andrewmbentonhttps://github.com/andrewmbenton
Oct 11, 2023https://github.com/sqlc-dev/sqlc/pull/2822#discussion_r1354304054
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2822
andrewmbentonhttps://github.com/andrewmbenton
October 11, 2023 00:30https://github.com/sqlc-dev/sqlc/pull/2822#commits-pushed-a7345e8
https://github.com/andrewmbenton
clean up protohttps://github.com/sqlc-dev/sqlc/pull/2822/commits/a7345e81743746d2eac3f5c3876c2acd83ed0a55
a7345e8https://github.com/sqlc-dev/sqlc/pull/2822/commits/a7345e81743746d2eac3f5c3876c2acd83ed0a55
https://github.com/andrewmbenton
update sqlc-gen-json testshttps://github.com/sqlc-dev/sqlc/pull/2822/commits/1adc44baed271990bf1cfd5e5f7b4b7273815235
1adc44bhttps://github.com/sqlc-dev/sqlc/pull/2822/commits/1adc44baed271990bf1cfd5e5f7b4b7273815235
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
October 11, 2023 15:55https://github.com/sqlc-dev/sqlc/pull/2822#event-10620765576
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
Oct 11, 2023 https://github.com/sqlc-dev/sqlc/pull/2822#pullrequestreview-1671756532
View reviewed changes https://github.com/sqlc-dev/sqlc/pull/2822/files/1adc44baed271990bf1cfd5e5f7b4b7273815235
internal/codegen/golang/opts.gohttps://github.com/sqlc-dev/sqlc/pull/2822/files/1adc44baed271990bf1cfd5e5f7b4b7273815235#diff-e6adefd7f5b0f37907bd2744a28814a1928a13ac1142fe8be3ae522af0eec449
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2822
https://github.com/andrewmbenton
put json plugin settings in PluginOptionshttps://github.com/sqlc-dev/sqlc/pull/2822/commits/cd6cebc03636a7450d8736af88134686c537949e
cd6cebchttps://github.com/sqlc-dev/sqlc/pull/2822/commits/cd6cebc03636a7450d8736af88134686c537949e
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
5ef20c6https://github.com/sqlc-dev/sqlc/commit/5ef20c67498cd0ebba7dada3feebeb5974af5990
Oct 11, 2023https://github.com/sqlc-dev/sqlc/pull/2822#event-10623049425
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
October 11, 2023 19:14https://github.com/sqlc-dev/sqlc/pull/2822#event-10623049779
https://github.com/p-linnane
p-linnanehttps://github.com/p-linnane
Oct 24, 2023 https://github.com/sqlc-dev/sqlc/pull/2822#ref-pullrequest-1960181296
sqlc 1.23.0 Homebrew/homebrew-core#152306 https://github.com/Homebrew/homebrew-core/pull/152306
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
Oct 26, 2023 https://github.com/sqlc-dev/sqlc/pull/2822#ref-pullrequest-1962906271
refactor: Remove ParsedGoType from codegen.proto, pass in opts as JSON #2918 https://github.com/sqlc-dev/sqlc/pull/2918
alfonsodevhttps://github.com/alfonsodev
Oct 13, 2025 https://github.com/sqlc-dev/sqlc/pull/2822#ref-commit-f107138
https://github.com/andrewmbenton
refactor(codegen): Remove golang and json settings from plugin proto (https://github.com/ExponentiaTeam/sqlc/commit/f107138dcc90063cb964063cdfc692eeb79a5cc7
s…https://github.com/sqlc-dev/sqlc/pull/2822
f107138https://github.com/ExponentiaTeam/sqlc/commit/f107138dcc90063cb964063cdfc692eeb79a5cc7
…qlc-dev#2822https://github.com/sqlc-dev/sqlc/pull/2822
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2822
https://github.com/kyleconroy
kyleconroy https://github.com/kyleconroy
https://github.com/sqlc-dev/sqlc/pull/2822/files/1adc44baed271990bf1cfd5e5f7b4b7273815235
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2822
https://github.com/andrewmbenton
https://github.com/kyleconroy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.