René's URL Explorer Experiment


Title: fix(engine/dolphin): support enum in ALTER definition by sapk · Pull Request #2680 · sqlc-dev/sqlc · GitHub

Open Graph Title: fix(engine/dolphin): support enum in ALTER definition by sapk · Pull Request #2680 · sqlc-dev/sqlc

X Title: fix(engine/dolphin): support enum in ALTER definition by sapk · Pull Request #2680 · sqlc-dev/sqlc

Description: Generate type-safe code from SQL. Contribute to sqlc-dev/sqlc development by creating an account on GitHub.

Open Graph Description: I got in a case similar to #1503. This PR will fix #1503. I found one discrepancy between column definition between create table and alter definition. I fix it by defining a common sub function. On...

X Description: I got in a case similar to #1503. This PR will fix #1503. I found one discrepancy between column definition between create table and alter definition. I fix it by defining a common sub function. On...

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/2680

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c06f244f-d4e8-abbc-c9f3-5c0f91966535
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD6A:18EF1B:927A8D4:CBADDC5:6A508E6B
html-safe-nonce0ef84c49df3af13508bbfcee181245ac0e5e512c2f09b3e7287bb61605a1ca9a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDZBOjE4RUYxQjo5MjdBOEQ0OkNCQUREQzU6NkE1MDhFNkIiLCJ2aXNpdG9yX2lkIjoiMjc2NDA1MDI5OTg5MDk5NDc5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca51ebf9046906fdc3be39aa08b77c1797a2b9ef5274d7a6e0306b4ec92423fc6
hovercard-subject-tagpull_request:1496304676
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sqlc-dev/sqlc/2680/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fb07e2fb3a899a6e8954cd45e0a1918e5952552a37547ec1b9be6525d7965cb7/sqlc-dev/sqlc/pull/2680
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fb07e2fb3a899a6e8954cd45e0a1918e5952552a37547ec1b9be6525d7965cb7/sqlc-dev/sqlc/pull/2680
og:image:altI got in a case similar to #1503. This PR will fix #1503. I found one discrepancy between column definition between create table and alter definition. I fix it by defining a common sub function. On...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesapk
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/2680#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2680
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2680
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2680
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2680
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2680
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2680
sqlc-dev https://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Fork 1.1k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Star 18k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Code https://github.com/sqlc-dev/sqlc
Issues 597 https://github.com/sqlc-dev/sqlc/issues
Pull requests 106 https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality 0 https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Code https://github.com/sqlc-dev/sqlc
Issues https://github.com/sqlc-dev/sqlc/issues
Pull requests https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
kyleconroyhttps://github.com/kyleconroy
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc/tree/main
sapk-fork:fix-1503https://github.com/sapk-fork/sqlc/tree/fix-1503
Conversationhttps://github.com/sqlc-dev/sqlc/pull/2680
Commits6 (6)https://github.com/sqlc-dev/sqlc/pull/2680/commits
Checkshttps://github.com/sqlc-dev/sqlc/pull/2680/checks
Files changedhttps://github.com/sqlc-dev/sqlc/pull/2680/files
fix(engine/dolphin): support enum in ALTER definitionhttps://github.com/sqlc-dev/sqlc/pull/2680#top
kyleconroyhttps://github.com/kyleconroy
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc/tree/main
sapk-fork:fix-1503https://github.com/sapk-fork/sqlc/tree/fix-1503
https://github.com/sapk
sapkhttps://github.com/sapk
Aug 31, 2023https://github.com/sqlc-dev/sqlc/pull/2680#issue-1874550938
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2680
#1503https://github.com/sqlc-dev/sqlc/issues/1503
#1503https://github.com/sqlc-dev/sqlc/issues/1503
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2680
sapkhttps://github.com/sapk
August 31, 2023 00:23https://github.com/sqlc-dev/sqlc/pull/2680#commits-pushed-9475610
https://github.com/sapk
setup expected to pass testhttps://github.com/sqlc-dev/sqlc/pull/2680/commits/9475610ef7415aaba09b87dd782c38d8fab26a49
9475610https://github.com/sqlc-dev/sqlc/pull/2680/commits/9475610ef7415aaba09b87dd782c38d8fab26a49
https://github.com/sapk
with alter resulthttps://github.com/sqlc-dev/sqlc/pull/2680/commits/c4616a94eec6210ee784addec7e26828c302c92c
c4616a9https://github.com/sqlc-dev/sqlc/pull/2680/commits/c4616a94eec6210ee784addec7e26828c302c92c
https://github.com/sapk
POChttps://github.com/sqlc-dev/sqlc/pull/2680/commits/f0b46ea61dc2fba888616f160832afa35ce0b067
f0b46eahttps://github.com/sqlc-dev/sqlc/pull/2680/commits/f0b46ea61dc2fba888616f160832afa35ce0b067
https://github.com/sapk
cleanuphttps://github.com/sqlc-dev/sqlc/pull/2680/commits/80a339895b44432eaba87de722806b26c1ffcc84
80a3398https://github.com/sqlc-dev/sqlc/pull/2680/commits/80a339895b44432eaba87de722806b26c1ffcc84
https://github.com/sapk
add alter change test casehttps://github.com/sqlc-dev/sqlc/pull/2680/commits/036f75edbdcc4868b9754e9c61a158aa4ea9dec3
036f75ehttps://github.com/sqlc-dev/sqlc/pull/2680/commits/036f75edbdcc4868b9754e9c61a158aa4ea9dec3
https://github.com/sapk
cleanuphttps://github.com/sqlc-dev/sqlc/pull/2680/commits/6265431cc3e764bcbf2aa661896389f93e523061
6265431https://github.com/sqlc-dev/sqlc/pull/2680/commits/6265431cc3e764bcbf2aa661896389f93e523061
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
Oct 13, 2023 https://github.com/sqlc-dev/sqlc/pull/2680#pullrequestreview-1677214639
View reviewed changes https://github.com/sqlc-dev/sqlc/pull/2680/files/6265431cc3e764bcbf2aa661896389f93e523061
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
b581867https://github.com/sqlc-dev/sqlc/commit/b581867fe2a99ae6dc8a0f7bcd4e5124138b41e0
Oct 13, 2023https://github.com/sqlc-dev/sqlc/pull/2680#event-10648062729
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
Oct 13, 2023 https://github.com/sqlc-dev/sqlc/pull/2680#ref-pullrequest-1942553113
fix(mysql): Add, drop, rename and change enum values #2853 https://github.com/sqlc-dev/sqlc/pull/2853
kyleconroyhttps://github.com/kyleconroy
Oct 13, 2023 https://github.com/sqlc-dev/sqlc/pull/2680#ref-commit-39576d6
https://github.com/kyleconroy
fix(mysql): Add, drop, rename and change enum values (https://github.com/sqlc-dev/sqlc/commit/39576d6e23e552a10b43dab20ab2eeb3cae9f8c2
#2853https://github.com/sqlc-dev/sqlc/pull/2853
)https://github.com/sqlc-dev/sqlc/commit/39576d6e23e552a10b43dab20ab2eeb3cae9f8c2
39576d6https://github.com/sqlc-dev/sqlc/commit/39576d6e23e552a10b43dab20ab2eeb3cae9f8c2
#2680https://github.com/sqlc-dev/sqlc/pull/2680
#2475https://github.com/sqlc-dev/sqlc/issues/2475
https://github.com/sapk
sapkhttps://github.com/sapk
October 14, 2023 06:45https://github.com/sqlc-dev/sqlc/pull/2680#event-10651811933
https://github.com/p-linnane
p-linnanehttps://github.com/p-linnane
Oct 24, 2023 https://github.com/sqlc-dev/sqlc/pull/2680#ref-pullrequest-1960181296
sqlc 1.23.0 Homebrew/homebrew-core#152306 https://github.com/Homebrew/homebrew-core/pull/152306
alfonsodevhttps://github.com/alfonsodev
Oct 13, 2025 https://github.com/sqlc-dev/sqlc/pull/2680#ref-commit-6165f0c
https://github.com/sapk
fix(engine/dolphin): support enum in ALTER definition (https://github.com/ExponentiaTeam/sqlc/commit/6165f0c5687db5ced04c5f7fccc4d74ec1d3aa6c
sqlc-dev#2680https://github.com/sqlc-dev/sqlc/pull/2680
)https://github.com/ExponentiaTeam/sqlc/commit/6165f0c5687db5ced04c5f7fccc4d74ec1d3aa6c
6165f0chttps://github.com/ExponentiaTeam/sqlc/commit/6165f0c5687db5ced04c5f7fccc4d74ec1d3aa6c
sqlc-dev#1503https://github.com/sqlc-dev/sqlc/issues/1503
sqlc-dev#1503https://github.com/sqlc-dev/sqlc/issues/1503
alfonsodevhttps://github.com/alfonsodev
Oct 13, 2025 https://github.com/sqlc-dev/sqlc/pull/2680#ref-commit-ecfd2dd
https://github.com/kyleconroy
fix(mysql): Add, drop, rename and change enum values (https://github.com/ExponentiaTeam/sqlc/commit/ecfd2ddebb7e70ea197b7e0da976e2c78ba91a1d
sqlc-dev#2853https://github.com/sqlc-dev/sqlc/pull/2853
)https://github.com/ExponentiaTeam/sqlc/commit/ecfd2ddebb7e70ea197b7e0da976e2c78ba91a1d
ecfd2ddhttps://github.com/ExponentiaTeam/sqlc/commit/ecfd2ddebb7e70ea197b7e0da976e2c78ba91a1d
sqlc-dev#2680https://github.com/sqlc-dev/sqlc/pull/2680
sqlc-dev#2475https://github.com/sqlc-dev/sqlc/issues/2475
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2680
https://github.com/kyleconroy
kyleconroy https://github.com/kyleconroy
https://github.com/sqlc-dev/sqlc/pull/2680/files/6265431cc3e764bcbf2aa661896389f93e523061
ALTER TABLE MODIFY enum not respected https://github.com/sqlc-dev/sqlc/issues/1503
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2680
https://github.com/sapk
https://github.com/kyleconroy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.