René's URL Explorer Experiment


Title: fix: count column aliases only once by akutschera · Pull Request #2399 · sqlc-dev/sqlc · GitHub

Open Graph Title: fix: count column aliases only once by akutschera · Pull Request #2399 · sqlc-dev/sqlc

X Title: fix: count column aliases only once by akutschera · Pull Request #2399 · sqlc-dev/sqlc

Description: Generate type-safe code from SQL. Contribute to sqlc-dev/sqlc development by creating an account on GitHub.

Open Graph Description: Alias column names don't exist in the table definition. When we take it from the select target list, we only need to do this once (and not once for every table in a join statement). Refs: #2398...

X Description: Alias column names don't exist in the table definition. When we take it from the select target list, we only need to do this once (and not once for every table in a join statement). Refs: #...

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/2399

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:49c3a75e-fe14-44fb-66a5-fee069b24caf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE678:25EC2E:1D91DAE:27C9C33:6A537156
html-safe-noncedc3cf89bec7e70fa8271f904512897cd0cb088d7c9c24c1c7e787c7ecf207c0d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjc4OjI1RUMyRToxRDkxREFFOjI3QzlDMzM6NkE1MzcxNTYiLCJ2aXNpdG9yX2lkIjoiNDExNDI4OTk3OTcwNDg5Njg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac39ca8e18013437cb483a1b6cc919cea4b8d8ceaa0c538eec90ad7bb2cbc39796
hovercard-subject-tagpull_request:1416052839
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sqlc-dev/sqlc/2399/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1a6f0427a341bd777639e00b002ab7ec1dc4df3618ab9d76fb68cf1b5ff24732/sqlc-dev/sqlc/pull/2399
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1a6f0427a341bd777639e00b002ab7ec1dc4df3618ab9d76fb68cf1b5ff24732/sqlc-dev/sqlc/pull/2399
og:image:altAlias column names don't exist in the table definition. When we take it from the select target list, we only need to do this once (and not once for every table in a join statement). Refs: #2398...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameakutschera
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/2399#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2399
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2399
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2399
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2399
Reloadhttps://github.com/sqlc-dev/sqlc/pull/2399
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2399
sqlc-dev https://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Fork 1.1k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Star 18k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Code https://github.com/sqlc-dev/sqlc
Issues 597 https://github.com/sqlc-dev/sqlc/issues
Pull requests 106 https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality 0 https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Code https://github.com/sqlc-dev/sqlc
Issues https://github.com/sqlc-dev/sqlc/issues
Pull requests https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
akutscherahttps://github.com/akutschera
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc/tree/main
akutschera:issue-2398https://github.com/akutschera/sqlc/tree/issue-2398
Conversationhttps://github.com/sqlc-dev/sqlc/pull/2399
Commits1 (1)https://github.com/sqlc-dev/sqlc/pull/2399/commits
Checkshttps://github.com/sqlc-dev/sqlc/pull/2399/checks
Files changedhttps://github.com/sqlc-dev/sqlc/pull/2399/files
fix: count column aliases only oncehttps://github.com/sqlc-dev/sqlc/pull/2399#top
akutscherahttps://github.com/akutschera
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc/tree/main
akutschera:issue-2398https://github.com/akutschera/sqlc/tree/issue-2398
https://github.com/akutschera
akutscherahttps://github.com/akutschera
Jul 1, 2023https://github.com/sqlc-dev/sqlc/pull/2399#issue-1783869627
#2398https://github.com/sqlc-dev/sqlc/issues/2398
#1886https://github.com/sqlc-dev/sqlc/issues/1886
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2399
https://github.com/akutschera
fix: count columns aliases only oncehttps://github.com/sqlc-dev/sqlc/pull/2399/commits/15d9ebd84a958f03318cca4851ed6a1c1bd8a23c
15d9ebdhttps://github.com/sqlc-dev/sqlc/pull/2399/commits/15d9ebd84a958f03318cca4851ed6a1c1bd8a23c
sqlc-dev#2398https://github.com/sqlc-dev/sqlc/issues/2398
sqlc-dev#1886https://github.com/sqlc-dev/sqlc/issues/1886
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
Jul 27, 2023https://github.com/sqlc-dev/sqlc/pull/2399#issuecomment-1654189816
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2399
andrewmbentonhttps://github.com/andrewmbenton
Jul 27, 2023 https://github.com/sqlc-dev/sqlc/pull/2399#ref-commit-5bd0257
https://github.com/andrewmbenton
fix(compiler): correctly validate alias in order/group by clauses for…https://github.com/sqlc-dev/sqlc/commit/5bd0257b6ec3cd5e9347555f29846d437df6c578
5bd0257https://github.com/sqlc-dev/sqlc/commit/5bd0257b6ec3cd5e9347555f29846d437df6c578
#1886https://github.com/sqlc-dev/sqlc/issues/1886
#2398https://github.com/sqlc-dev/sqlc/issues/2398
#2399https://github.com/sqlc-dev/sqlc/pull/2399
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
Jul 27, 2023 https://github.com/sqlc-dev/sqlc/pull/2399#ref-pullrequest-1825100240
fix(compiler): correctly validate alias in order/group by clauses for joins #2537 https://github.com/sqlc-dev/sqlc/pull/2537
https://github.com/andrewmbenton
andrewmbentonhttps://github.com/andrewmbenton
Jul 27, 2023https://github.com/sqlc-dev/sqlc/pull/2399#issuecomment-1654474246
#2537https://github.com/sqlc-dev/sqlc/pull/2537
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2399
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
#2537 https://github.com/sqlc-dev/sqlc/pull/2537
Jul 28, 2023https://github.com/sqlc-dev/sqlc/pull/2399#event-9950134446
kyleconroyhttps://github.com/kyleconroy
Jul 28, 2023 https://github.com/sqlc-dev/sqlc/pull/2399#ref-commit-7d6377f
https://github.com/andrewmbenton
fix(compiler): correctly validate alias in order/group by clauses for…https://github.com/sqlc-dev/sqlc/commit/7d6377fded11c041b77ee3745f8c315e6014e57e
7d6377fhttps://github.com/sqlc-dev/sqlc/commit/7d6377fded11c041b77ee3745f8c315e6014e57e
#2537https://github.com/sqlc-dev/sqlc/pull/2537
#1886https://github.com/sqlc-dev/sqlc/issues/1886
#2398https://github.com/sqlc-dev/sqlc/issues/2398
#2399https://github.com/sqlc-dev/sqlc/pull/2399
alfonsodevhttps://github.com/alfonsodev
Oct 13, 2025 https://github.com/sqlc-dev/sqlc/pull/2399#ref-commit-219e197
https://github.com/andrewmbenton
fix(compiler): correctly validate alias in order/group by clauses for…https://github.com/ExponentiaTeam/sqlc/commit/219e197f0fee664da9c3e7300b784f73c7cf8005
219e197https://github.com/ExponentiaTeam/sqlc/commit/219e197f0fee664da9c3e7300b784f73c7cf8005
sqlc-dev#2537https://github.com/sqlc-dev/sqlc/pull/2537
sqlc-dev#1886https://github.com/sqlc-dev/sqlc/issues/1886
sqlc-dev#2398https://github.com/sqlc-dev/sqlc/issues/2398
sqlc-dev#2399https://github.com/sqlc-dev/sqlc/pull/2399
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F2399
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/2399
https://github.com/akutschera
https://github.com/andrewmbenton
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.