René's URL Explorer Experiment


Title: Remove data_type from column proto by stephen · Pull Request #1468 · sqlc-dev/sqlc · GitHub

Open Graph Title: Remove data_type from column proto by stephen · Pull Request #1468 · sqlc-dev/sqlc

X Title: Remove data_type from column proto by stephen · Pull Request #1468 · sqlc-dev/sqlc

Description: Generate type-safe code from SQL. Contribute to sqlc-dev/sqlc development by creating an account on GitHub.

Open Graph Description: The information is duplicated from Column.type See #1460 (comment) DataType is never filled in so this comparison is buggy. This change mirrors what the go gen.go does instead. Deleting a field fro...

X Description: The information is duplicated from Column.type See #1460 (comment) DataType is never filled in so this comparison is buggy. This change mirrors what the go gen.go does instead. Deleting a field fro...

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/1468

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5f77c6b3-2983-c76e-0f33-3ad0239bb2ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C2C:3D97C8:267DE36:333FF4F:6B01A6E5
html-safe-nonce2fbc7ee8eb180d7e2e23693547e8211aadef96dbef5740d410959dba39332193
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzJDOjNEOTdDODoyNjdERTM2OjMzM0ZGNEY6NkIwMUE2RTUiLCJ2aXNpdG9yX2lkIjoiOTg3MzA5MjU1MzkwNTA0Njc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac483b159ccc24b93afd36e61c8012ab62f554cdd5e1ea093cbdc7a8684f11ea95
hovercard-subject-tagpull_request:869851353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sqlc-dev/sqlc/1468/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/90cd4ca34b4be80861441bb590a68a29ab280a22a3ab489541eef390b9b47768/sqlc-dev/sqlc/pull/1468
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90cd4ca34b4be80861441bb590a68a29ab280a22a3ab489541eef390b9b47768/sqlc-dev/sqlc/pull/1468
og:image:altThe information is duplicated from Column.type See #1460 (comment) DataType is never filled in so this comparison is buggy. This change mirrors what the go gen.go does instead. Deleting a field fro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestephen
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/1468#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F1468
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F1468
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/1468
Reloadhttps://github.com/sqlc-dev/sqlc/pull/1468
Reloadhttps://github.com/sqlc-dev/sqlc/pull/1468
sqlc-devhttps://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Codehttps://github.com/sqlc-dev/sqlc
Issues600 (600)https://github.com/sqlc-dev/sqlc/issues
Pull requests132 (132)https://github.com/sqlc-dev/sqlc/pulls
Discussionshttps://github.com/sqlc-dev/sqlc/discussions
Actionshttps://github.com/sqlc-dev/sqlc/actions
Projectshttps://github.com/sqlc-dev/sqlc/projects
Security and qualityhttps://github.com/sqlc-dev/sqlc/security
Insightshttps://github.com/sqlc-dev/sqlc/insights
https://github.com/sqlc-dev/sqlc
kyleconroyhttps://github.com/kyleconroy
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc/tree/main
stephen:datatype-refactorhttps://github.com/stephen/sqlc/tree/datatype-refactor
Conversationhttps://github.com/sqlc-dev/sqlc/pull/1468
Commits1 (1)https://github.com/sqlc-dev/sqlc/pull/1468/commits
Checkshttps://github.com/sqlc-dev/sqlc/pull/1468/checks
Files changedhttps://github.com/sqlc-dev/sqlc/pull/1468/files
Remove data_type from column proto https://github.com/sqlc-dev/sqlc/pull/1468#top
kyleconroyhttps://github.com/kyleconroy
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc/tree/main
stephen:datatype-refactorhttps://github.com/stephen/sqlc/tree/datatype-refactor
https://github.com/stephen
stephenhttps://github.com/stephen
Mar 2, 2022https://github.com/sqlc-dev/sqlc/pull/1468#issue-1157546561
#1460 (comment)https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r817029197
https://developers.google.com/protocol-buffers/docs/proto3#reservedhttps://developers.google.com/protocol-buffers/docs/proto3#reserved
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1468
https://github.com/stephen
fix bug where datatype is read fromhttps://github.com/sqlc-dev/sqlc/pull/1468/commits/2cec58a228df830ee902813befc0ec92e058943b
2cec58ahttps://github.com/sqlc-dev/sqlc/pull/1468/commits/2cec58a228df830ee902813befc0ec92e058943b
sqlc-dev#1460 (comment)https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r817029197
https://developers.google.com/protocol-buffers/docs/proto3#reservedhttps://developers.google.com/protocol-buffers/docs/proto3#reserved
https://github.com/stephen
stephenhttps://github.com/stephen
Mar 2, 2022https://github.com/sqlc-dev/sqlc/pull/1468#event-6173031775
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
Mar 2, 2022 https://github.com/sqlc-dev/sqlc/pull/1468#pullrequestreview-898152982
View reviewed changes https://github.com/sqlc-dev/sqlc/pull/1468/files/2cec58a228df830ee902813befc0ec92e058943b
kyleconroyhttps://github.com/kyleconroy
https://github.com/sqlc-dev/sqlc/pull/1468#pullrequestreview-898152982
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1468
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
eb640c8https://github.com/sqlc-dev/sqlc/commit/eb640c8f6f850ddb7ed8f58bdcdc1068d81b5087
Mar 2, 2022https://github.com/sqlc-dev/sqlc/pull/1468#event-6173802184
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F1468
https://github.com/kyleconroy
kyleconroy https://github.com/kyleconroy
https://github.com/sqlc-dev/sqlc/pull/1468/files/2cec58a228df830ee902813befc0ec92e058943b
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1468
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1468
https://github.com/stephen
https://github.com/kyleconroy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.