René's URL Explorer Experiment


Title: Fix nullable colums for subqueries in left and full joins by richardbizik · Pull Request #1462 · sqlc-dev/sqlc · GitHub

Open Graph Title: Fix nullable colums for subqueries in left and full joins by richardbizik · Pull Request #1462 · sqlc-dev/sqlc

X Title: Fix nullable colums for subqueries in left and full joins by richardbizik · Pull Request #1462 · sqlc-dev/sqlc

Description: Generate type-safe code from SQL. Contribute to sqlc-dev/sqlc development by creating an account on GitHub.

Open Graph Description: There is an issue when performing join on subquery. Fields that should be nullable are not because node is processed as ordinary select node. This pull request fixes the issue.

X Description: There is an issue when performing join on subquery. Fields that should be nullable are not because node is processed as ordinary select node. This pull request fixes the issue.

Opengraph URL: https://github.com/sqlc-dev/sqlc/pull/1462

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d9855bb5-0613-9f92-c8ad-b2eba3418612
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC81E:32DC0C:E76779:138A917:6A5173C7
html-safe-nonce53827b4dccdd83d157ee280e27f6c2cbad34bcf34d730c4887c8f137231f9c38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODFFOjMyREMwQzpFNzY3Nzk6MTM4QTkxNzo2QTUxNzNDNyIsInZpc2l0b3JfaWQiOiI0ODk0OTIwNDI1OTc5NjA1OTU5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacde51c698a586ed38fbb5aec2801b8a56afb13a7f9aff4654f54c10be81fcf5b8
hovercard-subject-tagpull_request:868238570
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sqlc-dev/sqlc/1462/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/968e85a6b9d4794f487f7f96f860f48c29b00e7f1cca6110dc0c99d2d8799465/sqlc-dev/sqlc/pull/1462
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/968e85a6b9d4794f487f7f96f860f48c29b00e7f1cca6110dc0c99d2d8799465/sqlc-dev/sqlc/pull/1462
og:image:altThere is an issue when performing join on subquery. Fields that should be nullable are not because node is processed as ordinary select node. This pull request fixes the issue.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerichardbizik
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb19955a9dd40fd99462443f7911b522d7216776a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/pull/1462#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F1462
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F1462
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/pull/1462
Reloadhttps://github.com/sqlc-dev/sqlc/pull/1462
Reloadhttps://github.com/sqlc-dev/sqlc/pull/1462
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
sqlc-dev https://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Notifications https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Fork 1.1k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Star 18k https://github.com/login?return_to=%2Fsqlc-dev%2Fsqlc
Code https://github.com/sqlc-dev/sqlc
Issues 597 https://github.com/sqlc-dev/sqlc/issues
Pull requests 106 https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality 0 https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
Code https://github.com/sqlc-dev/sqlc
Issues https://github.com/sqlc-dev/sqlc/issues
Pull requests https://github.com/sqlc-dev/sqlc/pulls
Discussions https://github.com/sqlc-dev/sqlc/discussions
Actions https://github.com/sqlc-dev/sqlc/actions
Projects https://github.com/sqlc-dev/sqlc/projects
Security and quality https://github.com/sqlc-dev/sqlc/security
Insights https://github.com/sqlc-dev/sqlc/pulse
richardbizikhttps://github.com/richardbizik
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc/tree/main
richardbizik:mainhttps://github.com/richardbizik/sqlc/tree/main
Conversationhttps://github.com/sqlc-dev/sqlc/pull/1462
Commits3 (3)https://github.com/sqlc-dev/sqlc/pull/1462/commits
Checkshttps://github.com/sqlc-dev/sqlc/pull/1462/checks
Files changedhttps://github.com/sqlc-dev/sqlc/pull/1462/files
Fix nullable colums for subqueries in left and full joinshttps://github.com/sqlc-dev/sqlc/pull/1462#top
richardbizikhttps://github.com/richardbizik
sqlc-dev:mainhttps://github.com/sqlc-dev/sqlc/tree/main
richardbizik:mainhttps://github.com/richardbizik/sqlc/tree/main
https://github.com/richardbizik
richardbizikhttps://github.com/richardbizik
Mar 1, 2022https://github.com/sqlc-dev/sqlc/pull/1462#issue-1155769231
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
Mar 2, 2022 https://github.com/sqlc-dev/sqlc/pull/1462#pullrequestreview-897131658
View reviewed changes https://github.com/sqlc-dev/sqlc/pull/1462/files
kyleconroyhttps://github.com/kyleconroy
https://github.com/sqlc-dev/sqlc/pull/1462#pullrequestreview-897131658
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
internal/sql/astutils/walk.gohttps://github.com/sqlc-dev/sqlc/pull/1462/files#diff-5f336bc84a11e8ee45fd2c51df3079a1afc98ae465447f14e2efdc3ad1d2c20a
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
internal/sql/ast/range_subselect.gohttps://github.com/sqlc-dev/sqlc/pull/1462/files#diff-3c29ea84bfe637c42abe0dfa762e6cf4b5cae09f01ed745105b08306973393ab
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
https://github.com/richardbizik
richardbizikhttps://github.com/richardbizik
Mar 3, 2022https://github.com/sqlc-dev/sqlc/pull/1462#issuecomment-1058325549
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
https://github.com/richardbizik
richardbizikhttps://github.com/richardbizik
kyleconroyhttps://github.com/kyleconroy
March 4, 2022 16:40https://github.com/sqlc-dev/sqlc/pull/1462#event-6186349234
https://github.com/sbres
sbreshttps://github.com/sbres
Mar 14, 2022 https://github.com/sqlc-dev/sqlc/pull/1462#ref-issue-1074655283
Left Join not generating correct Null* Types #1334 https://github.com/sqlc-dev/sqlc/issues/1334
https://github.com/sbres
sbreshttps://github.com/sbres
Mar 16, 2022https://github.com/sqlc-dev/sqlc/pull/1462#issuecomment-1069009256
https://www.db-fiddle.com/f/hXNdApf4mV3Qi1jEgu2egZ/3https://www.db-fiddle.com/f/hXNdApf4mV3Qi1jEgu2egZ/3
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
https://github.com/richardbizik
richardbizikhttps://github.com/richardbizik
Mar 16, 2022https://github.com/sqlc-dev/sqlc/pull/1462#issuecomment-1069052149
https://www.db-fiddle.com/f/f8yeYgvggnmw1t7p3M5YE6/1https://www.db-fiddle.com/f/f8yeYgvggnmw1t7p3M5YE6/1
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
Mar 19, 2022 https://github.com/sqlc-dev/sqlc/pull/1462#pullrequestreview-914958300
View reviewed changes https://github.com/sqlc-dev/sqlc/pull/1462/files
kyleconroyhttps://github.com/kyleconroy
https://github.com/sqlc-dev/sqlc/pull/1462#pullrequestreview-914958300
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1486https://github.com/sqlc-dev/sqlc/pull/1486
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
https://github.com/sbres
sbreshttps://github.com/sbres
Mar 19, 2022https://github.com/sqlc-dev/sqlc/pull/1462#issuecomment-1072981219
#1486https://github.com/sqlc-dev/sqlc/pull/1486
#1491https://github.com/sqlc-dev/sqlc/pull/1491
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
richardbizikhttps://github.com/richardbizik
March 19, 2022 14:02https://github.com/sqlc-dev/sqlc/pull/1462#commits-pushed-a550a77
https://github.com/richardbizik
Fix nullable colums for nested selects in left and full joinshttps://github.com/sqlc-dev/sqlc/pull/1462/commits/a550a77e3bd269952dfea7b165d81b0f378c8e15
a550a77https://github.com/sqlc-dev/sqlc/pull/1462/commits/a550a77e3bd269952dfea7b165d81b0f378c8e15
https://github.com/richardbizik
Removed ast modifications, replaced with nullableNodeshttps://github.com/sqlc-dev/sqlc/pull/1462/commits/fde2c8bf8d3630937608c856992c1de90a139777
fde2c8bhttps://github.com/sqlc-dev/sqlc/pull/1462/commits/fde2c8bf8d3630937608c856992c1de90a139777
https://github.com/richardbizik
Fixed nested queryhttps://github.com/sqlc-dev/sqlc/pull/1462/commits/4caff5ef6d0a6a72c2f9c2dac7876a505fe28f2d
4caff5ehttps://github.com/sqlc-dev/sqlc/pull/1462/commits/4caff5ef6d0a6a72c2f9c2dac7876a505fe28f2d
https://github.com/richardbizik
richardbizikhttps://github.com/richardbizik
force-pushedhttps://github.com/sqlc-dev/sqlc/compare/6bba5cd6c3803447a6a5c96935555b8ee68aa503..4caff5ef6d0a6a72c2f9c2dac7876a505fe28f2d
6bba5cdhttps://github.com/sqlc-dev/sqlc/commit/6bba5cd6c3803447a6a5c96935555b8ee68aa503
4caff5ehttps://github.com/sqlc-dev/sqlc/commit/4caff5ef6d0a6a72c2f9c2dac7876a505fe28f2d
Compare https://github.com/sqlc-dev/sqlc/compare/6bba5cd6c3803447a6a5c96935555b8ee68aa503..4caff5ef6d0a6a72c2f9c2dac7876a505fe28f2d
March 19, 2022 13:06https://github.com/sqlc-dev/sqlc/pull/1462#event-6269909290
https://github.com/richardbizik
richardbizikhttps://github.com/richardbizik
kyleconroyhttps://github.com/kyleconroy
March 19, 2022 13:08https://github.com/sqlc-dev/sqlc/pull/1462#event-6269910862
https://github.com/skabbes
skabbeshttps://github.com/skabbes
Apr 2, 2022 https://github.com/sqlc-dev/sqlc/pull/1462#ref-issue-1190677095
RFC: nullability (and other metadata) for input arguments / parameters to a query #1525 https://github.com/sqlc-dev/sqlc/issues/1525
https://github.com/richardbizik
richardbizikhttps://github.com/richardbizik
Apr 6, 2022https://github.com/sqlc-dev/sqlc/pull/1462#issuecomment-1090599953
@sbreshttps://github.com/sbres
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
https://github.com/richardbizik
richardbizikhttps://github.com/richardbizik
Apr 25, 2022https://github.com/sqlc-dev/sqlc/pull/1462#event-6487428200
https://github.com/kdubovikov
kdubovikovhttps://github.com/kdubovikov
May 19, 2022https://github.com/sqlc-dev/sqlc/pull/1462#issuecomment-1131757733
#1334https://github.com/sqlc-dev/sqlc/issues/1334
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
https://github.co/hiddenchars
https://github.com/sqlc-dev/sqlc/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F1462
https://github.com/kyleconroy
kyleconroy https://github.com/kyleconroy
Please reload this pagehttps://github.com/sqlc-dev/sqlc/pull/1462
https://github.com/richardbizik
https://github.com/sbres
https://github.com/kdubovikov
https://github.com/kyleconroy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.