| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4bbe6b0b-6cad-4830-e9a5-326905dd947a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 96C8:215B92:25BC54A:32443F6:6B01A363 |
| html-safe-nonce | 3311cac1caf127d32a9cb49fe7ccdb33b67f18c1d6b79b8dd0e33e02975ddc6f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkM4OjIxNUI5MjoyNUJDNTRBOjMyNDQzRjY6NkIwMUEzNjMiLCJ2aXNpdG9yX2lkIjoiNDE0NTU3MzY4MDgxMTk3NTUyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f318aaaba557571fc6e9526ecdc7152880edc2cbc407b750750509ff91e8586a |
| hovercard-subject-tag | pull_request:867410076 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sqlc-dev/sqlc/1460/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/843886ac34e337e13a96459fac10b69d17dfc348f7fe06ca543d7e62c9423f13/sqlc-dev/sqlc/pull/1460 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/843886ac34e337e13a96459fac10b69d17dfc348f7fe06ca543d7e62c9423f13/sqlc-dev/sqlc/pull/1460 |
| og:image:alt | See #288, #923, #1416 .
(hi @kyleconroy!)
I got excited about the plugin api and wanted to try a few things out with the golang code generation...
There are a couple questionable things in here tha... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | stephen |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git |
| octolytics-dimension-user_id | 136738596 |
| octolytics-dimension-user_login | sqlc-dev |
| octolytics-dimension-repository_id | 193160679 |
| octolytics-dimension-repository_nwo | sqlc-dev/sqlc |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 193160679 |
| octolytics-dimension-repository_network_root_nwo | sqlc-dev/sqlc |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/sqlc-dev/sqlc/pull/1460#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F1460 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F1460 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc |
| Reload | https://github.com/sqlc-dev/sqlc/pull/1460 |
| Reload | https://github.com/sqlc-dev/sqlc/pull/1460 |
| Reload | https://github.com/sqlc-dev/sqlc/pull/1460 |
| sqlc-dev | https://github.com/sqlc-dev |
| sqlc | https://github.com/sqlc-dev/sqlc |
| Code | https://github.com/sqlc-dev/sqlc |
| Issues600 (600) | https://github.com/sqlc-dev/sqlc/issues |
| Pull requests132 (132) | https://github.com/sqlc-dev/sqlc/pulls |
| Discussions | https://github.com/sqlc-dev/sqlc/discussions |
| Actions | https://github.com/sqlc-dev/sqlc/actions |
| Projects | https://github.com/sqlc-dev/sqlc/projects |
| Security and quality | https://github.com/sqlc-dev/sqlc/security |
| Insights | https://github.com/sqlc-dev/sqlc/insights |
| https://github.com/sqlc-dev/sqlc |
| kyleconroy | https://github.com/kyleconroy |
| sqlc-dev:main | https://github.com/sqlc-dev/sqlc/tree/main |
| stephen:main | https://github.com/stephen/sqlc/tree/main |
| Conversation | https://github.com/sqlc-dev/sqlc/pull/1460 |
| Commits7 (7) | https://github.com/sqlc-dev/sqlc/pull/1460/commits |
| Checks | https://github.com/sqlc-dev/sqlc/pull/1460/checks |
| Files changed | https://github.com/sqlc-dev/sqlc/pull/1460/files |
| Refactor go codegen to plugin types | https://github.com/sqlc-dev/sqlc/pull/1460#top |
| kyleconroy | https://github.com/kyleconroy |
| sqlc-dev:main | https://github.com/sqlc-dev/sqlc/tree/main |
| stephen:main | https://github.com/stephen/sqlc/tree/main |
|
| https://github.com/stephen |
| stephen | https://github.com/stephen |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#issue-1154808538 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| #288 | https://github.com/sqlc-dev/sqlc/issues/288 |
| #923 | https://github.com/sqlc-dev/sqlc/pull/923 |
| #1416 | https://github.com/sqlc-dev/sqlc/pull/1416 |
| @kyleconroy | https://github.com/kyleconroy |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| stephen | https://github.com/stephen |
| February 28, 2022 18:00 | https://github.com/sqlc-dev/sqlc/pull/1460#commits-pushed-d3de3a8 |
|
| https://github.com/stephen |
| move a lot of stuff | https://github.com/sqlc-dev/sqlc/pull/1460/commits/d3de3a8c3c3c828623d4e24131ff874b84558e89 |
| d3de3a8 | https://github.com/sqlc-dev/sqlc/pull/1460/commits/d3de3a8c3c3c828623d4e24131ff874b84558e89 |
|
| https://github.com/stephen |
| more | https://github.com/sqlc-dev/sqlc/pull/1460/commits/9367b8242cf980e63ca6e650b632be12f24ea7d8 |
| 9367b82 | https://github.com/sqlc-dev/sqlc/pull/1460/commits/9367b8242cf980e63ca6e650b632be12f24ea7d8 |
|
| https://github.com/stephen |
| last bit | https://github.com/sqlc-dev/sqlc/pull/1460/commits/286eb40bc115a518e55332ef6f00fda18d5acfcd |
| 286eb40 | https://github.com/sqlc-dev/sqlc/pull/1460/commits/286eb40bc115a518e55332ef6f00fda18d5acfcd |
|
| https://github.com/stephen |
| oops | https://github.com/sqlc-dev/sqlc/pull/1460/commits/433c059a9bbd2ed3e0527ce6b665af870040bede |
| 433c059 | https://github.com/sqlc-dev/sqlc/pull/1460/commits/433c059a9bbd2ed3e0527ce6b665af870040bede |
| https://github.com/stephen |
| stephen | https://github.com/stephen |
|
Mar 1, 2022
| https://github.com/sqlc-dev/sqlc/pull/1460#pullrequestreview-895816271 |
|
View reviewed changes
| https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede |
| stephen | https://github.com/stephen |
| https://github.com/sqlc-dev/sqlc/pull/1460#pullrequestreview-895816271 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| protos/plugin/codegen.proto | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-7bd827b9e5f70a79f2e832b726d22c7fd81735b254e86fa0e43147b46ae7b0c3 |
| stephen | https://github.com/stephen |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816418455 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| kyleconroy | https://github.com/kyleconroy |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816963146 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/cmd/shim.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-1fe57c4219899679429d16ce3afd38f0e5519b1df6e6004594a68496498de77e |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/cmd/shim.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-1fe57c4219899679429d16ce3afd38f0e5519b1df6e6004594a68496498de77e |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/cmd/shim.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-1fe57c4219899679429d16ce3afd38f0e5519b1df6e6004594a68496498de77e |
| stephen | https://github.com/stephen |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816419727 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| oneof | https://developers.google.com/protocol-buffers/docs/proto3#oneof |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| kyleconroy | https://github.com/kyleconroy |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816952645 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Python AST proto | https://github.com/kyleconroy/sqlc/blob/main/protos/python/ast.proto#L7 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| stephen | https://github.com/stephen |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816981659 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| kyleconroy | https://github.com/kyleconroy |
| Mar 2, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r817308904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/cmd/shim.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-1fe57c4219899679429d16ce3afd38f0e5519b1df6e6004594a68496498de77e |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/codegen/golang/gen.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-c04dab838c419b0703213fce993d48f3d4f5fd6a659bb993d5528dd763b36198 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/codegen/golang/go_type.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-9febf00618188ee666b7f8cc8382cd90e83a745379afbf307f106cdc6da10d9e |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/codegen/golang/postgresql_type.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-0f092fe64405c1184e1bc4a30d6ffb1d5dbd2397fe90fd70590c12f15512808c |
| stephen | https://github.com/stephen |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816420547 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| kyleconroy | https://github.com/kyleconroy |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816961940 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| https://github.com/kyleconroy |
| kyleconroy | https://github.com/kyleconroy |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#issuecomment-1055620416 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| https://github.com/kyleconroy |
| kyleconroy | https://github.com/kyleconroy |
|
Mar 1, 2022
| https://github.com/sqlc-dev/sqlc/pull/1460#pullrequestreview-896554890 |
|
View reviewed changes
| https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede |
| kyleconroy | https://github.com/kyleconroy |
| https://github.com/sqlc-dev/sqlc/pull/1460#pullrequestreview-896554890 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/cmd/shim.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-1fe57c4219899679429d16ce3afd38f0e5519b1df6e6004594a68496498de77e |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/cmd/shim.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-1fe57c4219899679429d16ce3afd38f0e5519b1df6e6004594a68496498de77e |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/cmd/shim.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-1fe57c4219899679429d16ce3afd38f0e5519b1df6e6004594a68496498de77e |
| kyleconroy | https://github.com/kyleconroy |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816952645 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Python AST proto | https://github.com/kyleconroy/sqlc/blob/main/protos/python/ast.proto#L7 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/cmd/shim.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-1fe57c4219899679429d16ce3afd38f0e5519b1df6e6004594a68496498de77e |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/codegen/golang/compat.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-767f605de481c89037ee55af2cfc30b725c0676a512b9ae26ae7d6d432269400 |
| kyleconroy | https://github.com/kyleconroy |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816954790 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| codegen/python | https://github.com/kyleconroy/sqlc/blob/main/internal/codegen/python/gen.go#L406 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| stephen | https://github.com/stephen |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816982570 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/codegen/golang/result.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-554ace7a315b3c4704a348e208df36f1f4cffbd0ba9dfd51048f11fbffe8c138 |
| kyleconroy | https://github.com/kyleconroy |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816961280 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| internal/codegen/golang/postgresql_type.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-0f092fe64405c1184e1bc4a30d6ffb1d5dbd2397fe90fd70590c12f15512808c |
| kyleconroy | https://github.com/kyleconroy |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816961940 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| protos/plugin/codegen.proto | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-7bd827b9e5f70a79f2e832b726d22c7fd81735b254e86fa0e43147b46ae7b0c3 |
| kyleconroy | https://github.com/kyleconroy |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816963146 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| protos/plugin/codegen.proto | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-7bd827b9e5f70a79f2e832b726d22c7fd81735b254e86fa0e43147b46ae7b0c3 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| protos/plugin/codegen.proto | https://github.com/sqlc-dev/sqlc/pull/1460/files/433c059a9bbd2ed3e0527ce6b665af870040bede#diff-7bd827b9e5f70a79f2e832b726d22c7fd81735b254e86fa0e43147b46ae7b0c3 |
| kyleconroy | https://github.com/kyleconroy |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816964287 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| stephen | https://github.com/stephen |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r816984383 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| stephen | https://github.com/stephen |
| March 1, 2022 11:07 | https://github.com/sqlc-dev/sqlc/pull/1460#commits-pushed-03dcc21 |
|
| https://github.com/stephen |
| convert to spaces, fix up insert_into_table | https://github.com/sqlc-dev/sqlc/pull/1460/commits/03dcc2191260907f6b34d00da8972020ecc63dc5 |
| 03dcc21 | https://github.com/sqlc-dev/sqlc/pull/1460/commits/03dcc2191260907f6b34d00da8972020ecc63dc5 |
|
| https://github.com/stephen |
| remove use of core.FQN from sameTableName | https://github.com/sqlc-dev/sqlc/pull/1460/commits/0e89cebf37565d4bfa9fb9138636401ad7684e2c |
| 0e89ceb | https://github.com/sqlc-dev/sqlc/pull/1460/commits/0e89cebf37565d4bfa9fb9138636401ad7684e2c |
|
| https://github.com/stephen |
| remove notes to self | https://github.com/sqlc-dev/sqlc/pull/1460/commits/32f4c968857273582f71d01b72fdf85589548f1d |
| 32f4c96 | https://github.com/sqlc-dev/sqlc/pull/1460/commits/32f4c968857273582f71d01b72fdf85589548f1d |
| https://github.com/stephen |
| stephen | https://github.com/stephen |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#issuecomment-1055677148 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| https://github.com/stephen |
| stephen | https://github.com/stephen |
|
Mar 1, 2022
| https://github.com/sqlc-dev/sqlc/pull/1460#pullrequestreview-896667386 |
|
View reviewed changes
| https://github.com/sqlc-dev/sqlc/pull/1460/files/32f4c968857273582f71d01b72fdf85589548f1d |
| internal/codegen/golang/go_type.go | https://github.com/sqlc-dev/sqlc/pull/1460/files/32f4c968857273582f71d01b72fdf85589548f1d#diff-9febf00618188ee666b7f8cc8382cd90e83a745379afbf307f106cdc6da10d9e |
| stephen | https://github.com/stephen |
| Mar 1, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r817029197 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/stephen/sqlc/blame/32f4c968857273582f71d01b72fdf85589548f1d/internal/codegen/python/gen.go#L199 | https://github.com/stephen/sqlc/blame/32f4c968857273582f71d01b72fdf85589548f1d/internal/codegen/python/gen.go#L199 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| kyleconroy | https://github.com/kyleconroy |
| Mar 2, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r817310061 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| https://github.com/kyleconroy |
| kyleconroy | https://github.com/kyleconroy |
|
Mar 2, 2022
| https://github.com/sqlc-dev/sqlc/pull/1460#pullrequestreview-897049317 |
|
View reviewed changes
| https://github.com/sqlc-dev/sqlc/pull/1460/files/32f4c968857273582f71d01b72fdf85589548f1d |
| https://github.com/kyleconroy |
| kyleconroy | https://github.com/kyleconroy |
| March 2, 2022 03:07 | https://github.com/sqlc-dev/sqlc/pull/1460#event-6166592478 |
| https://github.com/kyleconroy |
| kyleconroy | https://github.com/kyleconroy |
| aade087 | https://github.com/sqlc-dev/sqlc/commit/aade08708ea0c4aa88fe7b5dbe929e325c323ccd |
| Mar 2, 2022 | https://github.com/sqlc-dev/sqlc/pull/1460#event-6166601347 |
| stephen | https://github.com/stephen |
|
Mar 2, 2022
| https://github.com/sqlc-dev/sqlc/pull/1460#ref-commit-869e312 |
|
| https://github.com/stephen |
| fix bug where datatype is read from | https://github.com/stephen/sqlc/commit/869e3124cdcbdb8efe2f05829c2495786a158f0e |
| 869e312 | https://github.com/stephen/sqlc/commit/869e3124cdcbdb8efe2f05829c2495786a158f0e |
| sqlc-dev#1460 (comment) | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r817029197 |
| stephen | https://github.com/stephen |
|
Mar 2, 2022
| https://github.com/sqlc-dev/sqlc/pull/1460#ref-commit-2cec58a |
|
| https://github.com/stephen |
| fix bug where datatype is read from | https://github.com/stephen/sqlc/commit/2cec58a228df830ee902813befc0ec92e058943b |
| 2cec58a | https://github.com/stephen/sqlc/commit/2cec58a228df830ee902813befc0ec92e058943b |
| sqlc-dev#1460 (comment) | https://github.com/sqlc-dev/sqlc/pull/1460#discussion_r817029197 |
| https://developers.google.com/protocol-buffers/docs/proto3#reserved | https://developers.google.com/protocol-buffers/docs/proto3#reserved |
| https://github.com/stephen |
| stephen | https://github.com/stephen |
|
Mar 2, 2022
| https://github.com/sqlc-dev/sqlc/pull/1460#ref-pullrequest-1157546561 |
|
Remove data_type from column proto
#1468
| https://github.com/sqlc-dev/sqlc/pull/1468 |
| https://github.co/hiddenchars |
| https://github.com/sqlc-dev/sqlc/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fpull%2F1460 |
|
| https://github.com/kyleconroy |
|
kyleconroy
| https://github.com/kyleconroy |
|
| https://github.com/sqlc-dev/sqlc/pull/1460/files/32f4c968857273582f71d01b72fdf85589548f1d |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
| Please reload this page | https://github.com/sqlc-dev/sqlc/pull/1460 |
|
| https://github.com/stephen |
|
| https://github.com/kyleconroy |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |