René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"WASM plugin error causes SIGSEGV","articleBody":"### Version\n\n1.27.0\n\n### What happened?\n\nsqlc throws a SIGSEGV when a WASM plugin fails to load.\r\n\r\nThat's caused by https://github.com/sqlc-dev/sqlc/blob/main/internal/ext/wasm/wasm.go#L226 where sqlc calls `result.Close()` on a wazero module, but wazero already closes modules on error.\n\n### Relevant log output\n\n```shell\npanic: runtime error: invalid memory address or nil pointer dereference\r\n[signal SIGSEGV: segmentation violation code=0x1 addr=0xb0 pc=0x1140027]\r\n\r\ngoroutine 8 [running]:\r\ngithub.com/tetratelabs/wazero/internal/wasm.(*ModuleInstance).setExitCode(...)\r\n        github.com/tetratelabs/wazero@v1.7.3/internal/wasm/module_instance.go:142\r\ngithub.com/tetratelabs/wazero/internal/wasm.(*ModuleInstance).CloseWithExitCode(0x8?, {0x1dce8a0?, 0xc00036dc20?}, 0x1?)\r\n        github.com/tetratelabs/wazero@v1.7.3/internal/wasm/module_instance.go:101 +0x27\r\ngithub.com/tetratelabs/wazero/internal/wasm.(*ModuleInstance).Close(0xc0007bc090?, {0x1dce8a0?, 0xc00036dc20?})\r\n        github.com/tetratelabs/wazero@v1.7.3/internal/wasm/module_instance.go:96 +0x1f\r\ngithub.com/sqlc-dev/sqlc/internal/ext/wasm.(*Runner).Invoke(0xc0009cf3c0, {0x1dce8a0, 0xc00036dc20}, {0x1aa58a8, 0x1f}, {0x19991e0?, 0xc0007fa630?}, {0x18e1f80, 0xc0009cf400}, {0x0, ...})\r\n        github.com/sqlc-dev/sqlc/internal/ext/wasm/wasm.go:229 +0x1039\r\ngithub.com/sqlc-dev/sqlc/internal/plugin.(*codegenServiceClient).Generate(0xc0005f8ad8, {0x1dce8a0, 0xc00036dc20}, 0xc0007fa630, {0x0, 0x0, 0x0})\r\n        github.com/sqlc-dev/sqlc/internal/plugin/codegen_grpc.pb.go:42 +0xc8\r\ngithub.com/sqlc-dev/sqlc/internal/cmd.codegen({_, _}, {{{0x33eb9d0, 0x1}, {{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, ...}, ...}, ...}, ...)\r\n        github.com/sqlc-dev/sqlc/internal/cmd/generate.go:410 +0x552\r\ngithub.com/sqlc-dev/sqlc/internal/cmd.(*generator).ProcessResult(_, {_, _}, {{{0x33eb9d0, 0x1}, {{0x0, 0x0}, {0x0, 0x0}, {0x0, ...}, ...}, ...}, ...}, ...)\r\n        github.com/sqlc-dev/sqlc/internal/cmd/generate.go:203 +0xa5\r\ngithub.com/sqlc-dev/sqlc/internal/cmd.processQuerySets.func1()\r\n        github.com/sqlc-dev/sqlc/internal/cmd/process.go:113 +0x8f0\r\ngolang.org/x/sync/errgroup.(*Group).Go.func1()\r\n        golang.org/x/sync@v0.8.0/errgroup/errgroup.go:78 +0x50\r\ncreated by golang.org/x/sync/errgroup.(*Group).Go in goroutine 1\r\n        golang.org/x/sync@v0.8.0/errgroup/errgroup.go:75 +0x96\n```\n\n\n### Database schema\n\n```sql\nNA\n```\n\n\n### SQL queries\n\n```sql\nNA\n```\n\n\n### Configuration\n\n```yaml\nNA\n```\n\n\n### Playground URL\n\n_No response_\n\n### What operating system are you using?\n\n_No response_\n\n### What database engines are you using?\n\n_No response_\n\n### What type of code are you generating?\n\n_No response_","author":{"url":"https://github.com/edman","@type":"Person","name":"edman"},"datePublished":"2024-12-22T14:34:12.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/3758/sqlc/issues/3758"}