René's URL Explorer Experiment


Title: LEFT JOIN (SELECT ...) can cause incorrect type being generated. · Issue #3667 · sqlc-dev/sqlc · GitHub

Open Graph Title: LEFT JOIN (SELECT ...) can cause incorrect type being generated. · Issue #3667 · sqlc-dev/sqlc

X Title: LEFT JOIN (SELECT ...) can cause incorrect type being generated. · Issue #3667 · sqlc-dev/sqlc

Description: Version 1.27.0 What happened? Related: #983 When doing a LEFT JOIN (SELECT ...) sqlc doesn't detect that the columns can be nullable. Example (I've made this PoC available in the playground): -- name: BadQueryRow :many SELECT ad.name AS ...

Open Graph Description: Version 1.27.0 What happened? Related: #983 When doing a LEFT JOIN (SELECT ...) sqlc doesn't detect that the columns can be nullable. Example (I've made this PoC available in the playground): -- na...

X Description: Version 1.27.0 What happened? Related: #983 When doing a LEFT JOIN (SELECT ...) sqlc doesn't detect that the columns can be nullable. Example (I've made this PoC available in the playground...

Opengraph URL: https://github.com/sqlc-dev/sqlc/issues/3667

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"LEFT JOIN (SELECT ...) can cause incorrect type being generated.","articleBody":"### Version\r\n\r\n1.27.0\r\n\r\n### What happened?\r\n\r\nRelated: https://github.com/sqlc-dev/sqlc/pull/983\r\n\r\nWhen doing a LEFT JOIN (SELECT ...) sqlc doesn't detect that the columns can be nullable. \r\n\r\nExample (I've made this PoC available [in the playground](https://play.sqlc.dev/p/0f833be306744cb1854171be2660d45f96905012a1f0e3db421b56b4c761f333)):\r\n\r\n```sql\r\n-- name: BadQueryRow :many\r\nSELECT\r\n    ad.name AS app_directory_name, -- ad.name is nullable\r\n    ad.logo AS app_directory_logo,\r\n    ad.uuid AS app_directory_uuid\r\nFROM applications AS a\r\nLEFT JOIN ( -- instead of a normal left join\r\n    SELECT name, logo, uuid\r\n    FROM application_directory.applications\r\n    WHERE archived_at IS NULL\r\n) ad ON ad.uuid = a.app_directory_id\r\nGROUP BY\r\n    ad.name,\r\n    ad.logo,\r\n    ad.uuid\r\n```\r\n\r\nThis will return a Row with strings:\r\n\r\n```go\r\ntype BadQueryRow struct {\r\n\tAppDirectoryName string -- incorrect\r\n\tAppDirectoryLogo string\r\n\tAppDirectoryUuid uuid.UUID\r\n}\r\n```\r\n\r\nIf we use a basic LEFT JOIN:\r\n\r\n```sql\r\n-- name: GoodQuery :many\r\nSELECT\r\n\tad.name AS app_directory_name,\r\n    ad.logo AS app_directory_logo,\r\n    ad.uuid AS app_directory_uuid\r\nFROM applications AS a\r\nLEFT JOIN application_directory.applications ad ON ad.uuid = a.app_directory_id\r\nGROUP BY\r\n    ad.name,\r\n    ad.logo,\r\n    ad.uuid;\r\n```\r\n\r\nWe will get a correct struct:\r\n\r\n```go\r\ntype GoodQueryRow struct {\r\n\tAppDirectoryName sql.NullString\r\n\tAppDirectoryLogo sql.NullString\r\n\tAppDirectoryUuid uuid.NullUUID\r\n}\r\n```\r\n\r\nExpected behavior is for BadQueryRow to be identical to GoodQueryRow.\r\n\r\n\r\n### Relevant log output\r\n\r\n_No response_\r\n\r\n### Database schema\r\n\r\n_No response_\r\n\r\n### SQL queries\r\n\r\n_No response_\r\n\r\n### Configuration\r\n\r\n_No response_\r\n\r\n### Playground URL\r\n\r\nhttps://play.sqlc.dev/p/0f833be306744cb1854171be2660d45f96905012a1f0e3db421b56b4c761f333\r\n\r\n### What operating system are you using?\r\n\r\nLinux\r\n\r\n### What database engines are you using?\r\n\r\nPostgreSQL\r\n\r\n### What type of code are you generating?\r\n\r\nGo","author":{"url":"https://github.com/ignassew","@type":"Person","name":"ignassew"},"datePublished":"2024-10-21T10:34:15Z","url":"https://github.com/sqlc-dev/sqlc/issues/3667"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8f657c84-15f5-a784-e7f9-d2153d455442
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8AF4:154D88:15F56C6:1C023A3:6B0174CE
html-safe-nonce489feadfa33c358cbfda48ad7351b93fde752fed5634c3de7163e50beef9840b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUY0OjE1NEQ4ODoxNUY1NkM2OjFDMDIzQTM6NkIwMTc0Q0UiLCJ2aXNpdG9yX2lkIjoiNjA3MTkzMTM2Mjc3OTE2NTkwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9f961af9177864b40727e7129ca14e1dd1c650c9fca2928e3677c1f2e4defddb
hovercard-subject-tagissue:2602100938
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/sqlc-dev/sqlc/3667/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2f5f457f6fd73b751b4c146bb444c581786a209ce8554182dfb5e580076909b1/sqlc-dev/sqlc/issues/3667
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2f5f457f6fd73b751b4c146bb444c581786a209ce8554182dfb5e580076909b1/sqlc-dev/sqlc/issues/3667
og:image:altVersion 1.27.0 What happened? Related: #983 When doing a LEFT JOIN (SELECT ...) sqlc doesn't detect that the columns can be nullable. Example (I've made this PoC available in the playground): -- na...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameignassew
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/issues/3667#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fissues%2F3667
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fissues%2F3667
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/issues/3667
Reloadhttps://github.com/sqlc-dev/sqlc/issues/3667
Reloadhttps://github.com/sqlc-dev/sqlc/issues/3667
sqlc-devhttps://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Codehttps://github.com/sqlc-dev/sqlc
Issues600 (600)https://github.com/sqlc-dev/sqlc/issues
Pull requests132 (132)https://github.com/sqlc-dev/sqlc/pulls
Discussionshttps://github.com/sqlc-dev/sqlc/discussions
Actionshttps://github.com/sqlc-dev/sqlc/actions
Projectshttps://github.com/sqlc-dev/sqlc/projects
Security and qualityhttps://github.com/sqlc-dev/sqlc/security
Insightshttps://github.com/sqlc-dev/sqlc/insights
https://github.com/sqlc-dev/sqlc
New issuehttps://github.com/login?return_to=https://github.com/sqlc-dev/sqlc/issues/3667
New issuehttps://github.com/login?return_to=https://github.com/sqlc-dev/sqlc/issues/3667
LEFT JOIN (SELECT ...) can cause incorrect type being generated.https://github.com/sqlc-dev/sqlc/issues/3667#top
📚 postgresqlhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Abooks%3A%20postgresql%22
💻 linuxhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Acomputer%3A%20linux%22
🔧 golanghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Awrench%3A%20golang%22
bugSomething isn't workinghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/ignassew
ignassewhttps://github.com/ignassew
on Oct 21, 2024https://github.com/sqlc-dev/sqlc/issues/3667#issue-2602100938
#983https://github.com/sqlc-dev/sqlc/pull/983
in the playgroundhttps://play.sqlc.dev/p/0f833be306744cb1854171be2660d45f96905012a1f0e3db421b56b4c761f333
https://play.sqlc.dev/p/0f833be306744cb1854171be2660d45f96905012a1f0e3db421b56b4c761f333https://play.sqlc.dev/p/0f833be306744cb1854171be2660d45f96905012a1f0e3db421b56b4c761f333
ignassewhttps://github.com/ignassew
bugSomething isn't workinghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22bug%22
on Oct 21, 2024https://github.com/sqlc-dev/sqlc/issues/3667#event-14762169594
dosubothttps://github.com/apps/dosubot
📚 postgresqlhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Abooks%3A%20postgresql%22
💻 linuxhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Acomputer%3A%20linux%22
🔧 golanghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Awrench%3A%20golang%22
on Oct 21, 2024https://github.com/sqlc-dev/sqlc/issues/3667#event-14762201829
https://github.com/epistemer
epistemerhttps://github.com/epistemer
on Dec 7, 2024https://github.com/sqlc-dev/sqlc/issues/3667#issuecomment-2525209424
https://github.com/Kavantix
Kavantixhttps://github.com/Kavantix
on Feb 17, 2026https://github.com/sqlc-dev/sqlc/issues/3667#issuecomment-3914015385
https://github.com/Kavantix
Kavantixhttps://github.com/Kavantix
on Feb 17, 2026https://github.com/sqlc-dev/sqlc/issues/3667#issuecomment-3914036945
#4117https://github.com/sqlc-dev/sqlc/issues/4117
oandrzhttps://github.com/oandrz
on Sep 2, 2026https://github.com/sqlc-dev/sqlc/issues/3667#event-30451004682
Admin households and metrics: the operator's support and usage screen (…https://github.com/oandrz/Household/commit/27808091685a392d39a6e7dff0fac142b3020a72
…https://github.com/oandrz/Household/pull/16
2780809https://github.com/oandrz/Household/commit/27808091685a392d39a6e7dff0fac142b3020a72
Sign up for freehttps://github.com/signup?return_to=https://github.com/sqlc-dev/sqlc/issues/3667
Sign in to commenthttps://github.com/login?return_to=https://github.com/sqlc-dev/sqlc/issues/3667
📚 postgresqlhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Abooks%3A%20postgresql%22
💻 linuxhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Acomputer%3A%20linux%22
🔧 golanghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Awrench%3A%20golang%22
bugSomething isn't workinghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.