René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"incorrect ambiguous reference check","articleBody":"### Version\n\n1.18.0\n\n### What happened?\n\n\r\nThere seems to be a minor bug in checking ambiguous references when joning tables while using alias.\r\n\r\nTo reproduce, change the `sqlc/internal/endtoend/testdata/order_by_non_existing_column/postgresql` to\r\n```\r\n-- Example queries for sqlc\r\nCREATE TABLE authors (\r\n  id   INT\r\n);\r\n\r\nCREATE TABLE books (\r\n  id   INT,\r\n  author_id INT,\r\n  price INT\r\n);\r\n\r\n-- name: ListAuthors :many\r\nSELECT id FROM authors\r\nORDER BY adfadsf;\r\n\r\n-- name: ListAuthorsByCheapestBook :many\r\nSELECT\r\nauthor_id, min(b.price) as min_price\r\nFrom books b inner join authors a on a.id = b.author_id\r\nGROUP BY b.author_id\r\nORDER BY min_price;\r\n```\r\n\r\nThe column of min_price is not ambiguous but sqlc reports:\r\n```\r\n# package \r\nquery.sql:13:1: column reference \"adfadsf\" not found: if you want to skip this validation, set 'strict_order_by' to false\r\nquery.sql:17:1: column reference \"min_price\" is ambiguous: if you want to skip this validation, set 'strict_order_by' to false\r\n\r\n```\n\n### Relevant log output\n\n```shell\nquery.sql:13:1: column reference \"adfadsf\" not found: if you want to skip this validation, set 'strict_order_by' to false\r\nquery.sql:17:1: column reference \"min_price\" is ambiguous: if you want to skip this validation, set 'strict_order_by' to false\n```\n\n\n### Database schema\n\n```sql\nCREATE TABLE authors (\r\n  id   INT\r\n);\r\n\r\nCREATE TABLE books (\r\n  id   INT,\r\n  author_id INT,\r\n  price INT\r\n);\n```\n\n\n### SQL queries\n\n```sql\n-- name: ListAuthorsByCheapestBook :many\r\nSELECT\r\nauthor_id, min(b.price) as min_price\r\nFrom books b inner join authors a on a.id = b.author_id\r\nGROUP BY b.author_id\r\nORDER BY min_price;\n```\n\n\n### Configuration\n\n_No response_\n\n### Playground URL\n\n_No response_\n\n### What operating system are you using?\n\nLinux\n\n### What database engines are you using?\n\nPostgreSQL\n\n### What type of code are you generating?\n\nGo","author":{"url":"https://github.com/Stumble","@type":"Person","name":"Stumble"},"datePublished":"2023-06-30T23:54:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/2398/sqlc/issues/2398"}