René's URL Explorer Experiment


Title: Enums in joins are not treated as nullable · Issue #1157 · sqlc-dev/sqlc · GitHub

Open Graph Title: Enums in joins are not treated as nullable · Issue #1157 · sqlc-dev/sqlc

X Title: Enums in joins are not treated as nullable · Issue #1157 · sqlc-dev/sqlc

Description: Version 1.9.0 What happened? Support for nullable columns in joins were added in v1.9.0. Unfortunately, it appears this doesn't extend to the auto-generated enum types. As can be seen in the generated Go types, the ListBooksRow contains ...

Open Graph Description: Version 1.9.0 What happened? Support for nullable columns in joins were added in v1.9.0. Unfortunately, it appears this doesn't extend to the auto-generated enum types. As can be seen in the genera...

X Description: Version 1.9.0 What happened? Support for nullable columns in joins were added in v1.9.0. Unfortunately, it appears this doesn't extend to the auto-generated enum types. As can be seen in the ge...

Opengraph URL: https://github.com/sqlc-dev/sqlc/issues/1157

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Enums in joins are not treated as nullable","articleBody":"### Version\n\n1.9.0\n\n### What happened?\n\nSupport for nullable columns in joins were added in v1.9.0. Unfortunately, it appears this doesn't extend to the auto-generated enum types. As can be seen in the generated Go types, the `ListBooksRow` contains an `sql.NullString`, but the enum type is not similarly nullable.\r\n\r\nThere's a bit of a design discussion to be had around what the best way to handle this is, since enums use a custom type. Perhaps a pointer would be enough, so that it could be null?\r\n\r\nRelated to #374\n\n### Relevant log output\n\n_No response_\n\n### Database schema\n\n```sql\nCREATE TABLE authors (\r\n  id   BIGSERIAL PRIMARY KEY,\r\n  name TEXT      NOT NULL\r\n);\r\n\r\nCREATE TYPE book_type AS ENUM ('hardback', 'softback', 'ebook');\r\n\r\nCREATE TABLE books (\r\n  id        BIGSERIAL PRIMARY KEY,\r\n  title     TEXT      NOT NULL,\r\n  book_type book_type NOT NULL,\r\n  author_id BIGINT    NULL        REFERENCES authors(id)\r\n);\n```\n\n\n### SQL queries\n\n```sql\n-- name: ListBooks :many\r\nSELECT authors.name, books.title, books.book_type FROM authors\r\nLEFT JOIN books ON authors.id = books.author_id;\n```\n\n\n### Configuration\n\n```yaml\nversion: 1\r\npackages:\r\n  - path: \"tutorial\"\r\n    name: \"tutorial\"\r\n    engine: \"postgresql\"\r\n    schema: \"schema.sql\"\r\n    queries: \"query.sql\"\n```\n\n\n### Playground URL\n\nhttps://play.sqlc.dev/p/086e386e94012b813b228429fc8067716c2b68e66db27de20699daafdb9d12b9\n\n### What operating system are you using?\n\nLinux\n\n### What database engines are you using?\n\nPostgreSQL\n\n### What type of code are you generating?\n\nGo","author":{"url":"https://github.com/johanbrandhorst","@type":"Person","name":"johanbrandhorst"},"datePublished":"2021-08-29T16:29:40Z","url":"https://github.com/sqlc-dev/sqlc/issues/1157"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1aad904b-5c44-747e-18b9-faabd35f1c1c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD742:399E4B:212F747:2BFAE87:6B017B3B
html-safe-nonce3e68eb962fb1fec31cb7c9104369110fd2a7db888f76bbba6da72eed02d14174
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzQyOjM5OUU0QjoyMTJGNzQ3OjJCRkFFODc6NkIwMTdCM0IiLCJ2aXNpdG9yX2lkIjoiMjgwMTAyNDQ1Nzg3ODEwODk4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacded0c481c7121e1f25007b33d25a4229cc8f294e2450ab51f1f60f1500862a17
hovercard-subject-tagissue:982143485
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/sqlc-dev/sqlc/1157/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b59b899ec9293a7fd6c64a8e488509c42a4ed00bcce0d2dc8a152cc13722a4c7/sqlc-dev/sqlc/issues/1157
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b59b899ec9293a7fd6c64a8e488509c42a4ed00bcce0d2dc8a152cc13722a4c7/sqlc-dev/sqlc/issues/1157
og:image:altVersion 1.9.0 What happened? Support for nullable columns in joins were added in v1.9.0. Unfortunately, it appears this doesn't extend to the auto-generated enum types. As can be seen in the genera...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejohanbrandhorst
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/sqlc-dev/sqlc git https://github.com/sqlc-dev/sqlc.git
octolytics-dimension-user_id136738596
octolytics-dimension-user_loginsqlc-dev
octolytics-dimension-repository_id193160679
octolytics-dimension-repository_nwosqlc-dev/sqlc
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id193160679
octolytics-dimension-repository_network_root_nwosqlc-dev/sqlc
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/sqlc-dev/sqlc/issues/1157#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fissues%2F1157
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsqlc-dev%2Fsqlc%2Fissues%2F1157
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=sqlc-dev%2Fsqlc
Reloadhttps://github.com/sqlc-dev/sqlc/issues/1157
Reloadhttps://github.com/sqlc-dev/sqlc/issues/1157
Reloadhttps://github.com/sqlc-dev/sqlc/issues/1157
sqlc-devhttps://github.com/sqlc-dev
sqlchttps://github.com/sqlc-dev/sqlc
Codehttps://github.com/sqlc-dev/sqlc
Issues600 (600)https://github.com/sqlc-dev/sqlc/issues
Pull requests132 (132)https://github.com/sqlc-dev/sqlc/pulls
Discussionshttps://github.com/sqlc-dev/sqlc/discussions
Actionshttps://github.com/sqlc-dev/sqlc/actions
Projectshttps://github.com/sqlc-dev/sqlc/projects
Security and qualityhttps://github.com/sqlc-dev/sqlc/security
Insightshttps://github.com/sqlc-dev/sqlc/insights
https://github.com/sqlc-dev/sqlc
New issuehttps://github.com/login?return_to=https://github.com/sqlc-dev/sqlc/issues/1157
New issuehttps://github.com/login?return_to=https://github.com/sqlc-dev/sqlc/issues/1157
Enums in joins are not treated as nullablehttps://github.com/sqlc-dev/sqlc/issues/1157#top
📚 postgresqlhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Abooks%3A%20postgresql%22
🔧 golanghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Awrench%3A%20golang%22
bugSomething isn't workinghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/johanbrandhorst
johanbrandhorsthttps://github.com/johanbrandhorst
on Aug 29, 2021https://github.com/sqlc-dev/sqlc/issues/1157#issue-982143485
#374https://github.com/sqlc-dev/sqlc/issues/374
https://play.sqlc.dev/p/086e386e94012b813b228429fc8067716c2b68e66db27de20699daafdb9d12b9https://play.sqlc.dev/p/086e386e94012b813b228429fc8067716c2b68e66db27de20699daafdb9d12b9
johanbrandhorsthttps://github.com/johanbrandhorst
bugSomething isn't workinghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22bug%22
triageNew issues that hasn't been reviewedhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22triage%22
on Aug 29, 2021https://github.com/sqlc-dev/sqlc/issues/1157#event-5222915981
https://github.com/kyleconroy
kyleconroyhttps://github.com/kyleconroy
on Aug 29, 2021https://github.com/sqlc-dev/sqlc/issues/1157#issuecomment-907830588
#1097https://github.com/sqlc-dev/sqlc/issues/1097
kyleconroyhttps://github.com/kyleconroy
🔧 golanghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Awrench%3A%20golang%22
📚 postgresqlhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Abooks%3A%20postgresql%22
triageNew issues that hasn't been reviewedhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22triage%22
on Aug 29, 2021https://github.com/sqlc-dev/sqlc/issues/1157#event-5222958478
kyleconroyhttps://github.com/kyleconroy
v1.10.0https://github.com/sqlc-dev/sqlc/milestone/11
on Aug 29, 2021https://github.com/sqlc-dev/sqlc/issues/1157#event-5222958516
kyleconroyhttps://github.com/kyleconroy
v1.10.0https://github.com/sqlc-dev/sqlc/milestone/11
v1.11.0https://github.com/sqlc-dev/sqlc/milestone/12
on Sep 5, 2021https://github.com/sqlc-dev/sqlc/issues/1157#event-5257791672
kyleconroyhttps://github.com/kyleconroy
v1.11.0https://github.com/sqlc-dev/sqlc/milestone/12
on Jan 31, 2022https://github.com/sqlc-dev/sqlc/issues/1157#event-5977910205
https://github.com/sbres
sbreshttps://github.com/sbres
on Mar 14, 2022https://github.com/sqlc-dev/sqlc/issues/1157#issuecomment-1067166568
#1485https://github.com/sqlc-dev/sqlc/pull/1485
https://github.com/Jille
Jillehttps://github.com/Jille
on May 2, 2022https://github.com/sqlc-dev/sqlc/issues/1157#issuecomment-1115047809
@SnoozeThishttps://github.com/SnoozeThis
#1097https://github.com/sqlc-dev/sqlc/issues/1097
https://github.com/apps/snoozethishttps://github.com/apps/snoozethis
https://github.com/SnoozeThis
SnoozeThishttps://github.com/SnoozeThis
on May 2, 2022https://github.com/sqlc-dev/sqlc/issues/1157#issuecomment-1115048060
https://snoozeth.is/bq_DKWjbxEIhttps://snoozeth.is/bq_DKWjbxEI
#1097https://github.com/sqlc-dev/sqlc/issues/1097
https://github.com/sgrishanin
sgrishaninhttps://github.com/sgrishanin
on May 11, 2023https://github.com/sqlc-dev/sqlc/issues/1157#issuecomment-1544122538
@kyleconroyhttps://github.com/kyleconroy
#1485https://github.com/sqlc-dev/sqlc/pull/1485
https://github.com/sbres
sbreshttps://github.com/sbres
on May 11, 2023https://github.com/sqlc-dev/sqlc/issues/1157#issuecomment-1544781811
https://github.com/johanbrandhorst
johanbrandhorsthttps://github.com/johanbrandhorst
on May 11, 2023https://github.com/sqlc-dev/sqlc/issues/1157#issuecomment-1544784114
johanbrandhorsthttps://github.com/johanbrandhorst
completedhttps://github.com/sqlc-dev/sqlc/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 11, 2023https://github.com/sqlc-dev/sqlc/issues/1157#event-9227454078
https://github.com/SnoozeThis
SnoozeThishttps://github.com/SnoozeThis
on Sep 22, 2023https://github.com/sqlc-dev/sqlc/issues/1157#issuecomment-1731869006
Sign up for freehttps://github.com/signup?return_to=https://github.com/sqlc-dev/sqlc/issues/1157
Sign in to commenthttps://github.com/login?return_to=https://github.com/sqlc-dev/sqlc/issues/1157
📚 postgresqlhttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Abooks%3A%20postgresql%22
🔧 golanghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22%3Awrench%3A%20golang%22
bugSomething isn't workinghttps://github.com/sqlc-dev/sqlc/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.