Title: GitDataClient.createAnnotatedTag() creates a simple tag instead of an annotated tag · Issue #76 · spotify/github-java-client · GitHub
Open Graph Title: GitDataClient.createAnnotatedTag() creates a simple tag instead of an annotated tag · Issue #76 · spotify/github-java-client
X Title: GitDataClient.createAnnotatedTag() creates a simple tag instead of an annotated tag · Issue #76 · spotify/github-java-client
Description: This method is supposed to create an annotated tag. It creates a simple tag instead. According to the github create a tag api docs (emphasis added) Note that creating a tag object does not create the reference that makes a tag in Git. If...
Open Graph Description: This method is supposed to create an annotated tag. It creates a simple tag instead. According to the github create a tag api docs (emphasis added) Note that creating a tag object does not create t...
X Description: This method is supposed to create an annotated tag. It creates a simple tag instead. According to the github create a tag api docs (emphasis added) Note that creating a tag object does not create t...
Opengraph URL: https://github.com/spotify/github-java-client/issues/76
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"GitDataClient.createAnnotatedTag() creates a simple tag instead of an annotated tag","articleBody":"This method is supposed to create an annotated tag. It creates a simple tag instead. \r\n\r\nAccording to the github [create a tag](https://docs.github.com/en/rest/reference/git#create-a-tag-object) api docs (emphasis added)\r\n\r\n\u003e Note that creating a tag object does not create the reference that makes a tag in Git. If you want to create an annotated tag in Git, you have to do **this call to create the tag object**, and then create the refs/tags/[tag] reference. If you want to create a lightweight tag, you only have to create the tag reference - this call would be unnecessary.\r\n\r\nThey fail to mention that the refs/tags/[tag] reference should be to the **tag object** not to the commit. If you do this with a real repository. \r\n\r\nWhen I create a tag using the existin gimplementation, I get a simple tag, not an annotated one: \r\n\r\n```\r\n$ git cat-file -p valid-main-20210917T162830\r\ntree 27793a753db63b1705269e2727292f88b8e363f5\r\nparent ee26020ac582dbafe276a3482653657666419d55\r\nauthor xxxxx 1626388655 -0600\r\ncommitter xxxxx 1626388655 -0600\r\n\r\nFixes checkstyle from refactoring\r\n```\r\n\r\nWhen I fix the implementation, the git data is correct, showing an annotated tag.\r\n\r\n```\r\n$ git cat-file -p valid-main-20210917T164327\r\nobject ce43212b8b8fd2b37fbad58f5023bbef2abcf261\r\ntype commit\r\ntag valid-main-20210917T164327\r\ntagger xxxxxx 1631897008 +0000\r\n\r\nTest create tag\r\n```\r\n\r\nI will submit a PR with the fix to the method and the test.","author":{"url":"https://github.com/solarhess","@type":"Person","name":"solarhess"},"datePublished":"2021-09-17T17:00:20.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/76/github-java-client/issues/76"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5326b579-02cf-b18e-7d06-22322a866b77 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 98B0:11DD7E:191724:239B55:69778728 |
| html-safe-nonce | de62e3512ae274eccd4e87ef7f6e7b02ea6b7d78072816c39d6a354e3cd44269 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEIwOjExREQ3RToxOTE3MjQ6MjM5QjU1OjY5Nzc4NzI4IiwidmlzaXRvcl9pZCI6IjY5MzA0MTQzNjUwOTAyMTk4MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e3b48563a130a641c144c54d881a97a5ba69ef3bfe2d1bf300cb404932fa5310 |
| hovercard-subject-tag | issue:999554285 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/spotify/github-java-client/76/issue_layout |
| twitter:image | https://opengraph.githubassets.com/997b134f08df778235c1af2ccb8b8dcb50ef6ff0d735c252f251ade6bc401616/spotify/github-java-client/issues/76 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/997b134f08df778235c1af2ccb8b8dcb50ef6ff0d735c252f251ade6bc401616/spotify/github-java-client/issues/76 |
| og:image:alt | This method is supposed to create an annotated tag. It creates a simple tag instead. According to the github create a tag api docs (emphasis added) Note that creating a tag object does not create t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | solarhess |
| hostname | github.com |
| expected-hostname | github.com |
| None | fd37f8e74ecc49b700617ea694fa6d7b395b6c9a4b79c59b3014da220462ac69 |
| turbo-cache-control | no-preview |
| go-import | github.com/spotify/github-java-client git https://github.com/spotify/github-java-client.git |
| octolytics-dimension-user_id | 251374 |
| octolytics-dimension-user_login | spotify |
| octolytics-dimension-repository_id | 254401089 |
| octolytics-dimension-repository_nwo | spotify/github-java-client |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 254401089 |
| octolytics-dimension-repository_network_root_nwo | spotify/github-java-client |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 523f6485bbeeb9958ec03260b225e9183734585d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width