René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Modular Input: Error during ValidationDefinition/InputDefinition when no value for parameter is passed","articleBody":"I am able to reproduce this using v1.9.1. This issue happens when the user provides no value for a modular input parameter.\r\nhttps://github.com/splunk/splunk-sdk-java/blob/master/splunk/src/main/java/com/splunk/modularinput/XmlUtil.java textInNode() line number 38:\r\n```\r\nstatic String textInNode(Node node, String errorMessage) throws MalformedDataException {\r\n        Node child = node.getFirstChild();\r\n        if (child.getNodeType() != Node.TEXT_NODE) {\r\n            throw new MalformedDataException(errorMessage);\r\n        } else {\r\n            return ((Text)child).getData();\r\n        }\r\n    }\r\n```\r\nHere, no null check is performed for the `child` variable. In case when the modular input parameter has no value, `child` will be null and child.getNodeType() leads to null pointer.\r\n\r\nSample input to --validate-arguments that triggers the error:\r\n```\r\n\u003c?xml version=\"1.0\" encoding=\"utf-16\"?\u003e\r\n\u003citems xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\"\u003e\r\n    \u003cserver_host\u003etiny\u003c/server_host\u003e\r\n    \u003cserver_uri\u003ehttps://127.0.0.1:8089\u003c/server_uri\u003e\r\n    \u003ccheckpoint_dir\u003e/opt/splunk/var/lib/splunk/modinputs\u003c/checkpoint_dir\u003e\r\n    \u003csession_key\u003e123102983109283019283\u003c/session_key\u003e\r\n    \u003c!-- The items element only ever contains one item element --\u003e\r\n    \u003citem name=\"aaa\"\u003e\r\n        \u003cparam name=\"param1\"\u003evalue1\u003c/param\u003e\r\n        \u003cparam name=\"param_bug\"\u003e\u003c/param\u003e\r\n        \u003cparam name=\"disabled\"\u003e0\u003c/param\u003e\r\n        \u003cparam name=\"index\"\u003edefault\u003c/param\u003e\r\n        \u003cparam_list name=\"multiValue\"\u003e\r\n            \u003cvalue\u003evalue1\u003c/value\u003e\r\n            \u003cvalue\u003evalue2\u003c/value\u003e\r\n        \u003c/param_list\u003e\r\n        \u003cparam_list name=\"multiValue2\"\u003e\r\n            \u003cvalue\u003evalue3\u003c/value\u003e\r\n            \u003cvalue\u003evalue4\u003c/value\u003e\r\n        \u003c/param_list\u003e\r\n    \u003c/item\u003e\r\n\u003c/items\u003e\r\n```\r\nIn the above example `param_bug` has no value (user did not input any value to the modular input parameter), this causes `child` to be null in the `textInNode()` method.\r\n\r\nPlease let me know if you need any other information regarding this issue.\r\n\r\nSimilar issue was created previously: https://github.com/splunk/splunk-sdk-java/issues/122 back in March 2018, but it was closed stating that it could not reproduced.","author":{"url":"https://github.com/jrobins04","@type":"Person","name":"jrobins04"},"datePublished":"2022-10-25T06:07:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":11},"url":"https://github.com/198/splunk-sdk-java/issues/198"}