René's URL Explorer Experiment

Title: fix(features): resolve Features in declaration order; stop treating http:// ids as tarballs by aledbf · Pull Request #76 · spin-stack/devcontainer-cli · GitHub

Open Graph Title: fix(features): resolve Features in declaration order; stop treating http:// ids as tarballs by aledbf · Pull Request #76 · spin-stack/devcontainer-cli

X Title: fix(features): resolve Features in declaration order; stop treating http:// ids as tarballs by aledbf · Pull Request #76 · spin-stack/devcontainer-cli

Description: Two drifts from the reference (TypeScript Dev Container CLI v0.90.0) in how Features are resolved. 1. Feature resolution order What TS does. generateFeaturesConfig → userFeaturesToArray (containerFeaturesConfiguration.ts) iterates Object.keys(config.features), then appends the --additional-features ids the configuration does not name, in their own Object.keys order. JS property order puts integer-like keys first, ascending, then the others in declaration order. features resolve-dependencies uses the same list. That order decides which Feature is processed first: the first failing Feature reported, the log lines, and the dependency graph's worklist (the mermaid output). Before. sortedUserFeatures sorted the ids (up, build, read-configuration, upgrade, compose). features resolve-dependencies took Go map order, which is random. build also ran checkLegacyFeatures before resolving anything: it reported a legacy id even when a Feature declared ahead of it fails first, and even before the image pull (TS reports docker pull failing there). After. The loader records the order of the features keys across the configuration and its override (DevContainer.FeatureOrder, features.KeyOrder of the concatenated member names, matching how deepMergeConfig merges). mergeAdditionalFeatures appends the additional-only ids after them, in the additional JSON's JS order. features.UserFeaturesToArray takes that order and is used everywhere sortedUserFeatures was, plus features resolve-dependencies. It falls back to sorted order only for ids no order names (maps built by callers). checkLegacyFeatures is removed. The legacy error still comes from resolveFeatureID, in resolution order. Call sites checked against TS: outdated and the upgrade --feature rewrite already used the file's declaration order (orderedFeatureKeys). Integer-like ids are never OCI references, so they are unaffected. The disallowed-Features check (featureIDsInOrder) is unchanged. 2. http:// Feature ids What TS does. getFeatureIdType takes only https:// as direct-tarball. An http://… id falls through to fetchOCIFeatureManifestIfExistsFromUserIdentifier. There getRef rejects it without a request (Path '/host/…' … failed validation), because the path always starts with /. TS then logs Could not resolve Feature manifest for ''… and returns github-repo. processFeatureIdentifier's GitHub branch refuses any id that is not owner/repo/feature and logs Could not resolve Feature ''. Ensure the Feature is published…. It returns undefined, and buildDependencyGraph throws ERR: Feature '' could not be processed. You may not have permission to access this Feature, or may not be logged in. If the issue persists, report this to the Feature author. Before. Go downloaded the tarball over plain HTTP: ClassifyID accepted http://. After. ClassifyID accepts only https://. When oci.ParseRef rejects a reference that TS's GitHub Releases fallback would also refuse (more than one @, or not owner/repo/<[A-Za-z0-9_-]*>), the Feature is left unprocessed after logging the reference's warning and error lines, so the user sees the reference's error. A reference the fallback would fetch from GitHub Releases still fails with the parse error, because this CLI does not implement that fallback (already documented). This is a breaking change: a configuration with a working http:// Feature now fails. docs/migration.md has the migration: serve the tarball over HTTPS, using NODE_EXTRA_CA_CERTS/SSL_CERT_FILE for a private CA, or publish to an OCI registry. The commit uses fix(features)!: with a BREAKING CHANGE: footer. Tests Each new test was checked against origin/main and fails there: internal/config: TestLoadOrdersFeatureIDsAsJavaScriptEnumeratesThem covers integer-like ids first and an override adding Features after the base's. TestLoadKeepsContainerEnvAndFeatureOptionOrder is extended for FeatureOrder. internal/features: TestUserFeaturesToArrayFollowsTheOrderThenSortsTheRest. TestClassifyID now expects http:// to be OCI. internal/cli: TestReadConfigurationReportsTheFirstFeatureInDeclarationOrder covers declaration order, integer-like ids, an override adding a Feature, and additional Features after the config's, including integer-like ones. TestReadConfigurationReportsAnAdditionalIntegerLikeIDAfterTheConfigs. TestFeaturesResolveDependenciesListsFeaturesInDeclarationOrder. TestMergeAdditionalFeaturesAppendsTheirOrderAfterTheConfigs. TestPlainHTTPFeatureIDIsNotATarball: no request is made, and both processors log the reference's lines. TestUnparseableFeatureReferences: the fallback's refusals, and the owner/repo/feature parse error that is kept. TestResolveFeatureIDRefusesLegacyIDs keeps the assertions of the removed TestCheckLegacyFeatures. gradle is dropped there because it never reaches resolveFeatureID; TestFetchFeatureSetsMovesDeprecatedFeaturesIntoOptions covers it. The tests that served tarball Features over plain HTTP now use a trusted TLS test server (serveTrustedTLS). ts-oracle: getFeatureIdType("http://example.com/devcontainer-feature-node.tgz") returns github-repo (generated with task testdata:ts-oracle). The Go adapter maps a reference oci.ParseRef rejects to github-repo. Parity cases (docs/parity/parity-matrix.yaml). All match TS and all fail with the origin/main binary: features.resolve-dependencies-declaration-order-success (contract): mermaid order of 5 local Features. build.features-first-failure-in-declaration-order-error (runtime): ../zeta refused before legacy zz. build.features-integer-like-ids-first-error (runtime): 9 before 10. build.additional-features-after-config-error (runtime). build.features-http-id-not-a-tarball-error (runtime). Checks All checks ran locally in the worktree. The shared host has a stray /tmp/.git and its Docker is shared with other runs. go build ./..., go vet ./...: pass Affected package tests (internal/config, internal/features, internal/cli, with TMPDIR=/var/tmp/…): pass. The only failures are the parity cases that the /tmp/.git workspace breaks. go tool task lint: pass (0 issues; ctxlife, testquality, refs, mutate -stale-exempts, deadgate and taskgate all OK) TMPDIR=/var/tmp/… BASE=origin/main go tool task mutate: 195 refused, 0 survived, 5 did not build TMPDIR=/var/tmp/… go tool task test:race: pass go tool task testdata:ts-oracle and testdata:ts-oracle:check: pass (13 goldens) go tool task parity:contract: 115 matched. The 2 that failed are read-configuration.features-configuration-local-feature-{key-order,metadata}-success, the known /tmp/.git cases. go tool task spec:compliance: pass go tool task test:e2e -- -timeout 40m: pass. The default 5m timeout ran out inside TestE2E_CABundle on the loaded shared Docker; that test passes alone. Runtime parity: the 74 Feature/lockfile/upgrade cases across build, up, read-configuration, features and upgrade, including the 4 new build cases. 61 matched. 4 failed the same way with the origin/main binary, all from /tmp/.git: read-configuration.merged-image-registry-features-success, read-configuration.features-configuration-oci-feature-key-order-success, read-configuration.feature-host-variables-merged-success and features.test-single-scenario-success. The compose up failures were Docker contention. Rerun alone, 6 of 9 matched. The other 3 failed only on their cleanup command timing out (exit=-1), with no output difference. The full PARITY_COMMAND=build,features,read-configuration,upgrade run hit its 1h timeout on the shared Docker. CI on this PR: all green, including parity-runtime (0), parity-runtime (1), e2e and mutate. 🤖 Generated with Claude Code

Open Graph Description: Two drifts from the reference (TypeScript Dev Container CLI v0.90.0) in how Features are resolved. 1. Feature resolution order What TS does. generateFeaturesConfig → userFeaturesToArray (containerF...

X Description: Two drifts from the reference (TypeScript Dev Container CLI v0.90.0) in how Features are resolved. 1. Feature resolution order What TS does. generateFeaturesConfig → userFeaturesToArray (containerF...

Opengraph URL: https://github.com/spin-stack/devcontainer-cli/pull/76

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width