René's URL Explorer Experiment


Title: fix: Avoid crash in the presence of decorators. by varungandhi-src · Pull Request #184 · sourcegraph/scip-python · GitHub

Open Graph Title: fix: Avoid crash in the presence of decorators. by varungandhi-src · Pull Request #184 · sourcegraph/scip-python

X Title: fix: Avoid crash in the presence of decorators. by varungandhi-src · Pull Request #184 · sourcegraph/scip-python

Description: SCIP indexer for Python. Contribute to sourcegraph/scip-python development by creating an account on GitHub.

Open Graph Description: Changes the method lookup logic to use the same logic as Pyright internals instead of our own ad-hoc implementation of name resolution, which does not match Python's method resolution order (MR...

X Description: Changes the method lookup logic to use the same logic as Pyright internals instead of our own ad-hoc implementation of name resolution, which does not match Python's method resolution order...

Opengraph URL: https://github.com/sourcegraph/scip-python/pull/184

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c8909262-5519-adf9-68c6-8ca4f0da098f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA4C:1BF4D5:BCC1E8:F2E270:69923E29
html-safe-nonce903ad1c201a8600b4493b594a3ef68a6d615db22013f843bac8860bb4a3ba2ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTRDOjFCRjRENTpCQ0MxRTg6RjJFMjcwOjY5OTIzRTI5IiwidmlzaXRvcl9pZCI6IjQ3MzY2OTY5NjE4MTM1OTM2NDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1e7219464e8137e4d1180b643fb92f6fbc12c8b3db9509ed55e0cf8ea05ffab2
hovercard-subject-tagpull_request:2748268018
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sourcegraph/scip-python/184/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/99d89b75f1cc6ef31f2c6b01da5162308a232083203bc455ab36de3623678761/sourcegraph/scip-python/pull/184
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/99d89b75f1cc6ef31f2c6b01da5162308a232083203bc455ab36de3623678761/sourcegraph/scip-python/pull/184
og:image:altChanges the method lookup logic to use the same logic as Pyright internals instead of our own ad-hoc implementation of name resolution, which does not match Python's method resolution order (MR...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevarungandhi-src
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/sourcegraph/scip-python git https://github.com/sourcegraph/scip-python.git
octolytics-dimension-user_id3979584
octolytics-dimension-user_loginsourcegraph
octolytics-dimension-repository_id443942523
octolytics-dimension-repository_nwosourcegraph/scip-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id443942523
octolytics-dimension-repository_network_root_nwosourcegraph/scip-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sourcegraph/scip-python/pull/184#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fscip-python%2Fpull%2F184
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fscip-python%2Fpull%2F184
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sourcegraph%2Fscip-python
Reloadhttps://github.com/sourcegraph/scip-python/pull/184
Reloadhttps://github.com/sourcegraph/scip-python/pull/184
Reloadhttps://github.com/sourcegraph/scip-python/pull/184
sourcegraph https://github.com/sourcegraph
scip-pythonhttps://github.com/sourcegraph/scip-python
Notifications https://github.com/login?return_to=%2Fsourcegraph%2Fscip-python
Fork 41 https://github.com/login?return_to=%2Fsourcegraph%2Fscip-python
Star 79 https://github.com/login?return_to=%2Fsourcegraph%2Fscip-python
Code https://github.com/sourcegraph/scip-python
Issues 9 https://github.com/sourcegraph/scip-python/issues
Pull requests 22 https://github.com/sourcegraph/scip-python/pulls
Actions https://github.com/sourcegraph/scip-python/actions
Security 0 https://github.com/sourcegraph/scip-python/security
Insights https://github.com/sourcegraph/scip-python/pulse
Code https://github.com/sourcegraph/scip-python
Issues https://github.com/sourcegraph/scip-python/issues
Pull requests https://github.com/sourcegraph/scip-python/pulls
Actions https://github.com/sourcegraph/scip-python/actions
Security https://github.com/sourcegraph/scip-python/security
Insights https://github.com/sourcegraph/scip-python/pulse
varungandhi-srchttps://github.com/varungandhi-src
sciphttps://github.com/sourcegraph/scip-python/tree/scip
vg/fix-bughttps://github.com/sourcegraph/scip-python/tree/vg/fix-bug
Conversationhttps://github.com/sourcegraph/scip-python/pull/184
Commits1 (1)https://github.com/sourcegraph/scip-python/pull/184/commits
Checkshttps://github.com/sourcegraph/scip-python/pull/184/checks
Files changedhttps://github.com/sourcegraph/scip-python/pull/184/files
fix: Avoid crash in the presence of decorators.https://github.com/sourcegraph/scip-python/pull/184#top
varungandhi-srchttps://github.com/varungandhi-src
sciphttps://github.com/sourcegraph/scip-python/tree/scip
vg/fix-bughttps://github.com/sourcegraph/scip-python/tree/vg/fix-bug
https://github.com/varungandhi-src
varungandhi-srchttps://github.com/varungandhi-src
Aug 15, 2025https://github.com/sourcegraph/scip-python/pull/184#issue-3324636813
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
GRAPH-1278https://linear.app/sourcegraph/issue/GRAPH-1278
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
https://github.com/varungandhi-src
varungandhi-srchttps://github.com/varungandhi-src
Aug 15, 2025 https://github.com/sourcegraph/scip-python/pull/184#ref-pullrequest-3321356896
fix: Make tests more robust & fix path-handling bugs on macOS #183 https://github.com/sourcegraph/scip-python/pull/183
https://github.com/varungandhi-src
https://github.com/apps/graphite-app
varungandhi-srchttps://github.com/varungandhi-src
Aug 15, 2025https://github.com/sourcegraph/scip-python/pull/184#issuecomment-3190888926
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
chore: Add formatting step in pyright-scip & update CI pipeline #185https://github.com/sourcegraph/scip-python/pull/185
https://app.graphite.dev/github/pr/sourcegraph/scip-python/185?utm_source=stack-comment-icon
fix: Avoid crash in the presence of decorators. #184https://github.com/sourcegraph/scip-python/pull/184
https://app.graphite.dev/github/pr/sourcegraph/scip-python/184?utm_source=stack-comment-icon
(View in Graphite)https://app.graphite.dev/github/pr/sourcegraph/scip-python/184?utm_source=stack-comment-view-in-graphite
fix: Make tests more robust & fix path-handling bugs on macOS #183https://github.com/sourcegraph/scip-python/pull/183
https://app.graphite.dev/github/pr/sourcegraph/scip-python/183?utm_source=stack-comment-icon
Graphitehttps://graphite.dev?utm-source=stack-comment
stackinghttps://stacking.dev/?utm_source=stack-comment
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
https://github.com/varungandhi-src
varungandhi-srchttps://github.com/varungandhi-src
jupblbhttps://github.com/jupblb
August 15, 2025 08:03https://github.com/sourcegraph/scip-python/pull/184#event-19172710839
https://github.com/varungandhi-src
varungandhi-srchttps://github.com/varungandhi-src
August 15, 2025 08:04https://github.com/sourcegraph/scip-python/pull/184#event-19172718665
https://github.com/varungandhi-src
varungandhi-srchttps://github.com/varungandhi-src
force-pushedhttps://github.com/sourcegraph/scip-python/compare/e330ce90ca6de36013da7c76ef7369b2c9543a58..34a3753153546afa853dd6e090288620e60be136
e330ce9https://github.com/sourcegraph/scip-python/commit/e330ce90ca6de36013da7c76ef7369b2c9543a58
34a3753https://github.com/sourcegraph/scip-python/commit/34a3753153546afa853dd6e090288620e60be136
Compare https://github.com/sourcegraph/scip-python/compare/e330ce90ca6de36013da7c76ef7369b2c9543a58..34a3753153546afa853dd6e090288620e60be136
August 15, 2025 08:07https://github.com/sourcegraph/scip-python/pull/184#event-19172748872
https://github.com/varungandhi-src
varungandhi-srchttps://github.com/varungandhi-src
Aug 15, 2025 https://github.com/sourcegraph/scip-python/pull/184#pullrequestreview-3123211073
View reviewed changes https://github.com/sourcegraph/scip-python/pull/184/files
packages/pyright-scip/snapshots/output/unique/inherits_class.pyhttps://github.com/sourcegraph/scip-python/pull/184/files#diff-642b2c77a36a7dde96397189dddcca9fb99d5eb45c64b222c44edd77f07bdd5a
varungandhi-srchttps://github.com/varungandhi-src
Aug 15, 2025https://github.com/sourcegraph/scip-python/pull/184#discussion_r2278503144
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
packages/pyright-scip/snapshots/output/unique/multiinherits_test.pyhttps://github.com/sourcegraph/scip-python/pull/184/files#diff-5305ca4e9beae72d57792829aa21d54ca39ab8cb165b7121748c77c8e0d021da
varungandhi-srchttps://github.com/varungandhi-src
Aug 15, 2025https://github.com/sourcegraph/scip-python/pull/184#discussion_r2278503685
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
packages/pyright-scip/src/treeVisitor.tshttps://github.com/sourcegraph/scip-python/pull/184/files#diff-da126b54ebac8845ec0a5861dccc380e1bbc7d52e28139e2b5d5235efd5a9068
varungandhi-srchttps://github.com/varungandhi-src
Aug 15, 2025https://github.com/sourcegraph/scip-python/pull/184#discussion_r2278504251
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
GRAPH-1278https://linear.app/sourcegraph/issue/GRAPH-1278
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
packages/pyright-scip/src/treeVisitor.tshttps://github.com/sourcegraph/scip-python/pull/184/files#diff-da126b54ebac8845ec0a5861dccc380e1bbc7d52e28139e2b5d5235efd5a9068
varungandhi-srchttps://github.com/varungandhi-src
Aug 15, 2025https://github.com/sourcegraph/scip-python/pull/184#discussion_r2278505980
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://sourcegraph.sourcegraph.com/github.com/sourcegraph/scip-clang/-/blob/indexer/SymbolFormatter.cc?L707https://sourcegraph.sourcegraph.com/github.com/sourcegraph/scip-clang/-/blob/indexer/SymbolFormatter.cc?L707
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
packages/pyright-scip/snapshots/input/graph_1278/mwe.pyhttps://github.com/sourcegraph/scip-python/pull/184/files#diff-7f0c93132c8ed56e26aa091ac4995e2b3f3a63773d9292fd9508abbfff22fc44
varungandhi-srchttps://github.com/varungandhi-src
Aug 15, 2025https://github.com/sourcegraph/scip-python/pull/184#discussion_r2278506865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
https://github.com/varungandhi-src
varungandhi-srchttps://github.com/varungandhi-src
Aug 15, 2025 https://github.com/sourcegraph/scip-python/pull/184#ref-pullrequest-3324741538
chore: Add formatting step in pyright-scip & update CI pipeline #185 https://github.com/sourcegraph/scip-python/pull/185
August 15, 2025 12:04https://github.com/sourcegraph/scip-python/pull/184#event-19175254170
https://github.com/varungandhi-src
fix: Avoid crash in the presence of decorators.https://github.com/sourcegraph/scip-python/pull/184/commits/5d4d8688b853b4dc5dc720976c3ad1fd955631d2
5d4d868https://github.com/sourcegraph/scip-python/pull/184/commits/5d4d8688b853b4dc5dc720976c3ad1fd955631d2
https://github.com/varungandhi-src
varungandhi-srchttps://github.com/varungandhi-src
force-pushedhttps://github.com/sourcegraph/scip-python/compare/34a3753153546afa853dd6e090288620e60be136..5d4d8688b853b4dc5dc720976c3ad1fd955631d2
34a3753https://github.com/sourcegraph/scip-python/commit/34a3753153546afa853dd6e090288620e60be136
5d4d868https://github.com/sourcegraph/scip-python/commit/5d4d8688b853b4dc5dc720976c3ad1fd955631d2
Compare https://github.com/sourcegraph/scip-python/compare/34a3753153546afa853dd6e090288620e60be136..5d4d8688b853b4dc5dc720976c3ad1fd955631d2
August 15, 2025 12:08https://github.com/sourcegraph/scip-python/pull/184#event-19175291399
https://github.com/varungandhi-src
varungandhi-srchttps://github.com/varungandhi-src
f519201https://github.com/sourcegraph/scip-python/commit/f519201e7bf1a572993180cb8dbbb18cb1054aa9
Aug 15, 2025https://github.com/sourcegraph/scip-python/pull/184#event-19175363401
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
https://github.com/varungandhi-src
varungandhi-srchttps://github.com/varungandhi-src
August 15, 2025 12:15https://github.com/sourcegraph/scip-python/pull/184#event-19175363814
ofeki-neosechttps://github.com/ofeki-neosec
Dec 3, 2025 https://github.com/sourcegraph/scip-python/pull/184#ref-commit-9bffde3
https://github.com/varungandhi-src
https://github.com/ofeki-neosec
fix: Avoid crash in the presence of decorators. (https://github.com/ofeki-neosec/scip-python/commit/9bffde33d59dd08a3b0e3333a0bdb7d8a134c2c1
sourcegraph#184https://github.com/sourcegraph/scip-python/pull/184
)https://github.com/ofeki-neosec/scip-python/commit/9bffde33d59dd08a3b0e3333a0bdb7d8a134c2c1
9bffde3https://github.com/ofeki-neosec/scip-python/commit/9bffde33d59dd08a3b0e3333a0bdb7d8a134c2c1
https://github.co/hiddenchars
https://github.com/sourcegraph/scip-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fscip-python%2Fpull%2F184
https://github.com/jupblb
jupblb https://github.com/jupblb
Please reload this pagehttps://github.com/sourcegraph/scip-python/pull/184
https://github.com/varungandhi-src
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.