René's URL Explorer Experiment


Title: Upgrade to typescript 2.4.2 by tomv564 · Pull Request #356 · sourcegraph/javascript-typescript-langserver · GitHub

Open Graph Title: Upgrade to typescript 2.4.2 by tomv564 · Pull Request #356 · sourcegraph/javascript-typescript-langserver

X Title: Upgrade to typescript 2.4.2 by tomv564 · Pull Request #356 · sourcegraph/javascript-typescript-langserver

Description: Upgrading directly to 2.5 yielded even more issues, this smaller bump should be more manageable. Compile errors remaining: Removed types/fields in ast.ts Element type in Observables is now strictly checked causing issues with Observables to which we concat Observable Test issues remaining: Fix tests around imports Fix test and runtime issues around imports/references

Open Graph Description: Upgrading directly to 2.5 yielded even more issues, this smaller bump should be more manageable. Compile errors remaining: Removed types/fields in ast.ts Element type in Observables is now stric...

X Description: Upgrading directly to 2.5 yielded even more issues, this smaller bump should be more manageable. Compile errors remaining: Removed types/fields in ast.ts Element type in Observables is now stric...

Opengraph URL: https://github.com/sourcegraph/javascript-typescript-langserver/pull/356

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:67a31327-0cfb-93eb-c473-331688e4e1ad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95CA:882E2:F3B1F5:1427679:6B01011B
html-safe-nonce156e2bd0f7c4d0b3f3f5ce87773f44a14cdcf066ade2f8aa0d4d91778d875e19
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUNBOjg4MkUyOkYzQjFGNToxNDI3Njc5OjZCMDEwMTFCIiwidmlzaXRvcl9pZCI6Ijc2MTAwNzMzNjMyNDcwNzE1MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac56d96930ac2cfd52ecf15388f5bb0fdec25e0459c7bd80fa464892345290c763
hovercard-subject-tagpull_request:142266593
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
twitter:imagehttps://avatars.githubusercontent.com/u/4395832?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4395832?s=400&v=4
og:image:altUpgrading directly to 2.5 yielded even more issues, this smaller bump should be more manageable. Compile errors remaining: Removed types/fields in ast.ts Element type in Observables is now stric...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/sourcegraph/javascript-typescript-langserver git https://github.com/sourcegraph/javascript-typescript-langserver.git
octolytics-dimension-user_id3979584
octolytics-dimension-user_loginsourcegraph
octolytics-dimension-repository_id68805662
octolytics-dimension-repository_nwosourcegraph/javascript-typescript-langserver
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68805662
octolytics-dimension-repository_network_root_nwosourcegraph/javascript-typescript-langserver
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fpull%2F356%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fpull%2F356%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sourcegraph%2Fjavascript-typescript-langserver
Reloadhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
Reloadhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
Reloadhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
sourcegraphhttps://github.com/sourcegraph
javascript-typescript-langserverhttps://github.com/sourcegraph/javascript-typescript-langserver
Codehttps://github.com/sourcegraph/javascript-typescript-langserver
Issues90 (90)https://github.com/sourcegraph/javascript-typescript-langserver/issues
Pull requests58 (58)https://github.com/sourcegraph/javascript-typescript-langserver/pulls
Actionshttps://github.com/sourcegraph/javascript-typescript-langserver/actions
Security and qualityhttps://github.com/sourcegraph/javascript-typescript-langserver/security
Insightshttps://github.com/sourcegraph/javascript-typescript-langserver/insights
felixfbeckerhttps://github.com/felixfbecker
sourcegraph:masterhttps://github.com/sourcegraph/javascript-typescript-langserver/tree/master
tomv564:upgrade-to-typescript-2.4.2https://github.com/tomv564/javascript-typescript-langserver/tree/upgrade-to-typescript-2.4.2
Conversation 7 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356
Commits 13 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits
Checks 0 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/checks
Files changed https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
Upgrade to typescript 2.4.2 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#top
Show all changes 13 commits https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
e48bf6b fix: bump package version tomv564 Sep 21, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e48bf6bf05ef7a15abdad6691d11ec6e454c69a3
78db06a fix: TS diagnostics fields are now optional tomv564 Sep 21, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/78db06af97d4f0e3d27c71a431182ffa7163b318
fbc4671 fix: pass more restrictive type to url.format tomv564 Sep 21, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/fbc46712b365a5e1acc45b50c148693792a95edf
af7ac3d fix: TS2394 overload signature not compatible issues tomv564 Sep 21, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/af7ac3d527ac991131bd838137027ca3c783acef
776be85 fix: locations used in definitions to github test tomv564 Sep 21, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/776be8551f58158f2671e827192cb3da2e15d6ec
e4d6c35 fix: add resolved references to TS for imports tomv564 Sep 21, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e4d6c35793362fcde829e390a2a1c9fa22cddbd5
761d9f4 fix: Switch to getChildren() in ast tomv564 Sep 21, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/761d9f4c3ad9c5cd13d6a092dbb24f2d7df0118a
8908437 fix: instances where generics typing needed to be preserved tomv564 Sep 23, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/8908437479a97a4485c5493218a3350fd4c1e1ea
379d805 fix: test with triple-slash references should use declaration files tomv564 Sep 23, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/379d805f0036307d59e5298f67110c8f7a62cc21
3c09ac7 fix: remove accidentally committed test filter tomv564 Sep 23, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/3c09ac7f8ea8cabd0ab092aa3140cda731b84c83
65c815d fix: implement missing functions, revert ensureSourceFile hack tomv564 Sep 25, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/65c815d713c4761f16fecc8ab89e3a8e2256643c
7ec6eb5 fix: revert unneeded fix to triple-slash tests tomv564 Sep 25, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/7ec6eb568e2c3fbfe18779c37bd2aceb5f673055
832c560 refactor: remove pairOf felixfbecker Sep 27, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/832c560dc39178c5b0a4eeb1049ea6c4b372c991
Clear filters https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
package.json https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
ast.ts https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-0b70af546cf14b11ad666d8d4a40e47e96c6b7f9d93fb785a5a30603cb6744d2
connection.ts https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-a6be0583428e46844273df76939f02077073da3075716fc57d291a5f2463eaf5
diagnostics.ts https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-da8cc70370d67b4c482d5cf755fb7f45697844107dd73ccf7f5b54162703f63c
fs.ts https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-0ae6196489e6b091dd2a543075ae337519dd650b065bc569b5f76da07105c50a
packages.ts https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-fb26c05404e113c74169d4324a23e440cf70797c9f3a8253e5479eacc6d2d101
project-manager.ts https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-d7ecb568434079532355abf787fcf11e337db4f43e681a4865063a615cfedf54
typescript-service-helpers.ts https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-6c45710d9197914ba2bc5c0a94a14e108565bcc70397ce452426f0b47911aad0
typescript-service.ts https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-27ce1db3938c6c5cb798c2ed6f665e5d89945c274822534d759de0959d3a85e2
package.jsonhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/tomv564/javascript-typescript-langserver/blob/832c560dc39178c5b0a4eeb1049ea6c4b372c991/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/{{ revealButtonHref }}
https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.