| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:67a31327-0cfb-93eb-c473-331688e4e1ad |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 95CA:882E2:F3B1F5:1427679:6B01011B |
| html-safe-nonce | 156e2bd0f7c4d0b3f3f5ce87773f44a14cdcf066ade2f8aa0d4d91778d875e19 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUNBOjg4MkUyOkYzQjFGNToxNDI3Njc5OjZCMDEwMTFCIiwidmlzaXRvcl9pZCI6Ijc2MTAwNzMzNjMyNDcwNzE1MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 56d96930ac2cfd52ecf15388f5bb0fdec25e0459c7bd80fa464892345290c763 |
| hovercard-subject-tag | pull_request:142266593 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
| twitter:image | https://avatars.githubusercontent.com/u/4395832?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4395832?s=400&v=4 |
| og:image:alt | Upgrading directly to 2.5 yielded even more issues, this smaller bump should be more manageable.
Compile errors remaining:
Removed types/fields in ast.ts
Element type in Observables is now stric... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/sourcegraph/javascript-typescript-langserver git https://github.com/sourcegraph/javascript-typescript-langserver.git |
| octolytics-dimension-user_id | 3979584 |
| octolytics-dimension-user_login | sourcegraph |
| octolytics-dimension-repository_id | 68805662 |
| octolytics-dimension-repository_nwo | sourcegraph/javascript-typescript-langserver |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 68805662 |
| octolytics-dimension-repository_network_root_nwo | sourcegraph/javascript-typescript-langserver |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fpull%2F356%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fpull%2F356%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=sourcegraph%2Fjavascript-typescript-langserver |
| Reload | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
| Reload | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
| Reload | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
| sourcegraph | https://github.com/sourcegraph |
| javascript-typescript-langserver | https://github.com/sourcegraph/javascript-typescript-langserver |
| Code | https://github.com/sourcegraph/javascript-typescript-langserver |
| Issues90 (90) | https://github.com/sourcegraph/javascript-typescript-langserver/issues |
| Pull requests58 (58) | https://github.com/sourcegraph/javascript-typescript-langserver/pulls |
| Actions | https://github.com/sourcegraph/javascript-typescript-langserver/actions |
| Security and quality | https://github.com/sourcegraph/javascript-typescript-langserver/security |
| Insights | https://github.com/sourcegraph/javascript-typescript-langserver/insights |
| felixfbecker | https://github.com/felixfbecker |
| sourcegraph:master | https://github.com/sourcegraph/javascript-typescript-langserver/tree/master |
| tomv564:upgrade-to-typescript-2.4.2 | https://github.com/tomv564/javascript-typescript-langserver/tree/upgrade-to-typescript-2.4.2 |
|
Conversation
7
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
|
Commits
13
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits |
|
Checks
0
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/checks |
|
Files changed
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
|
Upgrade to typescript 2.4.2
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#top |
|
Show all changes
13 commits
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
|
e48bf6b
fix: bump package version
tomv564 Sep 21, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e48bf6bf05ef7a15abdad6691d11ec6e454c69a3 |
|
78db06a
fix: TS diagnostics fields are now optional
tomv564 Sep 21, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/78db06af97d4f0e3d27c71a431182ffa7163b318 |
|
fbc4671
fix: pass more restrictive type to url.format
tomv564 Sep 21, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/fbc46712b365a5e1acc45b50c148693792a95edf |
|
af7ac3d
fix: TS2394 overload signature not compatible issues
tomv564 Sep 21, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/af7ac3d527ac991131bd838137027ca3c783acef |
|
776be85
fix: locations used in definitions to github test
tomv564 Sep 21, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/776be8551f58158f2671e827192cb3da2e15d6ec |
|
e4d6c35
fix: add resolved references to TS for imports
tomv564 Sep 21, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e4d6c35793362fcde829e390a2a1c9fa22cddbd5 |
|
761d9f4
fix: Switch to getChildren() in ast
tomv564 Sep 21, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/761d9f4c3ad9c5cd13d6a092dbb24f2d7df0118a |
|
8908437
fix: instances where generics typing needed to be preserved
tomv564 Sep 23, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/8908437479a97a4485c5493218a3350fd4c1e1ea |
|
379d805
fix: test with triple-slash references should use declaration files
tomv564 Sep 23, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/379d805f0036307d59e5298f67110c8f7a62cc21 |
|
3c09ac7
fix: remove accidentally committed test filter
tomv564 Sep 23, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/3c09ac7f8ea8cabd0ab092aa3140cda731b84c83 |
|
65c815d
fix: implement missing functions, revert ensureSourceFile hack
tomv564 Sep 25, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/65c815d713c4761f16fecc8ab89e3a8e2256643c |
|
7ec6eb5
fix: revert unneeded fix to triple-slash tests
tomv564 Sep 25, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/7ec6eb568e2c3fbfe18779c37bd2aceb5f673055 |
|
832c560
refactor: remove pairOf
felixfbecker Sep 27, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/832c560dc39178c5b0a4eeb1049ea6c4b372c991 |
|
Clear filters
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
|
package.json
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
ast.ts
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-0b70af546cf14b11ad666d8d4a40e47e96c6b7f9d93fb785a5a30603cb6744d2 |
|
connection.ts
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-a6be0583428e46844273df76939f02077073da3075716fc57d291a5f2463eaf5 |
|
diagnostics.ts
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-da8cc70370d67b4c482d5cf755fb7f45697844107dd73ccf7f5b54162703f63c |
|
fs.ts
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-0ae6196489e6b091dd2a543075ae337519dd650b065bc569b5f76da07105c50a |
|
packages.ts
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-fb26c05404e113c74169d4324a23e440cf70797c9f3a8253e5479eacc6d2d101 |
|
project-manager.ts
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-d7ecb568434079532355abf787fcf11e337db4f43e681a4865063a615cfedf54 |
|
typescript-service-helpers.ts
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-6c45710d9197914ba2bc5c0a94a14e108565bcc70397ce452426f0b47911aad0 |
|
typescript-service.ts
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-27ce1db3938c6c5cb798c2ed6f665e5d89945c274822534d759de0959d3a85e2 |
| package.json | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
View file
| https://github.com/tomv564/javascript-typescript-langserver/blob/832c560dc39178c5b0a4eeb1049ea6c4b372c991/package.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/{{ revealButtonHref }} |
|
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |