René's URL Explorer Experiment


Title: Upgrade to typescript 2.4.2 by tomv564 · Pull Request #356 · sourcegraph/javascript-typescript-langserver · GitHub

Open Graph Title: Upgrade to typescript 2.4.2 by tomv564 · Pull Request #356 · sourcegraph/javascript-typescript-langserver

X Title: Upgrade to typescript 2.4.2 by tomv564 · Pull Request #356 · sourcegraph/javascript-typescript-langserver

Description: JavaScript and TypeScript code intelligence through the Language Server Protocol - Upgrade to typescript 2.4.2 by tomv564 · Pull Request #356 · sourcegraph/javascript-typescript-langserver

Open Graph Description: Upgrading directly to 2.5 yielded even more issues, this smaller bump should be more manageable. Compile errors remaining: Removed types/fields in ast.ts Element type in Observables is now stric...

X Description: Upgrading directly to 2.5 yielded even more issues, this smaller bump should be more manageable. Compile errors remaining: Removed types/fields in ast.ts Element type in Observables is now stric...

Opengraph URL: https://github.com/sourcegraph/javascript-typescript-langserver/pull/356

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ba9b4567-1e75-1a1f-7f38-2b079e082da1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4BA:3D97C8:C7A3A3:10B62F2:6B00FB1F
html-safe-nonce13d5d94ee45a02db4f8177b9e6f4f7c46d865472ed0480d8ef92d58b63bc7140
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEJBOjNEOTdDODpDN0EzQTM6MTBCNjJGMjo2QjAwRkIxRiIsInZpc2l0b3JfaWQiOiI4ODgwNTM4MTE1NDcxNjM3Mjc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1371a2e9adf932e3d5b04b407c53d9bb3b8dd7eb22ccf50b275ac2995c153a4a
hovercard-subject-tagpull_request:142266593
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sourcegraph/javascript-typescript-langserver/356/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4e986b974225bd3210af2035eea5cfebbb49c76785f1f30205a2d2aa91834e51/sourcegraph/javascript-typescript-langserver/pull/356
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4e986b974225bd3210af2035eea5cfebbb49c76785f1f30205a2d2aa91834e51/sourcegraph/javascript-typescript-langserver/pull/356
og:image:altUpgrading directly to 2.5 yielded even more issues, this smaller bump should be more manageable. Compile errors remaining: Removed types/fields in ast.ts Element type in Observables is now stric...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametomv564
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/sourcegraph/javascript-typescript-langserver git https://github.com/sourcegraph/javascript-typescript-langserver.git
octolytics-dimension-user_id3979584
octolytics-dimension-user_loginsourcegraph
octolytics-dimension-repository_id68805662
octolytics-dimension-repository_nwosourcegraph/javascript-typescript-langserver
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68805662
octolytics-dimension-repository_network_root_nwosourcegraph/javascript-typescript-langserver
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fpull%2F356
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fpull%2F356
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sourcegraph%2Fjavascript-typescript-langserver
Reloadhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
Reloadhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
Reloadhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
sourcegraphhttps://github.com/sourcegraph
javascript-typescript-langserverhttps://github.com/sourcegraph/javascript-typescript-langserver
Codehttps://github.com/sourcegraph/javascript-typescript-langserver
Issues90 (90)https://github.com/sourcegraph/javascript-typescript-langserver/issues
Pull requests58 (58)https://github.com/sourcegraph/javascript-typescript-langserver/pulls
Actionshttps://github.com/sourcegraph/javascript-typescript-langserver/actions
Security and qualityhttps://github.com/sourcegraph/javascript-typescript-langserver/security
Insightshttps://github.com/sourcegraph/javascript-typescript-langserver/insights
https://github.com/sourcegraph/javascript-typescript-langserver
felixfbeckerhttps://github.com/felixfbecker
sourcegraph:masterhttps://github.com/sourcegraph/javascript-typescript-langserver/tree/master
tomv564:upgrade-to-typescript-2.4.2https://github.com/tomv564/javascript-typescript-langserver/tree/upgrade-to-typescript-2.4.2
Conversationhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
Commits13 (13)https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits
Checkshttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/checks
Files changedhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files
Upgrade to typescript 2.4.2https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#top
felixfbeckerhttps://github.com/felixfbecker
sourcegraph:masterhttps://github.com/sourcegraph/javascript-typescript-langserver/tree/master
tomv564:upgrade-to-typescript-2.4.2https://github.com/tomv564/javascript-typescript-langserver/tree/upgrade-to-typescript-2.4.2
https://github.com/tomv564
tomv564https://github.com/tomv564
Sep 21, 2017https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issue-259391859
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
tomv564https://github.com/tomv564
September 21, 2017 08:21https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#commits-pushed-e48bf6b
https://github.com/tomv564
fix: bump package versionhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e48bf6bf05ef7a15abdad6691d11ec6e454c69a3
e48bf6bhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e48bf6bf05ef7a15abdad6691d11ec6e454c69a3
https://github.com/tomv564
fix: TS diagnostics fields are now optionalhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/78db06af97d4f0e3d27c71a431182ffa7163b318
78db06ahttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/78db06af97d4f0e3d27c71a431182ffa7163b318
https://github.com/tomv564
fix: pass more restrictive type to url.formathttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/fbc46712b365a5e1acc45b50c148693792a95edf
fbc4671https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/fbc46712b365a5e1acc45b50c148693792a95edf
https://github.com/tomv564
fix: TS2394 overload signature not compatible issueshttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/af7ac3d527ac991131bd838137027ca3c783acef
af7ac3dhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/af7ac3d527ac991131bd838137027ca3c783acef
https://github.com/tomv564
fix: locations used in definitions to github testhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/776be8551f58158f2671e827192cb3da2e15d6ec
776be85https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/776be8551f58158f2671e827192cb3da2e15d6ec
https://github.com/felixfbecker
felixfbeckerhttps://github.com/felixfbecker
Sep 21, 2017https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331072088
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
tomv564https://github.com/tomv564
September 21, 2017 22:29https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#commits-pushed-e4d6c35
https://github.com/tomv564
fix: add resolved references to TS for importshttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e4d6c35793362fcde829e390a2a1c9fa22cddbd5
e4d6c35https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e4d6c35793362fcde829e390a2a1c9fa22cddbd5
https://github.com/tomv564
fix: Switch to getChildren() in asthttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/761d9f4c3ad9c5cd13d6a092dbb24f2d7df0118a
761d9f4https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/761d9f4c3ad9c5cd13d6a092dbb24f2d7df0118a
https://github.com/tomv564
tomv564https://github.com/tomv564
Sep 21, 2017https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331274358
@felixfbeckerhttps://github.com/felixfbecker
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
tomv564https://github.com/tomv564
September 23, 2017 12:29https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#commits-pushed-8908437
https://github.com/tomv564
fix: instances where generics typing needed to be preservedhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/8908437479a97a4485c5493218a3350fd4c1e1ea
8908437https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/8908437479a97a4485c5493218a3350fd4c1e1ea
https://github.com/tomv564
fix: test with triple-slash references should use declaration fileshttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/379d805f0036307d59e5298f67110c8f7a62cc21
379d805https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/379d805f0036307d59e5298f67110c8f7a62cc21
https://github.com/tomv564
fix: remove accidentally committed test filterhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/3c09ac7f8ea8cabd0ab092aa3140cda731b84c83
3c09ac7https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/3c09ac7f8ea8cabd0ab092aa3140cda731b84c83
https://github.com/tomv564
tomv564https://github.com/tomv564
Sep 23, 2017https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331653529
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
microsoft/TypeScript#14495https://github.com/microsoft/TypeScript/issues/14495
microsoft/TypeScript#14774https://github.com/microsoft/TypeScript/pull/14774
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
https://github.com/tomv564
fix: implement missing functions, revert ensureSourceFile hackhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/65c815d713c4761f16fecc8ab89e3a8e2256643c
65c815dhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/65c815d713c4761f16fecc8ab89e3a8e2256643c
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 25, 2017https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331961824
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
Codecovhttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=h1
#356https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=desc
masterhttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/commit/6087974050c313488b2497c1c7aee10a3d8b3a15?src=pr&el=desc
https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree
src/fs.tshttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL2ZzLnRz
src/connection.tshttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb24udHM=
src/typescript-service.tshttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL3R5cGVzY3JpcHQtc2VydmljZS50cw==
src/packages.tshttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL3BhY2thZ2VzLnRz
src/ast.tshttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL2FzdC50cw==
src/project-manager.tshttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL3Byb2plY3QtbWFuYWdlci50cw==
src/diagnostics.tshttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL2RpYWdub3N0aWNzLnRz
Continue to review full report at Codecovhttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=footer
6087974...832c560https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
https://github.com/tomv564
fix: revert unneeded fix to triple-slash testshttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/7ec6eb568e2c3fbfe18779c37bd2aceb5f673055
7ec6eb5https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/7ec6eb568e2c3fbfe18779c37bd2aceb5f673055
https://github.com/tomv564
tomv564https://github.com/tomv564
Sep 25, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#ref-issue-260375457
LanguageServerHost fileExists / readFile no longer optional? microsoft/TypeScript#18753 https://github.com/microsoft/TypeScript/issues/18753
https://github.com/tomv564
tomv564https://github.com/tomv564
Sep 25, 2017https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331975775
@felixfbeckerhttps://github.com/felixfbecker
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
https://github.com/tomv564
tomv564https://github.com/tomv564
Sep 25, 2017https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331984814
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
https://github.com/felixfbecker
felixfbeckerhttps://github.com/felixfbecker
Sep 25, 2017https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331987254
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
https://github.com/felixfbecker
refactor: remove pairOfhttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/832c560dc39178c5b0a4eeb1049ea6c4b372c991
832c560https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/832c560dc39178c5b0a4eeb1049ea6c4b372c991
https://github.com/felixfbecker
felixfbeckerhttps://github.com/felixfbecker
Sep 27, 2017 https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#pullrequestreview-65411371
View reviewed changes https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files/832c560dc39178c5b0a4eeb1049ea6c4b372c991
https://github.com/felixfbecker
felixfbeckerhttps://github.com/felixfbecker
122329dhttps://github.com/sourcegraph/javascript-typescript-langserver/commit/122329df15a50434e49719032ef8420cd7645e0b
Sep 27, 2017https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#event-1266921168
https://github.com/tomv564
tomv564https://github.com/tomv564
September 27, 2017 05:47https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#event-1267076623
https://github.co/hiddenchars
https://github.com/sourcegraph/javascript-typescript-langserver/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fpull%2F356
https://github.com/felixfbecker
felixfbecker https://github.com/felixfbecker
https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files/832c560dc39178c5b0a4eeb1049ea6c4b372c991
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
Please reload this pagehttps://github.com/sourcegraph/javascript-typescript-langserver/pull/356
https://github.com/tomv564
https://github.com/felixfbecker
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.