| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ba9b4567-1e75-1a1f-7f38-2b079e082da1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D4BA:3D97C8:C7A3A3:10B62F2:6B00FB1F |
| html-safe-nonce | 13d5d94ee45a02db4f8177b9e6f4f7c46d865472ed0480d8ef92d58b63bc7140 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEJBOjNEOTdDODpDN0EzQTM6MTBCNjJGMjo2QjAwRkIxRiIsInZpc2l0b3JfaWQiOiI4ODgwNTM4MTE1NDcxNjM3Mjc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1371a2e9adf932e3d5b04b407c53d9bb3b8dd7eb22ccf50b275ac2995c153a4a |
| hovercard-subject-tag | pull_request:142266593 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/sourcegraph/javascript-typescript-langserver/356/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4e986b974225bd3210af2035eea5cfebbb49c76785f1f30205a2d2aa91834e51/sourcegraph/javascript-typescript-langserver/pull/356 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4e986b974225bd3210af2035eea5cfebbb49c76785f1f30205a2d2aa91834e51/sourcegraph/javascript-typescript-langserver/pull/356 |
| og:image:alt | Upgrading directly to 2.5 yielded even more issues, this smaller bump should be more manageable.
Compile errors remaining:
Removed types/fields in ast.ts
Element type in Observables is now stric... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tomv564 |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-cache |
| go-import | github.com/sourcegraph/javascript-typescript-langserver git https://github.com/sourcegraph/javascript-typescript-langserver.git |
| octolytics-dimension-user_id | 3979584 |
| octolytics-dimension-user_login | sourcegraph |
| octolytics-dimension-repository_id | 68805662 |
| octolytics-dimension-repository_nwo | sourcegraph/javascript-typescript-langserver |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 68805662 |
| octolytics-dimension-repository_network_root_nwo | sourcegraph/javascript-typescript-langserver |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fpull%2F356 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fpull%2F356 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=sourcegraph%2Fjavascript-typescript-langserver |
| Reload | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| Reload | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| Reload | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| sourcegraph | https://github.com/sourcegraph |
| javascript-typescript-langserver | https://github.com/sourcegraph/javascript-typescript-langserver |
| Code | https://github.com/sourcegraph/javascript-typescript-langserver |
| Issues90 (90) | https://github.com/sourcegraph/javascript-typescript-langserver/issues |
| Pull requests58 (58) | https://github.com/sourcegraph/javascript-typescript-langserver/pulls |
| Actions | https://github.com/sourcegraph/javascript-typescript-langserver/actions |
| Security and quality | https://github.com/sourcegraph/javascript-typescript-langserver/security |
| Insights | https://github.com/sourcegraph/javascript-typescript-langserver/insights |
| https://github.com/sourcegraph/javascript-typescript-langserver |
| felixfbecker | https://github.com/felixfbecker |
| sourcegraph:master | https://github.com/sourcegraph/javascript-typescript-langserver/tree/master |
| tomv564:upgrade-to-typescript-2.4.2 | https://github.com/tomv564/javascript-typescript-langserver/tree/upgrade-to-typescript-2.4.2 |
| Conversation | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| Commits13 (13) | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits |
| Checks | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/checks |
| Files changed | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files |
| Upgrade to typescript 2.4.2 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#top |
| felixfbecker | https://github.com/felixfbecker |
| sourcegraph:master | https://github.com/sourcegraph/javascript-typescript-langserver/tree/master |
| tomv564:upgrade-to-typescript-2.4.2 | https://github.com/tomv564/javascript-typescript-langserver/tree/upgrade-to-typescript-2.4.2 |
|
| https://github.com/tomv564 |
| tomv564 | https://github.com/tomv564 |
| Sep 21, 2017 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issue-259391859 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| tomv564 | https://github.com/tomv564 |
| September 21, 2017 08:21 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#commits-pushed-e48bf6b |
|
| https://github.com/tomv564 |
| fix: bump package version | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e48bf6bf05ef7a15abdad6691d11ec6e454c69a3 |
| e48bf6b | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e48bf6bf05ef7a15abdad6691d11ec6e454c69a3 |
|
| https://github.com/tomv564 |
| fix: TS diagnostics fields are now optional | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/78db06af97d4f0e3d27c71a431182ffa7163b318 |
| 78db06a | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/78db06af97d4f0e3d27c71a431182ffa7163b318 |
|
| https://github.com/tomv564 |
| fix: pass more restrictive type to url.format | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/fbc46712b365a5e1acc45b50c148693792a95edf |
| fbc4671 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/fbc46712b365a5e1acc45b50c148693792a95edf |
|
| https://github.com/tomv564 |
| fix: TS2394 overload signature not compatible issues | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/af7ac3d527ac991131bd838137027ca3c783acef |
| af7ac3d | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/af7ac3d527ac991131bd838137027ca3c783acef |
|
| https://github.com/tomv564 |
| fix: locations used in definitions to github test | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/776be8551f58158f2671e827192cb3da2e15d6ec |
| 776be85 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/776be8551f58158f2671e827192cb3da2e15d6ec |
| https://github.com/felixfbecker |
| felixfbecker | https://github.com/felixfbecker |
| Sep 21, 2017 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331072088 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| tomv564 | https://github.com/tomv564 |
| September 21, 2017 22:29 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#commits-pushed-e4d6c35 |
|
| https://github.com/tomv564 |
| fix: add resolved references to TS for imports | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e4d6c35793362fcde829e390a2a1c9fa22cddbd5 |
| e4d6c35 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/e4d6c35793362fcde829e390a2a1c9fa22cddbd5 |
|
| https://github.com/tomv564 |
| fix: Switch to getChildren() in ast | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/761d9f4c3ad9c5cd13d6a092dbb24f2d7df0118a |
| 761d9f4 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/761d9f4c3ad9c5cd13d6a092dbb24f2d7df0118a |
| https://github.com/tomv564 |
| tomv564 | https://github.com/tomv564 |
| Sep 21, 2017 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331274358 |
| @felixfbecker | https://github.com/felixfbecker |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| tomv564 | https://github.com/tomv564 |
| September 23, 2017 12:29 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#commits-pushed-8908437 |
|
| https://github.com/tomv564 |
| fix: instances where generics typing needed to be preserved | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/8908437479a97a4485c5493218a3350fd4c1e1ea |
| 8908437 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/8908437479a97a4485c5493218a3350fd4c1e1ea |
|
| https://github.com/tomv564 |
| fix: test with triple-slash references should use declaration files | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/379d805f0036307d59e5298f67110c8f7a62cc21 |
| 379d805 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/379d805f0036307d59e5298f67110c8f7a62cc21 |
|
| https://github.com/tomv564 |
| fix: remove accidentally committed test filter | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/3c09ac7f8ea8cabd0ab092aa3140cda731b84c83 |
| 3c09ac7 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/3c09ac7f8ea8cabd0ab092aa3140cda731b84c83 |
| https://github.com/tomv564 |
| tomv564 | https://github.com/tomv564 |
| Sep 23, 2017 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331653529 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| microsoft/TypeScript#14495 | https://github.com/microsoft/TypeScript/issues/14495 |
| microsoft/TypeScript#14774 | https://github.com/microsoft/TypeScript/pull/14774 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
|
| https://github.com/tomv564 |
| fix: implement missing functions, revert ensureSourceFile hack | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/65c815d713c4761f16fecc8ab89e3a8e2256643c |
| 65c815d | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/65c815d713c4761f16fecc8ab89e3a8e2256643c |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Sep 25, 2017 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331961824 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| Codecov | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=h1 |
| #356 | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=desc |
| master | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/commit/6087974050c313488b2497c1c7aee10a3d8b3a15?src=pr&el=desc |
| https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree |
| Impacted Files | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree |
| src/fs.ts | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL2ZzLnRz |
| src/connection.ts | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb24udHM= |
| src/typescript-service.ts | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL3R5cGVzY3JpcHQtc2VydmljZS50cw== |
| src/packages.ts | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL3BhY2thZ2VzLnRz |
| src/ast.ts | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL2FzdC50cw== |
| src/project-manager.ts | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL3Byb2plY3QtbWFuYWdlci50cw== |
| src/diagnostics.ts | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=tree#diff-c3JjL2RpYWdub3N0aWNzLnRz |
| Continue to review full report at Codecov | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=continue |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta |
| Codecov | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=footer |
| 6087974...832c560 | https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/356?src=pr&el=lastupdated |
| comment docs | https://docs.codecov.io/docs/pull-request-comments |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
|
| https://github.com/tomv564 |
| fix: revert unneeded fix to triple-slash tests | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/7ec6eb568e2c3fbfe18779c37bd2aceb5f673055 |
| 7ec6eb5 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/7ec6eb568e2c3fbfe18779c37bd2aceb5f673055 |
| https://github.com/tomv564 |
| tomv564 | https://github.com/tomv564 |
|
Sep 25, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#ref-issue-260375457 |
|
LanguageServerHost fileExists / readFile no longer optional?
microsoft/TypeScript#18753
| https://github.com/microsoft/TypeScript/issues/18753 |
| https://github.com/tomv564 |
| tomv564 | https://github.com/tomv564 |
| Sep 25, 2017 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331975775 |
| @felixfbecker | https://github.com/felixfbecker |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| https://github.com/tomv564 |
| tomv564 | https://github.com/tomv564 |
| Sep 25, 2017 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331984814 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| https://github.com/felixfbecker |
| felixfbecker | https://github.com/felixfbecker |
| Sep 25, 2017 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#issuecomment-331987254 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
|
| https://github.com/felixfbecker |
| refactor: remove pairOf | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/832c560dc39178c5b0a4eeb1049ea6c4b372c991 |
| 832c560 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/commits/832c560dc39178c5b0a4eeb1049ea6c4b372c991 |
| https://github.com/felixfbecker |
| felixfbecker | https://github.com/felixfbecker |
|
Sep 27, 2017
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#pullrequestreview-65411371 |
|
View reviewed changes
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files/832c560dc39178c5b0a4eeb1049ea6c4b372c991 |
| https://github.com/felixfbecker |
| felixfbecker | https://github.com/felixfbecker |
| 122329d | https://github.com/sourcegraph/javascript-typescript-langserver/commit/122329df15a50434e49719032ef8420cd7645e0b |
| Sep 27, 2017 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#event-1266921168 |
| https://github.com/tomv564 |
| tomv564 | https://github.com/tomv564 |
| September 27, 2017 05:47 | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356#event-1267076623 |
| https://github.co/hiddenchars |
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fpull%2F356 |
|
| https://github.com/felixfbecker |
|
felixfbecker
| https://github.com/felixfbecker |
|
| https://github.com/sourcegraph/javascript-typescript-langserver/pull/356/files/832c560dc39178c5b0a4eeb1049ea6c4b372c991 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
| Please reload this page | https://github.com/sourcegraph/javascript-typescript-langserver/pull/356 |
|
| https://github.com/tomv564 |
|
| https://github.com/felixfbecker |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |