Title: Diagnostics are different from those produced by calling `tsc` directly · Issue #621 · sourcegraph/javascript-typescript-langserver · GitHub
Open Graph Title: Diagnostics are different from those produced by calling `tsc` directly · Issue #621 · sourcegraph/javascript-typescript-langserver
X Title: Diagnostics are different from those produced by calling `tsc` directly · Issue #621 · sourcegraph/javascript-typescript-langserver
Description: In this project I see some puzzling differences between the diagnostics reported by: javascript-typescript-langserver (2.11.3) + LanguageClient-neovim (56859896904347856) + Neovim (v0.4.0-dev) + typescript (3.5.3) and tsc (from typescrip...
Open Graph Description: In this project I see some puzzling differences between the diagnostics reported by: javascript-typescript-langserver (2.11.3) + LanguageClient-neovim (56859896904347856) + Neovim (v0.4.0-dev) + ty...
X Description: In this project I see some puzzling differences between the diagnostics reported by: javascript-typescript-langserver (2.11.3) + LanguageClient-neovim (56859896904347856) + Neovim (v0.4.0-dev) + ty...
Opengraph URL: https://github.com/sourcegraph/javascript-typescript-langserver/issues/621
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Diagnostics are different from those produced by calling `tsc` directly","articleBody":"In [this project](https://github.com/wincent/corpus/tree/5adc1677dfe08eec18c9c1c43ee006892fa39aca) I see some puzzling differences between the diagnostics reported by:\r\n\r\n- javascript-typescript-langserver (2.11.3) + LanguageClient-neovim (56859896904347856) + Neovim (v0.4.0-dev) + typescript (3.5.3)\r\n- and `tsc` (from typescript 3.5.3)\r\n\r\n`tsc` will report a clean build, but javascript-typescript-langserver complains [in this file](https://github.com/wincent/corpus/blob/5adc1677dfe08eec18c9c1c43ee006892fa39aca/src/renderer/util/FrozenSet.ts#L23) that `Argument of type 'Iterable\u003cT> | null | undefined' is not assignable to parameter of type 'ReadonlyArray\u003cT> | null...`.\r\n\r\nThere are two `SetConstructor` overloads:\r\n\r\n- https://github.com/microsoft/TypeScript/blob/70b7bd5a1b8c3bc1ba7c644b37412368607706e6/src/lib/es2015.iterable.d.ts#L188\r\n- https://github.com/microsoft/TypeScript/blob/70b7bd5a1b8c3bc1ba7c644b37412368607706e6/src/lib/es2015.collection.d.ts#L48\r\n\r\nEvidently, `tsc` alone is picking the former, but in the context of javascript-typescript-langserver, it's picking the latter, leading to the diagnostic.\r\n\r\nIf I turn debug logging on in LanguageClient-neovim, I get [this](https://gist.github.com/wincent/e40ff8cb25e939e719cd62047d130f32).\r\n\r\nAnd logging with `--trace --logfil some-file` to `javascript-typescript-stdio` I get [this](https://gist.github.com/wincent/b6f7c437101ea72022e82dfb58bc6be2).\r\n\r\nI don't know if this is related to https://github.com/sourcegraph/javascript-typescript-langserver/issues/618 — perhaps it is not picking up my [tsconfig.json](https://github.com/wincent/corpus/blob/5adc1677dfe08eec18c9c1c43ee006892fa39aca/tsconfig.json). But I don't know if this is a bug in my own code, in TypeScript, in javascript-typescript-langserver, in LanguageClient-neovim, or maybe something else I am overlooking. One thing I did notice was that when I tried to repro in VSCode, it had the same problem, but when I updated it, the problem resolved; the release notes said:\r\n\r\n> **JavaScript and TypeScript nightly extension**\r\n>\r\n> The new JavaScript and TypeScript nightly extension uses the nightly build of TypeScript (typescript@next) for VS Code's built-in TypeScript version, which powers JavaScript and TypeScript IntelliSense. This makes it easy to test the latest TypeScript features and provide feedback about them!\"","author":{"url":"https://github.com/wincent","@type":"Person","name":"wincent"},"datePublished":"2019-07-21T10:47:59Z","url":"https://github.com/sourcegraph/javascript-typescript-langserver/issues/621"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7f716cbe-ed6e-405a-9ead-e7f9c7d99cd6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9A96:1087D4:FFDAEA:155FF60:6B0114E3 |
| html-safe-nonce | 7ab03176cb36ac74d89c79b3daa2a3804048b5572c2d45682d9c1a3bf23a015e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTk2OjEwODdENDpGRkRBRUE6MTU1RkY2MDo2QjAxMTRFMyIsInZpc2l0b3JfaWQiOiI2NTUzMDMyMjU3NTg0NTY3NTIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 497bbe23a9845fadf98ad3e9b21dd6e8f1ba87c65bbb72e21feca60812c6e0aa |
| hovercard-subject-tag | issue:470767935 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/sourcegraph/javascript-typescript-langserver/621/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3d7b0e76a07a2ef32089ebffdd177d2745cbc7f5b30289c2710c1fbcd9288ab4/sourcegraph/javascript-typescript-langserver/issues/621 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3d7b0e76a07a2ef32089ebffdd177d2745cbc7f5b30289c2710c1fbcd9288ab4/sourcegraph/javascript-typescript-langserver/issues/621 |
| og:image:alt | In this project I see some puzzling differences between the diagnostics reported by: javascript-typescript-langserver (2.11.3) + LanguageClient-neovim (56859896904347856) + Neovim (v0.4.0-dev) + ty... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | wincent |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/sourcegraph/javascript-typescript-langserver git https://github.com/sourcegraph/javascript-typescript-langserver.git |
| octolytics-dimension-user_id | 3979584 |
| octolytics-dimension-user_login | sourcegraph |
| octolytics-dimension-repository_id | 68805662 |
| octolytics-dimension-repository_nwo | sourcegraph/javascript-typescript-langserver |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 68805662 |
| octolytics-dimension-repository_network_root_nwo | sourcegraph/javascript-typescript-langserver |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width