René's URL Explorer Experiment


Title: Diagnostics are different from those produced by calling `tsc` directly · Issue #621 · sourcegraph/javascript-typescript-langserver · GitHub

Open Graph Title: Diagnostics are different from those produced by calling `tsc` directly · Issue #621 · sourcegraph/javascript-typescript-langserver

X Title: Diagnostics are different from those produced by calling `tsc` directly · Issue #621 · sourcegraph/javascript-typescript-langserver

Description: In this project I see some puzzling differences between the diagnostics reported by: javascript-typescript-langserver (2.11.3) + LanguageClient-neovim (56859896904347856) + Neovim (v0.4.0-dev) + typescript (3.5.3) and tsc (from typescrip...

Open Graph Description: In this project I see some puzzling differences between the diagnostics reported by: javascript-typescript-langserver (2.11.3) + LanguageClient-neovim (56859896904347856) + Neovim (v0.4.0-dev) + ty...

X Description: In this project I see some puzzling differences between the diagnostics reported by: javascript-typescript-langserver (2.11.3) + LanguageClient-neovim (56859896904347856) + Neovim (v0.4.0-dev) + ty...

Opengraph URL: https://github.com/sourcegraph/javascript-typescript-langserver/issues/621

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Diagnostics are different from those produced by calling `tsc` directly","articleBody":"In [this project](https://github.com/wincent/corpus/tree/5adc1677dfe08eec18c9c1c43ee006892fa39aca) I see some puzzling differences between the diagnostics reported by:\r\n\r\n- javascript-typescript-langserver (2.11.3) + LanguageClient-neovim (56859896904347856) + Neovim (v0.4.0-dev) + typescript (3.5.3)\r\n- and `tsc` (from typescript 3.5.3)\r\n\r\n`tsc` will report a clean build, but javascript-typescript-langserver complains [in this file](https://github.com/wincent/corpus/blob/5adc1677dfe08eec18c9c1c43ee006892fa39aca/src/renderer/util/FrozenSet.ts#L23) that `Argument of type 'Iterable\u003cT> | null | undefined' is not assignable to parameter of type 'ReadonlyArray\u003cT> | null...`.\r\n\r\nThere are two `SetConstructor` overloads:\r\n\r\n- https://github.com/microsoft/TypeScript/blob/70b7bd5a1b8c3bc1ba7c644b37412368607706e6/src/lib/es2015.iterable.d.ts#L188\r\n- https://github.com/microsoft/TypeScript/blob/70b7bd5a1b8c3bc1ba7c644b37412368607706e6/src/lib/es2015.collection.d.ts#L48\r\n\r\nEvidently, `tsc` alone is picking the former, but in the context of javascript-typescript-langserver, it's picking the latter, leading to the diagnostic.\r\n\r\nIf I turn debug logging on in LanguageClient-neovim, I get [this](https://gist.github.com/wincent/e40ff8cb25e939e719cd62047d130f32).\r\n\r\nAnd logging with `--trace --logfil some-file` to `javascript-typescript-stdio` I get [this](https://gist.github.com/wincent/b6f7c437101ea72022e82dfb58bc6be2).\r\n\r\nI don't know if this is related to https://github.com/sourcegraph/javascript-typescript-langserver/issues/618 — perhaps it is not picking up my [tsconfig.json](https://github.com/wincent/corpus/blob/5adc1677dfe08eec18c9c1c43ee006892fa39aca/tsconfig.json). But I don't know if this is a bug in my own code, in TypeScript, in javascript-typescript-langserver, in LanguageClient-neovim, or maybe something else I am overlooking. One thing I did notice was that when I tried to repro in VSCode, it had the same problem, but when I updated it, the problem resolved; the release notes said:\r\n\r\n> **JavaScript and TypeScript nightly extension**\r\n>\r\n> The new JavaScript and TypeScript nightly extension uses the nightly build of TypeScript (typescript@next) for VS Code's built-in TypeScript version, which powers JavaScript and TypeScript IntelliSense. This makes it easy to test the latest TypeScript features and provide feedback about them!\"","author":{"url":"https://github.com/wincent","@type":"Person","name":"wincent"},"datePublished":"2019-07-21T10:47:59Z","url":"https://github.com/sourcegraph/javascript-typescript-langserver/issues/621"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7f716cbe-ed6e-405a-9ead-e7f9c7d99cd6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9A96:1087D4:FFDAEA:155FF60:6B0114E3
html-safe-nonce7ab03176cb36ac74d89c79b3daa2a3804048b5572c2d45682d9c1a3bf23a015e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTk2OjEwODdENDpGRkRBRUE6MTU1RkY2MDo2QjAxMTRFMyIsInZpc2l0b3JfaWQiOiI2NTUzMDMyMjU3NTg0NTY3NTIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac497bbe23a9845fadf98ad3e9b21dd6e8f1ba87c65bbb72e21feca60812c6e0aa
hovercard-subject-tagissue:470767935
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/sourcegraph/javascript-typescript-langserver/621/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3d7b0e76a07a2ef32089ebffdd177d2745cbc7f5b30289c2710c1fbcd9288ab4/sourcegraph/javascript-typescript-langserver/issues/621
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3d7b0e76a07a2ef32089ebffdd177d2745cbc7f5b30289c2710c1fbcd9288ab4/sourcegraph/javascript-typescript-langserver/issues/621
og:image:altIn this project I see some puzzling differences between the diagnostics reported by: javascript-typescript-langserver (2.11.3) + LanguageClient-neovim (56859896904347856) + Neovim (v0.4.0-dev) + ty...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewincent
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/sourcegraph/javascript-typescript-langserver git https://github.com/sourcegraph/javascript-typescript-langserver.git
octolytics-dimension-user_id3979584
octolytics-dimension-user_loginsourcegraph
octolytics-dimension-repository_id68805662
octolytics-dimension-repository_nwosourcegraph/javascript-typescript-langserver
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68805662
octolytics-dimension-repository_network_root_nwosourcegraph/javascript-typescript-langserver
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/sourcegraph/javascript-typescript-langserver/issues/621#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fissues%2F621
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsourcegraph%2Fjavascript-typescript-langserver%2Fissues%2F621
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=sourcegraph%2Fjavascript-typescript-langserver
Reloadhttps://github.com/sourcegraph/javascript-typescript-langserver/issues/621
Reloadhttps://github.com/sourcegraph/javascript-typescript-langserver/issues/621
Reloadhttps://github.com/sourcegraph/javascript-typescript-langserver/issues/621
sourcegraphhttps://github.com/sourcegraph
javascript-typescript-langserverhttps://github.com/sourcegraph/javascript-typescript-langserver
Codehttps://github.com/sourcegraph/javascript-typescript-langserver
Issues90 (90)https://github.com/sourcegraph/javascript-typescript-langserver/issues
Pull requests58 (58)https://github.com/sourcegraph/javascript-typescript-langserver/pulls
Actionshttps://github.com/sourcegraph/javascript-typescript-langserver/actions
Security and qualityhttps://github.com/sourcegraph/javascript-typescript-langserver/security
Insightshttps://github.com/sourcegraph/javascript-typescript-langserver/insights
https://github.com/sourcegraph/javascript-typescript-langserver
Diagnostics are different from those produced by calling tsc directlyhttps://github.com/sourcegraph/javascript-typescript-langserver/issues/621#top
https://github.com/wincent
wincenthttps://github.com/wincent
on Jul 21, 2019https://github.com/sourcegraph/javascript-typescript-langserver/issues/621#issue-470767935
this projecthttps://github.com/wincent/corpus/tree/5adc1677dfe08eec18c9c1c43ee006892fa39aca
in this filehttps://github.com/wincent/corpus/blob/5adc1677dfe08eec18c9c1c43ee006892fa39aca/src/renderer/util/FrozenSet.ts#L23
https://github.com/microsoft/TypeScript/blob/70b7bd5a1b8c3bc1ba7c644b37412368607706e6/src/lib/es2015.iterable.d.ts#L188https://github.com/microsoft/TypeScript/blob/70b7bd5a1b8c3bc1ba7c644b37412368607706e6/src/lib/es2015.iterable.d.ts#L188
https://github.com/microsoft/TypeScript/blob/70b7bd5a1b8c3bc1ba7c644b37412368607706e6/src/lib/es2015.collection.d.ts#L48https://github.com/microsoft/TypeScript/blob/70b7bd5a1b8c3bc1ba7c644b37412368607706e6/src/lib/es2015.collection.d.ts#L48
thishttps://gist.github.com/wincent/e40ff8cb25e939e719cd62047d130f32
thishttps://gist.github.com/wincent/b6f7c437101ea72022e82dfb58bc6be2
#618https://github.com/sourcegraph/javascript-typescript-langserver/issues/618
tsconfig.jsonhttps://github.com/wincent/corpus/blob/5adc1677dfe08eec18c9c1c43ee006892fa39aca/tsconfig.json
https://github.com/wincent
wincenthttps://github.com/wincent
on Jul 21, 2019https://github.com/sourcegraph/javascript-typescript-langserver/issues/621#issuecomment-513546112
https://github.com/wincent
wincenthttps://github.com/wincent
on Jul 21, 2019https://github.com/sourcegraph/javascript-typescript-langserver/issues/621#issuecomment-513546574
https://www.npmjs.com/package/typescript-language-serverhttps://github.com/sourcegraph/javascript-typescript-langserver/issues/typescript-language-server
wincenthttps://github.com/wincent
on Jul 21, 2019https://github.com/sourcegraph/javascript-typescript-langserver/issues/621#event-2498009114
fix(vim): switch from javascript-typescript-langserverhttps://github.com/wincent/wincent/commit/4a887fbb14820f8e6e604ed36200e8de25909f77
4a887fbhttps://github.com/wincent/wincent/commit/4a887fbb14820f8e6e604ed36200e8de25909f77
Sign up for freehttps://github.com/signup?return_to=https://github.com/sourcegraph/javascript-typescript-langserver/issues/621
Sign in to commenthttps://github.com/login?return_to=https://github.com/sourcegraph/javascript-typescript-langserver/issues/621
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.