| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1d8a60d7-12ff-ec4c-7f06-d8ca49f15d4e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC8C:DEE16:3DDD76:509E82:696ECDA5 |
| html-safe-nonce | face277eda95613e09ab0f6fa0576340217bb01492413abf576c3961a33748ce |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzhDOkRFRTE2OjNEREQ3Njo1MDlFODI6Njk2RUNEQTUiLCJ2aXNpdG9yX2lkIjoiNzk0NTU0MDUyNDEzMzI0MDIyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bcd907f3eac6b876826451a727cf4e65954c0fc3527d9914d3def1203023e09f |
| hovercard-subject-tag | pull_request:608423088 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/solvespace/solvespace/992/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e0b11713ab826e323b2c59ab1d6943edfce487e1005aed20a1e2d0c60892ab2b/solvespace/solvespace/pull/992 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e0b11713ab826e323b2c59ab1d6943edfce487e1005aed20a1e2d0c60892ab2b/solvespace/solvespace/pull/992 |
| og:image:alt | Should fix #939 and fix #932 almost entirely, shifting the bottleneck for large models. Passes tests and memcheck.
Properties of this changeset:
memory complexity of IdLists increases by n * sizeo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pjanx |
| hostname | github.com |
| expected-hostname | github.com |
| None | b278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee |
| turbo-cache-control | no-preview |
| go-import | github.com/solvespace/solvespace git https://github.com/solvespace/solvespace.git |
| octolytics-dimension-user_id | 18541596 |
| octolytics-dimension-user_login | solvespace |
| octolytics-dimension-repository_id | 32905910 |
| octolytics-dimension-repository_nwo | solvespace/solvespace |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 32905910 |
| octolytics-dimension-repository_network_root_nwo | solvespace/solvespace |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 39aed5006635ab6f45e6b77d23e73b08a00272a3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/solvespace/solvespace/pull/992#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolvespace%2Fsolvespace%2Fpull%2F992 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolvespace%2Fsolvespace%2Fpull%2F992 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=solvespace%2Fsolvespace |
| Reload | https://github.com/solvespace/solvespace/pull/992 |
| Reload | https://github.com/solvespace/solvespace/pull/992 |
| Reload | https://github.com/solvespace/solvespace/pull/992 |
|
solvespace
| https://github.com/solvespace |
| solvespace | https://github.com/solvespace/solvespace |
|
Notifications
| https://github.com/login?return_to=%2Fsolvespace%2Fsolvespace |
|
Fork
541
| https://github.com/login?return_to=%2Fsolvespace%2Fsolvespace |
|
Star
3.7k
| https://github.com/login?return_to=%2Fsolvespace%2Fsolvespace |
|
Code
| https://github.com/solvespace/solvespace |
|
Issues
262
| https://github.com/solvespace/solvespace/issues |
|
Pull requests
27
| https://github.com/solvespace/solvespace/pulls |
|
Actions
| https://github.com/solvespace/solvespace/actions |
|
Projects
0
| https://github.com/solvespace/solvespace/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/solvespace/solvespace/security |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
|
Insights
| https://github.com/solvespace/solvespace/pulse |
|
Code
| https://github.com/solvespace/solvespace |
|
Issues
| https://github.com/solvespace/solvespace/issues |
|
Pull requests
| https://github.com/solvespace/solvespace/pulls |
|
Actions
| https://github.com/solvespace/solvespace/actions |
|
Projects
| https://github.com/solvespace/solvespace/projects |
|
Security
| https://github.com/solvespace/solvespace/security |
|
Insights
| https://github.com/solvespace/solvespace/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fsolvespace%2Fsolvespace%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fsolvespace%2Fsolvespace%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/solvespace/solvespace/pull/992#issue-comment-box |
| pjanx | https://github.com/pjanx |
| solvespace:master | https://github.com/solvespace/solvespace/tree/master |
| pjanx:master | https://github.com/pjanx/solvespace/tree/master |
|
Eradicate the IdList bottleneck
| https://github.com/solvespace/solvespace/pull/992#top |
| pjanx | https://github.com/pjanx |
| solvespace:master | https://github.com/solvespace/solvespace/tree/master |
| pjanx:master | https://github.com/pjanx/solvespace/tree/master |
|
Conversation
43
| https://github.com/solvespace/solvespace/pull/992 |
|
Commits
6
| https://github.com/solvespace/solvespace/pull/992/commits |
|
Checks
0
| https://github.com/solvespace/solvespace/pull/992/checks |
|
Files changed
| https://github.com/solvespace/solvespace/pull/992/files |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.co/hiddenchars |
| https://github.com/solvespace/solvespace/pull/{{ revealButtonHref }} |
|
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
| Apr 3, 2021 | https://github.com/solvespace/solvespace/pull/992#issue-849711509 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| #939 | https://github.com/solvespace/solvespace/issues/939 |
| #932 | https://github.com/solvespace/solvespace/issues/932 |
| Evil-Spirit's change | https://github.com/Evil-Spirit/solvespace-master/commit/44eb1a4703a1be50d74fdfeacb97f89c06e08ab6 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
| Apr 3, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-812905923 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| this issue | https://github.com/tensorflow/tensorflow/issues/15925#issuecomment-356275963 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
| force-pushed | https://github.com/solvespace/solvespace/compare/539dfc92acc269c5750d8b24b66ce7e76cf25faf..bd1789b37d59e28ed28218ae68337ec70c96c203 |
| 539dfc9 | https://github.com/solvespace/solvespace/commit/539dfc92acc269c5750d8b24b66ce7e76cf25faf |
| bd1789b | https://github.com/solvespace/solvespace/commit/bd1789b37d59e28ed28218ae68337ec70c96c203 |
|
Compare
| https://github.com/solvespace/solvespace/compare/539dfc92acc269c5750d8b24b66ce7e76cf25faf..bd1789b37d59e28ed28218ae68337ec70c96c203 |
| April 3, 2021 18:35 | https://github.com/solvespace/solvespace/pull/992#event-4548366791 |
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
|
Apr 3, 2021
| https://github.com/solvespace/solvespace/pull/992#ref-issue-810126969 |
|
Poor Linking performance
#939
| https://github.com/solvespace/solvespace/issues/939 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
| Apr 3, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-812914964 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| pjanx | https://github.com/pjanx |
| April 4, 2021 02:38 | https://github.com/solvespace/solvespace/pull/992#commits-pushed-5f0d25c |
|
| https://github.com/pjanx |
| GTK: silence a compiler warning | https://github.com/solvespace/solvespace/pull/992/commits/5f0d25c89b6bd6f6cc8bc262016278fd32e00e2a |
| 5f0d25c | https://github.com/solvespace/solvespace/pull/992/commits/5f0d25c89b6bd6f6cc8bc262016278fd32e00e2a |
|
| https://github.com/pjanx |
| IdList speedup 1: maintain an array of indexes | https://github.com/solvespace/solvespace/pull/992/commits/e2fb1475204643ed4bdeb599ac08882bd481f094 |
| e2fb147 | https://github.com/solvespace/solvespace/pull/992/commits/e2fb1475204643ed4bdeb599ac08882bd481f094 |
|
| https://github.com/pjanx |
| IdList speedup 2: use iterators | https://github.com/solvespace/solvespace/pull/992/commits/0e3fba0dd27a1f7ef9823514fe4fb0bf525aad05 |
| 0e3fba0 | https://github.com/solvespace/solvespace/pull/992/commits/0e3fba0dd27a1f7ef9823514fe4fb0bf525aad05 |
|
| https://github.com/pjanx |
| IdList speedup 3: optimize allocations | https://github.com/solvespace/solvespace/pull/992/commits/a3d43592ae88d5562f92b1924e9f205c289db239 |
| a3d4359 | https://github.com/solvespace/solvespace/pull/992/commits/a3d43592ae88d5562f92b1924e9f205c289db239 |
|
| https://github.com/pjanx |
| IdList speedup 4: make RemoveTagged fast again | https://github.com/solvespace/solvespace/pull/992/commits/6c55182f1c4e685ec2096ffe0496cef7f9d18828 |
| 6c55182 | https://github.com/solvespace/solvespace/pull/992/commits/6c55182f1c4e685ec2096ffe0496cef7f9d18828 |
|
| https://github.com/pjanx |
| IdList speedup 5: use range for rather than NextAfter | https://github.com/solvespace/solvespace/pull/992/commits/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf |
| 3b395bb | https://github.com/solvespace/solvespace/pull/992/commits/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf |
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
| force-pushed | https://github.com/solvespace/solvespace/compare/bd1789b37d59e28ed28218ae68337ec70c96c203..3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf |
| bd1789b | https://github.com/solvespace/solvespace/commit/bd1789b37d59e28ed28218ae68337ec70c96c203 |
| 3b395bb | https://github.com/solvespace/solvespace/commit/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf |
|
Compare
| https://github.com/solvespace/solvespace/compare/bd1789b37d59e28ed28218ae68337ec70c96c203..3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf |
| April 4, 2021 01:16 | https://github.com/solvespace/solvespace/pull/992#event-4548630224 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813052642 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/ruevs/solvespace/tree/FixIdList_TheNextAttempt | https://github.com/ruevs/solvespace/tree/FixIdList_TheNextAttempt |
| 3b395bb | https://github.com/solvespace/solvespace/commit/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf |
| https://github.com/solvespace/solvespace/files/5962704/case-vents.slvs.gz | https://github.com/solvespace/solvespace/files/5962704/case-vents.slvs.gz |
| #932 (comment) | https://github.com/solvespace/solvespace/issues/932#issue-806016900 |
| https://github.com/solvespace/solvespace/files/5974674/LeliaManya2.zip | https://github.com/solvespace/solvespace/files/5974674/LeliaManya2.zip |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813057763 |
| @phkahler | https://github.com/phkahler |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/phkahler |
| phkahler | https://github.com/phkahler |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813067981 |
| @phkahler | https://github.com/phkahler |
| @pjanx | https://github.com/pjanx |
| #738 | https://github.com/solvespace/solvespace/issues/738 |
| @ruevs | https://github.com/ruevs |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813086278 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/phkahler |
| phkahler | https://github.com/phkahler |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813089867 |
| @pjanx | https://github.com/pjanx |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813092926 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813097645 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813100829 |
| @phkahler | https://github.com/phkahler |
| starting to work on the IdList | https://github.com/solvespace/solvespace/pull/973 |
| Whitequark commit and EvilSpirits patch | https://github.com/solvespace/solvespace/issues/939#issuecomment-810641820 |
| #738 | https://github.com/solvespace/solvespace/issues/738 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
|
Apr 4, 2021
| https://github.com/solvespace/solvespace/pull/992#ref-issue-728394417 |
|
3.0 Release prep
#772
| https://github.com/solvespace/solvespace/issues/772 |
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813106152 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813108474 |
| Whiteqark | https://github.com/solvespace/solvespace/graphs/contributors |
| @phkahler | https://github.com/phkahler |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
|
Apr 4, 2021
| https://github.com/solvespace/solvespace/pull/992#pullrequestreview-627577692 |
|
View reviewed changes
| https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf |
| ruevs | https://github.com/ruevs |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/solvespace/solvespace/pull/992#pullrequestreview-627577692 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| on my version | https://github.com/ruevs/solvespace/tree/FixIdList_TheNextAttempt |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| src/dsc.h | https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf#diff-1e7cff49b59940cd86245d5af7e87f1303216f9d6801534711ea15fa2c72ed47 |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606862853 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| On mine | https://github.com/ruevs/solvespace/blob/6bc1aa91c6a0f1acfc986b34ff54ed36efcdbfc1/src/dsc.h#L421 |
| local T *elem | https://github.com/ruevs/solvespace/blob/6bc1aa91c6a0f1acfc986b34ff54ed36efcdbfc1/src/dsc.h#L478 |
| when the iterator is changed | https://github.com/ruevs/solvespace/blob/6bc1aa91c6a0f1acfc986b34ff54ed36efcdbfc1/src/dsc.h#L445 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606866588 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| src/dsc.h | https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf#diff-1e7cff49b59940cd86245d5af7e87f1303216f9d6801534711ea15fa2c72ed47 |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606863375 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @phkahler | https://github.com/phkahler |
| @rpavlik | https://github.com/rpavlik |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606866892 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| rpavlik | https://github.com/rpavlik |
| Apr 5, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r607117256 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| ruevs | https://github.com/ruevs |
| Apr 7, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r608633111 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| src/dsc.h | https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf#diff-1e7cff49b59940cd86245d5af7e87f1303216f9d6801534711ea15fa2c72ed47 |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606863707 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| ruevs@6bc1aa9 | https://github.com/ruevs/solvespace/commit/6bc1aa91c6a0f1acfc986b34ff54ed36efcdbfc1 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606867020 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606869780 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| src/dsc.h | https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf#diff-1e7cff49b59940cd86245d5af7e87f1303216f9d6801534711ea15fa2c72ed47 |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606864324 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| iterators on the index | https://github.com/ruevs/solvespace/blob/6bc1aa91c6a0f1acfc986b34ff54ed36efcdbfc1/src/dsc.h#L510 |
| predicate | https://github.com/ruevs/solvespace/blob/6bc1aa91c6a0f1acfc986b34ff54ed36efcdbfc1/src/dsc.h#L386 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606867472 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| ruevs | https://github.com/ruevs |
| Apr 5, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606870005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| src/dsc.h | https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf#diff-1e7cff49b59940cd86245d5af7e87f1303216f9d6801534711ea15fa2c72ed47 |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606864598 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Using vector for the storage | https://github.com/ruevs/solvespace/blob/6bc1aa91c6a0f1acfc986b34ff54ed36efcdbfc1/src/dsc.h#L404 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606867950 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @Evil-Spirit | https://github.com/Evil-Spirit |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| rpavlik | https://github.com/rpavlik |
| Apr 5, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r607117955 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| ruevs | https://github.com/ruevs |
| Apr 7, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r608730312 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rpavlik | https://github.com/rpavlik |
| https://github.com/ruevs/solvespace/blob/3c6e2be4b920d706d8231030467c5271a6d87d85/src/dsc.h#L570 | https://github.com/ruevs/solvespace/blob/3c6e2be4b920d706d8231030467c5271a6d87d85/src/dsc.h#L570 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| src/dsc.h | https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf#diff-1e7cff49b59940cd86245d5af7e87f1303216f9d6801534711ea15fa2c72ed47 |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606864851 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| insert in a vector | https://github.com/ruevs/solvespace/blob/6bc1aa91c6a0f1acfc986b34ff54ed36efcdbfc1/src/dsc.h#L537 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606868136 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| src/dsc.h | https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf#diff-1e7cff49b59940cd86245d5af7e87f1303216f9d6801534711ea15fa2c72ed47 |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606865167 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606868747 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| src/dsc.h | https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf#diff-1e7cff49b59940cd86245d5af7e87f1303216f9d6801534711ea15fa2c72ed47 |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#discussion_r606865355 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813117074 |
| #120 | https://github.com/solvespace/solvespace/issues/120 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
| Apr 4, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813117905 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
|
Apr 5, 2021
| https://github.com/solvespace/solvespace/pull/992#ref-pullrequest-850476342 |
|
Optimize IdList by Using an Index and a Proper Iterator
#1002
| https://github.com/solvespace/solvespace/pull/1002 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
| Apr 5, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813482052 |
| @pjanx | https://github.com/pjanx |
| #1002 | https://github.com/solvespace/solvespace/pull/1002 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/pjanx |
| pjanx | https://github.com/pjanx |
| Apr 5, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-813576449 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
|
Port idlist
#429
| https://github.com/solvespace/solvespace/pull/429 |
|
WIP: Port both IdList and List to std::vector
#433
| https://github.com/solvespace/solvespace/pull/433 |
| https://github.com/Evil-Spirit |
| Evil-Spirit | https://github.com/Evil-Spirit |
| Apr 7, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-814839094 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/baryluk |
| baryluk | https://github.com/baryluk |
| Apr 18, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-821912111 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| #932 | https://github.com/solvespace/solvespace/issues/932 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
| Apr 20, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-823583628 |
| #932 | https://github.com/solvespace/solvespace/issues/932 |
| https://github.com/solvespace/solvespace/files/5974674/LeliaManya2.zip | https://github.com/solvespace/solvespace/files/5974674/LeliaManya2.zip |
| #841 (comment) | https://github.com/solvespace/solvespace/issues/841#issuecomment-742153838 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/phkahler |
| phkahler | https://github.com/phkahler |
| May 7, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-834467150 |
| #120 | https://github.com/solvespace/solvespace/issues/120 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/phkahler |
| phkahler | https://github.com/phkahler |
| May 12, 2021 | https://github.com/solvespace/solvespace/pull/992#issuecomment-840175552 |
| @ruevs | https://github.com/ruevs |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
| https://github.com/phkahler |
| phkahler | https://github.com/phkahler |
| May 12, 2021 | https://github.com/solvespace/solvespace/pull/992#event-4739242534 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
|
performance
| https://github.com/solvespace/solvespace/issues?q=state%3Aopen%20label%3Aperformance |
|
internals
| https://github.com/solvespace/solvespace/issues?q=state%3Aopen%20label%3Ainternals |
| Jan 4, 2022 | https://github.com/solvespace/solvespace/pull/992#event-5839988644 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
|
Jan 9, 2022
| https://github.com/solvespace/solvespace/pull/992#ref-issue-1097323711 |
|
Performance testing models (slow speed benchmarks)
#1186
| https://github.com/solvespace/solvespace/issues/1186 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
|
Feb 10, 2022
| https://github.com/solvespace/solvespace/pull/992#ref-issue-1126982438 |
|
Performance drop with a step and repeat rotating
#1214
| https://github.com/solvespace/solvespace/issues/1214 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
|
Jun 1, 2022
| https://github.com/solvespace/solvespace/pull/992#ref-pullrequest-1254744609 |
|
Use nullptr instead of NULL
#1250
| https://github.com/solvespace/solvespace/pull/1250 |
| https://github.com/ruevs |
| ruevs | https://github.com/ruevs |
|
Feb 26, 2025
| https://github.com/solvespace/solvespace/pull/992#ref-pullrequest-2878454637 |
|
Minor refactoring of surface curve data into its own struct
#1536
| https://github.com/solvespace/solvespace/pull/1536 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolvespace%2Fsolvespace%2Fpull%2F992 |
|
| https://github.com/rpavlik |
|
rpavlik
| https://github.com/rpavlik |
|
| https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf |
|
| https://github.com/ruevs |
|
ruevs
| https://github.com/ruevs |
|
| https://github.com/solvespace/solvespace/pull/992/files/3b395bb5a7cc09023c9cb0c9d14ea63a5f5e07bf |
|
internals
| https://github.com/solvespace/solvespace/issues?q=state%3Aopen%20label%3Ainternals |
|
performance
| https://github.com/solvespace/solvespace/issues?q=state%3Aopen%20label%3Aperformance |
|
Poor Linking performance
| https://github.com/solvespace/solvespace/issues/939 |
|
Poor performance when extruding translate groups
| https://github.com/solvespace/solvespace/issues/932 |
| Please reload this page | https://github.com/solvespace/solvespace/pull/992 |
|
| https://github.com/pjanx |
|
| https://github.com/ruevs |
|
| https://github.com/phkahler |
|
| https://github.com/Evil-Spirit |
|
| https://github.com/baryluk |
|
| https://github.com/rpavlik |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |