René's URL Explorer Experiment


Title: Issues #92, #148: refactor to use common code between two rules by tozpeak · Pull Request #221 · solid-software/solid_lints · GitHub

Open Graph Title: Issues #92, #148: refactor to use common code between two rules by tozpeak · Pull Request #221 · solid-software/solid_lints

X Title: Issues #92, #148: refactor to use common code between two rules by tozpeak · Pull Request #221 · solid-software/solid_lints

Description: 🟧 Lints for Dart and Flutter based on software industry standards and best practices. - Issues #92, #148: refactor to use common code between two rules by tozpeak · Pull Request #221 · solid-software/solid_lints

Open Graph Description: I added a Visitor, that collects all SimpleIdentifiers from Expression instead of _isExpressionImmutable recursive method. This should work with wider range of Expressions as well. I worry a bit, t...

X Description: I added a Visitor, that collects all SimpleIdentifiers from Expression instead of _isExpressionImmutable recursive method. This should work with wider range of Expressions as well. I worry a bit, t...

Opengraph URL: https://github.com/solid-software/solid_lints/pull/221

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:08393338-caf7-e509-bc65-ba59112cf649
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92EE:49C83:E7708:12FA0E:6A52E29E
html-safe-nonce5ae4cc81af15f45f96480270f099e8666543493df148f903da616c0d2b4f15ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkVFOjQ5QzgzOkU3NzA4OjEyRkEwRTo2QTUyRTI5RSIsInZpc2l0b3JfaWQiOiIxMjczNTQ1MDEwMDYzNzk0ODQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac86649c0ef04c56df4c6339ef7bcf257a569d0a3678c01243b8527c2e39b1430d
hovercard-subject-tagpull_request:2881939611
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/solid-software/solid_lints/221/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c5a14a4af13d64cc831d9f4f1d325d89e0708a70f8a8993a9a806a25f6c0c144/solid-software/solid_lints/pull/221
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c5a14a4af13d64cc831d9f4f1d325d89e0708a70f8a8993a9a806a25f6c0c144/solid-software/solid_lints/pull/221
og:image:altI added a Visitor, that collects all SimpleIdentifiers from Expression instead of _isExpressionImmutable recursive method. This should work with wider range of Expressions as well. I worry a bit, t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametozpeak
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/solid-software/solid_lints git https://github.com/solid-software/solid_lints.git
octolytics-dimension-user_id40825054
octolytics-dimension-user_loginsolid-software
octolytics-dimension-repository_id438779269
octolytics-dimension-repository_nwosolid-software/solid_lints
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id438779269
octolytics-dimension-repository_network_root_nwosolid-software/solid_lints
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/solid-software/solid_lints/pull/221#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolid-software%2Fsolid_lints%2Fpull%2F221
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolid-software%2Fsolid_lints%2Fpull%2F221
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=solid-software%2Fsolid_lints
Reloadhttps://github.com/solid-software/solid_lints/pull/221
Reloadhttps://github.com/solid-software/solid_lints/pull/221
Reloadhttps://github.com/solid-software/solid_lints/pull/221
Please reload this pagehttps://github.com/solid-software/solid_lints/pull/221
solid-software https://github.com/solid-software
solid_lintshttps://github.com/solid-software/solid_lints
Notifications https://github.com/login?return_to=%2Fsolid-software%2Fsolid_lints
Fork 24 https://github.com/login?return_to=%2Fsolid-software%2Fsolid_lints
Star 41 https://github.com/login?return_to=%2Fsolid-software%2Fsolid_lints
Code https://github.com/solid-software/solid_lints
Issues 25 https://github.com/solid-software/solid_lints/issues
Pull requests 4 https://github.com/solid-software/solid_lints/pulls
Actions https://github.com/solid-software/solid_lints/actions
Projects https://github.com/solid-software/solid_lints/projects
Security and quality 0 https://github.com/solid-software/solid_lints/security
Insights https://github.com/solid-software/solid_lints/pulse
Code https://github.com/solid-software/solid_lints
Issues https://github.com/solid-software/solid_lints/issues
Pull requests https://github.com/solid-software/solid_lints/pulls
Actions https://github.com/solid-software/solid_lints/actions
Projects https://github.com/solid-software/solid_lints/projects
Security and quality https://github.com/solid-software/solid_lints/security
Insights https://github.com/solid-software/solid_lints/pulse
solid-dmytrotkachukhttps://github.com/solid-dmytrotkachuk
masterhttps://github.com/solid-software/solid_lints/tree/master
issues-92-148-common-code-refactorhttps://github.com/solid-software/solid_lints/tree/issues-92-148-common-code-refactor
Conversationhttps://github.com/solid-software/solid_lints/pull/221
Commits4 (4)https://github.com/solid-software/solid_lints/pull/221/commits
Checkshttps://github.com/solid-software/solid_lints/pull/221/checks
Files changedhttps://github.com/solid-software/solid_lints/pull/221/files
Issues #92, #148: refactor to use common code between two ruleshttps://github.com/solid-software/solid_lints/pull/221#top
solid-dmytrotkachukhttps://github.com/solid-dmytrotkachuk
masterhttps://github.com/solid-software/solid_lints/tree/master
issues-92-148-common-code-refactorhttps://github.com/solid-software/solid_lints/tree/issues-92-148-common-code-refactor
https://github.com/tozpeak
tozpeakhttps://github.com/tozpeak
Oct 2, 2025https://github.com/solid-software/solid_lints/pull/221#issue-3477688517
Please reload this pagehttps://github.com/solid-software/solid_lints/pull/221
https://github.com/tozpeak
Issueshttps://github.com/solid-software/solid_lints/pull/221/commits/c1a4de892dde98d207fd890b2a57e499653274d7
#92https://github.com/solid-software/solid_lints/issues/92
,https://github.com/solid-software/solid_lints/pull/221/commits/c1a4de892dde98d207fd890b2a57e499653274d7
#148https://github.com/solid-software/solid_lints/issues/148
: refactor to use common code between two ruleshttps://github.com/solid-software/solid_lints/pull/221/commits/c1a4de892dde98d207fd890b2a57e499653274d7
c1a4de8https://github.com/solid-software/solid_lints/pull/221/commits/c1a4de892dde98d207fd890b2a57e499653274d7
https://github.com/tozpeak
tozpeakhttps://github.com/tozpeak
solid-dmytrotkachukhttps://github.com/solid-dmytrotkachuk
October 2, 2025 14:11https://github.com/solid-software/solid_lints/pull/221#event-20060895676
https://github.com/tozpeak
tozpeakhttps://github.com/tozpeak
Oct 2, 2025https://github.com/solid-software/solid_lints/pull/221#event-20060895770
https://github.com/apps/gemini-code-assist
gemini-code-assisthttps://github.com/apps/gemini-code-assist
Oct 2, 2025https://github.com/solid-software/solid_lints/pull/221#issuecomment-3361401511
@tozpeakhttps://github.com/tozpeak
1https://github.com/solid-software/solid_lints/pull/221#user-content-fn-1-f11e85f605138fc72a9b8795d58c52c1
#92https://github.com/solid-software/solid_lints/issues/92
#148https://github.com/solid-software/solid_lints/issues/148
documentation pagehttps://developers.google.com/gemini-code-assist/docs/review-github-code
@gemini-code-assisthttps://github.com/gemini-code-assist
herehttps://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github
@gemini-code-assisthttps://github.com/gemini-code-assist
herehttps://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG
Gemini Code Assist IDE Extensionhttps://cloud.google.com/products/gemini/code-assist
Privacy Noticeshttps://policies.google.com/privacy
Generative AI Prohibited Use Policyhttps://policies.google.com/terms/generative-ai/use-policy
Terms of Servicehttps://policies.google.com/terms
herehttps://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github
use code with cautionhttps://support.google.com/legal/answer/13505487
↩https://github.com/solid-software/solid_lints/pull/221#user-content-fnref-1-f11e85f605138fc72a9b8795d58c52c1
Please reload this pagehttps://github.com/solid-software/solid_lints/pull/221
https://github.com/apps/gemini-code-assist
gemini-code-assisthttps://github.com/apps/gemini-code-assist
Oct 2, 2025 https://github.com/solid-software/solid_lints/pull/221#pullrequestreview-3294856017
View reviewed changes https://github.com/solid-software/solid_lints/pull/221/files/c1a4de892dde98d207fd890b2a57e499653274d7
gemini-code-assisthttps://github.com/apps/gemini-code-assist
https://github.com/solid-software/solid_lints/pull/221#pullrequestreview-3294856017
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/solid-software/solid_lints/pull/221
lib/src/common/visitors/select_expression_identifiers_visitor.darthttps://github.com/solid-software/solid_lints/pull/221/files/c1a4de892dde98d207fd890b2a57e499653274d7#diff-fb2b54b85f6c6e42f3cb5f6cb6c499d039095963024b34978aaa53345a73a00c
Please reload this pagehttps://github.com/solid-software/solid_lints/pull/221
lib/src/common/visitors/select_expression_identifiers_visitor.darthttps://github.com/solid-software/solid_lints/pull/221/files/c1a4de892dde98d207fd890b2a57e499653274d7#diff-fb2b54b85f6c6e42f3cb5f6cb6c499d039095963024b34978aaa53345a73a00c
Please reload this pagehttps://github.com/solid-software/solid_lints/pull/221
tozpeakhttps://github.com/tozpeak
October 2, 2025 17:14https://github.com/solid-software/solid_lints/pull/221#commits-pushed-d1dee6f
https://github.com/tozpeak
Issueshttps://github.com/solid-software/solid_lints/pull/221/commits/d1dee6fc8cc7813dfeb957526bf10fe4a7cecfa2
#92https://github.com/solid-software/solid_lints/issues/92
,https://github.com/solid-software/solid_lints/pull/221/commits/d1dee6fc8cc7813dfeb957526bf10fe4a7cecfa2
#148https://github.com/solid-software/solid_lints/issues/148
: fixed code formattinghttps://github.com/solid-software/solid_lints/pull/221/commits/d1dee6fc8cc7813dfeb957526bf10fe4a7cecfa2
d1dee6fhttps://github.com/solid-software/solid_lints/pull/221/commits/d1dee6fc8cc7813dfeb957526bf10fe4a7cecfa2
https://github.com/tozpeak
Issueshttps://github.com/solid-software/solid_lints/pull/221/commits/2fd08cd17d62463b1a29bf55b3f733154a413298
#92https://github.com/solid-software/solid_lints/issues/92
,https://github.com/solid-software/solid_lints/pull/221/commits/2fd08cd17d62463b1a29bf55b3f733154a413298
#148https://github.com/solid-software/solid_lints/issues/148
: simplified to use expr.accept(visitor)https://github.com/solid-software/solid_lints/pull/221/commits/2fd08cd17d62463b1a29bf55b3f733154a413298
2fd08cdhttps://github.com/solid-software/solid_lints/pull/221/commits/2fd08cd17d62463b1a29bf55b3f733154a413298
https://github.com/tozpeak
Issueshttps://github.com/solid-software/solid_lints/pull/221/commits/38d6a03f3ac9e75f2c0c32f8cef61e10244ffa99
#92https://github.com/solid-software/solid_lints/issues/92
,https://github.com/solid-software/solid_lints/pull/221/commits/38d6a03f3ac9e75f2c0c32f8cef61e10244ffa99
#148https://github.com/solid-software/solid_lints/issues/148
: removed unnecessary super callhttps://github.com/solid-software/solid_lints/pull/221/commits/38d6a03f3ac9e75f2c0c32f8cef61e10244ffa99
38d6a03https://github.com/solid-software/solid_lints/pull/221/commits/38d6a03f3ac9e75f2c0c32f8cef61e10244ffa99
https://github.com/solid-dmytrotkachuk
solid-dmytrotkachukhttps://github.com/solid-dmytrotkachuk
Oct 2, 2025 https://github.com/solid-software/solid_lints/pull/221#pullrequestreview-3295137304
View reviewed changes https://github.com/solid-software/solid_lints/pull/221/files/38d6a03f3ac9e75f2c0c32f8cef61e10244ffa99
solid-dmytrotkachukhttps://github.com/solid-dmytrotkachuk
https://github.com/solid-software/solid_lints/pull/221#pullrequestreview-3295137304
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@tozpeakhttps://github.com/tozpeak
Please reload this pagehttps://github.com/solid-software/solid_lints/pull/221
https://github.com/solid-dmytrotkachuk
solid-dmytrotkachukhttps://github.com/solid-dmytrotkachuk
7a96dd6https://github.com/solid-software/solid_lints/commit/7a96dd6ba4a60ffddbe45d6a22d3c32760efa6e0
Oct 2, 2025https://github.com/solid-software/solid_lints/pull/221#event-20062328575
Please reload this pagehttps://github.com/solid-software/solid_lints/pull/221
https://github.com/solid-dmytrotkachuk
solid-dmytrotkachukhttps://github.com/solid-dmytrotkachuk
October 2, 2025 15:14https://github.com/solid-software/solid_lints/pull/221#event-20062329184
https://github.co/hiddenchars
https://github.com/solid-software/solid_lints/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolid-software%2Fsolid_lints%2Fpull%2F221
https://github.com/solid-dmytrotkachuk
solid-dmytrotkachuk https://github.com/solid-dmytrotkachuk
https://github.com/solid-software/solid_lints/pull/221/files/38d6a03f3ac9e75f2c0c32f8cef61e10244ffa99
https://github.com/apps/gemini-code-assist
gemini-code-assist[bot] https://github.com/apps/gemini-code-assist
https://github.com/solid-software/solid_lints/pull/221/files/c1a4de892dde98d207fd890b2a57e499653274d7
https://github.com/tozpeak
tozpeak https://github.com/tozpeak
Please reload this pagehttps://github.com/solid-software/solid_lints/pull/221
https://github.com/tozpeak
https://github.com/solid-dmytrotkachuk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.