René's URL Explorer Experiment


Title: Fixing concurrency and thread issues in engine.io by afkelsall · Pull Request #18 · socketio/engine.io-server-java · GitHub

Open Graph Title: Fixing concurrency and thread issues in engine.io by afkelsall · Pull Request #18 · socketio/engine.io-server-java

X Title: Fixing concurrency and thread issues in engine.io by afkelsall · Pull Request #18 · socketio/engine.io-server-java

Description: Engine.IO Server Library for Java. Contribute to socketio/engine.io-server-java development by creating an account on GitHub.

Open Graph Description: Hi, I spent a few weeks investigating and load testing the engine.io-java server for a project. During this time I found and fixed several issues to do with concurrency, race conditions and the Tim...

X Description: Hi, I spent a few weeks investigating and load testing the engine.io-java server for a project. During this time I found and fixed several issues to do with concurrency, race conditions and the Tim...

Opengraph URL: https://github.com/socketio/engine.io-server-java/pull/18

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:568cca16-0bd2-d474-31d6-b8c012a41b58
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD484:218868:E6F743:137699F:6A4D82B4
html-safe-noncec492c4c909b6794fc24046f3669b4f34105a80c59784cef7261bcbe01fec8901
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDg0OjIxODg2ODpFNkY3NDM6MTM3Njk5Rjo2QTREODJCNCIsInZpc2l0b3JfaWQiOiI1OTgxMTEyNzIwMjIwMzI0NTMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7631b3349c356877983bf96aec270e51d494403b5a8ec26449d9a4df4ddf8d14
hovercard-subject-tagpull_request:346510454
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/socketio/engine.io-server-java/18/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b88aaa8da6748d8d3854129048ac42294f6c879ce39b36dfeeb5de747c62e090/socketio/engine.io-server-java/pull/18
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b88aaa8da6748d8d3854129048ac42294f6c879ce39b36dfeeb5de747c62e090/socketio/engine.io-server-java/pull/18
og:image:altHi, I spent a few weeks investigating and load testing the engine.io-java server for a project. During this time I found and fixed several issues to do with concurrency, race conditions and the Tim...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameafkelsall
hostnamegithub.com
expected-hostnamegithub.com
Nonec6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae
turbo-cache-controlno-cache
go-importgithub.com/socketio/engine.io-server-java git https://github.com/socketio/engine.io-server-java.git
octolytics-dimension-user_id10566080
octolytics-dimension-user_loginsocketio
octolytics-dimension-repository_id141633330
octolytics-dimension-repository_nwosocketio/engine.io-server-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id141633330
octolytics-dimension-repository_network_root_nwosocketio/engine.io-server-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6702a58b419a792226bd21ef0fb1bcb318bbcaa3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/socketio/engine.io-server-java/pull/18#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsocketio%2Fengine.io-server-java%2Fpull%2F18
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsocketio%2Fengine.io-server-java%2Fpull%2F18
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=socketio%2Fengine.io-server-java
Reloadhttps://github.com/socketio/engine.io-server-java/pull/18
Reloadhttps://github.com/socketio/engine.io-server-java/pull/18
Reloadhttps://github.com/socketio/engine.io-server-java/pull/18
Please reload this pagehttps://github.com/socketio/engine.io-server-java/pull/18
socketio https://github.com/socketio
engine.io-server-javahttps://github.com/socketio/engine.io-server-java
Notifications https://github.com/login?return_to=%2Fsocketio%2Fengine.io-server-java
Fork 50 https://github.com/login?return_to=%2Fsocketio%2Fengine.io-server-java
Star 172 https://github.com/login?return_to=%2Fsocketio%2Fengine.io-server-java
Code https://github.com/socketio/engine.io-server-java
Issues 7 https://github.com/socketio/engine.io-server-java/issues
Pull requests 6 https://github.com/socketio/engine.io-server-java/pulls
Actions https://github.com/socketio/engine.io-server-java/actions
Projects https://github.com/socketio/engine.io-server-java/projects
Wiki https://github.com/socketio/engine.io-server-java/wiki
Security and quality 0 https://github.com/socketio/engine.io-server-java/security
Insights https://github.com/socketio/engine.io-server-java/pulse
Code https://github.com/socketio/engine.io-server-java
Issues https://github.com/socketio/engine.io-server-java/issues
Pull requests https://github.com/socketio/engine.io-server-java/pulls
Actions https://github.com/socketio/engine.io-server-java/actions
Projects https://github.com/socketio/engine.io-server-java/projects
Wiki https://github.com/socketio/engine.io-server-java/wiki
Security and quality https://github.com/socketio/engine.io-server-java/security
Insights https://github.com/socketio/engine.io-server-java/pulse
trinopotyhttps://github.com/trinopoty
socketio:masterhttps://github.com/socketio/engine.io-server-java/tree/master
afkelsall:masterhttps://github.com/afkelsall/engine.io-server-java/tree/master
Conversationhttps://github.com/socketio/engine.io-server-java/pull/18
Commits5 (5)https://github.com/socketio/engine.io-server-java/pull/18/commits
Checkshttps://github.com/socketio/engine.io-server-java/pull/18/checks
Files changedhttps://github.com/socketio/engine.io-server-java/pull/18/files
Fixing concurrency and thread issues in engine.iohttps://github.com/socketio/engine.io-server-java/pull/18#top
trinopotyhttps://github.com/trinopoty
socketio:masterhttps://github.com/socketio/engine.io-server-java/tree/master
afkelsall:masterhttps://github.com/afkelsall/engine.io-server-java/tree/master
https://github.com/afkelsall
afkelsallhttps://github.com/afkelsall
Nov 28, 2019https://github.com/socketio/engine.io-server-java/pull/18#issue-529679681
Please reload this pagehttps://github.com/socketio/engine.io-server-java/pull/18
afkelsallhttps://github.com/afkelsall
November 27, 2019 23:08https://github.com/socketio/engine.io-server-java/pull/18#commits-pushed-7b7c356
https://github.com/afkelsall
Fixed issue where the client would occasionally timeout before the se…https://github.com/socketio/engine.io-server-java/pull/18/commits/7b7c3564b9220a87ce668e88382d0326ff645c42
7b7c356https://github.com/socketio/engine.io-server-java/pull/18/commits/7b7c3564b9220a87ce668e88382d0326ff645c42
https://github.com/afkelsall
Fixed concurrency issue accessing the mClients TreeMap which isn't th…https://github.com/socketio/engine.io-server-java/pull/18/commits/6854b21d01d494c80eb35ff3593c7be3239eadc9
6854b21https://github.com/socketio/engine.io-server-java/pull/18/commits/6854b21d01d494c80eb35ff3593c7be3239eadc9
https://github.com/afkelsall
Fixed issue when upgrading from long polling to websocket where the c…https://github.com/socketio/engine.io-server-java/pull/18/commits/6ae0c6eaba91e9bc6f6cbce1de68c8efc5361795
6ae0c6ehttps://github.com/socketio/engine.io-server-java/pull/18/commits/6ae0c6eaba91e9bc6f6cbce1de68c8efc5361795
https://github.com/afkelsall
Fixed issue where the server would create a new Timer thread for ever…https://github.com/socketio/engine.io-server-java/pull/18/commits/19e58e100d674a4228dc1d27bf3b7b259e5e27b2
19e58e1https://github.com/socketio/engine.io-server-java/pull/18/commits/19e58e100d674a4228dc1d27bf3b7b259e5e27b2
https://github.com/codecov-io
codecov-iohttps://github.com/codecov-io
Nov 28, 2019https://github.com/socketio/engine.io-server-java/pull/18#issuecomment-559332865
Codecovhttps://codecov.io/gh/socketio/engine.io-server-java/pull/18?src=pr&el=h1
#18https://codecov.io/gh/socketio/engine.io-server-java/pull/18?src=pr&el=desc
masterhttps://codecov.io/gh/socketio/engine.io-server-java/commit/3f4e62c7d3662d9273fe41e0fb3563b1b211f475?src=pr&el=desc
Please reload this pagehttps://github.com/socketio/engine.io-server-java/pull/18
https://github.com/trinopoty
trinopotyhttps://github.com/trinopoty
Nov 28, 2019 https://github.com/socketio/engine.io-server-java/pull/18#pullrequestreview-324140253
View reviewed changes https://github.com/socketio/engine.io-server-java/pull/18/files/19e58e100d674a4228dc1d27bf3b7b259e5e27b2
engine.io-server/src/main/java/io/socket/engineio/server/EngineIoServer.javahttps://github.com/socketio/engine.io-server-java/pull/18/files/19e58e100d674a4228dc1d27bf3b7b259e5e27b2#diff-ff50f8ec4ef6797560990bf09779d7850de43d510387dd4ae542f07ef9f24272
Please reload this pagehttps://github.com/socketio/engine.io-server-java/pull/18
engine.io-server/src/main/java/io/socket/engineio/server/EngineIoSocket.javahttps://github.com/socketio/engine.io-server-java/pull/18/files/19e58e100d674a4228dc1d27bf3b7b259e5e27b2#diff-c83c78e7b6bccdf4ca5d7e732454932de2e6c8f026a2a37789161cae6ae6f6e1
Please reload this pagehttps://github.com/socketio/engine.io-server-java/pull/18
engine.io-server/src/main/java/io/socket/engineio/server/EngineIoSocket.javahttps://github.com/socketio/engine.io-server-java/pull/18/files/19e58e100d674a4228dc1d27bf3b7b259e5e27b2#diff-c83c78e7b6bccdf4ca5d7e732454932de2e6c8f026a2a37789161cae6ae6f6e1
Please reload this pagehttps://github.com/socketio/engine.io-server-java/pull/18
https://github.com/afkelsall
Addressing PR comments:https://github.com/socketio/engine.io-server-java/pull/18/commits/1582754285cc3d2393247639adb1cda21d86d32d
1582754https://github.com/socketio/engine.io-server-java/pull/18/commits/1582754285cc3d2393247639adb1cda21d86d32d
https://github.com/trinopoty
trinopotyhttps://github.com/trinopoty
Dec 2, 2019 https://github.com/socketio/engine.io-server-java/pull/18#pullrequestreview-325075467
View reviewed changes https://github.com/socketio/engine.io-server-java/pull/18/files/1582754285cc3d2393247639adb1cda21d86d32d
trinopotyhttps://github.com/trinopoty
https://github.com/socketio/engine.io-server-java/pull/18#pullrequestreview-325075467
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/socketio/engine.io-server-java/pull/18
https://github.com/trinopoty
trinopotyhttps://github.com/trinopoty
bdf69ffhttps://github.com/socketio/engine.io-server-java/commit/bdf69ff357392ca91f8ff2ebe94bce6a45282737
Dec 2, 2019https://github.com/socketio/engine.io-server-java/pull/18#event-2844711268
https://github.co/hiddenchars
https://github.com/socketio/engine.io-server-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsocketio%2Fengine.io-server-java%2Fpull%2F18
https://github.com/trinopoty
trinopoty https://github.com/trinopoty
https://github.com/socketio/engine.io-server-java/pull/18/files/1582754285cc3d2393247639adb1cda21d86d32d
Please reload this pagehttps://github.com/socketio/engine.io-server-java/pull/18
https://github.com/afkelsall
https://github.com/codecov-io
https://github.com/trinopoty
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.