René's URL Explorer Experiment


Title: Blamed location is wrong when return type annotation is violated #15 by CodeSteak · Pull Request #29 · skogsbaer/write-your-python-program · GitHub

Open Graph Title: Blamed location is wrong when return type annotation is violated #15 by CodeSteak · Pull Request #29 · skogsbaer/write-your-python-program

X Title: Blamed location is wrong when return type annotation is violated #15 by CodeSteak · Pull Request #29 · skogsbaer/write-your-python-program

Description: Contribute to skogsbaer/write-your-python-program development by creating an account on GitHub.

Open Graph Description: closes #15 Extra function calls are inserted in the AST. If a "return"-location is searched, and the last return was triggered inside of the function that causes the violation, the locati...

X Description: closes #15 Extra function calls are inserted in the AST. If a "return"-location is searched, and the last return was triggered inside of the function that causes the violation, th...

Opengraph URL: https://github.com/skogsbaer/write-your-python-program/pull/29

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dd804897-a2fd-4034-08db-a5535d58065a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id860E:26ECEB:529623:6C5470:6B00CB54
html-safe-nonceb719dcfa54a7742406ac49f74d956d6be029900e9dfbb36915493909e8b2610c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjBFOjI2RUNFQjo1Mjk2MjM6NkM1NDcwOjZCMDBDQjU0IiwidmlzaXRvcl9pZCI6IjE5MjY5OTg0MTU1NzM1NjgzNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1c8b18acdf47ebd966280d3365fcaec844acce1e8526d4796122fa7e787a15ad
hovercard-subject-tagpull_request:746188373
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/skogsbaer/write-your-python-program/29/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b7ef6d5bac453785aa70b22972317cc1f0028875c34b17ecb3b9f81330b56a28/skogsbaer/write-your-python-program/pull/29
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b7ef6d5bac453785aa70b22972317cc1f0028875c34b17ecb3b9f81330b56a28/skogsbaer/write-your-python-program/pull/29
og:image:altcloses #15 Extra function calls are inserted in the AST. If a "return"-location is searched, and the last return was triggered inside of the function that causes the violation, the locati...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCodeSteak
hostnamegithub.com
expected-hostnamegithub.com
None98dc00e171c204462a6f367482a0f8c3c6b5dbca99cd7390e82d2df49ce096e4
turbo-cache-controlno-cache
go-importgithub.com/skogsbaer/write-your-python-program git https://github.com/skogsbaer/write-your-python-program.git
octolytics-dimension-user_id567524
octolytics-dimension-user_loginskogsbaer
octolytics-dimension-repository_id295649345
octolytics-dimension-repository_nwoskogsbaer/write-your-python-program
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id295649345
octolytics-dimension-repository_network_root_nwoskogsbaer/write-your-python-program
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseef013399cf0a3c324bea644a685d7c1e0f06b5b7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/skogsbaer/write-your-python-program/pull/29#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fskogsbaer%2Fwrite-your-python-program%2Fpull%2F29
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fskogsbaer%2Fwrite-your-python-program%2Fpull%2F29
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=skogsbaer%2Fwrite-your-python-program
Reloadhttps://github.com/skogsbaer/write-your-python-program/pull/29
Reloadhttps://github.com/skogsbaer/write-your-python-program/pull/29
Reloadhttps://github.com/skogsbaer/write-your-python-program/pull/29
skogsbaerhttps://github.com/skogsbaer
write-your-python-programhttps://github.com/skogsbaer/write-your-python-program
Codehttps://github.com/skogsbaer/write-your-python-program
Issues9 (9)https://github.com/skogsbaer/write-your-python-program/issues
Pull requestshttps://github.com/skogsbaer/write-your-python-program/pulls
Actionshttps://github.com/skogsbaer/write-your-python-program/actions
Projectshttps://github.com/skogsbaer/write-your-python-program/projects
Security and qualityhttps://github.com/skogsbaer/write-your-python-program/security
Insightshttps://github.com/skogsbaer/write-your-python-program/pulse
https://github.com/skogsbaer/write-your-python-program
skogsbaerhttps://github.com/skogsbaer
masterhttps://github.com/skogsbaer/write-your-python-program/tree/master
feature/15-locate-returnhttps://github.com/skogsbaer/write-your-python-program/tree/feature/15-locate-return
Conversationhttps://github.com/skogsbaer/write-your-python-program/pull/29
Commits21 (21)https://github.com/skogsbaer/write-your-python-program/pull/29/commits
Checkshttps://github.com/skogsbaer/write-your-python-program/pull/29/checks
Files changedhttps://github.com/skogsbaer/write-your-python-program/pull/29/files
Blamed location is wrong when return type annotation is violated #15https://github.com/skogsbaer/write-your-python-program/pull/29#top
skogsbaerhttps://github.com/skogsbaer
masterhttps://github.com/skogsbaer/write-your-python-program/tree/master
feature/15-locate-returnhttps://github.com/skogsbaer/write-your-python-program/tree/feature/15-locate-return
https://github.com/CodeSteak
CodeSteakhttps://github.com/CodeSteak
Sep 29, 2021https://github.com/skogsbaer/write-your-python-program/pull/29#issue-1011507453
#15https://github.com/skogsbaer/write-your-python-program/issues/15
Please reload this pagehttps://github.com/skogsbaer/write-your-python-program/pull/29
September 29, 2021 17:47https://github.com/skogsbaer/write-your-python-program/pull/29#commits-pushed-1954798
implement ast-transformer for return locationhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/1954798a6e982e00c4dc990c96a33db01bb1a99c
1954798https://github.com/skogsbaer/write-your-python-program/pull/29/commits/1954798a6e982e00c4dc990c96a33db01bb1a99c
implement ast-transformer for return location IIhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/cc6d50b4fe27b527c12315413af7904fc2090461
cc6d50bhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/cc6d50b4fe27b527c12315413af7904fc2090461
refactor Locationhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/24e9dd6b045da458ab03d36f7c60a1e159eaa7aa
24e9dd6https://github.com/skogsbaer/write-your-python-program/pull/29/commits/24e9dd6b045da458ab03d36f7c60a1e159eaa7aa
refactor Location IIhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/c917fcb577e6d88c6d35a74500383da2b67be80f
c917fcbhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/c917fcb577e6d88c6d35a74500383da2b67be80f
add return traces to import hookhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/0774f6ca603d55a5c8612931400735499f7dad18
0774f6chttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/0774f6ca603d55a5c8612931400735499f7dad18
update runner for new tranform_treehttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/502fc2017a316d834c99d5421f0126e54919dc77
502fc20https://github.com/skogsbaer/write-your-python-program/pull/29/commits/502fc2017a316d834c99d5421f0126e54919dc77
add unit test for return traces ast transformerhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/f39871b4981c17196bb3256ac5af4ba461f55a6d
f39871bhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/f39871b4981c17196bb3256ac5af4ba461f55a6d
unit test ReturnTraceManagerhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/fb599d56b43c4b0aac9af6bab60ef416f4af3e81
fb599d5https://github.com/skogsbaer/write-your-python-program/pull/29/commits/fb599d56b43c4b0aac9af6bab60ef416f4af3e81
fixhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/ef9829c9ac017183b955ab092779989d58da03e1
#26https://github.com/skogsbaer/write-your-python-program/issues/26
use abspath on runner.https://github.com/skogsbaer/write-your-python-program/pull/29/commits/ef9829c9ac017183b955ab092779989d58da03e1
ef9829chttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/ef9829c9ac017183b955ab092779989d58da03e1
#15https://github.com/skogsbaer/write-your-python-program/issues/15
add rudimentary documentationhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/3371ca99f3eb90a4351774b491f6a5bdbee88a0d
3371ca9https://github.com/skogsbaer/write-your-python-program/pull/29/commits/3371ca99f3eb90a4351774b491f6a5bdbee88a0d
Revert "https://github.com/skogsbaer/write-your-python-program/pull/29/commits/1b472b9009d1d9c704ad93f7ec760dd89f818bd7
fixhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/1b472b9009d1d9c704ad93f7ec760dd89f818bd7
#26https://github.com/skogsbaer/write-your-python-program/issues/26
use abspath on runner." - Unittest issueshttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/1b472b9009d1d9c704ad93f7ec760dd89f818bd7
1b472b9https://github.com/skogsbaer/write-your-python-program/pull/29/commits/1b472b9009d1d9c704ad93f7ec760dd89f818bd7
ef9829chttps://github.com/skogsbaer/write-your-python-program/commit/ef9829c9ac017183b955ab092779989d58da03e1
fix "just_transform" in REPLhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/622bb4a4a74bb199dd16dec8ee6dd0474fb721b8
622bb4ahttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/622bb4a4a74bb199dd16dec8ee6dd0474fb721b8
adjust error messages to new location outputhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/dc859b725869e5226dcf82cbbef7bdc780f271bb
dc859b7https://github.com/skogsbaer/write-your-python-program/pull/29/commits/dc859b725869e5226dcf82cbbef7bdc780f271bb
fix REPL IIhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/970fb8db1b33ae87d2b565fbc84883476590981d
970fb8dhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/970fb8db1b33ae87d2b565fbc84883476590981d
fix integration test for new location formathttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/a9be28866cb8613d9ad9ed32328ab1c0ac29b35f
a9be288https://github.com/skogsbaer/write-your-python-program/pull/29/commits/a9be28866cb8613d9ad9ed32328ab1c0ac29b35f
add missing argument in "enable_on_imports"https://github.com/skogsbaer/write-your-python-program/pull/29/commits/94d4e17ce06661647bf226300c8b0de85b4bb493
94d4e17https://github.com/skogsbaer/write-your-python-program/pull/29/commits/94d4e17ce06661647bf226300c8b0de85b4bb493
add test forhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/cf7e403b64133f0b71f8fe921de619ffdea67a18
#15https://github.com/skogsbaer/write-your-python-program/issues/15
cf7e403https://github.com/skogsbaer/write-your-python-program/pull/29/commits/cf7e403b64133f0b71f8fe921de619ffdea67a18
use abspath - needed matching of return traceshttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/6e2c1a56cf73d401bb110e2c94bba08a92ead496
6e2c1a5https://github.com/skogsbaer/write-your-python-program/pull/29/commits/6e2c1a56cf73d401bb110e2c94bba08a92ead496
dont use abspath - breaks return traceshttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/0fa302d5fd59118a6f0a5903454370463a633dc8
0fa302dhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/0fa302d5fd59118a6f0a5903454370463a633dc8
Merge branch 'master' into feature/15-locate-returnhttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/35fc723af8ce43ddb761236e2b089b9708b1b7b4
35fc723https://github.com/skogsbaer/write-your-python-program/pull/29/commits/35fc723af8ce43ddb761236e2b089b9708b1b7b4
fix testForwardRef*-Test after mergehttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/439b76eff84270658c928f784fd49fcc302eeb3a
439b76ehttps://github.com/skogsbaer/write-your-python-program/pull/29/commits/439b76eff84270658c928f784fd49fcc302eeb3a
https://github.com/skogsbaer
skogsbaerhttps://github.com/skogsbaer
Sep 30, 2021 https://github.com/skogsbaer/write-your-python-program/pull/29#pullrequestreview-767656874
View reviewed changes https://github.com/skogsbaer/write-your-python-program/pull/29/files/439b76eff84270658c928f784fd49fcc302eeb3a
skogsbaerhttps://github.com/skogsbaer
https://github.com/skogsbaer/write-your-python-program/pull/29#pullrequestreview-767656874
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/skogsbaer/write-your-python-program/pull/29
https://github.com/skogsbaer
skogsbaerhttps://github.com/skogsbaer
24d7f9ahttps://github.com/skogsbaer/write-your-python-program/commit/24d7f9a43f2b834daab4350534b21c3a88b141d8
Sep 30, 2021https://github.com/skogsbaer/write-your-python-program/pull/29#event-5386535395
https://github.com/CodeSteak
CodeSteakhttps://github.com/CodeSteak
October 24, 2021 14:29https://github.com/skogsbaer/write-your-python-program/pull/29#event-5509600369
https://github.co/hiddenchars
https://github.com/skogsbaer/write-your-python-program/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fskogsbaer%2Fwrite-your-python-program%2Fpull%2F29
https://github.com/skogsbaer
skogsbaer https://github.com/skogsbaer
https://github.com/skogsbaer/write-your-python-program/pull/29/files/439b76eff84270658c928f784fd49fcc302eeb3a
Please reload this pagehttps://github.com/skogsbaer/write-your-python-program/pull/29
Blamed location is wrong when return type annotation is violated https://github.com/skogsbaer/write-your-python-program/issues/15
Please reload this pagehttps://github.com/skogsbaer/write-your-python-program/pull/29
https://github.com/CodeSteak
https://github.com/skogsbaer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.