René's URL Explorer Experiment


Title: fix(credentials): replay remembered refusals as credential errors, derive the delegable Google services list, and correct a fallback TSDoc by waleedlatif1 · Pull Request #9993 · simstudioai/sim · GitHub

Open Graph Title: fix(credentials): replay remembered refusals as credential errors, derive the delegable Google services list, and correct a fallback TSDoc by waleedlatif1 · Pull Request #9993 · simstudioai/sim

X Title: fix(credentials): replay remembered refusals as credential errors, derive the delegable Google services list, and correct a fallback TSDoc by waleedlatif1 · Pull Request #9993 · simstudioai/sim

Description: Summary Follow-ups from the final review of the v0.9.56 credential changes: Remembered refusals are no longer reported as outages. The shared client-credentials failure memo can only store a few codes, so a refusal such as host_not_allowed or consent_required is stored as provider_unavailable. #9977 gave the first caller the real code, but every replay within the window still returned provider_unavailable, which maps to a 502 "temporarily unavailable". That told users to wait instead of fixing the credential. replayedFailure now relabels a remembered refusal (isRememberedRefusal) to invalid_credentials with its stored status, which maps to "reconnect the credential". No new stored codes, so older builds still decode every memo. Throttled and 5xx memos still replay as provider_unavailable. The per-instance mint cache also now treats the replay as permanent rather than transient. Delegable Google services come from one list. GOOGLE_DELEGATION_SERVICE_NAMES moves next to GOOGLE_DELEGATION_SERVICES and is used by the keyless refusal messages and the connect dialog, so the wording can't drift from the list. The text is unchanged. TSDoc fix. The credentials TSDoc in model-fallback-request.ts now says it is resolved once per call and shared by same-provider fallbacks. Type of Change Bug fix Testing Integration (coordinated-client-token.integration.ts): run against a throwaway local Postgres, 56 tests with vanta-token.integration.ts. A replayed consent_required refusal comes back as invalid_credentials / 400, and the exchange runs once. This fails on the previous code. The previous build's lossy refusal row now replays as a credential error. Throttled replays still return provider_unavailable. This fails if the relabel is broadened to every 4xx. Unit: 2,357 tests across lib/credentials, lib/oauth, executor/utils and the connect dialog pass. Lint and audits: bun run lint, check:client-boundary, check:boundaries, check:comment-hygiene, check:test-patterns, check:explicit-any, check:test-types and check:tool-registry-boundary --check pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-ups from the final review of the v0.9.56 credential changes: Remembered refusals are no longer reported as outages. The shared client-credentials failure memo can only store a few c...

X Description: Summary Follow-ups from the final review of the v0.9.56 credential changes: Remembered refusals are no longer reported as outages. The shared client-credentials failure memo can only store a few c...

Opengraph URL: https://github.com/simstudioai/sim/pull/9993

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d1b4e8a1-3ca1-00f8-7e52-abd2bea104cf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB846:1BC3DC:8AED13:C4946F:6AFB5090
html-safe-nonce1f1c2d16444fc14f25a28c33a3a17311dfba8638a56f8d1fb547f82e6edfb32c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODQ2OjFCQzNEQzo4QUVEMTM6QzQ5NDZGOjZBRkI1MDkwIiwidmlzaXRvcl9pZCI6IjQyMjM2ODkxMjg2NTIwMDE0MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacea97cbfe3e6939a7a57e2472a254a90abb8e0f872d457540a5934cd4fd5f4702
hovercard-subject-tagpull_request:5291363694
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9993/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-ups from the final review of the v0.9.56 credential changes: Remembered refusals are no longer reported as outages. The shared client-credentials failure memo can only store a few c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9993/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9993%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9993%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9993/files
Reloadhttps://github.com/simstudioai/sim/pull/9993/files
Reloadhttps://github.com/simstudioai/sim/pull/9993/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/credential-final-nitshttps://github.com/simstudioai/sim/tree/fix/credential-final-nits
Conversation 2 https://github.com/simstudioai/sim/pull/9993
Commits 1 https://github.com/simstudioai/sim/pull/9993/commits
Checks 80 https://github.com/simstudioai/sim/pull/9993/checks
Files changed https://github.com/simstudioai/sim/pull/9993/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9993/files
fix(credentials): replay remembered refusals as credential errors, derive the delegable Google services list, and correct a fallback TSDoc https://github.com/simstudioai/sim/pull/9993/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9993/files
70fb3f0 fix(credentials): replay remembered refusals as credential errors, de… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/9993/commits/70fb3f09505300824684dcc7e8059f7d6365eb0e
Clear filters https://github.com/simstudioai/sim/pull/9993/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9993/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9993/files
connect-service-account-modal.tsx https://github.com/simstudioai/sim/pull/9993/files#diff-673f1feeec21be0a8cbb89338feb58cac97495b307d17c2335a1f527df8d1b6a
google-keyless-fields.tsx https://github.com/simstudioai/sim/pull/9993/files#diff-57de838469dc58bb948484bf9df5395d824b5a291a7123d4d5786ca3e20877dc
model-fallback-request.ts https://github.com/simstudioai/sim/pull/9993/files#diff-94acf70316b671249e4e80a608aac7b1fb998aee3b0f8f826d15e6da064f6328
coordinated-client-token.integration.ts https://github.com/simstudioai/sim/pull/9993/files#diff-2af104082d15264eed76d52fd63e803089377c5f5309e4a4237d8b964a338471
coordinated-client-token.ts https://github.com/simstudioai/sim/pull/9993/files#diff-7504aee2b0c99d6687ebffec45d2421071ff5811735b70ac354c624c3321b8b8
google-workload-identity.server.ts https://github.com/simstudioai/sim/pull/9993/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
google-workload-identity.ts https://github.com/simstudioai/sim/pull/9993/files#diff-16a06d2b2f146f3f83ed025318ff49356c15b13eb665deb1842280efd8564712
...]/integrations/components/connect-service-account-modal/connect-service-account-modal.tsxhttps://github.com/simstudioai/sim/pull/9993/files#diff-673f1feeec21be0a8cbb89338feb58cac97495b307d17c2335a1f527df8d1b6a
View file https://github.com/simstudioai/sim/blob/70fb3f09505300824684dcc7e8059f7d6365eb0e/apps/sim/app/workspace/%5BworkspaceId%5D/integrations/components/connect-service-account-modal/connect-service-account-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9993/files#diff-673f1feeec21be0a8cbb89338feb58cac97495b307d17c2335a1f527df8d1b6a
https://github.com/simstudioai/sim/pull/9993/files#diff-673f1feeec21be0a8cbb89338feb58cac97495b307d17c2335a1f527df8d1b6a
https://github.com/simstudioai/sim/pull/9993/files#diff-673f1feeec21be0a8cbb89338feb58cac97495b307d17c2335a1f527df8d1b6a
https://github.com/simstudioai/sim/pull/9993/files#diff-673f1feeec21be0a8cbb89338feb58cac97495b307d17c2335a1f527df8d1b6a
...kspaceId]/integrations/components/connect-service-account-modal/google-keyless-fields.tsxhttps://github.com/simstudioai/sim/pull/9993/files#diff-57de838469dc58bb948484bf9df5395d824b5a291a7123d4d5786ca3e20877dc
View file https://github.com/simstudioai/sim/blob/70fb3f09505300824684dcc7e8059f7d6365eb0e/apps/sim/app/workspace/%5BworkspaceId%5D/integrations/components/connect-service-account-modal/google-keyless-fields.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9993/files#diff-57de838469dc58bb948484bf9df5395d824b5a291a7123d4d5786ca3e20877dc
https://github.com/simstudioai/sim/pull/9993/files#diff-57de838469dc58bb948484bf9df5395d824b5a291a7123d4d5786ca3e20877dc
apps/sim/executor/utils/model-fallback-request.tshttps://github.com/simstudioai/sim/pull/9993/files#diff-94acf70316b671249e4e80a608aac7b1fb998aee3b0f8f826d15e6da064f6328
View file https://github.com/simstudioai/sim/blob/70fb3f09505300824684dcc7e8059f7d6365eb0e/apps/sim/executor/utils/model-fallback-request.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9993/files#diff-94acf70316b671249e4e80a608aac7b1fb998aee3b0f8f826d15e6da064f6328
https://github.com/simstudioai/sim/pull/9993/files#diff-94acf70316b671249e4e80a608aac7b1fb998aee3b0f8f826d15e6da064f6328
apps/sim/lib/credentials/coordinated-client-token.integration.tshttps://github.com/simstudioai/sim/pull/9993/files#diff-2af104082d15264eed76d52fd63e803089377c5f5309e4a4237d8b964a338471
View file https://github.com/simstudioai/sim/blob/70fb3f09505300824684dcc7e8059f7d6365eb0e/apps/sim/lib/credentials/coordinated-client-token.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9993/files#diff-2af104082d15264eed76d52fd63e803089377c5f5309e4a4237d8b964a338471
https://github.com/simstudioai/sim/pull/9993/files#diff-2af104082d15264eed76d52fd63e803089377c5f5309e4a4237d8b964a338471
https://github.com/simstudioai/sim/pull/9993/files#diff-2af104082d15264eed76d52fd63e803089377c5f5309e4a4237d8b964a338471
https://github.com/simstudioai/sim/pull/9993/files#diff-2af104082d15264eed76d52fd63e803089377c5f5309e4a4237d8b964a338471
https://github.com/simstudioai/sim/pull/9993/files#diff-2af104082d15264eed76d52fd63e803089377c5f5309e4a4237d8b964a338471
https://github.com/simstudioai/sim/pull/9993/files#diff-2af104082d15264eed76d52fd63e803089377c5f5309e4a4237d8b964a338471
apps/sim/lib/credentials/coordinated-client-token.tshttps://github.com/simstudioai/sim/pull/9993/files#diff-7504aee2b0c99d6687ebffec45d2421071ff5811735b70ac354c624c3321b8b8
View file https://github.com/simstudioai/sim/blob/70fb3f09505300824684dcc7e8059f7d6365eb0e/apps/sim/lib/credentials/coordinated-client-token.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9993/files#diff-7504aee2b0c99d6687ebffec45d2421071ff5811735b70ac354c624c3321b8b8
https://github.com/simstudioai/sim/pull/9993/files#diff-7504aee2b0c99d6687ebffec45d2421071ff5811735b70ac354c624c3321b8b8
apps/sim/lib/credentials/google-workload-identity.server.tshttps://github.com/simstudioai/sim/pull/9993/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
View file https://github.com/simstudioai/sim/blob/70fb3f09505300824684dcc7e8059f7d6365eb0e/apps/sim/lib/credentials/google-workload-identity.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9993/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
https://github.com/simstudioai/sim/pull/9993/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
https://github.com/simstudioai/sim/pull/9993/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
https://github.com/simstudioai/sim/pull/9993/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
apps/sim/lib/credentials/google-workload-identity.tshttps://github.com/simstudioai/sim/pull/9993/files#diff-16a06d2b2f146f3f83ed025318ff49356c15b13eb665deb1842280efd8564712
View file https://github.com/simstudioai/sim/blob/70fb3f09505300824684dcc7e8059f7d6365eb0e/apps/sim/lib/credentials/google-workload-identity.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9993/files#diff-16a06d2b2f146f3f83ed025318ff49356c15b13eb665deb1842280efd8564712
https://github.com/simstudioai/sim/pull/9993/files#diff-16a06d2b2f146f3f83ed025318ff49356c15b13eb665deb1842280efd8564712
https://github.com/simstudioai/sim/pull/9993/files#diff-16a06d2b2f146f3f83ed025318ff49356c15b13eb665deb1842280efd8564712
Please reload this pagehttps://github.com/simstudioai/sim/pull/9993/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.