Title: fix(credentials): offer keyless Google delegation only for services that can be delegated by waleedlatif1 · Pull Request #9992 · simstudioai/sim · GitHub
Open Graph Title: fix(credentials): offer keyless Google delegation only for services that can be delegated by waleedlatif1 · Pull Request #9992 · simstudioai/sim
X Title: fix(credentials): offer keyless Google delegation only for services that can be delegated by waleedlatif1 · Pull Request #9992 · simstudioai/sim
Description: Summary The problem: when a keyless Google credential was refused, the advice said "reconnect the credential to delegate this service" even for Google services that can never be delegated. Those are Google Ads, Forms, Contacts, Tasks, Vault, Groups and Meet, plus impersonation on BigQuery/Vertex. These services list keyless credentials in their pickers, but the connect dialog only offers delegation for Gmail, Drive, Docs, Sheets and Calendar, so following the advice could never work. The fix: both refusals (impersonation without delegation, and a service keyless doesn't serve) now branch on whether the service can be delegated, using the same googleDelegationServiceFor check the function already uses for delegation. Delegable services keep the reconnect advice and their steps (google_keyless_delegation, google_keyless_service). Every other service is pointed to a JSON key credential, under new steps google_keyless_delegation_unavailable and google_keyless_service_unsupported. Unchanged: the order of the checks, and refusing before Google is contacted. Type of Change Bug fix Testing google-workload-identity.server.test.ts: delegable services, including a service named by its OAuth provider id, keep the reconnect steps. Ads, BigQuery/Vertex impersonation and an unknown service get the non-delegable steps. The four non-delegable cases fail on the previous code. 769 tests across lib/credentials (Google), lib/oauth and lib/credentials/application pass. bun run lint, check:test-patterns, check:comment-hygiene, check:explicit-any, check:boundaries and check:test-types pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary The problem: when a keyless Google credential was refused, the advice said "reconnect the credential to delegate this service" even for Google services that can never be delegate...
X Description: Summary The problem: when a keyless Google credential was refused, the advice said "reconnect the credential to delegate this service" even for Google services that can never be ...
Opengraph URL: https://github.com/simstudioai/sim/pull/9992
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4b9ad93c-c925-28fc-55d2-4ee83e605198 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ADDC:A5723:8CC410:C78F35:6AFB506F |
| html-safe-nonce | b8e3a39018f872a16c72cfd546c827be5230fd2caa4ddd7f919fe439b4a12ad5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRERDOkE1NzIzOjhDQzQxMDpDNzhGMzU6NkFGQjUwNkYiLCJ2aXNpdG9yX2lkIjoiNzAwNzMwNzk1MDU5NDkzNjk0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3a6d9580af5b82b136fe73718a44154fd587263a6002aedd0ef66c33954c2954 |
| hovercard-subject-tag | pull_request:5290938502 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9992/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary The problem: when a keyless Google credential was refused, the advice said "reconnect the credential to delegate this service" even for Google services that can never be delegate... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width