René's URL Explorer Experiment


Title: fix(credentials): offer keyless Google delegation only for services that can be delegated by waleedlatif1 · Pull Request #9992 · simstudioai/sim · GitHub

Open Graph Title: fix(credentials): offer keyless Google delegation only for services that can be delegated by waleedlatif1 · Pull Request #9992 · simstudioai/sim

X Title: fix(credentials): offer keyless Google delegation only for services that can be delegated by waleedlatif1 · Pull Request #9992 · simstudioai/sim

Description: Summary The problem: when a keyless Google credential was refused, the advice said "reconnect the credential to delegate this service" even for Google services that can never be delegated. Those are Google Ads, Forms, Contacts, Tasks, Vault, Groups and Meet, plus impersonation on BigQuery/Vertex. These services list keyless credentials in their pickers, but the connect dialog only offers delegation for Gmail, Drive, Docs, Sheets and Calendar, so following the advice could never work. The fix: both refusals (impersonation without delegation, and a service keyless doesn't serve) now branch on whether the service can be delegated, using the same googleDelegationServiceFor check the function already uses for delegation. Delegable services keep the reconnect advice and their steps (google_keyless_delegation, google_keyless_service). Every other service is pointed to a JSON key credential, under new steps google_keyless_delegation_unavailable and google_keyless_service_unsupported. Unchanged: the order of the checks, and refusing before Google is contacted. Type of Change Bug fix Testing google-workload-identity.server.test.ts: delegable services, including a service named by its OAuth provider id, keep the reconnect steps. Ads, BigQuery/Vertex impersonation and an unknown service get the non-delegable steps. The four non-delegable cases fail on the previous code. 769 tests across lib/credentials (Google), lib/oauth and lib/credentials/application pass. bun run lint, check:test-patterns, check:comment-hygiene, check:explicit-any, check:boundaries and check:test-types pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The problem: when a keyless Google credential was refused, the advice said "reconnect the credential to delegate this service" even for Google services that can never be delegate...

X Description: Summary The problem: when a keyless Google credential was refused, the advice said "reconnect the credential to delegate this service" even for Google services that can never be ...

Opengraph URL: https://github.com/simstudioai/sim/pull/9992

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4b9ad93c-c925-28fc-55d2-4ee83e605198
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADDC:A5723:8CC410:C78F35:6AFB506F
html-safe-nonceb8e3a39018f872a16c72cfd546c827be5230fd2caa4ddd7f919fe439b4a12ad5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRERDOkE1NzIzOjhDQzQxMDpDNzhGMzU6NkFGQjUwNkYiLCJ2aXNpdG9yX2lkIjoiNzAwNzMwNzk1MDU5NDkzNjk0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3a6d9580af5b82b136fe73718a44154fd587263a6002aedd0ef66c33954c2954
hovercard-subject-tagpull_request:5290938502
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9992/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The problem: when a keyless Google credential was refused, the advice said "reconnect the credential to delegate this service" even for Google services that can never be delegate...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9992/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9992%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9992%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9992/files
Reloadhttps://github.com/simstudioai/sim/pull/9992/files
Reloadhttps://github.com/simstudioai/sim/pull/9992/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/google-keyless-nondelegable-copyhttps://github.com/simstudioai/sim/tree/fix/google-keyless-nondelegable-copy
Conversation 8 https://github.com/simstudioai/sim/pull/9992
Commits 2 https://github.com/simstudioai/sim/pull/9992/commits
Checks 80 https://github.com/simstudioai/sim/pull/9992/checks
Files changed https://github.com/simstudioai/sim/pull/9992/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9992/files
fix(credentials): offer keyless Google delegation only for services that can be delegated https://github.com/simstudioai/sim/pull/9992/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9992/files
2c60aa2 fix(credentials): offer keyless Google delegation only for services t… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/9992/commits/2c60aa238c8bd8c559fcc0801ebfaf403953cd49
96868f8 fix(credentials): send unsupported Google services straight to the JS… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/9992/commits/96868f83a7c857cf60f920ee61ba382b1bf0d0b8
Clear filters https://github.com/simstudioai/sim/pull/9992/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9992/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9992/files
google-workload-identity.server.test.ts https://github.com/simstudioai/sim/pull/9992/files#diff-66b809e0216090980f854c874e0f08d0bf61d2d8dd398be25e1a9f75ea14b05c
google-workload-identity.server.ts https://github.com/simstudioai/sim/pull/9992/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
apps/sim/lib/credentials/google-workload-identity.server.test.tshttps://github.com/simstudioai/sim/pull/9992/files#diff-66b809e0216090980f854c874e0f08d0bf61d2d8dd398be25e1a9f75ea14b05c
View file https://github.com/simstudioai/sim/blob/96868f83a7c857cf60f920ee61ba382b1bf0d0b8/apps/sim/lib/credentials/google-workload-identity.server.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9992/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9992/files#diff-66b809e0216090980f854c874e0f08d0bf61d2d8dd398be25e1a9f75ea14b05c
https://github.com/simstudioai/sim/pull/9992/files#diff-66b809e0216090980f854c874e0f08d0bf61d2d8dd398be25e1a9f75ea14b05c
apps/sim/lib/credentials/google-workload-identity.server.tshttps://github.com/simstudioai/sim/pull/9992/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
View file https://github.com/simstudioai/sim/blob/96868f83a7c857cf60f920ee61ba382b1bf0d0b8/apps/sim/lib/credentials/google-workload-identity.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9992/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9992/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
https://github.com/simstudioai/sim/pull/9992/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
https://github.com/simstudioai/sim/pull/9992/files#diff-3d68c41b635133041dcfe20e956a895720f67db9ac7a20722a5356a85d823b08
Please reload this pagehttps://github.com/simstudioai/sim/pull/9992/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.