René's URL Explorer Experiment


Title: improvement(executor): run the Agent block on the shared model-fallback walk by waleedlatif1 · Pull Request #9982 · simstudioai/sim · GitHub

Open Graph Title: improvement(executor): run the Agent block on the shared model-fallback walk by waleedlatif1 · Pull Request #9982 · simstudioai/sim

X Title: improvement(executor): run the Agent block on the shared model-fallback walk by waleedlatif1 · Pull Request #9982 · simstudioai/sim

Description: Summary One shared fallback walk. Router, Evaluator and the Agent block now walk their model candidates through walkModelCandidates in executor/utils/model-fallbacks.ts. Before, the Agent kept its own copy of the walk. The walk owns: the candidate order; holding fallbacks until the final try; de-duplication; skipping unusable fallbacks (provider, permission, family); resolving the saved credential once per call for candidates on the primary's provider; the stop rules; the block-log modelFallbacks record. Callers supply three pieces: an attempt, an optional prepare (a fallback that throws there is skipped, not counted as a failure), and skip/fallback log callbacks. executeModelRequestWithFallbacks is now a thin wrapper. The Agent keeps its own behavior in its callbacks: Per-provider file hydration moves into prepare, which runs against the settled registries without mutating ctx. A fallback whose provider can't take the attached files is skipped. Stream priming, the deep-research hold, the evaluation-model refusal and the log text are unchanged. The manual save/restore of the error registries is gone. A fallback swaps ctx to the settled registries once, when its attempt starts. No behavior change for any of the three blocks. Type of Change Improvement (refactor) Testing The existing agent, router, evaluator and model-fallback-request tests pass unchanged; they serve as the behavior spec. New tests: A primary failure followed by an attachment-skipped fallback rethrows the primary's error, redacted against the failed attempt's registries. A later fallback runs from the settled registries. The walk doesn't count a prepare skip as a failure, and rethrows the last real error when only skips remain. Red proofs: Removing the registry swap or the skip semantics fails the new tests. The new Agent tests also pass against the previous Agent loop, which shows behavior is preserved. Runs: 1,894 executor and lib/workflows/blocks tests pass. bun run lint, check-block-registry.ts origin/staging, check:test-patterns, check:comment-hygiene, check:explicit-any, check:boundaries, check:utils, check:file-names and check:tool-registry-boundary --check pass. Type-check and the full suite run in CI. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary One shared fallback walk. Router, Evaluator and the Agent block now walk their model candidates through walkModelCandidates in executor/utils/model-fallbacks.ts. Before, the Agent kept its...

X Description: Summary One shared fallback walk. Router, Evaluator and the Agent block now walk their model candidates through walkModelCandidates in executor/utils/model-fallbacks.ts. Before, the Agent kept its...

Opengraph URL: https://github.com/simstudioai/sim/pull/9982

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7911ff4f-c96a-8c09-133b-734feb14a2c1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE880:3ED756:172AD4:204AAA:6AFB4E14
html-safe-nonce04bd04b28bb34211afb31dcaaa5839720c0099e4f09d75daa358c1f20db31fae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODgwOjNFRDc1NjoxNzJBRDQ6MjA0QUFBOjZBRkI0RTE0IiwidmlzaXRvcl9pZCI6IjIxNTA0NjMyNzkwNjE0ODcxMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6c416b8b77a126053288dd0a925c87744114b51e2d14feaac9db7ccae68da146
hovercard-subject-tagpull_request:5290172082
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9982/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary One shared fallback walk. Router, Evaluator and the Agent block now walk their model candidates through walkModelCandidates in executor/utils/model-fallbacks.ts. Before, the Agent kept its...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9982/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9982%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9982%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9982/files
Reloadhttps://github.com/simstudioai/sim/pull/9982/files
Reloadhttps://github.com/simstudioai/sim/pull/9982/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/agent-shared-fallback-loophttps://github.com/simstudioai/sim/tree/improvement/agent-shared-fallback-loop
Conversation 5 https://github.com/simstudioai/sim/pull/9982
Commits 2 https://github.com/simstudioai/sim/pull/9982/commits
Checks 83 https://github.com/simstudioai/sim/pull/9982/checks
Files changed https://github.com/simstudioai/sim/pull/9982/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9982/files
improvement(executor): run the Agent block on the shared model-fallback walk https://github.com/simstudioai/sim/pull/9982/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9982/files
6bdb85f improvement(executor): run the Agent block on the shared model-fallba… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/9982/commits/6bdb85faa39ba85a4451c0db0d05e4c62c1e0b59
57c67da fix(executor): type the agent test block log so the ratchet shrinks waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/9982/commits/57c67dadbdc2c08c32544c474fee80d7b27bed9a
Clear filters https://github.com/simstudioai/sim/pull/9982/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9982/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9982/files
handler.test.ts https://github.com/simstudioai/sim/pull/9982/files#diff-c31b847684cc5c1c0372c46df8a21d4bd1baa2ab192074fe7e65425bea420feb
handler.ts https://github.com/simstudioai/sim/pull/9982/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
model-fallback-request.ts https://github.com/simstudioai/sim/pull/9982/files#diff-94acf70316b671249e4e80a608aac7b1fb998aee3b0f8f826d15e6da064f6328
model-fallbacks.test.ts https://github.com/simstudioai/sim/pull/9982/files#diff-f0142f41277a40ad262a28f06f6c8640565298a225826c064cd21d57556876f4
model-fallbacks.ts https://github.com/simstudioai/sim/pull/9982/files#diff-71ae2b1afcbaefebd0c800bab2bf364d38530d4e1881f65985842ab6435a366c
check-test-types.baseline.json https://github.com/simstudioai/sim/pull/9982/files#diff-3f0e52298332b82e821be5c9210ddb89bb43ab248c2db79c27e6a783dbfe9e36
apps/sim/executor/handlers/agent/handler.test.tshttps://github.com/simstudioai/sim/pull/9982/files#diff-c31b847684cc5c1c0372c46df8a21d4bd1baa2ab192074fe7e65425bea420feb
View file https://github.com/simstudioai/sim/blob/57c67dadbdc2c08c32544c474fee80d7b27bed9a/apps/sim/executor/handlers/agent/handler.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9982/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9982/files#diff-c31b847684cc5c1c0372c46df8a21d4bd1baa2ab192074fe7e65425bea420feb
https://github.com/simstudioai/sim/pull/9982/files#diff-c31b847684cc5c1c0372c46df8a21d4bd1baa2ab192074fe7e65425bea420feb
https://github.com/simstudioai/sim/pull/9982/files#diff-c31b847684cc5c1c0372c46df8a21d4bd1baa2ab192074fe7e65425bea420feb
https://github.com/simstudioai/sim/pull/9982/files#diff-c31b847684cc5c1c0372c46df8a21d4bd1baa2ab192074fe7e65425bea420feb
https://github.com/simstudioai/sim/pull/9982/files#diff-c31b847684cc5c1c0372c46df8a21d4bd1baa2ab192074fe7e65425bea420feb
https://github.com/simstudioai/sim/pull/9982/files#diff-c31b847684cc5c1c0372c46df8a21d4bd1baa2ab192074fe7e65425bea420feb
Please reload this pagehttps://github.com/simstudioai/sim/pull/9982/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9982/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.