René's URL Explorer Experiment


Title: fix(executor): resolve saved model credentials inside each fallback attempt in Router and Evaluator by waleedlatif1 · Pull Request #9968 · simstudioai/sim · GitHub

Open Graph Title: fix(executor): resolve saved model credentials inside each fallback attempt in Router and Evaluator by waleedlatif1 · Pull Request #9968 · simstudioai/sim

X Title: fix(executor): resolve saved model credentials inside each fallback attempt in Router and Evaluator by waleedlatif1 · Pull Request #9968 · simstudioai/sim

Description: Summary Router (v1 and v2) and Evaluator now resolve saved credentials inside each model attempt. Before, they resolved the saved Vertex or Bedrock credential before their fallback loop, so a credential that couldn't be resolved failed the block before any configured fallback model ran. This covers revoked or unauthorized credentials and a transient AWS STS failure. The Agent block already resolves credentials per attempt. New shared helper, resolveBlockModelCredentials in executor/utils/model-credentials.ts, used by Agent, Router and Evaluator. It replaces three inline copies of the Vertex lookup and the Bedrock-only helper. Fallback behavior in executeModelRequestWithFallbacks: The credential is resolved once per call, only for candidates on the primary's provider, and merged after the fallback API-key choice. A same-provider fallback row never carries its own key, so its key and token are unchanged. A failed resolution fails the remaining same-provider candidates without calling again, then the loop moves to other providers. Other-provider candidates still get no session and no family credentials. Agent's cross-provider omit now uses the shared BLOCK_MODEL_CREDENTIAL_FIELDS list. Docs fix: the v2 knowledge connector credentialId description no longer says it is null for every API-key source. A saved-credential apiKey source sets it. Type of Change Bug fix Testing New tests: Router and Evaluator answer from a cross-provider fallback when the saved AWS credential is unavailable on the final try, and record the primary as failed. A same-provider fallback reuses the resolved session without resolving again. A failed resolution is not retried on the next same-provider candidate, and no session reaches the other provider. Red proofs: The handler tests fail on the old handlers. The reuse test fails without the cache. The failed-resolution test fails when only successful results are cached. Existing tests: the existing Bedrock signing, blank-credential, fail-closed and fallback-omit tests are unchanged and pass. Runs: 1,693 executor and LLM tests pass. So do bun run lint and check-block-registry.ts origin/staging. Audits: check:openapi, check:cli-api, check:cli-docs, check:mcp-operations, check:api-validation:strict, check:test-patterns, check:comment-hygiene, check:explicit-any, check:client-boundary, check:boundaries, check:utils, check:file-names, check:docs and check:tool-registry-boundary pass. Type-check and the full suite run in CI. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Router (v1 and v2) and Evaluator now resolve saved credentials inside each model attempt. Before, they resolved the saved Vertex or Bedrock credential before their fallback loop, so a cred...

X Description: Summary Router (v1 and v2) and Evaluator now resolve saved credentials inside each model attempt. Before, they resolved the saved Vertex or Bedrock credential before their fallback loop, so a cred...

Opengraph URL: https://github.com/simstudioai/sim/pull/9968

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5911331a-721d-61bb-71e4-298d5a372b72
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BF8:3ED756:F8D6C:15AF40:6AFB4BF5
html-safe-nonce02aa3f0384d2ba355a8f8214a0b3e0064276227025490c2b66fbd16bb743c0b0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkY4OjNFRDc1NjpGOEQ2QzoxNUFGNDA6NkFGQjRCRjUiLCJ2aXNpdG9yX2lkIjoiMjkzNjg1NjQxNDk3NjE2NjkwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacec34093b463041a7256f15cb51f58b1fb98e7bb94d2da9a50477b94199b63acd
hovercard-subject-tagpull_request:5287964225
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9968/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Router (v1 and v2) and Evaluator now resolve saved credentials inside each model attempt. Before, they resolved the saved Vertex or Bedrock credential before their fallback loop, so a cred...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9968/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9968%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9968%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9968/files
Reloadhttps://github.com/simstudioai/sim/pull/9968/files
Reloadhttps://github.com/simstudioai/sim/pull/9968/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/model-fallback-credentialshttps://github.com/simstudioai/sim/tree/fix/model-fallback-credentials
Conversation 2 https://github.com/simstudioai/sim/pull/9968
Commits 1 https://github.com/simstudioai/sim/pull/9968/commits
Checks 83 https://github.com/simstudioai/sim/pull/9968/checks
Files changed https://github.com/simstudioai/sim/pull/9968/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9968/files
fix(executor): resolve saved model credentials inside each fallback attempt in Router and Evaluator https://github.com/simstudioai/sim/pull/9968/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9968/files
a472092 fix(executor): resolve saved model credentials inside each fallback a… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/9968/commits/a47209284026d3d59c8cf18b3e6635e6b1fd7d7b
Clear filters https://github.com/simstudioai/sim/pull/9968/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9968/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9968/files
openapi-v2-knowledge.json https://github.com/simstudioai/sim/pull/9968/files#diff-c15da3de30ec533f5aedd9a2862e8afdb8e2a58490fe681b97959638218bf99e
handler.ts https://github.com/simstudioai/sim/pull/9968/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
handler.test.ts https://github.com/simstudioai/sim/pull/9968/files#diff-6e1551ead68a792f0d0e29e433e11f01858badcd790e4b7ad9b7e373e65fccb6
handler.ts https://github.com/simstudioai/sim/pull/9968/files#diff-3931548107186ba461bc1ea6f8eb680698d4d27dac086e79eb0e9d712f8d94ef
handler.test.ts https://github.com/simstudioai/sim/pull/9968/files#diff-ffd9df0bbf9f42b82c6bcfe1e6e6cefaed4f8038afd34e7a99a4e341284293c5
handler.ts https://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
bedrock-credential.ts https://github.com/simstudioai/sim/pull/9968/files#diff-1d36f72c718cefff963d6db048f79c231aeb768b3d1c8412e6fc7f4832f93134
model-credentials.ts https://github.com/simstudioai/sim/pull/9968/files#diff-913b8273ec08ffcd75782579ca5e7e046ef2f314f8b1eb2cf18ab855326f9efb
model-fallback-request.test.ts https://github.com/simstudioai/sim/pull/9968/files#diff-f95d9a25a54fbfcc7d5fb5c3ca4ec7373ff5bd24cbc3b3421fb5e42a25f8c6d2
model-fallback-request.ts https://github.com/simstudioai/sim/pull/9968/files#diff-94acf70316b671249e4e80a608aac7b1fb998aee3b0f8f826d15e6da064f6328
knowledge.ts https://github.com/simstudioai/sim/pull/9968/files#diff-f568a5d5fbd62fe2a8c1a67f10510e9c944808367c3450fe61c670fa6be6c8a1
apps/docs/openapi-v2-knowledge.jsonhttps://github.com/simstudioai/sim/pull/9968/files#diff-c15da3de30ec533f5aedd9a2862e8afdb8e2a58490fe681b97959638218bf99e
View file https://github.com/simstudioai/sim/blob/a47209284026d3d59c8cf18b3e6635e6b1fd7d7b/apps/docs/openapi-v2-knowledge.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9968/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9968/files#diff-c15da3de30ec533f5aedd9a2862e8afdb8e2a58490fe681b97959638218bf99e
https://github.com/simstudioai/sim/pull/9968/files#diff-c15da3de30ec533f5aedd9a2862e8afdb8e2a58490fe681b97959638218bf99e
https://github.com/simstudioai/sim/pull/9968/files#diff-c15da3de30ec533f5aedd9a2862e8afdb8e2a58490fe681b97959638218bf99e
https://github.com/simstudioai/sim/pull/9968/files#diff-c15da3de30ec533f5aedd9a2862e8afdb8e2a58490fe681b97959638218bf99e
apps/sim/executor/handlers/agent/handler.tshttps://github.com/simstudioai/sim/pull/9968/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
View file https://github.com/simstudioai/sim/blob/a47209284026d3d59c8cf18b3e6635e6b1fd7d7b/apps/sim/executor/handlers/agent/handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9968/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9968/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
https://github.com/simstudioai/sim/pull/9968/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
https://github.com/simstudioai/sim/pull/9968/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
https://github.com/simstudioai/sim/pull/9968/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
https://github.com/simstudioai/sim/pull/9968/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
https://github.com/simstudioai/sim/pull/9968/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
https://github.com/simstudioai/sim/pull/9968/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
https://github.com/simstudioai/sim/pull/9968/files#diff-f4424d266df62b78bc64f610a3058f7da0da25743c40f479375462e713d3e179
apps/sim/executor/handlers/evaluator/handler.test.tshttps://github.com/simstudioai/sim/pull/9968/files#diff-6e1551ead68a792f0d0e29e433e11f01858badcd790e4b7ad9b7e373e65fccb6
View file https://github.com/simstudioai/sim/blob/a47209284026d3d59c8cf18b3e6635e6b1fd7d7b/apps/sim/executor/handlers/evaluator/handler.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9968/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9968/files#diff-6e1551ead68a792f0d0e29e433e11f01858badcd790e4b7ad9b7e373e65fccb6
https://github.com/simstudioai/sim/pull/9968/files#diff-6e1551ead68a792f0d0e29e433e11f01858badcd790e4b7ad9b7e373e65fccb6
https://github.com/simstudioai/sim/pull/9968/files#diff-6e1551ead68a792f0d0e29e433e11f01858badcd790e4b7ad9b7e373e65fccb6
https://github.com/simstudioai/sim/pull/9968/files#diff-6e1551ead68a792f0d0e29e433e11f01858badcd790e4b7ad9b7e373e65fccb6
apps/sim/executor/handlers/evaluator/handler.tshttps://github.com/simstudioai/sim/pull/9968/files#diff-3931548107186ba461bc1ea6f8eb680698d4d27dac086e79eb0e9d712f8d94ef
View file https://github.com/simstudioai/sim/blob/a47209284026d3d59c8cf18b3e6635e6b1fd7d7b/apps/sim/executor/handlers/evaluator/handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9968/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9968/files#diff-3931548107186ba461bc1ea6f8eb680698d4d27dac086e79eb0e9d712f8d94ef
https://github.com/simstudioai/sim/pull/9968/files#diff-3931548107186ba461bc1ea6f8eb680698d4d27dac086e79eb0e9d712f8d94ef
https://github.com/simstudioai/sim/pull/9968/files#diff-3931548107186ba461bc1ea6f8eb680698d4d27dac086e79eb0e9d712f8d94ef
https://github.com/simstudioai/sim/pull/9968/files#diff-3931548107186ba461bc1ea6f8eb680698d4d27dac086e79eb0e9d712f8d94ef
https://github.com/simstudioai/sim/pull/9968/files#diff-3931548107186ba461bc1ea6f8eb680698d4d27dac086e79eb0e9d712f8d94ef
https://github.com/simstudioai/sim/pull/9968/files#diff-3931548107186ba461bc1ea6f8eb680698d4d27dac086e79eb0e9d712f8d94ef
https://github.com/simstudioai/sim/pull/9968/files#diff-3931548107186ba461bc1ea6f8eb680698d4d27dac086e79eb0e9d712f8d94ef
apps/sim/executor/handlers/router/handler.test.tshttps://github.com/simstudioai/sim/pull/9968/files#diff-ffd9df0bbf9f42b82c6bcfe1e6e6cefaed4f8038afd34e7a99a4e341284293c5
View file https://github.com/simstudioai/sim/blob/a47209284026d3d59c8cf18b3e6635e6b1fd7d7b/apps/sim/executor/handlers/router/handler.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9968/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9968/files#diff-ffd9df0bbf9f42b82c6bcfe1e6e6cefaed4f8038afd34e7a99a4e341284293c5
https://github.com/simstudioai/sim/pull/9968/files#diff-ffd9df0bbf9f42b82c6bcfe1e6e6cefaed4f8038afd34e7a99a4e341284293c5
https://github.com/simstudioai/sim/pull/9968/files#diff-ffd9df0bbf9f42b82c6bcfe1e6e6cefaed4f8038afd34e7a99a4e341284293c5
https://github.com/simstudioai/sim/pull/9968/files#diff-ffd9df0bbf9f42b82c6bcfe1e6e6cefaed4f8038afd34e7a99a4e341284293c5
apps/sim/executor/handlers/router/handler.tshttps://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
View file https://github.com/simstudioai/sim/blob/a47209284026d3d59c8cf18b3e6635e6b1fd7d7b/apps/sim/executor/handlers/router/handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9968/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
https://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
https://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
https://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
https://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
https://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
https://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
https://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
https://github.com/simstudioai/sim/pull/9968/files#diff-66c3b0e98e2ce89b1ccf18289a5267cde37221fee7174b2db3e8bacc4adc144c
Please reload this pagehttps://github.com/simstudioai/sim/pull/9968/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9968/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.