René's URL Explorer Experiment


Title: fix(desktop-browser): give a wait's closing snapshot a full budget and confirm ref reuse names the same element by waleedlatif1 · Pull Request #9966 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop-browser): give a wait's closing snapshot a full budget and confirm ref reuse names the same element by waleedlatif1 · Pull Request #9966 · simstudioai/sim

X Title: fix(desktop-browser): give a wait's closing snapshot a full budget and confirm ref reuse names the same element by waleedlatif1 · Pull Request #9966 · simstudioai/sim

Description: Summary Final-review follow-ups for the browser-agent changes in this release: browser_wait_for now ends with a snapshot, but its native watchdog still allowed only 5s after the wait. A wait that ran to its timeout on a heavy page could lose its closing observation and invalidate refs, where before it returned found: false with refs intact. The watchdog now adds a standalone snapshot's 20s budget; the renderer's wait budget (queue wait + timeout + 15s) still covers it Ref reuse also requires the stored entry to point at the same element (defensive: a page's id counter only grows per document, so this should be unreachable today; it keeps reuse correct if that ever changes) Rename a local in browser_wait_for that shadowed the module-level elementTarget Type of Change Bug fix Testing Red/green: 'gives a wait that runs to its timeout a full snapshot budget for its closing observation' fails on staging with the observation timed out, passes with the fix; watchdog expectations updated for the new budget 548 browser-agent tests pass, desktop type-check clean Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Final-review follow-ups for the browser-agent changes in this release: browser_wait_for now ends with a snapshot, but its native watchdog still allowed only 5s after the wait. A wait that ...

X Description: Summary Final-review follow-ups for the browser-agent changes in this release: browser_wait_for now ends with a snapshot, but its native watchdog still allowed only 5s after the wait. A wait that ...

Opengraph URL: https://github.com/simstudioai/sim/pull/9966

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ebd6bd20-6c06-d25d-c204-8530fa093368
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FD2:AA761:AA9D2:F0CC3:6AFB45CF
html-safe-nonce24830c0e0346319493c2fc9aae3e13fa7a73a2a3f97075b771a2265be94e8617
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkQyOkFBNzYxOkFBOUQyOkYwQ0MzOjZBRkI0NUNGIiwidmlzaXRvcl9pZCI6IjU3ODk0MTYxMjc4MDkxNDQyNzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacde829bd4118f909fc5f9348ec3d4d81a403c2cbe04bd208320dc00128d8af3a6
hovercard-subject-tagpull_request:5287821879
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9966/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Final-review follow-ups for the browser-agent changes in this release: browser_wait_for now ends with a snapshot, but its native watchdog still allowed only 5s after the wait. A wait that ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9966/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9966%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9966%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9966/files
Reloadhttps://github.com/simstudioai/sim/pull/9966/files
Reloadhttps://github.com/simstudioai/sim/pull/9966/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/browser-wait-observe-budgethttps://github.com/simstudioai/sim/tree/fix/browser-wait-observe-budget
Conversation 16 https://github.com/simstudioai/sim/pull/9966
Commits 3 https://github.com/simstudioai/sim/pull/9966/commits
Checks 87 https://github.com/simstudioai/sim/pull/9966/checks
Files changed https://github.com/simstudioai/sim/pull/9966/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9966/files
fix(desktop-browser): give a wait's closing snapshot a full budget and confirm ref reuse names the same element https://github.com/simstudioai/sim/pull/9966/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9966/files
70882e6 fix(desktop-browser): give a wait's closing snapshot a full budget an… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/9966/commits/70882e674f3d817f05d3d20c10ef7662e952f2b3
d67f5ac fix(browser-protocol): widen the renderer's wait grace to cover the c… waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/9966/commits/d67f5ac6bc056ccae89eff555ff07be075128d83
2d10152 test(mothership): expect the wider browser_wait_for renderer budget waleedlatif1 Nov 13, 2026 https://github.com/simstudioai/sim/pull/9966/commits/2d10152cdf6d4173e043f85534e3b758732958d8
Clear filters https://github.com/simstudioai/sim/pull/9966/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9966/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9966/files
driver.test.ts https://github.com/simstudioai/sim/pull/9966/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
driver.ts https://github.com/simstudioai/sim/pull/9966/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
page-functions.ts https://github.com/simstudioai/sim/pull/9966/files#diff-79ef2fc7ea864204365a95130b1ccae90cd9a282e9714a8fa37cb2fb4e5e29fc
executor.test.ts https://github.com/simstudioai/sim/pull/9966/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
browser-tool-execution.test.ts https://github.com/simstudioai/sim/pull/9966/files#diff-c395e5360aa0e76912da9f12b41a11bbbbbaaa51564afd3dc799f0fa45b531c8
index.ts https://github.com/simstudioai/sim/pull/9966/files#diff-7bf024cc51a5498c6b4d087358740c2011c9d5ea86c03391bd1d4623026224d3
apps/desktop/src/main/browser-agent/driver.test.tshttps://github.com/simstudioai/sim/pull/9966/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
View file https://github.com/simstudioai/sim/blob/2d10152cdf6d4173e043f85534e3b758732958d8/apps/desktop/src/main/browser-agent/driver.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9966/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9966/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
https://github.com/simstudioai/sim/pull/9966/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
https://github.com/simstudioai/sim/pull/9966/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
https://github.com/simstudioai/sim/pull/9966/files#diff-e3f3e254574c9ace38cf400e9ef8600989b25e602629bb7e6c7e4927a27830c5
apps/desktop/src/main/browser-agent/driver.tshttps://github.com/simstudioai/sim/pull/9966/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
View file https://github.com/simstudioai/sim/blob/2d10152cdf6d4173e043f85534e3b758732958d8/apps/desktop/src/main/browser-agent/driver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9966/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9966/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
Please reload this pagehttps://github.com/simstudioai/sim/pull/9966/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9966/files
https://github.com/simstudioai/sim/pull/9966/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9966/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9966/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9966/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9966/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/9966/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
apps/desktop/src/main/browser-agent/page-functions.tshttps://github.com/simstudioai/sim/pull/9966/files#diff-79ef2fc7ea864204365a95130b1ccae90cd9a282e9714a8fa37cb2fb4e5e29fc
View file https://github.com/simstudioai/sim/blob/2d10152cdf6d4173e043f85534e3b758732958d8/apps/desktop/src/main/browser-agent/page-functions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9966/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9966/files#diff-79ef2fc7ea864204365a95130b1ccae90cd9a282e9714a8fa37cb2fb4e5e29fc
https://github.com/simstudioai/sim/pull/9966/files#diff-79ef2fc7ea864204365a95130b1ccae90cd9a282e9714a8fa37cb2fb4e5e29fc
apps/sim/lib/mothership/request/tools/executor.test.tshttps://github.com/simstudioai/sim/pull/9966/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
View file https://github.com/simstudioai/sim/blob/2d10152cdf6d4173e043f85534e3b758732958d8/apps/sim/lib/mothership/request/tools/executor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9966/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9966/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
https://github.com/simstudioai/sim/pull/9966/files#diff-5c0149489977e70711d949724f46e8bcd43162b7fbd3928da59a33aa935af5e7
apps/sim/lib/mothership/tools/client/browser-tool-execution.test.tshttps://github.com/simstudioai/sim/pull/9966/files#diff-c395e5360aa0e76912da9f12b41a11bbbbbaaa51564afd3dc799f0fa45b531c8
View file https://github.com/simstudioai/sim/blob/2d10152cdf6d4173e043f85534e3b758732958d8/apps/sim/lib/mothership/tools/client/browser-tool-execution.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9966/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9966/files#diff-c395e5360aa0e76912da9f12b41a11bbbbbaaa51564afd3dc799f0fa45b531c8
https://github.com/simstudioai/sim/pull/9966/files#diff-c395e5360aa0e76912da9f12b41a11bbbbbaaa51564afd3dc799f0fa45b531c8
packages/browser-protocol/src/index.tshttps://github.com/simstudioai/sim/pull/9966/files#diff-7bf024cc51a5498c6b4d087358740c2011c9d5ea86c03391bd1d4623026224d3
View file https://github.com/simstudioai/sim/blob/2d10152cdf6d4173e043f85534e3b758732958d8/packages/browser-protocol/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9966/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9966/files#diff-7bf024cc51a5498c6b4d087358740c2011c9d5ea86c03391bd1d4623026224d3
Please reload this pagehttps://github.com/simstudioai/sim/pull/9966/files
https://github.com/simstudioai/sim/pull/9966/files#diff-7bf024cc51a5498c6b4d087358740c2011c9d5ea86c03391bd1d4623026224d3
Please reload this pagehttps://github.com/simstudioai/sim/pull/9966/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.