René's URL Explorer Experiment


Title: improvement(aws-marketplace): close billing gaps and simplify the license write paths by waleedlatif1 · Pull Request #9946 · simstudioai/sim · GitHub

Open Graph Title: improvement(aws-marketplace): close billing gaps and simplify the license write paths by waleedlatif1 · Pull Request #9946 · simstudioai/sim

X Title: improvement(aws-marketplace): close billing gaps and simplify the license write paths by waleedlatif1 · Pull Request #9946 · simstudioai/sim

Description: Summary Linking a Marketplace license to an organization that already pays Stripe for a self-serve plan is refused (buyer and admin paths), so AWS and Stripe never bill the same organization. Enterprise stays linkable, since the team provisions it with collection paused The Stripe checkout block counts only licenses of listings this deployment still sells A usage record frozen for sending is never added to, even when the charge and the freeze hold locks for different organizations (a license relinked after its organization was deleted); the charge rolls back and its units go to the next record Container license: a delegate grant, or one pending, rejected, disabled, or deleted by the license administrator, no longer turns Enterprise on; replicas restart at random points over ten minutes on a license change instead of all at once CloudFormation prerequisites: the RDS password is a fixed, URL-safe generated secret. RDS's managed password rotates every 7 days and may contain characters that break the connection URL, while the chart copies it into a Kubernetes Secret once Example values use a placeholder product ID, and say how to read both passwords out of Secrets Manager Simplification: one insert path for new licenses, the inactive-has-no-claim rule applied in one place, a once-only team notice helper, a single buyer contact shape, the claim lookup, lock recheck, and audit entry each written once, a shared products-map type, and a misplaced doc comment moved to its function Type of Change Bug fix Improvement Testing lifecycle.integration.ts, metering.integration.ts, checkout-guard.integration.ts against Postgres: 96 pass New tests: Stripe-billed organizations are refused and Enterprise ones linked; a license on a listing no longer sold does not block checkout. Each goes red with its guard reverted authorization.test.ts, entitlements.test.ts, aws-marketplace.test.tsx: 22 pass bun run lint, type-check, check:audits (all but the local-only docs content registry); aws cloudformation validate-template on the prerequisites template Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Linking a Marketplace license to an organization that already pays Stripe for a self-serve plan is refused (buyer and admin paths), so AWS and Stripe never bill the same organization. Ente...

X Description: Summary Linking a Marketplace license to an organization that already pays Stripe for a self-serve plan is refused (buyer and admin paths), so AWS and Stripe never bill the same organization. Ente...

Opengraph URL: https://github.com/simstudioai/sim/pull/9946

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9d4032c3-b54e-85d8-8a43-6c7caf37fbf8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE824:2E7BAB:692F83:916EFB:6AFB42BD
html-safe-nonce0f3593115e74d0bcf41692dbbd88c3fb293e9133b1661a43724df402607b4ac7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODI0OjJFN0JBQjo2OTJGODM6OTE2RUZCOjZBRkI0MkJEIiwidmlzaXRvcl9pZCI6IjU2MzA0OTU3Njk4MjU5NDIzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac84fe352888e54abbd08d430706b2daf2c559ff360ce5a624bf07551e78ef087d
hovercard-subject-tagpull_request:5284241477
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9946/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Linking a Marketplace license to an organization that already pays Stripe for a self-serve plan is refused (buyer and admin paths), so AWS and Stripe never bill the same organization. Ente...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9946/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9946%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9946%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9946/files
Reloadhttps://github.com/simstudioai/sim/pull/9946/files
Reloadhttps://github.com/simstudioai/sim/pull/9946/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
chore/aws-marketplace-audithttps://github.com/simstudioai/sim/tree/chore/aws-marketplace-audit
Conversation 29 https://github.com/simstudioai/sim/pull/9946
Commits 3 https://github.com/simstudioai/sim/pull/9946/commits
Checks 88 https://github.com/simstudioai/sim/pull/9946/checks
Files changed https://github.com/simstudioai/sim/pull/9946/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9946/files
improvement(aws-marketplace): close billing gaps and simplify the license write paths https://github.com/simstudioai/sim/pull/9946/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/9946/files
c48df42 improvement(aws-marketplace): close billing gaps and simplify the lic… waleedlatif1 Nov 12, 2026 https://github.com/simstudioai/sim/pull/9946/commits/c48df42b1a4ec63db1eec641dda724579b0126b4
56f101b fix(aws-marketplace): treat any live bound Stripe subscription as bil… waleedlatif1 Nov 12, 2026 https://github.com/simstudioai/sim/pull/9946/commits/56f101b5b2effd6618846b33788ebdd25f7cb3db
8e9c0d4 chore(helm): bump chart to 1.11.16 for the Marketplace example changes waleedlatif1 Nov 12, 2026 https://github.com/simstudioai/sim/pull/9946/commits/8e9c0d4402bfee6cf6fd3a0601a1be4bf27b102d
Clear filters https://github.com/simstudioai/sim/pull/9946/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9946/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9946/files
authorization.ts https://github.com/simstudioai/sim/pull/9946/files#diff-098eb29442c407cfec4301ad4de0f855a89ac20eca036d8734838de6e4157a0c
admin.ts https://github.com/simstudioai/sim/pull/9946/files#diff-f4923736c516778c068bef7d5175fd085f54dbdaa6fd60541f590b0a97a51c7a
use-cases.ts https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
checkout-guard.integration.ts https://github.com/simstudioai/sim/pull/9946/files#diff-37be87b454800c2a4e4e5a9d25f9e29906a622fe1ad23ffc016088ccc33ae68e
client.ts https://github.com/simstudioai/sim/pull/9946/files#diff-b1270551fcd0eb232e8a5152b5c7c31b5f407194f01fdeaad14ab68d7b16c387
config.ts https://github.com/simstudioai/sim/pull/9946/files#diff-08155d9ed304f06601d789931992230d5efd3296fcb44d92e9268f7b7e8341a0
container-license.ts https://github.com/simstudioai/sim/pull/9946/files#diff-78cd585c4cacb5b743b4e1f71f2d0f743c824180625afbf257cb581596abc7f1
lifecycle.integration.ts https://github.com/simstudioai/sim/pull/9946/files#diff-b93f34d55a43ca6dfc41dd38e4bda49063dfc4ab41dcc1a1375273c7d827eba2
metering.ts https://github.com/simstudioai/sim/pull/9946/files#diff-df9c67bb3cd8e53a402e39c402a70920321e89baecbbda619641ad76a18d97c0
products.ts https://github.com/simstudioai/sim/pull/9946/files#diff-200c5952f43de725331902f7c377de70d89c5740f9763ae6def52fa31237fde2
reconcile.ts https://github.com/simstudioai/sim/pull/9946/files#diff-16248e1b602aa4731841b94302e4905c96a45ebaf6c35084437d7d2c01e7025f
repository.ts https://github.com/simstudioai/sim/pull/9946/files#diff-4f5f1e2950d118f48332605b66d08c33c7299896a6c5e7efeeb676e294e43d4a
Chart.yaml https://github.com/simstudioai/sim/pull/9946/files#diff-d445852065771a32d12552f3dda5753bbf1f5cadfc7f4c3368a27d9c92932918
aws-marketplace-prerequisites.yaml https://github.com/simstudioai/sim/pull/9946/files#diff-87b920d21ea39342b9e60213d1f5996fca7c2305a0a93894547d474d4abc872a
values-aws-marketplace.yaml https://github.com/simstudioai/sim/pull/9946/files#diff-291811db5ad9dd7b4c50d48cb0c4356d9296092ec84298abd88452bf172dcf6e
apps/sim/lib/billing/authorization.tshttps://github.com/simstudioai/sim/pull/9946/files#diff-098eb29442c407cfec4301ad4de0f855a89ac20eca036d8734838de6e4157a0c
View file https://github.com/simstudioai/sim/blob/8e9c0d4402bfee6cf6fd3a0601a1be4bf27b102d/apps/sim/lib/billing/authorization.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9946/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9946/files#diff-098eb29442c407cfec4301ad4de0f855a89ac20eca036d8734838de6e4157a0c
https://github.com/simstudioai/sim/pull/9946/files#diff-098eb29442c407cfec4301ad4de0f855a89ac20eca036d8734838de6e4157a0c
https://github.com/simstudioai/sim/pull/9946/files#diff-098eb29442c407cfec4301ad4de0f855a89ac20eca036d8734838de6e4157a0c
https://github.com/simstudioai/sim/pull/9946/files#diff-098eb29442c407cfec4301ad4de0f855a89ac20eca036d8734838de6e4157a0c
apps/sim/lib/billing/aws-marketplace/application/admin.tshttps://github.com/simstudioai/sim/pull/9946/files#diff-f4923736c516778c068bef7d5175fd085f54dbdaa6fd60541f590b0a97a51c7a
View file https://github.com/simstudioai/sim/blob/8e9c0d4402bfee6cf6fd3a0601a1be4bf27b102d/apps/sim/lib/billing/aws-marketplace/application/admin.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9946/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9946/files#diff-f4923736c516778c068bef7d5175fd085f54dbdaa6fd60541f590b0a97a51c7a
https://github.com/simstudioai/sim/pull/9946/files#diff-f4923736c516778c068bef7d5175fd085f54dbdaa6fd60541f590b0a97a51c7a
https://github.com/simstudioai/sim/pull/9946/files#diff-f4923736c516778c068bef7d5175fd085f54dbdaa6fd60541f590b0a97a51c7a
https://github.com/simstudioai/sim/pull/9946/files#diff-f4923736c516778c068bef7d5175fd085f54dbdaa6fd60541f590b0a97a51c7a
apps/sim/lib/billing/aws-marketplace/application/use-cases.tshttps://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
View file https://github.com/simstudioai/sim/blob/8e9c0d4402bfee6cf6fd3a0601a1be4bf27b102d/apps/sim/lib/billing/aws-marketplace/application/use-cases.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9946/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
Please reload this pagehttps://github.com/simstudioai/sim/pull/9946/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9946/files
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
https://github.com/simstudioai/sim/pull/9946/files#diff-a88ac917026392e34720d9502cef5ff9c43a591e3973e5b392c6512ec265a080
apps/sim/lib/billing/aws-marketplace/checkout-guard.integration.tshttps://github.com/simstudioai/sim/pull/9946/files#diff-37be87b454800c2a4e4e5a9d25f9e29906a622fe1ad23ffc016088ccc33ae68e
View file https://github.com/simstudioai/sim/blob/8e9c0d4402bfee6cf6fd3a0601a1be4bf27b102d/apps/sim/lib/billing/aws-marketplace/checkout-guard.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9946/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9946/files#diff-37be87b454800c2a4e4e5a9d25f9e29906a622fe1ad23ffc016088ccc33ae68e
https://github.com/simstudioai/sim/pull/9946/files#diff-37be87b454800c2a4e4e5a9d25f9e29906a622fe1ad23ffc016088ccc33ae68e
https://github.com/simstudioai/sim/pull/9946/files#diff-37be87b454800c2a4e4e5a9d25f9e29906a622fe1ad23ffc016088ccc33ae68e
https://github.com/simstudioai/sim/pull/9946/files#diff-37be87b454800c2a4e4e5a9d25f9e29906a622fe1ad23ffc016088ccc33ae68e
https://github.com/simstudioai/sim/pull/9946/files#diff-37be87b454800c2a4e4e5a9d25f9e29906a622fe1ad23ffc016088ccc33ae68e
https://github.com/simstudioai/sim/pull/9946/files#diff-37be87b454800c2a4e4e5a9d25f9e29906a622fe1ad23ffc016088ccc33ae68e
apps/sim/lib/billing/aws-marketplace/client.tshttps://github.com/simstudioai/sim/pull/9946/files#diff-b1270551fcd0eb232e8a5152b5c7c31b5f407194f01fdeaad14ab68d7b16c387
View file https://github.com/simstudioai/sim/blob/8e9c0d4402bfee6cf6fd3a0601a1be4bf27b102d/apps/sim/lib/billing/aws-marketplace/client.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9946/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9946/files#diff-b1270551fcd0eb232e8a5152b5c7c31b5f407194f01fdeaad14ab68d7b16c387
https://github.com/simstudioai/sim/pull/9946/files#diff-b1270551fcd0eb232e8a5152b5c7c31b5f407194f01fdeaad14ab68d7b16c387
Please reload this pagehttps://github.com/simstudioai/sim/pull/9946/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9946/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.