| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:6e9a497a-a9bc-e76b-cdb5-b6ccdac6c4ae |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 83F2:1BD5CA:7022A8:9B2149:6AFB42CC |
| html-safe-nonce | 7fd1604ccdc923c7b4da1cc625e4eb169df12c11f6f69743753b3ea296e7b12c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0YyOjFCRDVDQTo3MDIyQTg6OUIyMTQ5OjZBRkI0MkNDIiwidmlzaXRvcl9pZCI6IjI4MDkxMzUyNTg4MDMwNjE0NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | eed457f50a669e52df160536a0a61cab753d4b84c32bbb0bdbda323fb7bcccac |
| hovercard-subject-tag | pull_request:5276906962 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9934/commits |
| twitter:image | https://opengraph.githubassets.com/c52c9ff07db0b6be2b12704691604217dd3b83c8a0687cc98c8a7b1998f01537/simstudioai/sim/pull/9934 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c52c9ff07db0b6be2b12704691604217dd3b83c8a0687cc98c8a7b1998f01537/simstudioai/sim/pull/9934 |
| og:image:alt | Summary
The S3 knowledge connector can now sign with a saved AWS credential owned by the knowledge base's workspace or organization: access keys, an assumed role, or a keyless OIDC role. The ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | waleedlatif1 |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-cache |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/simstudioai/sim/pull/9934/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9934%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9934%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=simstudioai%2Fsim |
| Reload | https://github.com/simstudioai/sim/pull/9934/commits |
| Reload | https://github.com/simstudioai/sim/pull/9934/commits |
| Reload | https://github.com/simstudioai/sim/pull/9934/commits |
| simstudioai | https://github.com/simstudioai |
| sim | https://github.com/simstudioai/sim |
| Code | https://github.com/simstudioai/sim |
| Issues129 (129) | https://github.com/simstudioai/sim/issues |
| Pull requests200 (200) | https://github.com/simstudioai/sim/pulls |
| Actions | https://github.com/simstudioai/sim/actions |
| Projects | https://github.com/simstudioai/sim/projects |
| Security and quality | https://github.com/simstudioai/sim/security |
| Insights | https://github.com/simstudioai/sim/pulse |
| https://github.com/simstudioai/sim |
| waleedlatif1 | https://github.com/waleedlatif1 |
| staging | https://github.com/simstudioai/sim/tree/staging |
| feat/keyless-storage-connectors | https://github.com/simstudioai/sim/tree/feat/keyless-storage-connectors |
| Conversation | https://github.com/simstudioai/sim/pull/9934 |
| Commits12 (12) | https://github.com/simstudioai/sim/pull/9934/commits |
| Checks | https://github.com/simstudioai/sim/pull/9934/checks |
| Files changed | https://github.com/simstudioai/sim/pull/9934/files |
| feat(knowledge): let the S3 connector sync with a saved AWS credential | https://github.com/simstudioai/sim/pull/9934/commits#top |
| waleedlatif1 | https://github.com/waleedlatif1 |
| staging | https://github.com/simstudioai/sim/tree/staging |
| feat/keyless-storage-connectors | https://github.com/simstudioai/sim/tree/feat/keyless-storage-connectors |
| feat(connectors): sign S3 connector requests with a seeded AWS session | https://github.com/simstudioai/sim/pull/9934/commits/4c8cf5ce4c730da5089688d35594bb02d5e2d979 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 4c8cf5c | https://github.com/simstudioai/sim/pull/9934/commits/4c8cf5ce4c730da5089688d35594bb02d5e2d979 |
| https://github.com/simstudioai/sim/tree/4c8cf5ce4c730da5089688d35594bb02d5e2d979 |
| feat(knowledge): let a key connector sync with its declared saved credential | https://github.com/simstudioai/sim/pull/9934/commits/ec68dc19d1700c12af56dd6a2fb3aaff1aa1981a |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| ec68dc1 | https://github.com/simstudioai/sim/pull/9934/commits/ec68dc19d1700c12af56dd6a2fb3aaff1aa1981a |
| https://github.com/simstudioai/sim/tree/ec68dc19d1700c12af56dd6a2fb3aaff1aa1981a |
| feat(knowledge): offer a saved AWS credential when setting up an S3 connector | https://github.com/simstudioai/sim/pull/9934/commits/9fa364799d3767c0506b1aae2b18aa5b03413776 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 9fa3647 | https://github.com/simstudioai/sim/pull/9934/commits/9fa364799d3767c0506b1aae2b18aa5b03413776 |
| https://github.com/simstudioai/sim/tree/9fa364799d3767c0506b1aae2b18aa5b03413776 |
| docs(knowledge): describe the S3 connector's saved AWS credential option | https://github.com/simstudioai/sim/pull/9934/commits/84cec2d86382e0f535cbbd9a0308c6ff4a8de9db |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 84cec2d | https://github.com/simstudioai/sim/pull/9934/commits/84cec2d86382e0f535cbbd9a0308c6ff4a8de9db |
| https://github.com/simstudioai/sim/tree/84cec2d86382e0f535cbbd9a0308c6ff4a8de9db |
| fix(knowledge): refuse moving a stored-key connector onto its saved credential | https://github.com/simstudioai/sim/pull/9934/commits/732a49756da01d1fca28f82d1bfac67cfc753971 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 732a497 | https://github.com/simstudioai/sim/pull/9934/commits/732a49756da01d1fca28f82d1bfac67cfc753971 |
| https://github.com/simstudioai/sim/tree/732a49756da01d1fca28f82d1bfac67cfc753971 |
| fix(knowledge): classify saved AWS credential failures and labels consistently | https://github.com/simstudioai/sim/pull/9934/commits/d65041fb105644c6eabf404c63677adabb32e7cd |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| d65041f | https://github.com/simstudioai/sim/pull/9934/commits/d65041fb105644c6eabf404c63677adabb32e7cd |
| https://github.com/simstudioai/sim/tree/d65041fb105644c6eabf404c63677adabb32e7cd |
| fix(connectors): sign saved AWS credentials only for commercial and GovCloud S3 | https://github.com/simstudioai/sim/pull/9934/commits/3874c67928f1468b5872e531919996a4762e800b |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 3874c67 | https://github.com/simstudioai/sim/pull/9934/commits/3874c67928f1468b5872e531919996a4762e800b |
| https://github.com/simstudioai/sim/tree/3874c67928f1468b5872e531919996a4762e800b |
| docs(knowledge): state saved-credential availability and rollback limits | https://github.com/simstudioai/sim/pull/9934/commits/198d8ac6f48b15ae51a8aeb5400a3b688e53a930 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 198d8ac | https://github.com/simstudioai/sim/pull/9934/commits/198d8ac6f48b15ae51a8aeb5400a3b688e53a930 |
| https://github.com/simstudioai/sim/tree/198d8ac6f48b15ae51a8aeb5400a3b688e53a930 |
| fix(knowledge): redact saved AWS session secrets and share the credential service check | https://github.com/simstudioai/sim/pull/9934/commits/942a7a9d5d7a668026acdb407d1066b48ce58741 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 942a7a9 | https://github.com/simstudioai/sim/pull/9934/commits/942a7a9d5d7a668026acdb407d1066b48ce58741 |
| https://github.com/simstudioai/sim/tree/942a7a9d5d7a668026acdb407d1066b48ce58741 |
| fix(knowledge): keep long-lived saved AWS keys per run and gate saved-credential edits on rollout | https://github.com/simstudioai/sim/pull/9934/commits/0d4ca288359e7fba057482e30dccd0b59ff1f033 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 0d4ca28 | https://github.com/simstudioai/sim/pull/9934/commits/0d4ca288359e7fba057482e30dccd0b59ff1f033 |
| https://github.com/simstudioai/sim/tree/0d4ca288359e7fba057482e30dccd0b59ff1f033 |
| docs(knowledge): describe the saved-credential provider as a service, not an OAuth service | https://github.com/simstudioai/sim/pull/9934/commits/e340e9b268404a3a108ea325c3d6510e6d4ea26d |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| e340e9b | https://github.com/simstudioai/sim/pull/9934/commits/e340e9b268404a3a108ea325c3d6510e6d4ea26d |
| https://github.com/simstudioai/sim/tree/e340e9b268404a3a108ea325c3d6510e6d4ea26d |
| test(llm): mock AWS credentials through the central @sim/testing mock | https://github.com/simstudioai/sim/pull/9934/commits/ff5b89e3a26bc565e703ec410e8760889e38614b |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| ff5b89e | https://github.com/simstudioai/sim/pull/9934/commits/ff5b89e3a26bc565e703ec410e8760889e38614b |
| https://github.com/simstudioai/sim/tree/ff5b89e3a26bc565e703ec410e8760889e38614b |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |