René's URL Explorer Experiment


Title: fix(http): keep unwrapping legacy success envelopes for existing workflows by waleedlatif1 · Pull Request #9909 · simstudioai/sim · GitHub

Open Graph Title: fix(http): keep unwrapping legacy success envelopes for existing workflows by waleedlatif1 · Pull Request #9909 · simstudioai/sim

X Title: fix(http): keep unwrapping legacy success envelopes for existing workflows by waleedlatif1 · Pull Request #9909 · simstudioai/sim

Description: Summary Follow-up to #9889 (issue #9838). Deleting the old /api/proxy envelope branch fixed JSend-style 200s, but it also changed two behaviors existing API/Webhook blocks have had since that route was removed: a 200 body with success, status, and data was unwrapped, so read the inner data a 200 body with success: false failed the block with the body's error, so error branches ran Restores both through one shared toHttpToolResponse helper in tools/http/utils.ts, gated on the body carrying a success field — the only shape the old route ever produced (success: response.ok). A body without it (JSend {status, data}) stays an ordinary response, which is the #9838 fix Net effect vs. before #9889: only bodies with no success field change. Non-string envelope errors are now JSON-serialized instead of reaching the caller as an object ([object Object] in the API block) Both tools share the helper, which also drops their duplicated header-copy loops Type of Change Bug fix Testing tools/index.test.ts: both real tools through executeTool for JSend, success: true unwrap, and success: false with string and object errors. Red on #9889 as merged (6 compat cases), red on pre-#9889 code only for the JSend case and the object-error serialization, green with this change bunx vitest run tools/index.test.ts tools/http executor/handlers/api (284 passed), biome, check:utils, check:test-patterns, check:comment-hygiene; full gate in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #9889 (issue #9838). Deleting the old /api/proxy envelope branch fixed JSend-style 200s, but it also changed two behaviors existing API/Webhook blocks have had since that rout...

X Description: Summary Follow-up to #9889 (issue #9838). Deleting the old /api/proxy envelope branch fixed JSend-style 200s, but it also changed two behaviors existing API/Webhook blocks have had since that rout...

Opengraph URL: https://github.com/simstudioai/sim/pull/9909

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5d96a3ce-3407-5226-5adc-8bf05d21509e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE066:1B6493:D721C5:127551C:6AFB5C70
html-safe-nonce583ce0aac95171f2b695c4c5422dfa97eb429be26d5f2f7589747260a2f884ef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDY2OjFCNjQ5MzpENzIxQzU6MTI3NTUxQzo2QUZCNUM3MCIsInZpc2l0b3JfaWQiOiIxMzQwOTE3ODQxNzM4NzAxOTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0c1bab8b96ececf04d2e18f1d448f6f908706dfae7c7e5ad5d06d9e4acb0d15e
hovercard-subject-tagpull_request:5267875852
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9909/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #9889 (issue #9838). Deleting the old /api/proxy envelope branch fixed JSend-style 200s, but it also changed two behaviors existing API/Webhook blocks have had since that rout...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9909/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9909%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9909%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9909/files
Reloadhttps://github.com/simstudioai/sim/pull/9909/files
Reloadhttps://github.com/simstudioai/sim/pull/9909/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/http-legacy-envelope-compathttps://github.com/simstudioai/sim/tree/fix/http-legacy-envelope-compat
Conversation 5 https://github.com/simstudioai/sim/pull/9909
Commits 1 https://github.com/simstudioai/sim/pull/9909/commits
Checks 80 https://github.com/simstudioai/sim/pull/9909/checks
Files changed https://github.com/simstudioai/sim/pull/9909/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9909/files
fix(http): keep unwrapping legacy success envelopes for existing workflows https://github.com/simstudioai/sim/pull/9909/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/9909/files
2d87d91 fix(http): keep unwrapping legacy success envelopes for existing work… waleedlatif1 Nov 11, 2026 https://github.com/simstudioai/sim/pull/9909/commits/2d87d913c6d1e9650b62fa23040266d06e35dd7f
Clear filters https://github.com/simstudioai/sim/pull/9909/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9909/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9909/files
request.ts https://github.com/simstudioai/sim/pull/9909/files#diff-fa2e8e1d6e333609ecc1d7afdb23af48acaf8fe38e07b2bc12e23ce7a6023d7f
types.ts https://github.com/simstudioai/sim/pull/9909/files#diff-c6c7a6ebf18d408ea6fb1aeb306c964f9e0919dd84d21d2cb3678a478fb3b9e8
utils.ts https://github.com/simstudioai/sim/pull/9909/files#diff-5eddc77d4ae5e8075e2ea3b94443a213e36bccaa25a7647429e5b15dbd173687
webhook_request.ts https://github.com/simstudioai/sim/pull/9909/files#diff-70c217722f9e14655f3f764c0795b6ac7269aa8d7b1da0c1ab61d4fa93eab02e
index.test.ts https://github.com/simstudioai/sim/pull/9909/files#diff-9ba0f7033f9247e496b4f9e0f46183a13c79b1bb48d721ba4bf042bdd08e4dd0
apps/sim/tools/http/request.tshttps://github.com/simstudioai/sim/pull/9909/files#diff-fa2e8e1d6e333609ecc1d7afdb23af48acaf8fe38e07b2bc12e23ce7a6023d7f
View file https://github.com/simstudioai/sim/blob/2d87d913c6d1e9650b62fa23040266d06e35dd7f/apps/sim/tools/http/request.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9909/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9909/files#diff-fa2e8e1d6e333609ecc1d7afdb23af48acaf8fe38e07b2bc12e23ce7a6023d7f
https://github.com/simstudioai/sim/pull/9909/files#diff-fa2e8e1d6e333609ecc1d7afdb23af48acaf8fe38e07b2bc12e23ce7a6023d7f
https://github.com/simstudioai/sim/pull/9909/files#diff-fa2e8e1d6e333609ecc1d7afdb23af48acaf8fe38e07b2bc12e23ce7a6023d7f
apps/sim/tools/http/types.tshttps://github.com/simstudioai/sim/pull/9909/files#diff-c6c7a6ebf18d408ea6fb1aeb306c964f9e0919dd84d21d2cb3678a478fb3b9e8
View file https://github.com/simstudioai/sim/blob/2d87d913c6d1e9650b62fa23040266d06e35dd7f/apps/sim/tools/http/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9909/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9909/files#diff-c6c7a6ebf18d408ea6fb1aeb306c964f9e0919dd84d21d2cb3678a478fb3b9e8
https://github.com/simstudioai/sim/pull/9909/files#diff-c6c7a6ebf18d408ea6fb1aeb306c964f9e0919dd84d21d2cb3678a478fb3b9e8
apps/sim/tools/http/utils.tshttps://github.com/simstudioai/sim/pull/9909/files#diff-5eddc77d4ae5e8075e2ea3b94443a213e36bccaa25a7647429e5b15dbd173687
View file https://github.com/simstudioai/sim/blob/2d87d913c6d1e9650b62fa23040266d06e35dd7f/apps/sim/tools/http/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9909/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9909/files#diff-5eddc77d4ae5e8075e2ea3b94443a213e36bccaa25a7647429e5b15dbd173687
https://github.com/simstudioai/sim/pull/9909/files#diff-5eddc77d4ae5e8075e2ea3b94443a213e36bccaa25a7647429e5b15dbd173687
Please reload this pagehttps://github.com/simstudioai/sim/pull/9909/files
apps/sim/tools/http/webhook_request.tshttps://github.com/simstudioai/sim/pull/9909/files#diff-70c217722f9e14655f3f764c0795b6ac7269aa8d7b1da0c1ab61d4fa93eab02e
View file https://github.com/simstudioai/sim/blob/2d87d913c6d1e9650b62fa23040266d06e35dd7f/apps/sim/tools/http/webhook_request.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9909/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9909/files#diff-70c217722f9e14655f3f764c0795b6ac7269aa8d7b1da0c1ab61d4fa93eab02e
https://github.com/simstudioai/sim/pull/9909/files#diff-70c217722f9e14655f3f764c0795b6ac7269aa8d7b1da0c1ab61d4fa93eab02e
https://github.com/simstudioai/sim/pull/9909/files#diff-70c217722f9e14655f3f764c0795b6ac7269aa8d7b1da0c1ab61d4fa93eab02e
apps/sim/tools/index.test.tshttps://github.com/simstudioai/sim/pull/9909/files#diff-9ba0f7033f9247e496b4f9e0f46183a13c79b1bb48d721ba4bf042bdd08e4dd0
View file https://github.com/simstudioai/sim/blob/2d87d913c6d1e9650b62fa23040266d06e35dd7f/apps/sim/tools/index.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9909/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9909/files#diff-9ba0f7033f9247e496b4f9e0f46183a13c79b1bb48d721ba4bf042bdd08e4dd0
https://github.com/simstudioai/sim/pull/9909/files#diff-9ba0f7033f9247e496b4f9e0f46183a13c79b1bb48d721ba4bf042bdd08e4dd0
https://github.com/simstudioai/sim/pull/9909/files#diff-9ba0f7033f9247e496b4f9e0f46183a13c79b1bb48d721ba4bf042bdd08e4dd0
Please reload this pagehttps://github.com/simstudioai/sim/pull/9909/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.