René's URL Explorer Experiment


Title: fix(workflows): refuse operation edits that would overwrite a concurrent change by waleedlatif1 · Pull Request #9902 · simstudioai/sim · GitHub

Open Graph Title: fix(workflows): refuse operation edits that would overwrite a concurrent change by waleedlatif1 · Pull Request #9902 · simstudioai/sim

X Title: fix(workflows): refuse operation edits that would overwrite a concurrent change by waleedlatif1 · Pull Request #9902 · simstudioai/sim

Description: Summary Applying workflow operations read the stored graph outside the workflow row lock, applied the batch in memory, then wrote the whole graph back. Two concurrent POST /api/v2/workflows/{id}/operations calls (or v2 and Copilot, or v2 and someone editing in the builder) could silently drop each other's edits. The write now re-reads the stored graph under the row lock and refuses with a 409 conflict if another edit committed after the base read. The caller re-reads and retries; nothing is lost silently. Applying the batch stays outside the lock on purpose: it does credential lookups, MCP server discovery, and lint queries, which must not run while holding the row lock (and would trip the transaction tripwire). Only one indexed graph read and a fingerprint comparison run under the lock. The fingerprint is order-insensitive (sorted keys, edges sorted by id) because the loader doesn't order rows. Unchanged: Copilot's caller-supplied base graph, dry run (no lock, no write), atomic, skipped-item reporting, lint, minted IDs, audit, and PUT /state. Test plan New unit tests: a concurrent change is refused; the same rows in a different order still commit. Both fail with the guard reverted. apply-workflow-operations and replace-normalized-state tests pass locally CI type-check, audits, full suite

Open Graph Description: Summary Applying workflow operations read the stored graph outside the workflow row lock, applied the batch in memory, then wrote the whole graph back. Two concurrent POST /api/v2/workflows/{id}/o...

X Description: Summary Applying workflow operations read the stored graph outside the workflow row lock, applied the batch in memory, then wrote the whole graph back. Two concurrent POST /api/v2/workflows/{id}/o...

Opengraph URL: https://github.com/simstudioai/sim/pull/9902

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:12db50f7-82ff-a689-104f-ebd4f545937b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3DC:FBC06:D31744:1230E3E:6AFB5C6D
html-safe-noncead81aade3831d16c503a57b1f343182fffe045519e9325377be86c0a9aa0623b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0RDOkZCQzA2OkQzMTc0NDoxMjMwRTNFOjZBRkI1QzZEIiwidmlzaXRvcl9pZCI6IjQ1NzUxNjY5ODYwMjAwMzU2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2f4466dfd84d98973f908158189aa72c8b7d31f409d07ce9e9f49595e2c76f91
hovercard-subject-tagpull_request:5267173686
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9902/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Applying workflow operations read the stored graph outside the workflow row lock, applied the batch in memory, then wrote the whole graph back. Two concurrent POST /api/v2/workflows/{id}/o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9902/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9902%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9902%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9902/files
Reloadhttps://github.com/simstudioai/sim/pull/9902/files
Reloadhttps://github.com/simstudioai/sim/pull/9902/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/workflow-ops-lock-base-readhttps://github.com/simstudioai/sim/tree/fix/workflow-ops-lock-base-read
Conversation 13 https://github.com/simstudioai/sim/pull/9902
Commits 2 https://github.com/simstudioai/sim/pull/9902/commits
Checks 80 https://github.com/simstudioai/sim/pull/9902/checks
Files changed https://github.com/simstudioai/sim/pull/9902/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9902/files
fix(workflows): refuse operation edits that would overwrite a concurrent change https://github.com/simstudioai/sim/pull/9902/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/9902/files
697933c fix(workflows): serialize operation edits under the workflow row lock waleedlatif1 Nov 11, 2026 https://github.com/simstudioai/sim/pull/9902/commits/697933c22ea9c7c4c96a59cbe616496bb2403722
9566068 fix(workflows): fingerprint only stored rows so container child order… waleedlatif1 Nov 11, 2026 https://github.com/simstudioai/sim/pull/9902/commits/95660685ed4a0432319510b389e12aa85ea45ff1
Clear filters https://github.com/simstudioai/sim/pull/9902/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9902/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9902/files
apply-workflow-operations.test.ts https://github.com/simstudioai/sim/pull/9902/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
apply-workflow-operations.ts https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
custom-block-authoring.test.ts https://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
replace-normalized-state.ts https://github.com/simstudioai/sim/pull/9902/files#diff-0e534903cd494f4d5ad75d5647a832b1f9c50622fb69f80751a992734577ca96
apps/sim/lib/workflows/application/apply-workflow-operations.test.tshttps://github.com/simstudioai/sim/pull/9902/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
View file https://github.com/simstudioai/sim/blob/95660685ed4a0432319510b389e12aa85ea45ff1/apps/sim/lib/workflows/application/apply-workflow-operations.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9902/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9902/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
https://github.com/simstudioai/sim/pull/9902/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
https://github.com/simstudioai/sim/pull/9902/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
https://github.com/simstudioai/sim/pull/9902/files#diff-c9eb1870c4d990c58d4978fc22c3f7581a0bffc42a2fce2ffcff4d5f64ca46a3
apps/sim/lib/workflows/application/apply-workflow-operations.tshttps://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
View file https://github.com/simstudioai/sim/blob/95660685ed4a0432319510b389e12aa85ea45ff1/apps/sim/lib/workflows/application/apply-workflow-operations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9902/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
Please reload this pagehttps://github.com/simstudioai/sim/pull/9902/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9902/files
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
https://github.com/simstudioai/sim/pull/9902/files#diff-d174b714d30772adf965251cfe7d111be6683cbbbdb74e4137b90e685551ca52
apps/sim/lib/workflows/application/custom-block-authoring.test.tshttps://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
View file https://github.com/simstudioai/sim/blob/95660685ed4a0432319510b389e12aa85ea45ff1/apps/sim/lib/workflows/application/custom-block-authoring.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9902/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
https://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
https://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
https://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
https://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
https://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
https://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
https://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
https://github.com/simstudioai/sim/pull/9902/files#diff-5b6a85dbde83d2fe11afa1a4c155464104607f4f4249e307844fe83617b5f2fa
apps/sim/lib/workflows/persistence/replace-normalized-state.tshttps://github.com/simstudioai/sim/pull/9902/files#diff-0e534903cd494f4d5ad75d5647a832b1f9c50622fb69f80751a992734577ca96
View file https://github.com/simstudioai/sim/blob/95660685ed4a0432319510b389e12aa85ea45ff1/apps/sim/lib/workflows/persistence/replace-normalized-state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9902/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9902/files#diff-0e534903cd494f4d5ad75d5647a832b1f9c50622fb69f80751a992734577ca96
https://github.com/simstudioai/sim/pull/9902/files#diff-0e534903cd494f4d5ad75d5647a832b1f9c50622fb69f80751a992734577ca96
Please reload this pagehttps://github.com/simstudioai/sim/pull/9902/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.