Title: chore(deps): bump electron-builder to 26.18.0 by waleedlatif1 · Pull Request #9893 · simstudioai/sim · GitHub
Open Graph Title: chore(deps): bump electron-builder to 26.18.0 by waleedlatif1 · Pull Request #9893 · simstudioai/sim
X Title: chore(deps): bump electron-builder to 26.18.0 by waleedlatif1 · Pull Request #9893 · simstudioai/sim
Description: Summary Bumps electron-builder 26.15.3 → 26.18.0 in apps/desktop (devDependency). Lockfile moves only the builder family (app-builder-lib/dmg-builder/electron-publish/electron-builder-squirrel-windows 26.18.0, builder-util 26.16.0, @electron/rebuild 4.2.1, plus a nested @noble/hashes@1 for app-builder-lib). electron-updater is versioned independently and already on its latest 6.x (6.8.12), so it is not part of this bump. No Sim code or config changes. Relevant upstream changes for Sim's config (macOS dmg + zip, universal, hardened runtime, notarize, publish: github used only for app-update.yml): Workspace production-dependency collection fixes (26.15.6) and workspace/mapped-destination path containment for asar (26.18.0): the packaged app.asar is byte-identical before and after (below). macOS zip is created with 7-Zip -snl again instead of the native zip -y path that 26.15.x used; symlinks are preserved and the extracted app passes codesign --verify --deep --strict (below). Electron's LICENSE.electron.txt and LICENSES.chromium.html are now retained in Contents/Resources (license compliance; two new files in the bundle, outside the asar). set-key-partition-list now gets the temp keychain password. Only used when electron-builder imports CSC_LINK itself; our release workflow prepares its own keychain and passes CSC_KEYCHAIN, so that path is not taken. mac dmg/zip blockmaps still use the default chunker (the new finer chunking applies only to NSIS store-asar). dmg-builder and the GitHub publisher have no code changes. The rest (NSIS, snap, flatpak, pnpm, squirrel, gitlab, MAS afterSign) doesn't apply to our targets. Type of Change Other: dependency upgrade Testing Unsigned local packages on 26.15.3 and 26.18.0 from the same dist/ (CSC_IDENTITY_AUTO_DISCOVERY=false, --publish never, ad-hoc identity, hardened runtime off, arm64; the icon was swapped for a PNG because this machine has no Xcode 26 actool, identical for both runs): --mac dir: app.asar is byte-identical (cmp), and so is app.asar.unpacked. Its file list (3,633 entries) has the expected production deps (@sim/* workspace packages, electron-updater, @lydell/node-pty + both darwin prebuilds, etc.), no devDependencies, and the ../sim font mapping still lands at static/SeasonSansUprightsVF.woff2. Info.plist is identical. The only bundle difference is the two license files above. --mac zip: extracted with ditto -x -k (how Squirrel.Mac unpacks updates). Both versions keep all 14 symlinks with identical targets, every *.framework/Versions/Current is a symlink, codesign --verify --deep --strict passes, the embedded app.asar and app-update.yml are identical, and latest-mac.yml has the same shape. CI desktop-e2e / package-smoke builds the universal unsigned app and runs the packaged smoke suite on this PR. Only a signed release run can confirm these: Developer ID signing + notarization of the universal dmg/zip, and the .icon → Assets.car/icns path with the newer icons toolset (needs Xcode 26). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code
Open Graph Description: Summary Bumps electron-builder 26.15.3 → 26.18.0 in apps/desktop (devDependency). Lockfile moves only the builder family (app-builder-lib/dmg-builder/electron-publish/electron-builder-squirrel-win...
X Description: Summary Bumps electron-builder 26.15.3 → 26.18.0 in apps/desktop (devDependency). Lockfile moves only the builder family (app-builder-lib/dmg-builder/electron-publish/electron-builder-squirrel-win...
Opengraph URL: https://github.com/simstudioai/sim/pull/9893
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6d6a3fce-9b73-135e-9f72-6b1d38f8c86a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E168:3BD2EB:AD75FB:F473C5:6AFB79B5 |
| html-safe-nonce | 43d08e0024aa8a227502f5d6eb388751ba58cd6705e51ad9e3b4f171a5b2794c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTY4OjNCRDJFQjpBRDc1RkI6RjQ3M0M1OjZBRkI3OUI1IiwidmlzaXRvcl9pZCI6Ijc5NTk4Mzk3Mjg3MTMwMzgyNjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 73e57a4863f02dfd490ef77e2a38ac7b2ea3f46ca87e9864de39abc6e46379f2 |
| hovercard-subject-tag | pull_request:5266868415 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9893/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Bumps electron-builder 26.15.3 → 26.18.0 in apps/desktop (devDependency). Lockfile moves only the builder family (app-builder-lib/dmg-builder/electron-publish/electron-builder-squirrel-win... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width