René's URL Explorer Experiment


Title: fix(sim-setup): stop doctor --fix from turning ${VAR} references into literals by waleedlatif1 · Pull Request #9868 · simstudioai/sim · GitHub

Open Graph Title: fix(sim-setup): stop doctor --fix from turning ${VAR} references into literals by waleedlatif1 · Pull Request #9868 · simstudioai/sim

X Title: fix(sim-setup): stop doctor --fix from turning ${VAR} references into literals by waleedlatif1 · Pull Request #9868 · simstudioai/sim

Description: Summary Follow-up to #9861. doctor --fix mirrors values from apps/sim/.env into the realtime and db env files. Since #9861 it escaped a hand-written ${VAR} reference into the literal "\${VAR}", so the copy stopped expanding A value written with an unescaped $ reference is no longer auto-mirrored. Copied to another file, a reference resolves against that file's variables, so neither a literal copy nor a verbatim copy is safe. The consistency finding now says to copy it, and the variables it uses, by hand. Seeding a new file and the missing-key autofix skip these values too The same rule covers values upsertEnv cannot write safely, such as a $ mixed with a backslash. Every copy path checks it first: seeding, the missing-key fix, and both consistency mirrors. Doctor reports these values instead of throwing, and never generates a shared secret in place of one it couldn't copy The consistency check compares values as written whenever a $ reference is involved, so it catches a file an earlier --fix already escaped. Plain values, including escaped \$ literals, mirror exactly as before reset with Docker stopped and no install detected also suggests switching kubectl to the cluster's context, since an undetected Kubernetes install looks the same Type of Change Bug fix Testing checks.test.ts runs doctor's real consistency autofixes against env files in a temp root: a ${VAR} DATABASE_URL against a different URL a ${VAR} DATABASE_URL against the same reference already escaped into a literal a ${VAR} DATABASE_URL written the same way in both files a referenced shared secret missing from realtime an unwritable \$-plus-backslash value The first two must report a finding with no autofix and leave the db file byte-for-byte unchanged; they fail on staging's code. The third must not be flagged. checks, env-files and lifecycle tests pass 33/33; the last two fail on the previous commit bun run type-check in packages/sim-setup, biome, check:unused-exports; full suite in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary Follow-up to #9861. doctor --fix mirrors values from apps/sim/.env into the realtime and db env files. Since #9861 it escaped a hand-written ${VAR} reference into the literal "\${VAR}...

X Description: Summary Follow-up to #9861. doctor --fix mirrors values from apps/sim/.env into the realtime and db env files. Since #9861 it escaped a hand-written ${VAR} reference into the literal "\${...

Opengraph URL: https://github.com/simstudioai/sim/pull/9868

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:858fb174-6e85-c393-d3fb-979f572a6555
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CE2:219171:DE929D:1395889:6AFB63EC
html-safe-noncefcd2fbbf4d7fa9b2c31477ff48b7021e5d97e2bd3ccfe5b40ab2c39ad3bbd817
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0UyOjIxOTE3MTpERTkyOUQ6MTM5NTg4OTo2QUZCNjNFQyIsInZpc2l0b3JfaWQiOiIyNzcyNDIwNTI5NzM3MTMwOTg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace295a007f393fa221fc1be1dc200caa2cedb661b5b09f6665a030674c141add8
hovercard-subject-tagpull_request:5251534544
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9868/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #9861. doctor --fix mirrors values from apps/sim/.env into the realtime and db env files. Since #9861 it escaped a hand-written ${VAR} reference into the literal "\${VAR}...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/9868/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9868%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F9868%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/9868/files
Reloadhttps://github.com/simstudioai/sim/pull/9868/files
Reloadhttps://github.com/simstudioai/sim/pull/9868/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sim-setup-env-mirror-refshttps://github.com/simstudioai/sim/tree/fix/sim-setup-env-mirror-refs
Conversation 34 https://github.com/simstudioai/sim/pull/9868
Commits 4 https://github.com/simstudioai/sim/pull/9868/commits
Checks 48 https://github.com/simstudioai/sim/pull/9868/checks
Files changed https://github.com/simstudioai/sim/pull/9868/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9868/files
fix(sim-setup): stop doctor --fix from turning ${VAR} references into literals https://github.com/simstudioai/sim/pull/9868/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/9868/files
a3bc53e fix(sim-setup): mirror env values as written so ${VAR} references sur… waleedlatif1 Nov 11, 2026 https://github.com/simstudioai/sim/pull/9868/commits/a3bc53e612e72c60b9f95b2a208365605be69cf8
41a8bdd fix(sim-setup): leave $ references for a hand copy instead of mirrori… waleedlatif1 Nov 11, 2026 https://github.com/simstudioai/sim/pull/9868/commits/41a8bdd41c04ddd423e80562335dacdc2b43eced
6243955 fix(sim-setup): never generate a shared secret doctor can't copy, and… waleedlatif1 Nov 11, 2026 https://github.com/simstudioai/sim/pull/9868/commits/6243955b7814fb9c76d8dd92720861a24bf6e121
acca16f fix(sim-setup): give a placeholder shared secret the same fix as a mi… waleedlatif1 Nov 11, 2026 https://github.com/simstudioai/sim/pull/9868/commits/acca16f3ef2b7ff380f834e9572be38b2cda2bcd
Clear filters https://github.com/simstudioai/sim/pull/9868/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9868/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/9868/files
checks.test.ts https://github.com/simstudioai/sim/pull/9868/files#diff-09827b24c7aadbe1b98c670daaa21f3fe95c63ae0913eac446a7ce6517191ab4
checks.ts https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
env-files.ts https://github.com/simstudioai/sim/pull/9868/files#diff-0ba42f1b90e31b90010f56c986d0a13d14deecfdbd0c9efa51359d2293662988
lifecycle.ts https://github.com/simstudioai/sim/pull/9868/files#diff-6897f7c4ffb93578c61e9c4deb76836f0b218284665f6cfeab88d0f6f01a901f
packages/sim-setup/src/checks.test.tshttps://github.com/simstudioai/sim/pull/9868/files#diff-09827b24c7aadbe1b98c670daaa21f3fe95c63ae0913eac446a7ce6517191ab4
View file https://github.com/simstudioai/sim/blob/acca16f3ef2b7ff380f834e9572be38b2cda2bcd/packages/sim-setup/src/checks.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9868/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9868/files#diff-09827b24c7aadbe1b98c670daaa21f3fe95c63ae0913eac446a7ce6517191ab4
https://github.com/simstudioai/sim/pull/9868/files#diff-09827b24c7aadbe1b98c670daaa21f3fe95c63ae0913eac446a7ce6517191ab4
https://github.com/simstudioai/sim/pull/9868/files#diff-09827b24c7aadbe1b98c670daaa21f3fe95c63ae0913eac446a7ce6517191ab4
packages/sim-setup/src/checks.tshttps://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
View file https://github.com/simstudioai/sim/blob/acca16f3ef2b7ff380f834e9572be38b2cda2bcd/packages/sim-setup/src/checks.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9868/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
Please reload this pagehttps://github.com/simstudioai/sim/pull/9868/files
https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
https://github.com/simstudioai/sim/pull/9868/files#diff-ad91ba14088910e0dac254de5565f5e487bfdd292efb93291fbe81f3aa198a79
packages/sim-setup/src/env-files.tshttps://github.com/simstudioai/sim/pull/9868/files#diff-0ba42f1b90e31b90010f56c986d0a13d14deecfdbd0c9efa51359d2293662988
View file https://github.com/simstudioai/sim/blob/acca16f3ef2b7ff380f834e9572be38b2cda2bcd/packages/sim-setup/src/env-files.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9868/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9868/files#diff-0ba42f1b90e31b90010f56c986d0a13d14deecfdbd0c9efa51359d2293662988
https://github.com/simstudioai/sim/pull/9868/files#diff-0ba42f1b90e31b90010f56c986d0a13d14deecfdbd0c9efa51359d2293662988
https://github.com/simstudioai/sim/pull/9868/files#diff-0ba42f1b90e31b90010f56c986d0a13d14deecfdbd0c9efa51359d2293662988
https://github.com/simstudioai/sim/pull/9868/files#diff-0ba42f1b90e31b90010f56c986d0a13d14deecfdbd0c9efa51359d2293662988
packages/sim-setup/src/lifecycle.tshttps://github.com/simstudioai/sim/pull/9868/files#diff-6897f7c4ffb93578c61e9c4deb76836f0b218284665f6cfeab88d0f6f01a901f
View file https://github.com/simstudioai/sim/blob/acca16f3ef2b7ff380f834e9572be38b2cda2bcd/packages/sim-setup/src/lifecycle.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/9868/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/9868/files#diff-6897f7c4ffb93578c61e9c4deb76836f0b218284665f6cfeab88d0f6f01a901f
https://github.com/simstudioai/sim/pull/9868/files#diff-6897f7c4ffb93578c61e9c4deb76836f0b218284665f6cfeab88d0f6f01a901f
Please reload this pagehttps://github.com/simstudioai/sim/pull/9868/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.