Title: fix(next): align with route-handler framing in 16.4.5 and hash Bun patches into turbo tasks by waleedlatif1 · Pull Request #9822 · simstudioai/sim · GitHub
Open Graph Title: fix(next): align with route-handler framing in 16.4.5 and hash Bun patches into turbo tasks by waleedlatif1 · Pull Request #9822 · simstudioai/sim
X Title: fix(next): align with route-handler framing in 16.4.5 and hash Bun patches into turbo tasks by waleedlatif1 · Pull Request #9822 · simstudioai/sim
Description: Summary Next.js 16.4.5 (taken in #9819 for its security advisories) drops Content-Length, Content-Encoding, and Transfer-Encoding from every Node route-handler response. Upstream keeps this deliberately: vercel/next.js#101220 closed the scoped alternative (#101201) because a fetch() response is indistinguishable from a synthetic one. This PR aligns with that instead of patching around it (#9820, closed) SSE: SSE_HEADERS now sends Cache-Control: no-cache, no-transform, and Chat's SSE_RESPONSE_HEADERS drops its Content-Encoding: none marker, which 16.4.5 strips anyway. no-transform is the standard signal Next's bundled compression middleware and intermediaries honor, so streams stay unbuffered when route-handler compression arrives (16.4.6) The project-files E2E's Content-Length requirement was relaxed separately in #9824 turbo.json hashes patches/** into every task (globalDependencies). bun.lock records only a patch's path, so editing a Bun patch left every task hash unchanged and CI replayed builds of the unpatched dependency (it did on #9820) Side-effect audit: Same-origin readers of Content-Length (file text preview, CLI OAuth and update checks, desktop updater manifest) use it only as an early size rejection, and each also caps bytes while streaming. Without the header they fall back to the streaming cap No route sends a pre-compressed body with Content-Encoding; proxy paths already delete it In-process delivery integration tests bypass Next's sender and are unaffected Downloads still stream and range responses still carry Content-Range; browsers lose the total size/progress for streamed route-handler downloads until large files are served from signed storage URLs Type of Change Bug fix Testing turbo run build --dry=json: with staging's turbo.json, editing patches/next@16.4.5.patch leaves the @sim/app#build hash unchanged; with this change the hash changes Confirmed Next's bundled compression skips Cache-Control: no-transform responses SSE-adjacent suites: chat identifier route, copilot chat stream route, sse, workflow streaming, managed-agent run session, mothership chat post, lifecycle start: 186 tests pass Project-files E2E, lint, type-check, and check:audits run in CI Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Next.js 16.4.5 (taken in #9819 for its security advisories) drops Content-Length, Content-Encoding, and Transfer-Encoding from every Node route-handler response. Upstream keeps this delibe...
X Description: Summary Next.js 16.4.5 (taken in #9819 for its security advisories) drops Content-Length, Content-Encoding, and Transfer-Encoding from every Node route-handler response. Upstream keeps this delibe...
Opengraph URL: https://github.com/simstudioai/sim/pull/9822
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a8530b90-d44b-03a3-20c4-53740b0984a7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECE0:70580:227E55:311BB2:6AFB22B1 |
| html-safe-nonce | 7b474ff29fb25e5950d15efceb7c6f7f30c6bc81794610d48aad2255fe6f0cba |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0UwOjcwNTgwOjIyN0U1NTozMTFCQjI6NkFGQjIyQjEiLCJ2aXNpdG9yX2lkIjoiNTMyNDUzNzY2Mzc4MzExNzQ4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 53e04aa5eafa1af5e8c0a09374f4e1cc38bae5c60e76da6ca5ce36e0d566867b |
| hovercard-subject-tag | pull_request:5232867546 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/9822/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Next.js 16.4.5 (taken in #9819 for its security advisories) drops Content-Length, Content-Encoding, and Transfer-Encoding from every Node route-handler response. Upstream keeps this delibe... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9219899e0d0ce0b87aeba2c640c955f83631457e5baff5df7a36ce599d2635b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd3b60f1fd9c5f10a3dcde41ae35682f53e85cee |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width